[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14367878#comment-14367878
]
Guozhang Wang commented on KAFKA-1481:
--
We hit an issue related to this ticket, which
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14272057#comment-14272057
]
Jun Rao commented on KAFKA-1481:
Also committed the doc change to 0.8.2 documentation.
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258109#comment-14258109
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi Jun, thx for answer, it helps
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255722#comment-14255722
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi guys, maybe it is not a best
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255845#comment-14255845
]
Jun Rao commented on KAFKA-1481:
The JMX will be registered the first time that the flush
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255875#comment-14255875
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Already did, waited more than 1 day
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255956#comment-14255956
]
Jun Rao commented on KAFKA-1481:
Ok, the metric does show up. By default, the flush is
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214559#comment-14214559
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi, provided new patch, last one?:)
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215304#comment-14215304
]
Jun Rao commented on KAFKA-1481:
Thanks for the patch. +1 from me. Just a few minor
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215371#comment-14215371
]
Joel Koshy commented on KAFKA-1481:
---
+1 (for 0.8.2)
Stop using dashes AND underscores
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215645#comment-14215645
]
Jun Rao commented on KAFKA-1481:
[~vladimir.tretyakov], thanks a lot for your work.
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212264#comment-14212264
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi, added new patches (code + doc),
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212536#comment-14212536
]
Jun Rao commented on KAFKA-1481:
Thanks for the patch. Appreciate your persistence. A few
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212563#comment-14212563
]
Jun Rao commented on KAFKA-1481:
83. On another thought, the port tag may be ok since a
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212598#comment-14212598
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Thx Jun, will try to fix everything
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212873#comment-14212873
]
Joel Koshy commented on KAFKA-1481:
---
[~junrao] For 80.2, I believe the additional
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212987#comment-14212987
]
Jun Rao commented on KAFKA-1481:
[~jjkoshy], yes, re-registering an existing mbean is a
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213409#comment-14213409
]
Otis Gospodnetic commented on KAFKA-1481:
-
bq. 80.4 We will need to add the same
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14210144#comment-14210144
]
Jun Rao commented on KAFKA-1481:
Thinking about his a bit more, I agree with [~jjkoshy]
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14211341#comment-14211341
]
Joel Koshy commented on KAFKA-1481:
---
Re: BrokerTopicMetrics so that it can be
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14211555#comment-14211555
]
Jun Rao commented on KAFKA-1481:
My concern is that in the code, if you have a class
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14208284#comment-14208284
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Maybe somebody can answer my last
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14208497#comment-14208497
]
Jun Rao commented on KAFKA-1481:
65. The following are some of the choices that we have.
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14209055#comment-14209055
]
Joel Koshy commented on KAFKA-1481:
---
(1) and (4) seem equivalent (i.e., AllTopics vs
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14206303#comment-14206303
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi [~junrao],
{quote}
Vladimir
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14206333#comment-14206333
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi again,
65. Honestly I'd prefer
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14205937#comment-14205937
]
Jun Rao commented on KAFKA-1481:
[~vladimir.tretyakov], we could probably just add a new
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14204467#comment-14204467
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi [~jjkoshy] thx for your
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197412#comment-14197412
]
Joel Koshy commented on KAFKA-1481:
---
Sorry I ran out of time - will look tomorrow.
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14194551#comment-14194551
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi, added new patch
50. I think it
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195548#comment-14195548
]
Jun Rao commented on KAFKA-1481:
[~jjkoshy], do you want to take another look at the
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195545#comment-14195545
]
Jun Rao commented on KAFKA-1481:
Thanks for the patch. Just some minor comments below.
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195573#comment-14195573
]
Joel Koshy commented on KAFKA-1481:
---
Yes thanks - I'll take a look at this tomorrow.
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191698#comment-14191698
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi Jun, added new one, changed
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14192034#comment-14192034
]
Jun Rao commented on KAFKA-1481:
Thanks for the patch. A few more comments.
50.
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14190581#comment-14190581
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi Jun, added new patch, removed
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191115#comment-14191115
]
Jun Rao commented on KAFKA-1481:
Thanks for the patch. Looks good overall. Some minor
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188553#comment-14188553
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi Jun, thx for juicy feedback
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14186124#comment-14186124
]
Jun Rao commented on KAFKA-1481:
Vladimir,
Thanks for the patch. Really appreciate your
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182670#comment-14182670
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi Jun, thx for your feedback
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14180056#comment-14180056
]
Jun Rao commented on KAFKA-1481:
Otis,
I expect that we will have about another 4 weeks
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178039#comment-14178039
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi, added last patch
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178739#comment-14178739
]
Jun Rao commented on KAFKA-1481:
Otis,
Yes, we can include this in the 0.8.2 final
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178815#comment-14178815
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi, Jun, will be perfect!
Stop
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179092#comment-14179092
]
Bhavesh Mistry commented on KAFKA-1481:
---
Hi [~junrao],
Can you please let me know
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179102#comment-14179102
]
Jun Rao commented on KAFKA-1481:
Thanks for the patch. Some comments below.
20.
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179132#comment-14179132
]
Jun Rao commented on KAFKA-1481:
Bhavesh,
Created a subtask to track the metric name in
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177149#comment-14177149
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi, fuf:), created new patch (for
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177250#comment-14177250
]
Jun Rao commented on KAFKA-1481:
Thanks for the patch. It doesn't seem to apply. Could you
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177423#comment-14177423
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi, thx for quick reply, did
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177717#comment-14177717
]
Jun Rao commented on KAFKA-1481:
It still doesn't apply.
git apply -p0
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173425#comment-14173425
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi Jun, thx for juicy feedback, few
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172118#comment-14172118
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Added 2 patches (created with git
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173157#comment-14173157
]
Jun Rao commented on KAFKA-1481:
Thanks for the patch. The IDEA one applies successfully
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171371#comment-14171371
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi, Jun,
Thx that you found a
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14169396#comment-14169396
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Added another patch which introduce
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170275#comment-14170275
]
Jun Rao commented on KAFKA-1481:
Vladimir,
Thanks for the patch. My suggestion is
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143500#comment-14143500
]
Otis Gospodnetic commented on KAFKA-1481:
-
This is [~junrao]'s new suggestion for
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134039#comment-14134039
]
Jun Rao commented on KAFKA-1481:
Ok, I am fine with taking this patch as a stop-gap
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14131073#comment-14131073
]
Neha Narkhede commented on KAFKA-1481:
--
This issue has popped up enough times on the
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127899#comment-14127899
]
Otis Gospodnetic commented on KAFKA-1481:
-
Here is a Kafka user who said:
{quote}
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122025#comment-14122025
]
Guozhang Wang commented on KAFKA-1481:
--
[~junrao] do you think we can check in this
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113641#comment-14113641
]
Otis Gospodnetic commented on KAFKA-1481:
-
bq. if you know the clientId, you can
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093822#comment-14093822
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi Jun Rao, I understood what you
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093830#comment-14093830
]
Joe Stein commented on KAFKA-1481:
--
[~junrao] If this patch is going to cause existing
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14094147#comment-14094147
]
Jun Rao commented on KAFKA-1481:
The name of FetchQueueSize is of the following format. If
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092501#comment-14092501
]
Otis Gospodnetic commented on KAFKA-1481:
-
Looks like 0.9 has been pushed to
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092863#comment-14092863
]
Jun Rao commented on KAFKA-1481:
I am wondering if you can get around the problem by just
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092910#comment-14092910
]
Vladimir Tretyakov commented on KAFKA-1481:
---
Hi Jun Rao, look at
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14093709#comment-14093709
]
Jun Rao commented on KAFKA-1481:
I am not sure exactly what your use cases are, but I was
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040652#comment-14040652
]
Otis Gospodnetic commented on KAFKA-1481:
-
Hi Jun, thanks for having a look.
bq.
[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038721#comment-14038721
]
Otis Gospodnetic commented on KAFKA-1481:
-
Nice and simple patch. Question about
72 matches
Mail list logo
