[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492628#comment-14492628 ] Guozhang Wang commented on KAFKA-1910: -- 1. Sounds good. Refactor KafkaConsumer

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-04-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492569#comment-14492569 ] Guozhang Wang commented on KAFKA-1910: -- Hey Jay, 1. I agree with you, the function

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-04-13 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492598#comment-14492598 ] Jay Kreps commented on KAFKA-1910: -- Hey [~guozhang], 1. Cool. Yeah I think create is

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-04-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491698#comment-14491698 ] Jay Kreps commented on KAFKA-1910: -- Hey [~guozhang], on the whole this made things a lot

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-04-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483724#comment-14483724 ] Guozhang Wang commented on KAFKA-1910: -- Created reviewboard

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-04-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14482084#comment-14482084 ] Guozhang Wang commented on KAFKA-1910: -- [~jjkoshy]: 1. No the error code change was

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-31 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1433#comment-1433 ] Joel Koshy commented on KAFKA-1910: --- BTW, just to be clear, what I would like to discuss

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-30 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387652#comment-14387652 ] Joel Koshy commented on KAFKA-1910: --- [~guozhang] this patch modified some of the

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-19 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370281#comment-14370281 ] Guozhang Wang commented on KAFKA-1910: -- Pushed two fixes to the new consumer to

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-19 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370061#comment-14370061 ] Guozhang Wang commented on KAFKA-1910: -- Created reviewboard

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357145#comment-14357145 ] Jun Rao commented on KAFKA-1910: [~guozhang], I still see the following transient unit

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357348#comment-14357348 ] Guozhang Wang commented on KAFKA-1910: -- Found the root cause: in handling

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359506#comment-14359506 ] Jun Rao commented on KAFKA-1910: In BounceBrokerScheduler, is there a particular reason

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-11 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357529#comment-14357529 ] Guozhang Wang commented on KAFKA-1910: -- [~junrao] Could you take a look at the patch

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-11 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357366#comment-14357366 ] Guozhang Wang commented on KAFKA-1910: -- Got some problems with RB, uploading the

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357725#comment-14357725 ] Jun Rao commented on KAFKA-1910: Are the changes in ConsumerTest needed? The extra logging

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-11 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357794#comment-14357794 ] Guozhang Wang commented on KAFKA-1910: -- Thanks Jun, incorporated the comments and

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355640#comment-14355640 ] Jun Rao commented on KAFKA-1910: The most recent jenkins run has the following two unit

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355739#comment-14355739 ] Guozhang Wang commented on KAFKA-1910: -- Jun, I will take a look at it now. Refactor

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355916#comment-14355916 ] Guozhang Wang commented on KAFKA-1910: -- Just check-in the fix, which resolves the

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355969#comment-14355969 ] Guozhang Wang commented on KAFKA-1910: -- Some changes are reverted by accident in the

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-03-02 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344174#comment-14344174 ] Guozhang Wang commented on KAFKA-1910: -- Created reviewboard

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-02-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341201#comment-14341201 ] Guozhang Wang commented on KAFKA-1910: -- Jay, I found my fix to KAFKA-1948 was not

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-02-25 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14336985#comment-14336985 ] Guozhang Wang commented on KAFKA-1910: -- The uploaded patch contains multiple fixes to

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-02-25 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337621#comment-14337621 ] Jay Kreps commented on KAFKA-1910: -- Where is the RB? Refactor KafkaConsumer

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

2015-02-01 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14300251#comment-14300251 ] Jay Kreps commented on KAFKA-1910: -- I guess the real question is how to slice it up. Big