Hey all,
So finally I had some time for some lower prio stuff since everyone is
still on holiday. I've implemented this Github action check in a PR:
https://github.com/apache/kafka/pull/15115
It uses the Github API to fetch the name and email of the user based on the
username who submitted the
Yes, perhaps this can be used in the github action too, I think this is a
very useful tool. Sadly I couldn't get to the github action but hopefully I
will get there soon.
On Fri, Apr 28, 2023 at 8:48 AM David Jacot
wrote:
> Thanks, David. This is a nice addition!
>
> Coming back to the original
Thanks, David. This is a nice addition!
Coming back to the original proposal of using github actions, it may be
possible to run David's script automatically. For instance, we could
trigger an action which pulls the folks who have approved the PR and feed
the script when a comment with `reviewers`
I just merged the "reviewers" script I wrote a while ago:
https://github.com/apache/kafka/pull/11096
It works by finding previous occurrences of "Reviewers: ...", so it only
works for people who have reviewed something before. I do suspect this is
largely the common case.
E.g., searching for
I've tried the script, but it's not quite complete.
I've had issues finding folks -- if they haven't reviewed in kafka, we can
not find an email for them. I also had some issues with finding folks who
had reviewed before.
Right now, my strategy is to use GitHub to search previous commits for
It's a lot more convenient to have it in the commit than having to follow
links, etc.
David Arthur also wrote a script to help with this step, I believe.
Ismael
On Tue, Apr 18, 2023, 9:29 AM Divij Vaidya wrote:
> Do we even need a manual attribution for a reviewer in the commit message?
>
Do we even need a manual attribution for a reviewer in the commit message?
GitHub automatically marks the folks as "reviewers" who have used the
"review-changes" button on the top left corner and left feedback. GitHub
also has searchability for such reviews done by a particular person using
the
I'm not that familiar with Actions either, it just seemed like a tool for
this purpose. :)
I Did some digging and what I have in mind is that on pull request review
it can trigger a workflow:
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_review
We
Hi all,
Unless I miss something, wouldn't this GitHub action either amend the
commit (breaking signature if any) or directly do the commit itself
(meaning the action would be the one squashing and merging and not the
maintainer anymore)?
Let me know if I'm missing something or if there are some
Hi all,
Unfortunately I forgot to add myself as a reviewer *again *on a PR when
merging. Shame on me.
However I was thinking about looking into Github actions whether we can
automate this process or at least prevent PRs from merging that don't have
"reviewers" in the description.
Has anyone ever
10 matches
Mail list logo
