Re: Review Request 27534: Patch for KAFKA-1746

2014-11-10 Thread Mayuresh Gharat
On Nov. 8, 2014, 3:01 a.m., Mayuresh Gharat wrote: system_test/utils/kafka_system_test_utils.py, line 2403 https://reviews.apache.org/r/27534/diff/1/?file=747724#file747724line2403 This causes many system tests (approx 98) to fail Ewen Cheslack-Postava wrote: Can you give

Re: Review Request 27534: Patch for KAFKA-1746

2014-11-10 Thread Mayuresh Gharat
On Nov. 8, 2014, 3:01 a.m., Mayuresh Gharat wrote: system_test/utils/kafka_system_test_utils.py, line 2403 https://reviews.apache.org/r/27534/diff/1/?file=747724#file747724line2403 This causes many system tests (approx 98) to fail Ewen Cheslack-Postava wrote: Can you give

Re: Review Request 27534: Patch for KAFKA-1746

2014-11-07 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27534/#review60460 --- system_test/utils/kafka_system_test_utils.py

Re: Review Request 27534: Patch for KAFKA-1746

2014-11-06 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27534/#review60276 --- Ship it! Ship It! - Neha Narkhede On Nov. 3, 2014, 7:46 p.m.,

Re: Review Request 27534: Patch for KAFKA-1746

2014-11-05 Thread Guozhang Wang
On Nov. 5, 2014, 1 a.m., Guozhang Wang wrote: Where will testcaseEnv.validationStatusDict[Test completed] be used? Ewen Cheslack-Postava wrote: That's where all the validation results (the test's assertions) are stored. It gets scanned through at the end of the test run in

Re: Review Request 27534: Patch for KAFKA-1746

2014-11-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27534/#review59898 --- Where will testcaseEnv.validationStatusDict[Test completed] be

Re: Review Request 27534: Patch for KAFKA-1746

2014-11-04 Thread Ewen Cheslack-Postava
On Nov. 5, 2014, 1 a.m., Guozhang Wang wrote: Where will testcaseEnv.validationStatusDict[Test completed] be used? That's where all the validation results (the test's assertions) are stored. It gets scanned through at the end of the test run in system_test_runner.py to generate the report

Review Request 27534: Patch for KAFKA-1746

2014-11-03 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27534/ --- Review request for kafka. Bugs: KAFKA-1746