Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

2015-03-06 Thread Guozhang Wang
On March 5, 2015, 11:39 p.m., Onur Karaman wrote: clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorTest.java, line 83 https://reviews.apache.org/r/31650/diff/2/?file=886350#file886350line83 I think these scenarios should be split up into separate

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

2015-03-06 Thread Guozhang Wang
On March 5, 2015, 10:42 p.m., Onur Karaman wrote: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java, lines 137-138 https://reviews.apache.org/r/31650/diff/1/?file=882439#file882439line137 This is really minor, but are longs necessary for these

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

2015-03-06 Thread Guozhang Wang
On March 5, 2015, 11:39 p.m., Onur Karaman wrote: clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorTest.java, line 83 https://reviews.apache.org/r/31650/diff/2/?file=886350#file886350line83 I think these scenarios should be split up into separate

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

2015-03-06 Thread Onur Karaman
On March 5, 2015, 11:39 p.m., Onur Karaman wrote: clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorTest.java, line 83 https://reviews.apache.org/r/31650/diff/2/?file=886350#file886350line83 I think these scenarios should be split up into separate

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

2015-03-05 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/ --- (Updated March 5, 2015, 10:55 p.m.) Review request for kafka. Bugs:

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

2015-03-05 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/#review75406 ---

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

2015-03-05 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/ --- (Updated March 5, 2015, 10:57 p.m.) Review request for kafka. Bugs:

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

2015-03-05 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/#review75411 ---

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

2015-03-05 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/#review75355 ---

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

2015-03-05 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/#review75419 --- Ship it! Ship It! - Jay Kreps On March 5, 2015, 10:57 p.m.,

Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

2015-03-02 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/ --- Review request for kafka. Bugs: KAFKA-1910