Re: [DISCUSS] KIP-924: customizable task assignment for Streams

2024-04-19 Thread Matthias J. Sax
One more thing. It might be good to clearly call out, which interfaced a user would implement, vs the other ones Kafka Streams implements and TaskAssignor only uses. My understanding is, that users would implement `TaskAssignor`, `TaskAssignment`, and `StreamsClientAssignment`. For

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #2829

2024-04-19 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-924: customizable task assignment for Streams

2024-04-19 Thread Matthias J. Sax
Great KIP. I have some minor comments/questions: 100 The KIP says: "In the future, additional plugins can use the same partition.assignor prefix". What does this mean? 101 (nit) The KIP says: "Note that the thread-level assignment will remain an un-configurable internal implementation

Re: [VOTE] KIP-1037: Allow WriteTxnMarkers API with Alter Cluster Permission

2024-04-19 Thread Justine Olshan
Hey Nikhil, I meant to comment on the discussion thread, but my draft took so long, you opened the vote. Regardless, I just wanted to say that it makes sense to me. +1 (binding) Justine On Fri, Apr 19, 2024 at 7:22 AM Nikhil Ramakrishnan < ramakrishnan.nik...@gmail.com> wrote: > Hi everyone,

Re: [DISCUSS] KIP-924: customizable task assignment for Streams

2024-04-19 Thread Rohan Desai
Bruno, I've incorporated your feedback into the KIP document. On Fri, Apr 19, 2024 at 3:55 PM Rohan Desai wrote: > Thanks for the feedback Bruno! For the most part I think it makes sense, > but leaving a couple follow-up thoughts/questions: > > re 4: I think Sophie's point was slightly

Re: [DISCUSS] KIP-932: Queues for Kafka

2024-04-19 Thread Jun Rao
Hi, Andrew, Thanks for the reply. A few more comments. 120. There is still reference to ConsumerGroupMetadataKey. 121. ShareUpdateValue.SnapshotEpoch: Should we change it since it's not a snapshot? 122. ConsumerGroupMemberMetadataValue includes epoch, but ShareGroupMemberMetadataValue does

Re: [DISCUSS] KIP-924: customizable task assignment for Streams

2024-04-19 Thread Rohan Desai
Thanks for the feedback Bruno! For the most part I think it makes sense, but leaving a couple follow-up thoughts/questions: re 4: I think Sophie's point was slightly different - that we might want to wrap the return type for `assign` in a class so that its easily extensible. This makes sense to

[jira] [Resolved] (KAFKA-15585) DescribeTopic API

2024-04-19 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-15585. Resolution: Fixed > DescribeTopic API > - > > Key: KAFKA-15585 >

[jira] [Created] (KAFKA-16589) Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close

2024-04-19 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16589: -- Summary: Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close Key: KAFKA-16589 URL:

[jira] [Resolved] (KAFKA-16486) Integrate metric measurability changes in metrics collector

2024-04-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-16486. - Fix Version/s: 3.8.0 Resolution: Done > Integrate metric measurability changes

Re: [DISCUSS] KIP-1036: Extend RecordDeserializationException exception

2024-04-19 Thread Frédérik Rouleau
Hi everyone, Thanks for all that valuable feedback. So we have a consensus not to use Record. I have updated to PR by creating 2 childs classes KeyDeserializationException and ValueDeserializationException. Those classes directly embed the required fields. I do not think a wrapper object would

Re: [VOTE] KIP-1020 Move `window.size.ms` and `windowed.inner.serde.class` from `StreamsConfig` to TimeWindowedDe/Serializer class

2024-04-19 Thread Lucia Cerchie
Thanks all for voting. I'm now closing the vote. The vote passes with - 3 +1 bindings votes from Lucas Brutschy, Sophie Blee-Goldman, and Matthias J Sax - 0 +1 non-binding votes - 0 -1 votes Thanks, Lucia Cerchie On Mon, Apr 8, 2024 at 2:08 AM Lucas Brutschy wrote: > +1 (binding) > > Thanks,

[jira] [Created] (KAFKA-16588) broker shutdown hangs when `log.segment.delete.delay.ms` is zero

2024-04-19 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16588: -- Summary: broker shutdown hangs when `log.segment.delete.delay.ms` is zero Key: KAFKA-16588 URL: https://issues.apache.org/jira/browse/KAFKA-16588 Project: Kafka

[jira] [Resolved] (KAFKA-16579) Revert changes to consumer_rolling_upgrade_test.py for the new async Consumer

2024-04-19 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee resolved KAFKA-16579. Resolution: Fixed > Revert changes to consumer_rolling_upgrade_test.py for the new async Consumer

Re: [DISCUSS] KIP-950: Tiered Storage Disablement

2024-04-19 Thread Christo Lolov
Heya all! I have updated KIP-950. A list of what I have updated is: * Explicitly state that Zookeeper-backed clusters will have ENABLED -> DISABLING -> DISABLED while KRaft-backed clusters will only have ENABLED -> DISABLED * Added two configurations for the new thread pools and explained where

[VOTE] KIP-1037: Allow WriteTxnMarkers API with Alter Cluster Permission

2024-04-19 Thread Nikhil Ramakrishnan
Hi everyone, I would like to start a voting thread for KIP-1037: Allow WriteTxnMarkers API with Alter Cluster Permission (https://cwiki.apache.org/confluence/display/KAFKA/KIP-1037%3A+Allow+WriteTxnMarkers+API+with+Alter+Cluster+Permission) as there have been no objections on the discussion

Re: [ANNOUNCE] New Kafka PMC Member: Greg Harris

2024-04-19 Thread Lucas Brutschy
Congrats! On Thu, Apr 18, 2024 at 6:50 PM Justine Olshan wrote: > > Congratulations Greg! > > On Thu, Apr 18, 2024 at 12:03 AM Matthias J. Sax wrote: > > > Congrats Greg! > > > > On 4/15/24 10:44 AM, Hector Geraldino (BLOOMBERG/ 919 3RD A) wrote: > > > Congrats! Well deserved > > > > > > From:

Re: [DISCUSS] KIP-1039: Disable automatic topic creation for MirrorMaker2 consumers

2024-04-19 Thread aaron ai
Hi Omnia, Thanks for your feedback! Yes, another approach could be to disable this option manually. IMHO, it's hard to envision a scenario where enabling it would be necessary. BTW, I've already added this part into the KIP. On Fri, Apr 19, 2024 at 6:18 PM Omnia Ibrahim wrote: > Hi Aaron, >

Re: [DISCUSS] KIP-1039: Disable automatic topic creation for MirrorMaker2 consumers

2024-04-19 Thread Omnia Ibrahim
Hi Aaron, You mentioned that there is no public interface changes however changing the default value of a config should be considered as a public change. You can check other KIP where we changed the default config value for a reference. Can you please list what is the impact of changing the

[DISCUSS] KIP-1039: Disable automatic topic creation for MirrorMaker2 consumers

2024-04-19 Thread aaron ai
Hi all, Here is the KIP-1039: Disable automatic topic creation for MirrorMaker2 consumers < https://cwiki.apache.org/confluence/display/KAFKA/KIP-1039%3A+Disable+automatic+topic+creation+for+MirrorMaker2+consumers > Looking forward to your feedback! Best regards, Aaron

Re: [DISCUSS] KIP-1028: Docker Official Image for Apache Kafka

2024-04-19 Thread Manikumar
Thanks Krish. KIP looks good to me. On Wed, Apr 17, 2024 at 1:38 PM Krish Vora wrote: > > Hi Manikumar, > > Thanks for the comments. > > Maybe as part of the release process, RM can create a JIRA for this > > task. This can be taken by RM or any comitter or any contributor (with > > some help

[jira] [Created] (KAFKA-16587) Store subscription model for consumer group in group state

2024-04-19 Thread Ritika Reddy (Jira)
Ritika Reddy created KAFKA-16587: Summary: Store subscription model for consumer group in group state Key: KAFKA-16587 URL: https://issues.apache.org/jira/browse/KAFKA-16587 Project: Kafka