Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

Thanks Matthias -- sorry I forgot to get back to you! Thanks for kicking off the voting thread on this On Thu, Mar 28, 2024 at 3:58 AM Matthias J. Sax wrote: > Thanks. I think you can start a VOTE. > > -Matthias > > > On 3/20/24 9:24 PM, Lucia Cerchie wrote: > > thanks Sophie, I've made the

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

Thanks. I think you can start a VOTE. -Matthias On 3/20/24 9:24 PM, Lucia Cerchie wrote: thanks Sophie, I've made the updates, would appreciate one more look before submission On Wed, Mar 20, 2024 at 8:36 AM Sophie Blee-Goldman wrote: A few minor notes on the KIP but otherwise I think you

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

thanks Sophie, I've made the updates, would appreciate one more look before submission On Wed, Mar 20, 2024 at 8:36 AM Sophie Blee-Goldman wrote: > A few minor notes on the KIP but otherwise I think you can go ahead and > call for a vote! > > 1. Need to update the Motivation section to say

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

A few minor notes on the KIP but otherwise I think you can go ahead and call for a vote! 1. Need to update the Motivation section to say "console clients" or "console consumer/producer" instead of " plain consumer client" 2. Remove the first paragraph under "Public Interfaces" (ie the KIP-writing

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

Thanks for the discussion! I've updated the KIP here with what I believe are the relevant pieces, please let me know if anything is missing: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=290982804 On Sun, Mar 17, 2024 at 7:09 PM Sophie Blee-Goldman wrote: > Sounds good! > >

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

Sounds good! @Lucia when you have a moment can you update the KIP with the new proposal, including the details that Matthias pointed out in his last response? After that's done I think you can go ahead and call for a vote whenever you're ready! On Sat, Mar 16, 2024 at 7:35 PM Matthias J. Sax

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

Thanks for the summary. Sounds right to me. That is what I would propose. As you pointed out, we of course still need to support the current confis, and we should log a warning when in use (even if the new one is in use IMHO) -- but that's more an implementation detail. I agree that the new

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

> > Should we change it do `.serializer` and `.deserialize`? That's a good point -- if we're going to split this up by defining the config in both the TimeWindowedSerializer and TimeWindowedDeserializer, then it makes perfect sense to go a step further and actually define only the relevant

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

By "don't add them" do you just mean we would not have any actual variables defined anywhere for these configs (eg WINDOW_SIZE_MS) and simply document -- somewhere -- that one can use the string "window.size.ms" when configuring a command-line client with a windowed serde? Yes. That's the

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

By "don't add them" do you just mean we would not have any actual variables defined anywhere for these configs (eg WINDOW_SIZE_MS) and simply document -- somewhere -- that one can use the string "window.size.ms" when configuring a command-line client with a windowed serde? Or something else? I

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

Yes, it's used inside `TimeWindowedSerializer` and actually also inside `TimeWindowDeserializer`. However, it does IMHO not change that we should remove it from `StreamsConfig` because both configs are not intended to be used in Java code... If one writes Java code, they should use new

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

PS-- I was re-reading the PR that originated this discussion and realized that `window.inner.serde.class` is used here in KStreams. This goes against removing it,

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

Sophie, I'll add a paragraph about removing `windowed.inner.serde.class` to the KIP. I'll also add putting it in the `TimeWindowedSerde` class with some add'tl guidance on the docs addition. Also, I double-checked setting window.size.ms on the client and it doesn't throw an error at all, in

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

Thanks for responding Matthias -- you got there first, but I was going to say exactly the same thing as in your most reply. In other words, I see the `windowed.inner.serde.class` as being in the same boat as the ` window.size.ms` config, so whatever we do with one we should do for the other. I do

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

One more thought after I did some more digging on the related PR. Should we do the same thing for `windowed.inner.serde.class`? Both config belong to windowed serdes (which KS provide) but the KS code itself does never use them (and in fact, disallows to use them and would throw an error is

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

Thanks for the KIP. Sounds like a nice cleanup. window.size.ms is not a true KafkaStreams config, and results in an error when set from a KStreams application What error? Given that the configs is used by `TimeWindowedDeserializer` I am wondering if we should additionally add public

[DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

Hey everyone, I'd like to discuss KIP-1020 , which would move to deprecate `window.size.ms` in `StreamsConfig` since ` window.size.ms` is a client config. Thanks in advance! Lucia Cerchie