[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359004#comment-14359004
]
Ewen Cheslack-Postava commented on KAFKA-1988:
--
[~noxis] Because it wasn't a
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359229#comment-14359229
]
Wojciech Kuranowski commented on KAFKA-1988:
Please update this issue.
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358613#comment-14358613
]
Wojciech Kuranowski commented on KAFKA-1988:
Why this fix is not included in
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359678#comment-14359678
]
Ewen Cheslack-Postava commented on KAFKA-1988:
--
[~tongli] You're all good, it
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346038#comment-14346038
]
Tong Li commented on KAFKA-1988:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346045#comment-14346045
]
Tong Li commented on KAFKA-1988:
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346274#comment-14346274
]
Guozhang Wang commented on KAFKA-1988:
--
Thanks [~tongli], +1 and committed to trunk.
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343109#comment-14343109
]
Tong Li commented on KAFKA-1988:
[~guozhang] Yes, the o.a.k.c.c.u.Utils.abs used in few
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340663#comment-14340663
]
Jun Rao commented on KAFKA-1988:
Hi, Tong,
My suggestion is slightly different. My point
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339921#comment-14339921
]
Tong Li commented on KAFKA-1988:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339924#comment-14339924
]
Tong Li commented on KAFKA-1988:
Jun Rao,
Thanks for taking time reviewing the
Date: 02/27/2015 12:43 AM
Subject: [jira] [Commented] (KAFKA-1988)
org.apache.kafka.common.utils.Utils.abs method returns wrong value
for negative numbers.
[ https://issues.apache.org/jira/browse/KAFKA-1988?
page=com.atlassian.jira.plugin.system.issuetabpanels:comment
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340959#comment-14340959
]
Tong Li commented on KAFKA-1988:
Run Rao, I got the point now. Thanks so much for your
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340993#comment-14340993
]
Guozhang Wang commented on KAFKA-1988:
--
+1. Thanks Tong / Jun for fixing this and
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341004#comment-14341004
]
Tong Li commented on KAFKA-1988:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339751#comment-14339751
]
Jun Rao commented on KAFKA-1988:
Actually, we can probably keep the same logic in
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339478#comment-14339478
]
Tong Li commented on KAFKA-1988:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339500#comment-14339500
]
Jun Rao commented on KAFKA-1988:
Thanks for the patch. +1.
We actually made the same
18 matches
Mail list logo
