----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31007/ -----------------------------------------------------------
Review request for kafka. Bugs: KAFKA-1926 https://issues.apache.org/jira/browse/KAFKA-1926 Repository: kafka Description ------- More patch set will be submitted to address utils.java issues Following things happen in this patch set: 1. Crc32.java was removed so that the core uses the same class defined in the client package. 2. Removed Time trait defined in Time.scala to use the interface defined in the client Time module. 3. Rewrite the SystemTime object in Time.scala so that it uses the client SystemTime class. 4. References to Time has been all refacted to use the interface defined in client module. 5. .gitignore does not exclude the following build process created folder and files: core/data/* gradle/wrapper/* Diffs ----- .gitignore 06a64184eaa531fcbf5586692b78bfd48e4176ba clients/src/main/java/org/apache/kafka/common/utils/Time.java 66c44de74521ed13cff75d556ebefa8846485b21 core/src/main/scala/kafka/cluster/Partition.scala e6ad8be5e33b6fb31c078ad78f8de709869ddc04 core/src/main/scala/kafka/cluster/Replica.scala bd13c20338ce3d73113224440e858a12814e5adb core/src/main/scala/kafka/log/Log.scala 846023bb98d0fa0603016466360c97071ac935ea core/src/main/scala/kafka/log/LogCleaner.scala f8e7cd5fabce78c248a9027c4bb374a792508675 core/src/main/scala/kafka/log/LogManager.scala 47d250af62c1aa53d11204a332d0684fb4217c8d core/src/main/scala/kafka/log/LogSegment.scala ac9643423a28d189133705ba69b16cfce23f0049 core/src/main/scala/kafka/network/SocketServer.scala 76ce41aed6e04ac5ba88395c4d5008aca17f9a73 core/src/main/scala/kafka/server/KafkaServer.scala 7e5ddcb9be8fcef3df6ebc82a13ef44ef95f73ae core/src/main/scala/kafka/server/ReplicaManager.scala fb948b9ab28c516e81dab14dcbe211dcd99842b6 core/src/main/scala/kafka/server/TopicConfigManager.scala 47295d40131492aaac786273819b7bc6e22e5486 core/src/main/scala/kafka/utils/Crc32.java 0e0e7bcb33886f47b9770a122d00d6eafdbb89a9 core/src/main/scala/kafka/utils/Throttler.scala d1a144d7882919426824799ff8e8a47f89c83158 core/src/main/scala/kafka/utils/Time.scala 194cc1fa73b6a68914caf46b7dd7d415b2ff6a9f core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c core/src/test/scala/unit/kafka/server/ISRExpirationTest.scala a703d2715048c5602635127451593903f8d20576 core/src/test/scala/unit/kafka/server/LogOffsetTest.scala c06ee756bf0fe07e5d3c92823a476c960b37afd6 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 5b93239cdc26b5be7696f4e7863adb9fbe5f0ed5 core/src/test/scala/unit/kafka/utils/MockScheduler.scala c6740782813cbf7c979bf1b94dd829945ef38458 core/src/test/scala/unit/kafka/utils/MockTime.scala ee65748afefd5e2d699e68fbd402b0ed9a659589 core/src/test/scala/unit/kafka/utils/TestUtils.scala 21d0ed2cb7c9459261d3cdc7c21dece5e2079698 Diff: https://reviews.apache.org/r/31007/diff/ Testing ------- Thanks, Tong Li