Re: RFC: removing raft_consensus-test (mock-based)

2016-09-20 Thread Adar Dembo
Does this mean we should also remove gmock from thirdparty and go back to plain gtest? Or are we still making use of other gmock features (not related to mocking, if any)? On Tuesday, September 20, 2016, Todd Lipcon wrote: > Great, glad you agree. It also feels good to delete

RFC: removing raft_consensus-test (mock-based)

2016-09-20 Thread David Alves
+1, we've since broadened our coverage in other tests that those cases are covered elsewhere. Plus I agree that with the queue taking more responsibility mocking it becomes a hardship. -david > I'm doing a bit of Consensus refactoring, and finding that the > raft_consensus-test mock-based test