[jira] [Commented] (LOG4J2-2060) AbstactDatabase appender issue with AsyncLogger

2017-10-05 Thread Tolga Kavukcu (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193453#comment-16193453 ] Tolga Kavukcu commented on LOG4J2-2060: --- Thanks [~rem...@yahoo.com] i will test it with problematic

[jira] [Commented] (LOG4J2-1535) KafkaAppender NullPointerException when putting the related jars in tomcat lib

2017-10-05 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193303#comment-16193303 ] Mikael Ståldal commented on LOG4J2-1535: [~Flowcont] can you create a new ticket about the Spark

Re: Binary compatibility for managers in log4j-core

2017-10-05 Thread Gary Gregory
How about switching to a Builder like we have been doing for Appenders? Gary On Thu, Oct 5, 2017 at 11:38 AM, Mikael Ståldal wrote: > The specific case is KafkaManager constructor. Can we just add a new > parameter, or should we overload? > > > On 2017-10-05 19:02, Matt

Re: Binary compatibility for managers in log4j-core

2017-10-05 Thread Mikael Ståldal
The specific case is KafkaManager constructor. Can we just add a new parameter, or should we overload? On 2017-10-05 19:02, Matt Sicker wrote: Since appenders are usually final classes, I think the only compatibility there is calling compatibility. For managers, users can extend the classes,

[jira] [Commented] (LOG4J2-2060) AbstactDatabase appender issue with AsyncLogger

2017-10-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193245#comment-16193245 ] Remko Popma commented on LOG4J2-2060: - You are correct. AbstractDatabaseManager should not keep a

Re: Binary compatibility for managers in log4j-core

2017-10-05 Thread Gary Gregory
"Within reason" should be the operative term here... IOW, let's not handcuff ourselves unless necessary. Gary On Thu, Oct 5, 2017 at 11:02 AM, Matt Sicker wrote: > Since appenders are usually final classes, I think the only compatibility > there is calling compatibility. For

[jira] [Updated] (LOG4J2-2060) AbstactDatabase appender issue with AsyncLogger

2017-10-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-2060: Fix Version/s: 2.9.2 > AbstactDatabase appender issue with AsyncLogger >

[jira] [Assigned] (LOG4J2-2060) AbstactDatabase appender issue with AsyncLogger

2017-10-05 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-2060: --- Assignee: Remko Popma > AbstactDatabase appender issue with AsyncLogger >

Re: Binary compatibility for managers in log4j-core

2017-10-05 Thread Matt Sicker
Since appenders are usually final classes, I think the only compatibility there is calling compatibility. For managers, users can extend the classes, so implementation compatibility would make sense. On 5 October 2017 at 11:53, Mikael Ståldal wrote: > We try to keep binary

Re: Binary compatibility for managers in log4j-core

2017-10-05 Thread Ralph Goers
Since they are not something end users would normally not be accessing via an API, I think my answer would be No, it is not essential that binary compatibility be maintained with managers. Ralph > On Oct 5, 2017, at 9:53 AM, Mikael Ståldal wrote: > > We try to keep binary

[jira] [Commented] (LOG4J2-2062) Add possibility of sending the key of a message to Kafka using KafkaAppender

2017-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193193#comment-16193193 ] ASF GitHub Bot commented on LOG4J2-2062: Github user mikaelstaldal commented on a diff in the

[jira] [Commented] (LOG4J2-2062) Add possibility of sending the key of a message to Kafka using KafkaAppender

2017-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193191#comment-16193191 ] ASF GitHub Bot commented on LOG4J2-2062: Github user mikaelstaldal commented on a diff in the

[jira] [Commented] (LOG4J2-2062) Add possibility of sending the key of a message to Kafka using KafkaAppender

2017-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193192#comment-16193192 ] ASF GitHub Bot commented on LOG4J2-2062: Github user mikaelstaldal commented on a diff in the

[jira] [Commented] (LOG4J2-2062) Add possibility of sending the key of a message to Kafka using KafkaAppender

2017-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193190#comment-16193190 ] ASF GitHub Bot commented on LOG4J2-2062: Github user mikaelstaldal commented on a diff in the

[GitHub] logging-log4j2 pull request #112: LOG4J2-2062 Added property to KafkaAppende...

2017-10-05 Thread mikaelstaldal
Github user mikaelstaldal commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/112#discussion_r142994778 --- Diff: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaManager.java --- @@ -47,18 +47,24 @@

[GitHub] logging-log4j2 pull request #112: LOG4J2-2062 Added property to KafkaAppende...

2017-10-05 Thread mikaelstaldal
Github user mikaelstaldal commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/112#discussion_r142996203 --- Diff: src/site/xdoc/manual/appenders.xml --- @@ -1735,6 +1735,11 @@ public class JpaLogEntity extends AbstractLogEventWrapperEntity {

[GitHub] logging-log4j2 pull request #112: LOG4J2-2062 Added property to KafkaAppende...

2017-10-05 Thread mikaelstaldal
Github user mikaelstaldal commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/112#discussion_r142995363 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaAppenderTest.java --- @@ -135,6 +135,22 @@ public

[GitHub] logging-log4j2 pull request #112: LOG4J2-2062 Added property to KafkaAppende...

2017-10-05 Thread mikaelstaldal
Github user mikaelstaldal commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/112#discussion_r142995940 --- Diff: src/site/xdoc/manual/appenders.xml --- @@ -1735,6 +1735,11 @@ public class JpaLogEntity extends AbstractLogEventWrapperEntity {

Binary compatibility for managers in log4j-core

2017-10-05 Thread Mikael Ståldal
We try to keep binary compatibility for appenders and layouts in log4j-core. Does that apply to the managers used by appenders as well?

[jira] [Commented] (LOG4J2-1535) KafkaAppender NullPointerException when putting the related jars in tomcat lib

2017-10-05 Thread Jorge Sanchez (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192854#comment-16192854 ] Jorge Sanchez commented on LOG4J2-1535: --- The library and version is kafka-clients-0.10.2.0 >

[jira] [Comment Edited] (LOG4J2-2060) AbstactDatabase appender issue with AsyncLogger

2017-10-05 Thread Tolga Kavukcu (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192744#comment-16192744 ] Tolga Kavukcu edited comment on LOG4J2-2060 at 10/5/17 11:04 AM: - Hi is

[jira] [Commented] (LOG4J2-2060) AbstactDatabase appender issue with AsyncLogger

2017-10-05 Thread Tolga Kavukcu (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192744#comment-16192744 ] Tolga Kavukcu commented on LOG4J2-2060: --- Hi is there any ideas or suggestion for this ticket ? >

[jira] [Updated] (LOG4J2-2058) java.locale.providers set to HOST causes Log4j2 to crash in Java 9

2017-10-05 Thread Dean Wookey (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dean Wookey updated LOG4J2-2058: Description: When using the JUL log manager, setting the java.locale.providers property to "HOST"

[jira] [Commented] (LOG4J2-524) Feature request: auto-delete older rolled over files

2017-10-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192668#comment-16192668 ] ASF GitHub Bot commented on LOG4J2-524: --- Github user kdoteu commented on the issue:

[jira] [Updated] (LOG4J2-2058) java.locale.providers set to HOST causes Log4j2 to crash in Java 9

2017-10-05 Thread Dean Wookey (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dean Wookey updated LOG4J2-2058: Description: When using the JUL log manager, setting the java.locale.providers property to "HOST"

[GitHub] logging-log4j2 issue #7: LOG4J2-524: auto-delete older rolled over files

2017-10-05 Thread kdoteu
Github user kdoteu commented on the issue: https://github.com/apache/logging-log4j2/pull/7 There is no documentation about this feature. How to define maxAge ... ---

[jira] [Commented] (LOG4J2-1888) Log4j throws a java.nio.charset.UnsupportedCharsetException: cp65001

2017-10-05 Thread Frank Steudle (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192538#comment-16192538 ] Frank Steudle commented on LOG4J2-1888: --- Found help for my problem in issue

[jira] [Commented] (LOG4J2-2053) Exception java.nio.charset.UnsupportedCharsetException: cp65001 in 2.9.0

2017-10-05 Thread Frank Steudle (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192530#comment-16192530 ] Frank Steudle commented on LOG4J2-2053: --- Hi Gary, thank you very much for the great response! I