[
https://issues.apache.org/jira/browse/LUCENE-8882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876132#comment-16876132
]
Adrien Grand commented on LUCENE-8882:
--
Can you elaborate more on how this would help replace
[
https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8862.
--
Resolution: Fixed
Fix Version/s: 8.2
master (9.0)
> Collector Level
[
https://issues.apache.org/jira/browse/LUCENE-8892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874962#comment-16874962
]
Adrien Grand commented on LUCENE-8892:
--
+1
> Missing closing parens in string representation of
[
https://issues.apache.org/jira/browse/LUCENE-8831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874906#comment-16874906
]
Adrien Grand commented on LUCENE-8831:
--
[~ivera] This looks like a good candidate for 8.1.2?
>
[
https://issues.apache.org/jira/browse/LUCENE-8878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874810#comment-16874810
]
Adrien Grand commented on LUCENE-8878:
--
[~mikemccand] ImpactsEnum as mostly about exposing maximum
[
https://issues.apache.org/jira/browse/LUCENE-8890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8890.
--
Resolution: Fixed
Fix Version/s: 8.2
master (9.0)
Thank you
[
https://issues.apache.org/jira/browse/LUCENE-8890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand moved SOLR-12736 to LUCENE-8890:
-
Affects Version/s: (was: 8.0)
Lucene Fields: New
[
https://issues.apache.org/jira/browse/LUCENE-8889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8889.
--
Resolution: Fixed
Fix Version/s: 8.2
master (9.0)
Oops I had not
[
https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874010#comment-16874010
]
Adrien Grand commented on LUCENE-8871:
--
The visibility changes are required because our Javadocs
[
https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873980#comment-16873980
]
Adrien Grand commented on LUCENE-8871:
--
[~sokolov] I tried to address the precommit failures but
[
https://issues.apache.org/jira/browse/LUCENE-8886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873941#comment-16873941
]
Adrien Grand commented on LUCENE-8886:
--
+1
> TestMutablePointsReaderUtils not doing what it is
[
https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873849#comment-16873849
]
Adrien Grand commented on LUCENE-8855:
--
[~ab] I'd be in favor of waiting for 8.2, which we could
[
https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873426#comment-16873426
]
Adrien Grand commented on LUCENE-8855:
--
[~ab] I'm surprised this went to 8.1, this isn't a bug fix?
[
https://issues.apache.org/jira/browse/LUCENE-8885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873323#comment-16873323
]
Adrien Grand commented on LUCENE-8885:
--
I don't think backward compatibility should be a concern
[
https://issues.apache.org/jira/browse/LUCENE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873014#comment-16873014
]
Adrien Grand commented on LUCENE-8877:
--
Abstraction increases complexity too, it feels reasonable
[
https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873011#comment-16873011
]
Adrien Grand commented on LUCENE-8855:
--
+1
> Add Accountable to Query implementations
>
[
https://issues.apache.org/jira/browse/LUCENE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873009#comment-16873009
]
Adrien Grand commented on LUCENE-8870:
--
bq. Currently NumericDocValuesField does not support the
[
https://issues.apache.org/jira/browse/LUCENE-8878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873003#comment-16873003
]
Adrien Grand commented on LUCENE-8878:
--
bq. Is it the case today? I wonder whether the ordinals are
[
https://issues.apache.org/jira/browse/LUCENE-8878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872534#comment-16872534
]
Adrien Grand commented on LUCENE-8878:
--
+1 to simplify, even at the cost of some performance. As
[
https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872532#comment-16872532
]
Adrien Grand commented on LUCENE-8855:
--
BytesRefHash has some code commented out that looks like a
[
https://issues.apache.org/jira/browse/LUCENE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872205#comment-16872205
]
Adrien Grand commented on LUCENE-8806:
--
Oh, that is interesting. Are you testing on wikibigall or
[
https://issues.apache.org/jira/browse/LUCENE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872156#comment-16872156
]
Adrien Grand commented on LUCENE-8806:
--
I'm a bit confused as to why HighPhraseHighTerm and some
[
https://issues.apache.org/jira/browse/LUCENE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872151#comment-16872151
]
Adrien Grand commented on LUCENE-8806:
--
FYI we have an issue for phrases already LUCENE-8311.
>
[
https://issues.apache.org/jira/browse/LUCENE-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871732#comment-16871732
]
Adrien Grand commented on LUCENE-8875:
--
Aggregates don't have this issue since they don't track top
[
https://issues.apache.org/jira/browse/LUCENE-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871560#comment-16871560
]
Adrien Grand commented on LUCENE-8875:
--
What do you mean by bucket aggregates?
> Should
[
https://issues.apache.org/jira/browse/LUCENE-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871508#comment-16871508
]
Adrien Grand commented on LUCENE-8875:
--
I like pre-populating the hit queue mostly because it makes
[
https://issues.apache.org/jira/browse/LUCENE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871491#comment-16871491
]
Adrien Grand commented on LUCENE-8870:
--
I think this new constructor would be misleading. For
[
https://issues.apache.org/jira/browse/LUCENE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871436#comment-16871436
]
Adrien Grand commented on LUCENE-8806:
--
+1
Can you run luceneutil on some disjunctions of phrase
[
https://issues.apache.org/jira/browse/LUCENE-8876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871408#comment-16871408
]
Adrien Grand commented on LUCENE-8876:
--
I agree that the use of "applicable" suggests that the THEN
[
https://issues.apache.org/jira/browse/LUCENE-8868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868334#comment-16868334
]
Adrien Grand commented on LUCENE-8868:
--
Is the index-time overhead noticeable? I'm thinking this
[
https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868322#comment-16868322
]
Adrien Grand commented on LUCENE-8855:
--
Thanks Andrzej this looks like a better trade-off to me in
[
https://issues.apache.org/jira/browse/LUCENE-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867284#comment-16867284
]
Adrien Grand commented on LUCENE-8858:
--
Thanks [~janhoy] and [~hossman]!
> Migrate Lucene's Moin
[
https://issues.apache.org/jira/browse/LUCENE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866873#comment-16866873
]
Adrien Grand commented on LUCENE-8867:
--
+1 to split
> Optimise BKD tree for low cardinality leaves
[
https://issues.apache.org/jira/browse/LUCENE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866830#comment-16866830
]
Adrien Grand commented on LUCENE-8867:
--
Sorry, reading my comment again I realize it wasn't clear.
[
https://issues.apache.org/jira/browse/LUCENE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866785#comment-16866785
]
Adrien Grand commented on LUCENE-8867:
--
This is only an issue in the case that not all dimensions
[
https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866782#comment-16866782
]
Adrien Grand commented on LUCENE-8769:
--
It feels a bit wrong to me to implement support for AND and
[
https://issues.apache.org/jira/browse/LUCENE-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866720#comment-16866720
]
Adrien Grand commented on LUCENE-8853:
--
I had to change the random directory creation logic to only
[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8796.
--
Resolution: Fixed
Fix Version/s: 8.2
master (9.0)
> Use exponential
[
https://issues.apache.org/jira/browse/LUCENE-8856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866462#comment-16866462
]
Adrien Grand commented on LUCENE-8856:
--
+1
> Move Intervals query from sandbox to queries module
>
[
https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866460#comment-16866460
]
Adrien Grand commented on LUCENE-8862:
--
Right, but the benefit of doing it from within the
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866456#comment-16866456
]
Adrien Grand commented on LUCENE-8811:
--
+1 from me, I'd like [~romseygeek] to have a look at the
[
https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866447#comment-16866447
]
Adrien Grand commented on LUCENE-8862:
--
bq. your thought is that the memory tracker itself have a
[
https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866445#comment-16866445
]
Adrien Grand commented on LUCENE-8855:
--
Would it be an option to use a visitor that assumes some
[
https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866436#comment-16866436
]
Adrien Grand commented on LUCENE-8862:
--
Could you pass the MemoryTrackerObject that you mentioned
[
https://issues.apache.org/jira/browse/LUCENE-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866424#comment-16866424
]
Adrien Grand commented on LUCENE-8859:
--
I don't think it would be too bad since reading the FST
[
https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866364#comment-16866364
]
Adrien Grand commented on LUCENE-8862:
--
I'd like to avoid adding new methods to the collector API
[
https://issues.apache.org/jira/browse/LUCENE-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865884#comment-16865884
]
Adrien Grand commented on LUCENE-8859:
--
I don't have objections to exposing this option. This makes
[
https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865879#comment-16865879
]
Adrien Grand commented on LUCENE-8862:
--
I see. Do we need a visitor at all, we could pass the
[
https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865859#comment-16865859
]
Adrien Grand commented on LUCENE-8862:
--
One you have a visitor API, how would you implement
[
https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865469#comment-16865469
]
Adrien Grand commented on LUCENE-8862:
--
Memory accounting has a cost API-wise. Like queries, I
[
https://issues.apache.org/jira/browse/LUCENE-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865402#comment-16865402
]
Adrien Grand commented on LUCENE-8766:
--
[~romseygeek] FYI this seems to make the smoke tester a bit
[
https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864245#comment-16864245
]
Adrien Grand commented on LUCENE-8855:
--
I had the temptation to make Query implement Accountable a
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863944#comment-16863944
]
Adrien Grand commented on LUCENE-8829:
--
I'm fine with dropping the ability to set shard indices on
Adrien Grand created LUCENE-8860:
Summary: LatLonShapeBoundingBoxQuery could make more decisions on
inner nodes
Key: LUCENE-8860
URL: https://issues.apache.org/jira/browse/LUCENE-8860
Project: Lucene
[
https://issues.apache.org/jira/browse/LUCENE-8854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862456#comment-16862456
]
Adrien Grand commented on LUCENE-8854:
--
I can't find the issue but I think we had discussions in
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861964#comment-16861964
]
Adrien Grand commented on LUCENE-8811:
--
In general this looks good to me, I'd like to give
[
https://issues.apache.org/jira/browse/LUCENE-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861861#comment-16861861
]
Adrien Grand commented on LUCENE-8839:
--
I agree it is simple to do, but my feeling is that this
[
https://issues.apache.org/jira/browse/LUCENE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-8851:
-
Attachment: LUCENE-8851-6.patch
Status: Open (was: Open)
Attach LUCENE-8851-6.patch
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860697#comment-16860697
]
Adrien Grand commented on LUCENE-8829:
--
bq. You mean that use docID based tie breaking iff
[
https://issues.apache.org/jira/browse/LUCENE-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8843.
--
Resolution: Fixed
Fix Version/s: 8.2
master (9.0)
Thanks
[
https://issues.apache.org/jira/browse/LUCENE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-8851:
-
Attachment: LUCENE-8851-5.patch
> Test issue for Adrien - ignore
>
[
https://issues.apache.org/jira/browse/LUCENE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860652#comment-16860652
]
Adrien Grand commented on LUCENE-8851:
--
Using the "Comment" dialog for file LUCENE-8851-5.patch.
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860649#comment-16860649
]
Adrien Grand commented on LUCENE-8829:
--
bq. However, if setShardIndex = false, then that also
[
https://issues.apache.org/jira/browse/LUCENE-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860639#comment-16860639
]
Adrien Grand commented on LUCENE-8839:
--
Ah, thanks for clarifying. I think some users will want to
[
https://issues.apache.org/jira/browse/LUCENE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860627#comment-16860627
]
Adrien Grand commented on LUCENE-8851:
--
Other comment.
> Test issue for Adrien - ignore
>
[
https://issues.apache.org/jira/browse/LUCENE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860622#comment-16860622
]
Adrien Grand commented on LUCENE-8851:
--
Comment 1. [^LUCENE-8851.patch]
> Test issue for Adrien -
Adrien Grand created LUCENE-8851:
Summary: Test issue for Adrien - ignore
Key: LUCENE-8851
URL: https://issues.apache.org/jira/browse/LUCENE-8851
Project: Lucene - Core
Issue Type: Bug
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860111#comment-16860111
]
Adrien Grand commented on LUCENE-8829:
--
The change makes sense to me logically but the API is a bit
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8362.
--
Resolution: Fixed
Fix Version/s: 8.2
master (9.0)
> Add DocValue
[
https://issues.apache.org/jira/browse/LUCENE-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8815.
--
Resolution: Fixed
Fix Version/s: 8.2
master (9.0)
> Enable
[
https://issues.apache.org/jira/browse/LUCENE-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8834.
--
Resolution: Fixed
Fix Version/s: 8.2
master (9.0)
> Cache the
[
https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860017#comment-16860017
]
Adrien Grand commented on LUCENE-8769:
--
I don't think AND support is really interesting, since it
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859988#comment-16859988
]
Adrien Grand commented on LUCENE-8362:
--
FYI I slightly modified your patch to give range values a
[
https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-8769:
-
Comment: was deleted
(was: FYI I slightly modified your patch to give range values a good
[
https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859986#comment-16859986
]
Adrien Grand commented on LUCENE-8769:
--
FYI I slightly modified your patch to give range values a
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859854#comment-16859854
]
Adrien Grand commented on LUCENE-8362:
--
Thanks Atri, this looks good in general. I only spotted one
[
https://issues.apache.org/jira/browse/LUCENE-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859206#comment-16859206
]
Adrien Grand commented on LUCENE-8841:
--
Yes that would be possible.
> Explore Relevance Based
[
https://issues.apache.org/jira/browse/LUCENE-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859181#comment-16859181
]
Adrien Grand commented on LUCENE-8841:
--
It used to be an Apache project. :) (Lucene subproject
[
https://issues.apache.org/jira/browse/LUCENE-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8825.
--
Resolution: Fixed
Fix Version/s: 8.2
master (9.0)
> Improve Print
[
https://issues.apache.org/jira/browse/LUCENE-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858703#comment-16858703
]
Adrien Grand commented on LUCENE-8839:
--
I don't understand how the goal of this issue differs from
[
https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858391#comment-16858391
]
Adrien Grand commented on LUCENE-8791:
--
My concern is that we are introducing complexity for a
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857376#comment-16857376
]
Adrien Grand commented on LUCENE-8362:
--
Could we move it to the same package as
[
https://issues.apache.org/jira/browse/LUCENE-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857375#comment-16857375
]
Adrien Grand commented on LUCENE-8825:
--
Yes it's on my TODO list. I'm off today but I should be
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857035#comment-16857035
]
Adrien Grand commented on LUCENE-8362:
--
This looks good in general, some minor comments:
- tests
[
https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857019#comment-16857019
]
Adrien Grand commented on LUCENE-8150:
--
No they are not, I removed the fixVersion.
> Remove
[
https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-8150:
-
Fix Version/s: (was: master (9.0))
> Remove references to segments.gen.
>
[
https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-8150:
-
Fix Version/s: (was: 8.1)
> Remove references to segments.gen.
>
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856672#comment-16856672
]
Adrien Grand commented on LUCENE-8362:
--
I'll have a look today.
> Add DocValue support for
[
https://issues.apache.org/jira/browse/LUCENE-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856658#comment-16856658
]
Adrien Grand commented on LUCENE-8825:
--
+1 it looks useful to me
> Improve Print Info Of CheckHits
[
https://issues.apache.org/jira/browse/LUCENE-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855970#comment-16855970
]
Adrien Grand commented on LUCENE-8819:
--
TopDocs#merge has two use-cases, one is to merge results
[
https://issues.apache.org/jira/browse/LUCENE-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855964#comment-16855964
]
Adrien Grand commented on LUCENE-8830:
--
The logic looks fine to me, the omitNorms flag is just set
[
https://issues.apache.org/jira/browse/LUCENE-8796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855534#comment-16855534
]
Adrien Grand commented on LUCENE-8796:
--
Hmm it's disappointing it's not making things noticeably
[
https://issues.apache.org/jira/browse/LUCENE-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-8803.
--
Resolution: Fixed
Fix Version/s: 8.2
master (9.0)
> Provide a
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855432#comment-16855432
]
Adrien Grand commented on LUCENE-8362:
--
Thanks [~atris] I like how this is structured in general.
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850635#comment-16850635
]
Adrien Grand commented on LUCENE-8811:
--
I'm wondering whether IndexSearcher could return "this" in
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850577#comment-16850577
]
Adrien Grand commented on LUCENE-8362:
--
Thanks Atri. I missed the part about "exactly match" in
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849507#comment-16849507
]
Adrien Grand commented on LUCENE-8362:
--
This would be the right implementation indeed!
> Add
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849445#comment-16849445
]
Adrien Grand commented on LUCENE-8362:
--
I had a quick look. The code organization looks good in
[
https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848917#comment-16848917
]
Adrien Grand commented on LUCENE-8362:
--
I like the approach, I'd just reduce visibility of new code
[
https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848908#comment-16848908
]
Adrien Grand commented on LUCENE-8791:
--
bq. Sometimes this set is not that small, Documents may be
101 - 200 of 4980 matches
Mail list logo
