[jira] [Commented] (LUCENE-8806) WANDScorer should support two-phase iterator

[ https://issues.apache.org/jira/browse/LUCENE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848902#comment-16848902 ] Adrien Grand commented on LUCENE-8806: -- The change to correct. Regarding tests, could you have a

[jira] [Commented] (LUCENE-8808) Introduce Optional Cap on Number Of Threads Per Query

[ https://issues.apache.org/jira/browse/LUCENE-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847715#comment-16847715 ] Adrien Grand commented on LUCENE-8808: -- Sorry I don't. This is a hard problem. Your approach makes

[jira] [Commented] (LUCENE-8808) Introduce Optional Cap on Number Of Threads Per Query

[ https://issues.apache.org/jira/browse/LUCENE-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847400#comment-16847400 ] Adrien Grand commented on LUCENE-8808: -- In general I'm reluctant to adding more configuration

[jira] [Resolved] (LUCENE-7386) Flatten nested disjunctions

[ https://issues.apache.org/jira/browse/LUCENE-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-7386. -- Resolution: Fixed Fix Version/s: master (9.0) 8.1 > Flatten nested

[jira] [Commented] (LUCENE-8810) Flattening of nested disjunctions does not take into account number of clause limitation of builder

[ https://issues.apache.org/jira/browse/LUCENE-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847343#comment-16847343 ] Adrien Grand commented on LUCENE-8810: -- Doing instanceof checks feels too fragile to me, this won't

[jira] [Commented] (LUCENE-8810) Flattening of nested disjunctions does not take into account number of clause limitation of builder

[ https://issues.apache.org/jira/browse/LUCENE-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847320#comment-16847320 ] Adrien Grand commented on LUCENE-8810: -- I'm expecting that this would mostly be an issue for users

[jira] [Created] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

Adrien Grand created LUCENE-8811: Summary: Add maximum clause count check to IndexSearcher rather than BooleanQuery Key: LUCENE-8811 URL: https://issues.apache.org/jira/browse/LUCENE-8811 Project:

[jira] [Commented] (LUCENE-8808) Introduce Optional Cap on Number Of Threads Per Query

[ https://issues.apache.org/jira/browse/LUCENE-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845828#comment-16845828 ] Adrien Grand commented on LUCENE-8808: -- I don't think it really fixes the problem, it only makes it

[jira] [Commented] (LUCENE-8362) Add DocValue support for RangeFields

[ https://issues.apache.org/jira/browse/LUCENE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845816#comment-16845816 ] Adrien Grand commented on LUCENE-8362: -- I agree this could be useful in conjunction with

[jira] [Commented] (LUCENE-8808) Introduce Optional Cap on Number Of Threads Per Query

[ https://issues.apache.org/jira/browse/LUCENE-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845802#comment-16845802 ] Adrien Grand commented on LUCENE-8808: -- Can you explain the use-case a bit more? What does it buy

[jira] [Resolved] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8757. -- Resolution: Fixed Fix Version/s: 8.2 master (9.0) Merged, thanks

[jira] [Resolved] (LUCENE-8805) Parameter changes for stringField() in StoredFieldVisitor

[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8805. -- Resolution: Fixed Fix Version/s: master (9.0) Thanks [~danmuzi], I just merged your

[jira] [Commented] (LUCENE-8807) Change all download URLs in build files to HTTPS

[ https://issues.apache.org/jira/browse/LUCENE-8807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845009#comment-16845009 ] Adrien Grand commented on LUCENE-8807: -- As usual, thanks [~thetaphi] for taking care of these

[jira] [Commented] (LUCENE-8727) IndexSearcher#search(Query,int) should operate on a shared priority queue when configured with an executor

[ https://issues.apache.org/jira/browse/LUCENE-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844817#comment-16844817 ] Adrien Grand commented on LUCENE-8727: -- I mentioned a shared priority queue in the description, but

[jira] [Commented] (LUCENE-8788) Order LeafReaderContexts by Estimated Number Of Hits

[ https://issues.apache.org/jira/browse/LUCENE-8788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844820#comment-16844820 ] Adrien Grand commented on LUCENE-8788: -- I think this is definitely worth exploring. It looks like a

[jira] [Commented] (LUCENE-8788) Order LeafReaderContexts by Estimated Number Of Hits

[ https://issues.apache.org/jira/browse/LUCENE-8788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844796#comment-16844796 ] Adrien Grand commented on LUCENE-8788: -- Do I get your idea right that your plan is to select

[jira] [Commented] (LUCENE-8770) BlockMaxConjunctionScorer should support two-phase scorers

[ https://issues.apache.org/jira/browse/LUCENE-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844618#comment-16844618 ] Adrien Grand commented on LUCENE-8770: -- +1 > BlockMaxConjunctionScorer should support two-phase

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844595#comment-16844595 ] Adrien Grand commented on LUCENE-8757: -- [~atris] I think it is still not correct since the values

[jira] [Comment Edited] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844198#comment-16844198 ] Adrien Grand edited comment on LUCENE-8757 at 5/20/19 6:30 PM: --- Thanks

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844198#comment-16844198 ] Adrien Grand commented on LUCENE-8757: -- Thanks [~atris]. I think there is a bug in

[jira] [Commented] (LUCENE-8805) Parameter changes for stringField() in StoredFieldVisitor

[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844183#comment-16844183 ] Adrien Grand commented on LUCENE-8805: -- The patch looks good in general. In SolrDocumentFetcher,

[jira] [Commented] (LUCENE-8791) Add CollectorRescorer

[ https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844029#comment-16844029 ] Adrien Grand commented on LUCENE-8791: -- bq. Yes, We run CPU intensive ML models to rescore hits, it

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844013#comment-16844013 ] Adrien Grand commented on LUCENE-8757: -- I think we could add an assertion for this in

[jira] [Commented] (LUCENE-8770) BlockMaxConjunctionScorer should support two-phase scorers

[ https://issues.apache.org/jira/browse/LUCENE-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844001#comment-16844001 ] Adrien Grand commented on LUCENE-8770: -- This is great. I wonder how useful computing the score in

[jira] [Commented] (LUCENE-8804) FieldType attribute map should not be modifiable after freeze

[ https://issues.apache.org/jira/browse/LUCENE-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843979#comment-16843979 ] Adrien Grand commented on LUCENE-8804: -- This makes sense to me. [~mikemccand] Any objections? >

[jira] [Commented] (LUCENE-8689) Boolean DocValues Codec Implementation

[ https://issues.apache.org/jira/browse/LUCENE-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843945#comment-16843945 ] Adrien Grand commented on LUCENE-8689: -- [~Dmitry Popov] Since your codec only iterates on ones at

[jira] [Commented] (LUCENE-8805) Parameter changes for binaryField() and stringField() in StoredFieldVisitor

[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843931#comment-16843931 ] Adrien Grand commented on LUCENE-8805: -- I like how passing a String to stringField makes the API

[jira] [Commented] (LUCENE-4012) Make all query classes serializable, and provide a query parser to consume them

[ https://issues.apache.org/jira/browse/LUCENE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843910#comment-16843910 ] Adrien Grand commented on LUCENE-4012: -- bq. My thought is that each query parser could potentially

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843876#comment-16843876 ] Adrien Grand commented on LUCENE-8757: -- [~atris] Your last patch sorts in reverse order of docBase,

[jira] [Commented] (LUCENE-8799) Add Force Commit Method to RandomIndexWriter

[ https://issues.apache.org/jira/browse/LUCENE-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840620#comment-16840620 ] Adrien Grand commented on LUCENE-8799: -- [~atris] I don't have a checkout of the code locally so

[jira] [Commented] (LUCENE-8799) Add Force Commit Method to RandomIndexWriter

[ https://issues.apache.org/jira/browse/LUCENE-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839913#comment-16839913 ] Adrien Grand commented on LUCENE-8799: -- What does it do differently than

[jira] [Commented] (LUCENE-7697) IndexSearcher should leverage index sorting

[ https://issues.apache.org/jira/browse/LUCENE-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838371#comment-16838371 ] Adrien Grand commented on LUCENE-7697: -- I am not, but [~jtibshirani] recently mentioned to me that

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838363#comment-16838363 ] Adrien Grand commented on LUCENE-8757: -- Yes. Top-docs collectors are expected to tie-break by doc

[jira] [Resolved] (LUCENE-7697) IndexSearcher should leverage index sorting

[ https://issues.apache.org/jira/browse/LUCENE-7697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-7697. -- Resolution: Duplicate Oops, actually I've done what I had in mind in LUCENE-8059, I had

[jira] [Commented] (LUCENE-8791) Add CollectorRescorer

[ https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838136#comment-16838136 ] Adrien Grand commented on LUCENE-8791: -- I like the idea of a collector-based rescorer so that you

[jira] [Commented] (LUCENE-8795) ArrayIndexOutOfBoundsException during System.arraycopy in BKDWriter

[ https://issues.apache.org/jira/browse/LUCENE-8795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838132#comment-16838132 ] Adrien Grand commented on LUCENE-8795: -- TestBKD

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838131#comment-16838131 ] Adrien Grand commented on LUCENE-8757: -- I think we need to sort by docBase before constructing the

[jira] [Resolved] (LUCENE-8795) ArrayIndexOutOfBoundsException during System.arraycopy in BKDWriter

[ https://issues.apache.org/jira/browse/LUCENE-8795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8795. -- Resolution: Won't Fix Closing since this looks like a JVM bug. >

[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch

[ https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834714#comment-16834714 ] Adrien Grand commented on LUCENE-7840: -- +1 > BooleanQuery.rewriteNoScoring - optimize away any

[jira] [Commented] (LUCENE-8795) ArrayIndexOutOfBoundsException during System.arraycopy in BKDWriter

[ https://issues.apache.org/jira/browse/LUCENE-8795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834709#comment-16834709 ] Adrien Grand commented on LUCENE-8795: -- I just did a quick review, here is the code for this

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827026#comment-16827026 ] Adrien Grand commented on LUCENE-8776: -- I am sorry that this change broke your use-case, but

[jira] [Created] (LUCENE-8779) MinHashFilter generates invalid terms

Adrien Grand created LUCENE-8779: Summary: MinHashFilter generates invalid terms Key: LUCENE-8779 URL: https://issues.apache.org/jira/browse/LUCENE-8779 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824974#comment-16824974 ] Adrien Grand commented on LUCENE-8776: -- I'd rather keep this check for the reasons Robert

[jira] [Commented] (LUCENE-8768) Javadoc search support

[ https://issues.apache.org/jira/browse/LUCENE-8768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821800#comment-16821800 ] Adrien Grand commented on LUCENE-8768: -- [~thetaphi] Any thoughts about this? > Javadoc search

[jira] [Resolved] (LUCENE-8154) TODO List when upgrading to Java 9 as minimum requirement

[ https://issues.apache.org/jira/browse/LUCENE-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8154. -- Resolution: Implemented [~erickerickson] Indeed, this is superseded by LUCENE-8738. > TODO

[jira] [Commented] (LUCENE-8765) OneDimensionBKDWriter valueCount validation didn't include leafCount

[ https://issues.apache.org/jira/browse/LUCENE-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820188#comment-16820188 ] Adrien Grand commented on LUCENE-8765: -- Good catch! This patch seems to have been created off an

[jira] [Commented] (LUCENE-8759) BlockMaxConjunctionScorer's simplified way of computing max scores hurts performance

[ https://issues.apache.org/jira/browse/LUCENE-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819305#comment-16819305 ] Adrien Grand commented on LUCENE-8759: -- Maybe the test could explicitly test both normal and

[jira] [Commented] (LUCENE-8759) BlockMaxConjunctionScorer's simplified way of computing max scores hurts performance

[ https://issues.apache.org/jira/browse/LUCENE-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819154#comment-16819154 ] Adrien Grand commented on LUCENE-8759: -- I gave a try at simplifying this a bit and have the

[jira] [Commented] (LUCENE-8759) BlockMaxConjunctionScorer's simplified way of computing max scores hurts performance

[ https://issues.apache.org/jira/browse/LUCENE-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818980#comment-16818980 ] Adrien Grand commented on LUCENE-8759: -- I'm wondering whether the logic could be simplified: the

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818207#comment-16818207 ] Adrien Grand commented on LUCENE-8738: -- +1 on the suggested short-term workaround > Bump minimum

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817665#comment-16817665 ] Adrien Grand commented on LUCENE-8738: -- Feel free to send it, +1 for tomorrow CEST. > Bump minimum

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817616#comment-16817616 ] Adrien Grand commented on LUCENE-8738: -- Thanks Uwe. Sorry for the late reply, +1 to send an email

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816072#comment-16816072 ] Adrien Grand commented on LUCENE-8738: -- Agreed it would be simpler to just call queueCoreClose()

[jira] [Commented] (LUCENE-8725) Make TermsQuery.SeekingTermSetTermsEnum public

[ https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815143#comment-16815143 ] Adrien Grand commented on LUCENE-8725: -- +1 to the patch, let's maybe make it internal rather than

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814823#comment-16814823 ] Adrien Grand commented on LUCENE-8738: -- [~thetaphi] I tested Eclipse indeed. I only had issue with

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814577#comment-16814577 ] Adrien Grand commented on LUCENE-8738: -- [~thetaphi] Do you know what still needs to be done before

[jira] [Created] (LUCENE-8762) Lucene50PostingsReader should specialize reading docs+freqs with impacts

Adrien Grand created LUCENE-8762: Summary: Lucene50PostingsReader should specialize reading docs+freqs with impacts Key: LUCENE-8762 URL: https://issues.apache.org/jira/browse/LUCENE-8762 Project:

[jira] [Created] (LUCENE-8760) Reconsider the best way to encode postings now that we can skip non-competitive hits

Adrien Grand created LUCENE-8760: Summary: Reconsider the best way to encode postings now that we can skip non-competitive hits Key: LUCENE-8760 URL: https://issues.apache.org/jira/browse/LUCENE-8760

[jira] [Created] (LUCENE-8759) BlockMaxConjunctionScorer's simplified way of computing max scores hurts performance

Adrien Grand created LUCENE-8759: Summary: BlockMaxConjunctionScorer's simplified way of computing max scores hurts performance Key: LUCENE-8759 URL: https://issues.apache.org/jira/browse/LUCENE-8759

[jira] [Resolved] (LUCENE-8619) Decrease I/O pressure of OfflineSorter

[ https://issues.apache.org/jira/browse/LUCENE-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8619. -- Resolution: Not A Problem This isn't a problem anymore now that Ignacio rewrote the merging

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813565#comment-16813565 ] Adrien Grand commented on LUCENE-8738: -- Sorry Uwe, I don't understand what you are suggesting. >

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813445#comment-16813445 ] Adrien Grand commented on LUCENE-8738: -- Apparently the issue can be worked around by calling the

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813346#comment-16813346 ] Adrien Grand commented on LUCENE-8738: -- There seems to be issues with links to the standard API. I

[jira] [Commented] (LUCENE-7386) Flatten nested disjunctions

[ https://issues.apache.org/jira/browse/LUCENE-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813211#comment-16813211 ] Adrien Grand commented on LUCENE-7386: -- For the record I had to disable the verification of scores

[jira] [Commented] (LUCENE-8708) Can we simplify conjunctions of range queries automatically?

[ https://issues.apache.org/jira/browse/LUCENE-8708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813199#comment-16813199 ] Adrien Grand commented on LUCENE-8708: -- Thanks Atri for giving it a try! This change is a bit too

[jira] [Commented] (LUCENE-8753) New PostingFormat - UniformSplit

[ https://issues.apache.org/jira/browse/LUCENE-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813164#comment-16813164 ] Adrien Grand commented on LUCENE-8753: -- bq. BlockTree and UniformSplit had the same QPS for Term

[jira] [Commented] (LUCENE-8747) Allow access to Weight and submatches from Matches instances

[ https://issues.apache.org/jira/browse/LUCENE-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811015#comment-16811015 ] Adrien Grand commented on LUCENE-8747: -- Is getWeight really needed or could you pull an iterator

[jira] [Commented] (LUCENE-8749) Proposal: Pluggable Interface for Slice Allocation Algorithm

[ https://issues.apache.org/jira/browse/LUCENE-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810987#comment-16810987 ] Adrien Grand commented on LUCENE-8749: -- I'm wondering whether customizing slices would actually be

[jira] [Commented] (LUCENE-8751) Weight#matches should use the scorerSupplier to create scorers

[ https://issues.apache.org/jira/browse/LUCENE-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810980#comment-16810980 ] Adrien Grand commented on LUCENE-8751: -- +1 > Weight#matches should use the scorerSupplier to

[jira] [Commented] (LUCENE-8701) Speed up ToParentBlockJoinQuery when total hit count is not needed

[ https://issues.apache.org/jira/browse/LUCENE-8701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810659#comment-16810659 ] Adrien Grand commented on LUCENE-8701: -- +1 it looks good. Maybe we should call searcher#rewrite

[jira] [Commented] (LUCENE-8688) Forced merges merge more than necessary

[ https://issues.apache.org/jira/browse/LUCENE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810629#comment-16810629 ] Adrien Grand commented on LUCENE-8688: -- I backported to branch_7_7 as well in case we do a new

[jira] [Updated] (LUCENE-8688) Forced merges merge more than necessary

[ https://issues.apache.org/jira/browse/LUCENE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8688: - Fix Version/s: 7.7.2 > Forced merges merge more than necessary >

[jira] [Commented] (LUCENE-8753) New PostingFormat - UniformSplit

[ https://issues.apache.org/jira/browse/LUCENE-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808813#comment-16808813 ] Adrien Grand commented on LUCENE-8753: -- I haven't read the pdf or the patch yet. The LowTerm

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808610#comment-16808610 ] Adrien Grand commented on LUCENE-8738: -- +1 The other part that needs reviews is the replacement of

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808503#comment-16808503 ] Adrien Grand commented on LUCENE-8738: -- +1 to disable jtidy for now > Bump minimum Java version

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808415#comment-16808415 ] Adrien Grand commented on LUCENE-8738: -- Currently the build prevents tidy from running if the Java

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807848#comment-16807848 ] Adrien Grand commented on LUCENE-8738: -- [~thetaphi] I'm curious if you have an idea how to make

[jira] [Commented] (LUCENE-8732) Allow ConstantScoreQuery to skip counting hits

[ https://issues.apache.org/jira/browse/LUCENE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804163#comment-16804163 ] Adrien Grand commented on LUCENE-8732: -- If someone has time to look, I think we have a similar

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801064#comment-16801064 ] Adrien Grand commented on LUCENE-8739: -- Zstd looks great indeed. We'd need a pure Java impl if we

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801036#comment-16801036 ] Adrien Grand commented on LUCENE-8738: -- You argued to keep this code around in the vote thread,

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800943#comment-16800943 ] Adrien Grand commented on LUCENE-8738: -- [~thetaphi] Feel free to heavy commit, I don't plan to

[jira] [Commented] (LUCENE-8738) Bump minimum Java version requirement to 11

[ https://issues.apache.org/jira/browse/LUCENE-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800921#comment-16800921 ] Adrien Grand commented on LUCENE-8738: -- Hi Uwe, thanks for this checklist. I have started looking

[jira] [Created] (LUCENE-8738) Bump minimum version requirement to 11

Adrien Grand created LUCENE-8738: Summary: Bump minimum version requirement to 11 Key: LUCENE-8738 URL: https://issues.apache.org/jira/browse/LUCENE-8738 Project: Lucene - Core Issue Type:

[jira] [Resolved] (LUCENE-8737) Simon poortman

[ https://issues.apache.org/jira/browse/LUCENE-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8737. -- Resolution: Invalid Fix Version/s: (was: Positions Branch) I'm assuming this was a

[jira] [Commented] (LUCENE-8732) Allow ConstantScoreQuery to skip counting hits

[ https://issues.apache.org/jira/browse/LUCENE-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798867#comment-16798867 ] Adrien Grand commented on LUCENE-8732: -- +1 to the approach. Should we keep returning the sub scorer

[jira] [Commented] (LUCENE-8733) retrospectively add @since javadocs for 'intervals' classes

[ https://issues.apache.org/jira/browse/LUCENE-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798313#comment-16798313 ] Adrien Grand commented on LUCENE-8733: -- I have mixed feelings. I have never found the "@since" tag

[jira] [Commented] (LUCENE-8733) retrospectively add @since javadocs for 'intervals' classes

[ https://issues.apache.org/jira/browse/LUCENE-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798295#comment-16798295 ] Adrien Grand commented on LUCENE-8733: -- Most of the classes whose documentation is updated are

[jira] [Commented] (LUCENE-8731) mark MultiTermAwareComponent as deprecated (7.x and 7.7 only)

[ https://issues.apache.org/jira/browse/LUCENE-8731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796413#comment-16796413 ] Adrien Grand commented on LUCENE-8731: -- Let's use the "@Deprecated" annotation on the class in

[jira] [Created] (SOLR-13334) Expose FeatureField

Adrien Grand created SOLR-13334: --- Summary: Expose FeatureField Key: SOLR-13334 URL: https://issues.apache.org/jira/browse/SOLR-13334 Project: Solr Issue Type: Improvement Security Level:

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796063#comment-16796063 ] Adrien Grand commented on SOLR-13289: - +1 to expose these optimizations. I like option 1 better too.

[jira] [Commented] (LUCENE-7958) Give TermInSetQuery better advancing capabilities

[ https://issues.apache.org/jira/browse/LUCENE-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795905#comment-16795905 ] Adrien Grand commented on LUCENE-7958: -- Thanks for sharing [~hermes]. I should resurrect the above

[jira] [Updated] (LUCENE-8150) Remove references to segments.gen.

[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8150: - Attachment: LUCENE-8150.patch > Remove references to segments.gen. >

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795886#comment-16795886 ] Adrien Grand commented on LUCENE-8150: -- Here is a new patch based on the above comments. The

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793604#comment-16793604 ] Adrien Grand commented on LUCENE-8150: -- I could work around it now that I know of this trap, but if

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793597#comment-16793597 ] Adrien Grand commented on LUCENE-8150: -- Indeed! I think it's due to the fact that I'm always

[jira] [Resolved] (LUCENE-8688) Forced merges merge more than necessary

[ https://issues.apache.org/jira/browse/LUCENE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8688. -- Resolution: Fixed Fix Version/s: master (9.0) 8.1 Merged. Thanks

[jira] [Commented] (LUCENE-8725) Make TermsQuery public

[ https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793420#comment-16793420 ] Adrien Grand commented on LUCENE-8725: -- I think it was done this way to make sure that

[jira] [Created] (LUCENE-8727) IndexSearcher#search(Query,int) should operate on a shared priority queue when configured with an executor

Adrien Grand created LUCENE-8727: Summary: IndexSearcher#search(Query,int) should operate on a shared priority queue when configured with an executor Key: LUCENE-8727 URL:

[jira] [Commented] (LUCENE-8688) Forced merges merge more than necessary

[ https://issues.apache.org/jira/browse/LUCENE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792497#comment-16792497 ] Adrien Grand commented on LUCENE-8688: -- bq. otherwise the case of merging from a single segments

[jira] [Commented] (LUCENE-8725) Make TermsQuery public

[ https://issues.apache.org/jira/browse/LUCENE-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792478#comment-16792478 ] Adrien Grand commented on LUCENE-8725: -- Is my assumption correct that you are interested in this

<    1   2   3   4   5   6   7   8   9   10   >