[jira] [Commented] (LUCENE-8688) Forced merges merge more than necessary

2019-03-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791557#comment-16791557 ] Adrien Grand commented on LUCENE-8688: -- Thanks for iterating on this, I think there are still some

[jira] [Commented] (LUCENE-8718) Add docValueCount support for SortedSetDocValues

2019-03-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791485#comment-16791485 ] Adrien Grand commented on LUCENE-8718: -- How different would it be from doing the following from the

[jira] [Commented] (LUCENE-8542) Provide the LeafSlice to CollectorManager.newCollector to save memory on small index slices

2019-03-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791471#comment-16791471 ] Adrien Grand commented on LUCENE-8542: -- bq. the default implementation of slices() may not be

[jira] [Commented] (LUCENE-8542) Provide the LeafSlice to CollectorManager.newCollector to save memory on small index slices

2019-03-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790882#comment-16790882 ] Adrien Grand commented on LUCENE-8542: -- Right I get how it can help with small slices, but at the

[jira] [Commented] (LUCENE-8542) Provide the LeafSlice to CollectorManager.newCollector to save memory on small index slices

2019-03-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790607#comment-16790607 ] Adrien Grand commented on LUCENE-8542: -- I don't think this change really helps as the number of

[jira] [Commented] (LUCENE-8542) Provide the LeafSlice to CollectorManager.newCollector to save memory on small index slices

2019-03-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790497#comment-16790497 ] Adrien Grand commented on LUCENE-8542: -- I think this goes against the use-case that Lucene is

[jira] [Commented] (LUCENE-8721) LatLonShapePolygon and LineQuery fail on shared dateline queries

2019-03-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790349#comment-16790349 ] Adrien Grand commented on LUCENE-8721: -- Should we check whether there is an intersection between

[jira] [Commented] (LUCENE-8718) Add docValueCount support for SortedSetDocValues

2019-03-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789317#comment-16789317 ] Adrien Grand commented on LUCENE-8718: -- Should we do it? Counts are required with numerics because

[jira] [Commented] (SOLR-13299) Solr 8 RC2 does not start on Windows with SSL/TLS enabled on Java 8

2019-03-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786501#comment-16786501 ] Adrien Grand commented on SOLR-13299: - This looks consistent with what the Linux/MacOS startup script

[jira] [Commented] (LUCENE-8688) Forced merges merge more than necessary

2019-03-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784295#comment-16784295 ] Adrien Grand commented on LUCENE-8688: -- bq. Unfortunately I wasn't quite able to find the new

[jira] [Commented] (LUCENE-8692) IndexWriter.getTragicException() nay not reflect all corrupting exceptions (notably: NoSuchFileException)

2019-03-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783151#comment-16783151 ] Adrien Grand commented on LUCENE-8692: -- bq. the new test seems to have also uncovered some issues

[jira] [Created] (LUCENE-8715) Make Lucene70Codec read-only

2019-03-01 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8715: Summary: Make Lucene70Codec read-only Key: LUCENE-8715 URL: https://issues.apache.org/jira/browse/LUCENE-8715 Project: Lucene - Core Issue Type: Bug

[jira] [Commented] (LUCENE-8709) TestBKDRadixSelector.testRandomLastByteTwoValues failure

2019-03-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781412#comment-16781412 ] Adrien Grand commented on LUCENE-8709: -- A NPE would indicate that we have a bug in our code anyway,

[jira] [Commented] (LUCENE-8688) Forced merges merge more than necessary

2019-02-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780682#comment-16780682 ] Adrien Grand commented on LUCENE-8688: -- Thanks [~original-brownbear] for looking! I had a quick

[jira] [Commented] (LUCENE-8216) Better cross-field scoring

2019-02-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780533#comment-16780533 ] Adrien Grand commented on LUCENE-8216: -- I opened LUCENE-8710 and LUCENE-8711 as follow-ups. >

[jira] [Created] (LUCENE-8711) Move the logic to score across multiple fields to Similarity?

2019-02-28 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8711: Summary: Move the logic to score across multiple fields to Similarity? Key: LUCENE-8711 URL: https://issues.apache.org/jira/browse/LUCENE-8711 Project: Lucene - Core

[jira] [Created] (LUCENE-8710) Support different values of b per field in BM25FQuery

2019-02-28 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8710: Summary: Support different values of b per field in BM25FQuery Key: LUCENE-8710 URL: https://issues.apache.org/jira/browse/LUCENE-8710 Project: Lucene - Core

[jira] [Commented] (LUCENE-8703) Build point writers only when needed on the BKD tree

2019-02-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780360#comment-16780360 ] Adrien Grand commented on LUCENE-8703: -- +1 > Build point writers only when needed on the BKD tree

[jira] [Commented] (LUCENE-8709) TestBKDRadixSelector.testRandomLastByteTwoValues failure

2019-02-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780341#comment-16780341 ] Adrien Grand commented on LUCENE-8709: -- I think I liked the previous patch a bit better as it would

[jira] [Commented] (LUCENE-8614) ArrayIndexOutOfBoundsException in ByteBlockPool

2019-02-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780319#comment-16780319 ] Adrien Grand commented on LUCENE-8614: -- +1 to check for overflows and raise a better error Maybe

[jira] [Commented] (LUCENE-8708) Can we simplify conjunctions of range queries automatically?

2019-02-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777169#comment-16777169 ] Adrien Grand commented on LUCENE-8708: -- Agreed it'd be nice to have this sort of case optimized as

[jira] [Created] (LUCENE-8708) Can we simplify conjunctions of range queries automatically?

2019-02-25 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8708: Summary: Can we simplify conjunctions of range queries automatically? Key: LUCENE-8708 URL: https://issues.apache.org/jira/browse/LUCENE-8708 Project: Lucene - Core

[jira] [Commented] (LUCENE-8696) TestGeo3DPoint.testGeo3DRelations failure

2019-02-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776920#comment-16776920 ] Adrien Grand commented on LUCENE-8696: -- [~kwri...@metacarta.com] FYI your latest commits are

[jira] [Updated] (LUCENE-8705) Compress BKD trees by encoding the difference between two dimensions

2019-02-22 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8705: - Summary: Compress BKD trees by encoding the difference between two dimensions (was: Compress

[jira] [Created] (LUCENE-8705) Compress BKD trees by only encoding the difference between two dimensions

2019-02-21 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8705: Summary: Compress BKD trees by only encoding the difference between two dimensions Key: LUCENE-8705 URL: https://issues.apache.org/jira/browse/LUCENE-8705 Project:

[jira] [Commented] (LUCENE-8701) Speed up ToParentBlockJoinQuery when total hit count is not needed

2019-02-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772231#comment-16772231 ] Adrien Grand commented on LUCENE-8701: -- +1 I think some more comments could make it easier to read.

[jira] [Commented] (LUCENE-8686) TestTaxonomySumValueSource.testRandom Failure

2019-02-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772219#comment-16772219 ] Adrien Grand commented on LUCENE-8686: -- +1 > TestTaxonomySumValueSource.testRandom Failure >

[jira] [Commented] (LUCENE-8565) SimpleQueryParser to support field filtering (aka Add field:text operator)

2019-02-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771744#comment-16771744 ] Adrien Grand commented on LUCENE-8565: -- I like the idea. One thing that I'm wondering is whether

[jira] [Commented] (LUCENE-8292) Fix FilterLeafReader.FilterTermsEnum to delegate all seekExact methods

2019-02-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769128#comment-16769128 ] Adrien Grand commented on LUCENE-8292: -- I don't think there is a perfect fix here, the current

[jira] [Commented] (LUCENE-8689) Boolean DocValues Codec Implementation

2019-02-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766919#comment-16766919 ] Adrien Grand commented on LUCENE-8689: -- cc [~toke] > Boolean DocValues Codec Implementation >

[jira] [Resolved] (LUCENE-8585) Create jump-tables for DocValues at index-time

2019-02-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8585. -- Resolution: Fixed Fix Version/s: 8.0 [~toke] We are about to cut a 8.0 RC so I'm

[jira] [Commented] (LUCENE-8689) Boolean DocValues Codec Implementation

2019-02-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766916#comment-16766916 ] Adrien Grand commented on LUCENE-8689: -- Have you tried a 8.0 snapshot? The codec now encodes the

[jira] [Commented] (LUCENE-8692) IndexWriter.getTragicException() nay not reflect all corrupting exceptions (notably: NoSuchFileException)

2019-02-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766039#comment-16766039 ] Adrien Grand commented on LUCENE-8692: -- I had a quick look and every time the test failed for me it

[jira] [Commented] (LUCENE-8688) Forced merges merge more than necessary

2019-02-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763699#comment-16763699 ] Adrien Grand commented on LUCENE-8688: -- [~erickerickson] This seems to have been introduced in

[jira] [Created] (LUCENE-8688) Forced merges merge more than necessary

2019-02-08 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8688: Summary: Forced merges merge more than necessary Key: LUCENE-8688 URL: https://issues.apache.org/jira/browse/LUCENE-8688 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8673) Use radix partitioning when merging dimensional points

2019-02-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763405#comment-16763405 ] Adrien Grand commented on LUCENE-8673: -- The indexing throughput jump is ridiculous.

[jira] [Commented] (LUCENE-8675) Divide Segment Search Amongst Multiple Threads

2019-02-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758489#comment-16758489 ] Adrien Grand commented on LUCENE-8675: -- If some segments are getting large enough that

[jira] [Commented] (LUCENE-8675) Divide Segment Search Amongst Multiple Threads

2019-01-31 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757568#comment-16757568 ] Adrien Grand commented on LUCENE-8675: -- The best way to address such issues is on top of Lucene by

[jira] [Commented] (LUCENE-8673) Use radix sorting when merging dimensional points

2019-01-31 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757251#comment-16757251 ] Adrien Grand commented on LUCENE-8673: -- The title of this issue and of the PR is a bit confusing

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-01-30 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755945#comment-16755945 ] Adrien Grand commented on LUCENE-8635: -- bq. Does that exlude autogenerated id fields that are uuid,

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-01-29 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755352#comment-16755352 ] Adrien Grand commented on LUCENE-8635: -- Given that the performance hit is mostly on PK lookups,

[jira] [Commented] (LUCENE-8665) Add temporary code in TestBackwardsCompatibility to handle two concurrent releases

2019-01-29 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755148#comment-16755148 ] Adrien Grand commented on LUCENE-8665: -- Given that we need to release 8.0 after 7.7 anyway to make

[jira] [Commented] (LUCENE-8664) Add equals/hashcode to TotalHits

2019-01-29 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754982#comment-16754982 ] Adrien Grand commented on LUCENE-8664: -- I am not sure we should do this, I can't think of any

[jira] [Commented] (LUCENE-8662) Override seekExact(BytesRef) in FilterLeafReader.FilterTermsEnum

2019-01-29 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754976#comment-16754976 ] Adrien Grand commented on LUCENE-8662: -- [~markrmil...@gmail.com] I agree that this index seems to

[jira] [Commented] (LUCENE-8662) Override seekExact(BytesRef) in FilterLeafReader.FilterTermsEnum

2019-01-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754688#comment-16754688 ] Adrien Grand commented on LUCENE-8662: -- Thanks for the ping [~markrmil...@gmail.com].

[jira] [Commented] (LUCENE-8660) Include totalHitsThreshold when tracking total hits in TopDocsCollector

2019-01-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754076#comment-16754076 ] Adrien Grand commented on LUCENE-8660: -- +1 > Include totalHitsThreshold when tracking total hits

[jira] [Commented] (LUCENE-8660) Include totalHitsThreshold when tracking total hits in TopDocsCollector

2019-01-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753872#comment-16753872 ] Adrien Grand commented on LUCENE-8660: -- Thanks [~jim.ferenczi]. I think we also need to update

[jira] [Commented] (LUCENE-8640) validate delimiters when parsing date ranges

2019-01-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753771#comment-16753771 ] Adrien Grand commented on LUCENE-8640: -- +1 > validate delimiters when parsing date ranges >

[jira] [Commented] (LUCENE-8640) validate delimiters when parsing date ranges

2019-01-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753746#comment-16753746 ] Adrien Grand commented on LUCENE-8640: -- [~mkhludnev] This change is causing failures on branch_7x,

[jira] [Commented] (LUCENE-8585) Create jump-tables for DocValues at index-time

2019-01-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752100#comment-16752100 ] Adrien Grand commented on LUCENE-8585: -- I just pushed the above patch. > Create jump-tables for

[jira] [Commented] (LUCENE-8652) Add boosting support in the SynonymQuery

2019-01-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752108#comment-16752108 ] Adrien Grand commented on LUCENE-8652: -- Let's keep the constructor that takes a Term[] on

[jira] [Commented] (LUCENE-8652) Add boosting support in the SynonymQuery

2019-01-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752105#comment-16752105 ] Adrien Grand commented on LUCENE-8652: -- +1 the approach makes sense to me I'm wondering whether we

[jira] [Commented] (LUCENE-8657) CharsRef.compareTo() should always be in UTF-8 order

2019-01-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752059#comment-16752059 ] Adrien Grand commented on LUCENE-8657: -- It might be a bit surprising that CharsRef doesn't not

[jira] [Resolved] (LUCENE-8658) Illegal assertion in WANDScorer

2019-01-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8658. -- Resolution: Fixed Fix Version/s: master (9.0) 8.0 > Illegal

[jira] [Created] (LUCENE-8658) Illegal assertion in WANDScorer

2019-01-24 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8658: Summary: Illegal assertion in WANDScorer Key: LUCENE-8658 URL: https://issues.apache.org/jira/browse/LUCENE-8658 Project: Lucene - Core Issue Type: Bug

[jira] [Commented] (LUCENE-8654) Polygon2D#relateTriangle returns the wrong answer if polygon is inside the triangle

2019-01-22 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748946#comment-16748946 ] Adrien Grand commented on LUCENE-8654: -- Please add a note to the changelog when pushing. >

[jira] [Commented] (LUCENE-8654) Polygon2D#relateTriangle returns the wrong answer if polygon is inside the triangle

2019-01-22 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748937#comment-16748937 ] Adrien Grand commented on LUCENE-8654: -- +1 > Polygon2D#relateTriangle returns the wrong answer if

[jira] [Commented] (LUCENE-8618) MMapDirectory's read ahead on random-access files might trash the OS cache

2019-01-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748139#comment-16748139 ] Adrien Grand commented on LUCENE-8618: -- This index was hot in terms of usage but much larger than

[jira] [Commented] (LUCENE-8585) Create jump-tables for DocValues at index-time

2019-01-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747950#comment-16747950 ] Adrien Grand commented on LUCENE-8585: -- [~toke] I was just playing with this new doc-value format

[jira] [Commented] (LUCENE-8649) LatLonShape: Within and disjoint queries don’t work with indexed multishapes

2019-01-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747805#comment-16747805 ] Adrien Grand commented on LUCENE-8649: -- Thanks Ignacio, it looks good to me, I just have two minor

[jira] [Commented] (LUCENE-8620) Add CONTAINS support for LatLonShape

2019-01-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747768#comment-16747768 ] Adrien Grand commented on LUCENE-8620: -- bq. or I can implement it now and perform some mapping for

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-01-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746576#comment-16746576 ] Adrien Grand commented on LUCENE-8635: -- bq. The PK lookup doesn't concern me much since such

[jira] [Commented] (LUCENE-8585) Create jump-tables for DocValues at index-time

2019-01-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746256#comment-16746256 ] Adrien Grand commented on LUCENE-8585: -- bq. Considering your involvement in this, I suggest I set

[jira] [Commented] (LUCENE-8585) Create jump-tables for DocValues at index-time

2019-01-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745344#comment-16745344 ] Adrien Grand commented on LUCENE-8585: -- bq. BaseDocValuesFormatTestCase focuses on Variable Bits

[jira] [Commented] (LUCENE-8646) Add multi-term intervals

2019-01-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745081#comment-16745081 ] Adrien Grand commented on LUCENE-8646: -- +1 Thanks for enforcing a maximum number of terms. > Add

[jira] [Commented] (LUCENE-8581) Change LatLonShape encoding to use 4 BYTES Per Dimension

2019-01-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744792#comment-16744792 ] Adrien Grand commented on LUCENE-8581: -- +1 > Change LatLonShape encoding to use 4 BYTES Per

[jira] [Commented] (LUCENE-8634) LatLonShape: Query with the same polygon that is indexed might not match

2019-01-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744233#comment-16744233 ] Adrien Grand commented on LUCENE-8634: -- I think it depends what happens in such a case: would we

[jira] [Commented] (LUCENE-8634) LatLonShape: Query with the same polygon that is indexed might not match

2019-01-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744180#comment-16744180 ] Adrien Grand commented on LUCENE-8634: -- bq. This is the same case as in the tessellator The

[jira] [Commented] (LUCENE-8634) LatLonShape: Query with the same polygon that is indexed might not match

2019-01-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743997#comment-16743997 ] Adrien Grand commented on LUCENE-8634: -- Thanks Ignacio. I understand how it makes things better but

[jira] [Commented] (LUCENE-8635) Lazy loading Lucene FST offheap using mmap

2019-01-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743730#comment-16743730 ] Adrien Grand commented on LUCENE-8635: -- This is pretty cool. I'm happily surprised as well of how

[jira] [Commented] (LUCENE-8620) Add CONTAINS support for LatLonShape

2019-01-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743298#comment-16743298 ] Adrien Grand commented on LUCENE-8620: -- Thanks Ignacio and sorry for taking so long to have a look.

[jira] [Commented] (LUCENE-8636) TestPointQueries times out on nightly

2019-01-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742881#comment-16742881 ] Adrien Grand commented on LUCENE-8636: -- [~dweiss] Yes. I'm unsure what bugs testRandomBinaryBig

[jira] [Commented] (LUCENE-8636) TestPointQueries times out on nightly

2019-01-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742114#comment-16742114 ] Adrien Grand commented on LUCENE-8636: -- Thanks for checking. Maybe we should remove this test then,

[jira] [Commented] (LUCENE-8636) TestPointQueries times out on nightly

2019-01-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742092#comment-16742092 ] Adrien Grand commented on LUCENE-8636: -- Hi Dawid, thanks for looking. It gives the nightly test a

[jira] [Commented] (LUCENE-8623) Decrease I/O pressure when merging high dimensional points

2019-01-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741286#comment-16741286 ] Adrien Grand commented on LUCENE-8623: -- +1 patch looks good. Given how much this helps I'm

[jira] [Commented] (LUCENE-8585) Create jump-tables for DocValues at index-time

2019-01-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740841#comment-16740841 ] Adrien Grand commented on LUCENE-8585: -- Thanks Toke for all the iterations. There are still some

[jira] [Commented] (LUCENE-8585) Create jump-tables for DocValues at index-time

2019-01-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738843#comment-16738843 ] Adrien Grand commented on LUCENE-8585: -- Thanks Toke. Regarding timing, I know [~romseygeek] wants

[jira] [Commented] (LUCENE-8623) Decrease I/O pressure when merging high dimensional points

2019-01-07 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735581#comment-16735581 ] Adrien Grand commented on LUCENE-8623: -- Wow this is a significant reduction indeed. > Decrease I/O

[jira] [Commented] (LUCENE-8627) TestSearchAfter.testQueries() failure

2019-01-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732280#comment-16732280 ] Adrien Grand commented on LUCENE-8627: -- [~erickerickson] This test bug only affects master, 7.x

[jira] [Commented] (LUCENE-8585) Create jump-tables for DocValues at index-time

2018-12-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726857#comment-16726857 ] Adrien Grand commented on LUCENE-8585: -- I'm fine either way. Even if we don't add it today, it will

[jira] [Created] (LUCENE-8621) Move LatLonShape out of sandbox

2018-12-21 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8621: Summary: Move LatLonShape out of sandbox Key: LUCENE-8621 URL: https://issues.apache.org/jira/browse/LUCENE-8621 Project: Lucene - Core Issue Type:

[jira] [Created] (LUCENE-8619) Decrease I/O pressure of OfflineSorter

2018-12-21 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8619: Summary: Decrease I/O pressure of OfflineSorter Key: LUCENE-8619 URL: https://issues.apache.org/jira/browse/LUCENE-8619 Project: Lucene - Core Issue Type:

[jira] [Resolved] (LUCENE-8600) DocValuesFieldUpdates should use a better sort

2018-12-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8600. -- Resolution: Fixed Fix Version/s: 7.7 master (8.0) >

[jira] [Created] (LUCENE-8618) MMapDirectory's read ahead on random-access files might trash the OS cache

2018-12-21 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8618: Summary: MMapDirectory's read ahead on random-access files might trash the OS cache Key: LUCENE-8618 URL: https://issues.apache.org/jira/browse/LUCENE-8618 Project:

[jira] [Commented] (LUCENE-8612) Add the ability to enforce gaps between intervals

2018-12-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726655#comment-16726655 ] Adrien Grand commented on LUCENE-8612: -- Looks good. I'm wondering whether we should return

[jira] [Commented] (LUCENE-8585) Create jump-tables for DocValues at index-time

2018-12-21 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726650#comment-16726650 ] Adrien Grand commented on LUCENE-8585: -- Thanks Toke, I'll have a look today. > Create jump-tables

[jira] [Commented] (LUCENE-8581) Change LatLonShape encoding to use 4 BYTES Per Dimension

2018-12-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726112#comment-16726112 ] Adrien Grand commented on LUCENE-8581: -- bq. Why is Rectangle2D referring to LatLonShape.BYTES ?

[jira] [Created] (LUCENE-8615) Can LatLonShape's tessellator create more search-efficient triangles?

2018-12-20 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8615: Summary: Can LatLonShape's tessellator create more search-efficient triangles? Key: LUCENE-8615 URL: https://issues.apache.org/jira/browse/LUCENE-8615 Project:

[jira] [Commented] (LUCENE-8581) Change LatLonShape encoding to use 4 BYTES Per Dimension

2018-12-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724781#comment-16724781 ] Adrien Grand commented on LUCENE-8581: -- According to luceneutil this change gives 8% faster box

[jira] [Commented] (LUCENE-8585) Create jump-tables for DocValues at index-time

2018-12-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724413#comment-16724413 ] Adrien Grand commented on LUCENE-8585: -- My understanding of [~romseygeek]'s proposal to cut a

[jira] [Commented] (LUCENE-8581) Change LatLonShape encoding to use 4 BYTES Per Dimension

2018-12-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724186#comment-16724186 ] Adrien Grand commented on LUCENE-8581: -- +1 > Change LatLonShape encoding to use 4 BYTES Per

[jira] [Commented] (LUCENE-8581) Change LatLonShape encoding to use 4 BYTES Per Dimension

2018-12-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723189#comment-16723189 ] Adrien Grand commented on LUCENE-8581: -- Then let's also rename constants so that they enumerate

[jira] [Commented] (LUCENE-8601) Adding attributes to IndexFieldType

2018-12-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723036#comment-16723036 ] Adrien Grand commented on LUCENE-8601: -- Should the copy constructor of FieldType clone the

[jira] [Resolved] (LUCENE-8315) Make FeatureField easier to use

2018-12-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8315. -- Resolution: Fixed Fix Version/s: 7.4 master (8.0) > Make

[jira] [Resolved] (LUCENE-8207) Add case insensitive support to RegExp

2018-12-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8207. -- Resolution: Won't Fix > Add case insensitive support to RegExp >

[jira] [Resolved] (LUCENE-8072) Improve accuracy of similarity scores

2018-12-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8072. -- Resolution: Won't Fix > Improve accuracy of similarity scores >

[jira] [Commented] (LUCENE-8581) Change LatLonShape encoding to use 4 BYTES Per Dimension

2018-12-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721336#comment-16721336 ] Adrien Grand commented on LUCENE-8581: -- +1 Let's get [~nknize]'s opinion about whether to go with

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721085#comment-16721085 ] Adrien Grand commented on LUCENE-8609: -- +1 to deprecate > Allow getting consistent docstats from

[jira] [Commented] (LUCENE-8585) Create jump-tables for DocValues at index-time

2018-12-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719167#comment-16719167 ] Adrien Grand commented on LUCENE-8585: -- Thanks Toke, I'll give it a look by the end of the week.

[jira] [Commented] (LUCENE-8607) Allow MatchAllDocsQuery to skip counting hits

2018-12-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719145#comment-16719145 ] Adrien Grand commented on LUCENE-8607: -- +1 > Allow MatchAllDocsQuery to skip counting hits >

<    1   2   3   4   5   6   7   8   9   10   >