[
https://issues.apache.org/jira/browse/LUCENE-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055537#comment-16055537
]
Dawid Weiss commented on LUCENE-7883:
-
I can look into the clustering plugin's use of it. I recall it
[
https://issues.apache.org/jira/browse/LUCENE-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055255#comment-16055255
]
Dawid Weiss commented on LUCENE-7873:
-
LGTM.
> Remove context classloader from SPI lookups by
[
https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053984#comment-16053984
]
Dawid Weiss edited comment on LUCENE-7882 at 6/19/17 1:27 PM:
--
It probably
[
https://issues.apache.org/jira/browse/LUCENE-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053984#comment-16053984
]
Dawid Weiss commented on LUCENE-7882:
-
It probably does because they're loaded into their own class
[
https://issues.apache.org/jira/browse/LUCENE-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053892#comment-16053892
]
Dawid Weiss commented on LUCENE-7848:
-
This isn't urgent and can wait.
As for indexing graphs, I
[
https://issues.apache.org/jira/browse/LUCENE-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053806#comment-16053806
]
Dawid Weiss commented on LUCENE-7848:
-
Couldn't resist not to look. The index is fine. The query
[
https://issues.apache.org/jira/browse/LUCENE-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7848:
Attachment: capture-3.png
Token graph for the input (indexing and search is the same).
>
[
https://issues.apache.org/jira/browse/LUCENE-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7848:
Attachment: LUCENE-7848.patch
Here's a test (testLucene7848) that reproduces the behavior observed
[
https://issues.apache.org/jira/browse/LUCENE-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053739#comment-16053739
]
Dawid Weiss commented on LUCENE-7848:
-
Hi Jim,
The patch looks ok, although it doesn't solve the
[
https://issues.apache.org/jira/browse/LUCENE-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052152#comment-16052152
]
Dawid Weiss commented on LUCENE-7848:
-
On short holidays, Jim, but I'll try to review next week.
[
https://issues.apache.org/jira/browse/SOLR-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048773#comment-16048773
]
Dawid Weiss commented on SOLR-10760:
bq. [...] and then advise people to add trie field declarations
[
https://issues.apache.org/jira/browse/SOLR-10849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved SOLR-10849.
Resolution: Fixed
Fix Version/s: 6.7
master (7.0)
> MoreLikeThisComponent
[
https://issues.apache.org/jira/browse/LUCENE-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-7870.
-
Resolution: Invalid
I mark this as invalid then; I think we've reached the consensus that it's
[
https://issues.apache.org/jira/browse/SOLR-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043152#comment-16043152
]
Dawid Weiss commented on SOLR-10844:
Crap. Sorry Hoss, you're right.
> group.facet failures when the
[
https://issues.apache.org/jira/browse/LUCENE-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042657#comment-16042657
]
Dawid Weiss commented on LUCENE-7870:
-
One quick follow up. Read section 5.3 too: it declares the
[
https://issues.apache.org/jira/browse/LUCENE-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042650#comment-16042650
]
Dawid Weiss commented on LUCENE-7870:
-
I recall this came as a surprise to me too, actually -- I once
[
https://issues.apache.org/jira/browse/LUCENE-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042611#comment-16042611
]
Dawid Weiss commented on LUCENE-7870:
-
I understand the issue, but somehow don't believe calling
[
https://issues.apache.org/jira/browse/SOLR-10849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated SOLR-10849:
---
Attachment: SOLR-10849.patch
> MoreLikeThisComponent should expose setMaxDocFreqPct (maxDoc frequency
Dawid Weiss created SOLR-10849:
--
Summary: MoreLikeThisComponent should expose setMaxDocFreqPct
(maxDoc frequency percentage)
Key: SOLR-10849
URL: https://issues.apache.org/jira/browse/SOLR-10849
[
https://issues.apache.org/jira/browse/LUCENE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-7864.
-
Resolution: Fixed
Fix Version/s: master (7.0)
> IndexMergeTool is not using intermediate
[
https://issues.apache.org/jira/browse/SOLR-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042268#comment-16042268
]
Dawid Weiss commented on SOLR-10844:
I think it's a duplicate of SOLR-9989?
> group.facet failures
[
https://issues.apache.org/jira/browse/LUCENE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7864:
Attachment: LUCENE-7864.patch
> IndexMergeTool is not using intermediate hard links (even if
Dawid Weiss created LUCENE-7864:
---
Summary: IndexMergeTool is not using intermediate hard links (even
if possible)
Key: LUCENE-7864
URL: https://issues.apache.org/jira/browse/LUCENE-7864
Project: Lucene
[
https://issues.apache.org/jira/browse/SOLR-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027356#comment-16027356
]
Dawid Weiss edited comment on SOLR-10760 at 5/27/17 8:21 AM:
-
Just a note -
[
https://issues.apache.org/jira/browse/SOLR-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027356#comment-16027356
]
Dawid Weiss commented on SOLR-10760:
Just a note - the problem I recently hit with a new type of this
[
https://issues.apache.org/jira/browse/LUCENE-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026129#comment-16026129
]
Dawid Weiss commented on LUCENE-7848:
-
{code}
Analyzer a4 = new Analyzer() {
@Override
[
https://issues.apache.org/jira/browse/LUCENE-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024639#comment-16024639
]
Dawid Weiss commented on LUCENE-7841:
-
That depends on what you understand by "fix for". I use the
[
https://issues.apache.org/jira/browse/LUCENE-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-7841.
-
Resolution: Fixed
Scheduled this for 6.7 so that we don't have to rush it in at the last moment.
[
https://issues.apache.org/jira/browse/LUCENE-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7841:
Fix Version/s: 6.7
master (7.0)
6.x
> Normalize ґ to г in
[
https://issues.apache.org/jira/browse/LUCENE-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reassigned LUCENE-7841:
---
Assignee: Dawid Weiss
> Normalize ґ to г in Ukrainian analyzer
>
[
https://issues.apache.org/jira/browse/LUCENE-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021325#comment-16021325
]
Dawid Weiss commented on LUCENE-7848:
-
Thanks Jim. I agree the output from the filter looks odd too,
[
https://issues.apache.org/jira/browse/LUCENE-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020955#comment-16020955
]
Dawid Weiss commented on LUCENE-7841:
-
Andriy, you need to regenerate jar checksums if you're
[
https://issues.apache.org/jira/browse/LUCENE-7842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-7842.
-
Resolution: Invalid
Apologies, I think it's my fault.
> WordDelimiterGraphFilter adds an extra
[
https://issues.apache.org/jira/browse/LUCENE-7842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7842:
Attachment: capture-5.png
> WordDelimiterGraphFilter adds an extra position for "foo - bar"
>
Dawid Weiss created LUCENE-7842:
---
Summary: WordDelimiterGraphFilter adds an extra position for "foo
- bar"
Key: LUCENE-7842
URL: https://issues.apache.org/jira/browse/LUCENE-7842
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-7800.
-
Resolution: Fixed
Fix Version/s: 6.7
> Remove code that potentially rethrows checked
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012204#comment-16012204
]
Dawid Weiss commented on LUCENE-7800:
-
In fact, we could even use it for the attribute factory too --
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012203#comment-16012203
]
Dawid Weiss commented on LUCENE-7800:
-
Very good idea, will use that.
> Remove code that potentially
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7800:
Attachment: LUCENE-7800.patch
Precommit (javadoc) and ParseException unwrapping in the compiler
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7800:
Attachment: LUCENE-7800.patch
I return to this issue to either resolve it or have it vetoed,
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010414#comment-16010414
]
Dawid Weiss edited comment on LUCENE-7800 at 5/15/17 12:30 PM:
---
I return to
[
https://issues.apache.org/jira/browse/SOLR-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010338#comment-16010338
]
Dawid Weiss commented on SOLR-10678:
I looked at it, here's a summary of my findings.
1) Clustering
[
https://issues.apache.org/jira/browse/SOLR-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved SOLR-10678.
Resolution: Invalid
> Clustering can be executed multiple times in distributed mode
>
[
https://issues.apache.org/jira/browse/SOLR-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010338#comment-16010338
]
Dawid Weiss edited comment on SOLR-10678 at 5/15/17 11:21 AM:
--
I looked at
[
https://issues.apache.org/jira/browse/SOLR-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008598#comment-16008598
]
Dawid Weiss commented on SOLR-10678:
Clustering should run when the search results are collected. In
[
https://issues.apache.org/jira/browse/SOLR-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008017#comment-16008017
]
Dawid Weiss commented on SOLR-10678:
My current understanding of what's going on is that we indeed run
[
https://issues.apache.org/jira/browse/SOLR-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated SOLR-10678:
---
Description: As reported on SO:
Dawid Weiss created SOLR-10678:
--
Summary: Clustering can be executed multiple times in distributed
mode
Key: SOLR-10678
URL: https://issues.apache.org/jira/browse/SOLR-10678
Project: Solr
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reassigned LUCENE-7800:
---
Assignee: Dawid Weiss
> Remove code that potentially rethrows checked exceptions from
[
https://issues.apache.org/jira/browse/LUCENE-7514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989906#comment-15989906
]
Dawid Weiss commented on LUCENE-7514:
-
Didn't look, but I once replaced float generation with
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988610#comment-15988610
]
Dawid Weiss edited comment on LUCENE-7800 at 4/28/17 10:32 AM:
---
Moving the
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988610#comment-15988610
]
Dawid Weiss commented on LUCENE-7800:
-
Moving the discussion here from LUCENE-7796. Uwe, I don't
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-7796.
-
Resolution: Fixed
Fix Version/s: 6.6
> Make reThrow idiom declare Error return type so
[
https://issues.apache.org/jira/browse/SOLR-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated SOLR-10581:
---
Affects Version/s: master (7.0)
> Json update handler doesn't support nested documents in streaming
[
https://issues.apache.org/jira/browse/SOLR-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988285#comment-15988285
]
Dawid Weiss commented on SOLR-10581:
I don't have {{mapUniqueKeyOnly=true}} in my 6.2.1 configuration
[
https://issues.apache.org/jira/browse/SOLR-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated SOLR-10581:
---
Description:
Posting nested documents to {{/update/json/docs}} doesn't seem to work for me
(but
[
https://issues.apache.org/jira/browse/SOLR-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated SOLR-10581:
---
Description:
Posting nested documents to {{/update/json/docs}} doesn't seem to work for me
(but
[
https://issues.apache.org/jira/browse/SOLR-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reopened SOLR-10581:
Actually, still a bug I think.
> Json update handler doesn't support nested documents in streaming
[
https://issues.apache.org/jira/browse/SOLR-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved SOLR-10581.
Resolution: Invalid
Fixed in SOLR-7123, apologies for the noise.
> Json update handler doesn't
Dawid Weiss created SOLR-10581:
--
Summary: Json update handler doesn't support nested documents in
streaming mode
Key: SOLR-10581
URL: https://issues.apache.org/jira/browse/SOLR-10581
Project: Solr
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7796:
Attachment: LUCENE-7796.patch
> Make reThrow idiom declare Error return type so callers may use it
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986780#comment-15986780
]
Dawid Weiss commented on LUCENE-7796:
-
I ran several dozen runs of the full core (Lucene) test suite.
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7796:
Summary: Make reThrow idiom declare Error return type so callers may use it
in a way that compiler
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984740#comment-15984740
]
Dawid Weiss commented on LUCENE-7796:
-
I'll let this bake on my test machine for a bit and see I can
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984687#comment-15984687
]
Dawid Weiss commented on LUCENE-7796:
-
I am very confident in my changes. :) I mostly changed places
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984637#comment-15984637
]
Dawid Weiss commented on LUCENE-7796:
-
bq. Are you really sure exceptions are never null in all these
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984605#comment-15984605
]
Dawid Weiss commented on LUCENE-7796:
-
I agree we should rename the method.
bq. By the way, I think
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984575#comment-15984575
]
Dawid Weiss edited comment on LUCENE-7796 at 4/26/17 11:00 AM:
---
TL;DR; I
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984575#comment-15984575
]
Dawid Weiss edited comment on LUCENE-7796 at 4/26/17 10:59 AM:
---
TL;DR; I
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7796:
Attachment: LUCENE-7796.patch
TL;DR; I looked at all occurrences of rethrow (ioutils) and I really
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982608#comment-15982608
]
Dawid Weiss commented on LUCENE-7796:
-
Hi Uwe. Let me know what you think about the above before this
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980353#comment-15980353
]
Dawid Weiss commented on LUCENE-7796:
-
bq. Did you know that the Class#newInstance() also throws
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980321#comment-15980321
]
Dawid Weiss edited comment on LUCENE-7800 at 4/23/17 8:28 AM:
--
bq. The
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980321#comment-15980321
]
Dawid Weiss commented on LUCENE-7800:
-
bq. The MethodHandles called there are known to not throw
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980321#comment-15980321
]
Dawid Weiss edited comment on LUCENE-7800 at 4/23/17 8:28 AM:
--
bq. The
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980320#comment-15980320
]
Dawid Weiss commented on LUCENE-7796:
-
bq. That's not true. It is misuse, but behavior is still
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7800:
Description:
For a long time I considered the "sneaky" throw hack to be a nice way of coding
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7800:
Attachment: LUCENE-7800.patch
Patch removing sneaky throw from attribute factory and snowball
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7800:
Fix Version/s: 6.x
> Remove code that potentially rethrows checked exceptions from methods that
>
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7800:
Priority: Minor (was: Major)
> Remove code that potentially rethrows checked exceptions from
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7800:
Fix Version/s: master (7.0)
> Remove code that potentially rethrows checked exceptions from
[
https://issues.apache.org/jira/browse/LUCENE-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7800:
Summary: Remove code that potentially rethrows checked exceptions from
methods that don't declare
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980077#comment-15980077
]
Dawid Weiss commented on LUCENE-7796:
-
I agree: the rethrow-checked hack is essentially an abuse of
Dawid Weiss created LUCENE-7800:
---
Summary: Remove "
Key: LUCENE-7800
URL: https://issues.apache.org/jira/browse/LUCENE-7800
Project: Lucene - Core
Issue Type: Task
Reporter: Dawid
[
https://issues.apache.org/jira/browse/LUCENE-7792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980070#comment-15980070
]
Dawid Weiss commented on LUCENE-7792:
-
Looks good to me. I'd be picky with naming and change two
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979293#comment-15979293
]
Dawid Weiss commented on LUCENE-7796:
-
This is what I think IOUtils.reThrow* methods should look
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979280#comment-15979280
]
Dawid Weiss commented on LUCENE-7796:
-
I looked at the code now. The test-framework's {{Rethrow}} is
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979258#comment-15979258
]
Dawid Weiss commented on LUCENE-7796:
-
That has to be an unchecked exception, Hoss, not Throwable (or
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7796:
Summary: Make reThrow idiom declare RuntimeException return type so callers
may use it in a way
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978274#comment-15978274
]
Dawid Weiss commented on LUCENE-7796:
-
No problem, my description wasn't clear and was meant as a
[
https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978259#comment-15978259
]
Dawid Weiss commented on LUCENE-7796:
-
Sorry, I wasn't clear -- this method would *still*
Dawid Weiss created LUCENE-7796:
---
Summary: Make reThrow idiom return Throwable to enforce code
unreachability
Key: LUCENE-7796
URL: https://issues.apache.org/jira/browse/LUCENE-7796
Project: Lucene -
[
https://issues.apache.org/jira/browse/LUCENE-7792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978202#comment-15978202
]
Dawid Weiss commented on LUCENE-7792:
-
I'll file a separate issue for reThrow.
As for executor
[
https://issues.apache.org/jira/browse/LUCENE-7792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976659#comment-15976659
]
Dawid Weiss commented on LUCENE-7792:
-
Looks good looking at the patch alone. It could be probably
[
https://issues.apache.org/jira/browse/LUCENE-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7785:
Fix Version/s: 6.6
> Move dictionary for Ukrainian analyzer to external dependency
>
[
https://issues.apache.org/jira/browse/LUCENE-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974465#comment-15974465
]
Dawid Weiss commented on LUCENE-7785:
-
Thanks Andriy, Steve!
> Move dictionary for Ukrainian
[
https://issues.apache.org/jira/browse/LUCENE-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-7785.
-
Resolution: Fixed
Fix Version/s: 6.x
> Move dictionary for Ukrainian analyzer to external
[
https://issues.apache.org/jira/browse/LUCENE-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7785:
Fix Version/s: master (7.0)
> Move dictionary for Ukrainian analyzer to external dependency
>
[
https://issues.apache.org/jira/browse/LUCENE-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974408#comment-15974408
]
Dawid Weiss commented on LUCENE-7785:
-
Will merge this in.
> Move dictionary for Ukrainian analyzer
[
https://issues.apache.org/jira/browse/LUCENE-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-7785:
Priority: Minor (was: Major)
> Move dictionary for Ukrainian analyzer to external dependency
>
501 - 600 of 2721 matches
Mail list logo
