[
https://issues.apache.org/jira/browse/SOLR-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423163#comment-16423163
]
Varun Thacker commented on SOLR-12154:
--
{quote}Does that also cover log4j 1.2?
{quote}
Yeah it does
[
https://issues.apache.org/jira/browse/SOLR-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12154:
-
Attachment: SOLR-12154.patch
> Disallow Log4j2 explicit usage via forbidden APIs
>
[
https://issues.apache.org/jira/browse/SOLR-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423159#comment-16423159
]
Varun Thacker commented on SOLR-12144:
--
+1 LGTM
> Remove SOLR_LOG_PRESTART_ROTATION and leverage
[
https://issues.apache.org/jira/browse/SOLR-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423127#comment-16423127
]
Varun Thacker commented on SOLR-12144:
--
{quote} Guess the reason for {{solr.N.log}} being default in
[
https://issues.apache.org/jira/browse/SOLR-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422912#comment-16422912
]
Varun Thacker commented on SOLR-12163:
--
{quote}I can't find any reference to a {{zookeeper-env.sh}}
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker resolved SOLR-7887.
-
Resolution: Fixed
> Upgrade Solr to use log4j2 -- log4j 1 now officially end of life
>
[
https://issues.apache.org/jira/browse/SOLR-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422784#comment-16422784
]
Varun Thacker commented on SOLR-12144:
--
{quote}We should either document this so people who change
[
https://issues.apache.org/jira/browse/SOLR-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420934#comment-16420934
]
Varun Thacker commented on SOLR-12163:
--
1. "Any shards or Solr instances" -> "All remaining Solr
[
https://issues.apache.org/jira/browse/SOLR-12065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420787#comment-16420787
]
Varun Thacker commented on SOLR-12065:
--
Lastly, if you upload the patch as SOLR-12065.patch , you can
[
https://issues.apache.org/jira/browse/SOLR-12065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420785#comment-16420785
]
Varun Thacker commented on SOLR-12065:
--
Hi Rohit,
Thanks for the patch. This looks great!
Some
[
https://issues.apache.org/jira/browse/SOLR-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419663#comment-16419663
]
Varun Thacker commented on SOLR-12163:
--
This looks great!
I need to read it more thoroughly but one
[
https://issues.apache.org/jira/browse/SOLR-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12164:
-
Comment: was deleted
(was: This looks great!
I need to read it more thoroughly but one thing
[
https://issues.apache.org/jira/browse/SOLR-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419648#comment-16419648
]
Varun Thacker commented on SOLR-12164:
--
This looks great!
I need to read it more thoroughly but
[
https://issues.apache.org/jira/browse/SOLR-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416549#comment-16416549
]
Varun Thacker commented on SOLR-12154:
--
Very quick patch. There is a nocommit in there and also
[
https://issues.apache.org/jira/browse/SOLR-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12154:
-
Attachment: SOLR-12154.patch
> Disallow Log4j2 explicit usage via forbidden APIs
>
[
https://issues.apache.org/jira/browse/SOLR-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416531#comment-16416531
]
Varun Thacker commented on SOLR-12154:
--
Some of these classes already suppress the forbidden message
[
https://issues.apache.org/jira/browse/SOLR-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12154:
-
Description:
We need to add org.apache.logging.log4j.** to forbidden APIs
From
[
https://issues.apache.org/jira/browse/SOLR-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12154:
-
Description:
We need to add org.apache.logging.log4j.** to forbidden APIs
From
[
https://issues.apache.org/jira/browse/SOLR-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12154:
-
Issue Type: Sub-task (was: Task)
Security: (was: Public)
Parent: SOLR-7887
>
Varun Thacker created SOLR-12154:
Summary: Disallow Log4j2 explicit usage via forbidden APIs
Key: SOLR-12154
URL: https://issues.apache.org/jira/browse/SOLR-12154
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415909#comment-16415909
]
Varun Thacker commented on SOLR-12144:
--
+1 to defaulting SOLR_LOG_PRESTART_ROTATION to false. I
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414905#comment-16414905
]
Varun Thacker commented on SOLR-7887:
-
{quote}How about we do that change in master? A new major
[
https://issues.apache.org/jira/browse/SOLR-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414826#comment-16414826
]
Varun Thacker commented on SOLR-12144:
--
SOLR_LOG_PRESTART_ROTATION also archives console logs and gc
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414824#comment-16414824
]
Varun Thacker commented on SOLR-7887:
-
[~janhoy] I created SOLR-12144 to track the work to remove
Varun Thacker created SOLR-12144:
Summary: Remove SOLR_LOG_PRESTART_ROTATION and leverage log4j2
Key: SOLR-12144
URL: https://issues.apache.org/jira/browse/SOLR-12144
Project: Solr
Issue
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414760#comment-16414760
]
Varun Thacker commented on SOLR-7887:
-
Updated patch for the 2nd round of followups
- Patch merges and
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-7887:
Attachment: SOLR-7887_followup_2.patch
> Upgrade Solr to use log4j2 -- log4j 1 now officially end of
[
https://issues.apache.org/jira/browse/SOLR-11948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker reassigned SOLR-11948:
Assignee: Varun Thacker
> Move the lang-configurations from managed-schema to its own xml
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414742#comment-16414742
]
Varun Thacker commented on SOLR-7887:
-
{quote}Did the follow-up patch make it to 7x? (everybody's a
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414735#comment-16414735
]
Varun Thacker commented on SOLR-7887:
-
Makes a lot of sense. I'm happy to tackle that but maybe we
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414700#comment-16414700
]
Varun Thacker commented on SOLR-7887:
-
{quote}I wonder if the changelog should indicate that this is a
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414667#comment-16414667
]
Varun Thacker edited comment on SOLR-7887 at 3/26/18 10:33 PM:
---
[~koji] while
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414667#comment-16414667
]
Varun Thacker commented on SOLR-7887:
-
[~koji] while upgrading log4j.properties for prometheus
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414594#comment-16414594
]
Varun Thacker commented on SOLR-7887:
-
Thanks [~steve_rowe] for pointing out.
I need to fix a few more
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414576#comment-16414576
]
Varun Thacker edited comment on SOLR-7887 at 3/26/18 9:13 PM:
--
Follow-up
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414576#comment-16414576
]
Varun Thacker commented on SOLR-7887:
-
Follow-up patch2:
- Thanks Ralph for pointing out the url
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-7887:
Attachment: SOLR-7887_followup_2.patch
> Upgrade Solr to use log4j2 -- log4j 1 now officially end of
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414402#comment-16414402
]
Varun Thacker commented on SOLR-7887:
-
{quote}bq. validate the command line flags : rotate_solr_logs ,
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414327#comment-16414327
]
Varun Thacker commented on SOLR-7887:
-
{quote}You mean you can't find it in that file, or can't find
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414281#comment-16414281
]
Varun Thacker commented on SOLR-7887:
-
Small update to the followup patch . the sys prop in the initial
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-7887:
Attachment: SOLR-7887-followup_1.patch
> Upgrade Solr to use log4j2 -- log4j 1 now officially end of
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414215#comment-16414215
]
Varun Thacker commented on SOLR-7887:
-
- Moved CHANGES entry from the Solr 7.3 section to 7.4
- Fixed
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414126#comment-16414126
]
Varun Thacker commented on SOLR-7887:
-
Also I think we need to validate the command line flags :
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413411#comment-16413411
]
Varun Thacker commented on SOLR-7887:
-
Thanks Shalin for pointing it out. You're right we should fix
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413399#comment-16413399
]
Varun Thacker commented on SOLR-7887:
-
5. In solr/contrib/prometheus-exporter/ivy.xml , why is the
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-7887:
Affects Version/s: (was: 5.2.1)
> Upgrade Solr to use log4j2 -- log4j 1 now officially end of
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker reopened SOLR-7887:
-
> Upgrade Solr to use log4j2 -- log4j 1 now officially end of life
>
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413360#comment-16413360
]
Varun Thacker commented on SOLR-7887:
-
I validated two things from the Solr Admin UI
* ERRORs and
[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413115#comment-16413115
]
Varun Thacker commented on SOLR-7887:
-
Thanks Erick!
I'm looking at the patch right now.
The two
[
https://issues.apache.org/jira/browse/SOLR-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412129#comment-16412129
]
Varun Thacker commented on SOLR-10513:
--
{quote}Like {{LevenshteinDistance}}. We want to prove here
[
https://issues.apache.org/jira/browse/SOLR-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411954#comment-16411954
]
Varun Thacker commented on SOLR-10513:
--
Thanks Amrit for the patch and Abhishek for the analysis!
[
https://issues.apache.org/jira/browse/SOLR-12087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408606#comment-16408606
]
Varun Thacker commented on SOLR-12087:
--
Hi Dat,
Great catch!
A couple of minor comments about
[
https://issues.apache.org/jira/browse/SOLR-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker reassigned SOLR-12130:
Assignee: Varun Thacker
> Investigate why CdcrReplicationDistributedZkTest is slow
>
Varun Thacker created SOLR-12130:
Summary: Investigate why CdcrReplicationDistributedZkTest is slow
Key: SOLR-12130
URL: https://issues.apache.org/jira/browse/SOLR-12130
Project: Solr
Issue
[
https://issues.apache.org/jira/browse/SOLR-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12063:
-
Fix Version/s: 7.3
> PeerSync and Leader Election skips delete-by-id and in-place updates when
>
[
https://issues.apache.org/jira/browse/SOLR-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker resolved SOLR-12063.
--
Resolution: Fixed
Thanks Amrit!
> PeerSync and Leader Election skips delete-by-id and in-place
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker resolved SOLR-12083.
--
Resolution: Fixed
Thanks Amrit!
> RealTimeGetComponent fails for INPLACE_UPDATE when Cdcr
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12083:
-
Affects Version/s: (was: 7.3)
> RealTimeGetComponent fails for INPLACE_UPDATE when Cdcr
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12083:
-
Fix Version/s: 7.3
> RealTimeGetComponent fails for INPLACE_UPDATE when Cdcr enabled
>
[
https://issues.apache.org/jira/browse/SOLR-11331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403200#comment-16403200
]
Varun Thacker commented on SOLR-11331:
--
Hi Uwe,
{quote}bq. [~varunthacker]: Should I commit this and
[
https://issues.apache.org/jira/browse/SOLR-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402540#comment-16402540
]
Varun Thacker commented on SOLR-12063:
--
Until INFRA-15850 is resolved the user tagged with the commit
[
https://issues.apache.org/jira/browse/SOLR-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402535#comment-16402535
]
Varun Thacker commented on SOLR-12063:
--
Whoops I tagged SOLR-12083 in the commit message . So the
[
https://issues.apache.org/jira/browse/SOLR-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402529#comment-16402529
]
Varun Thacker commented on SOLR-12063:
--
I've reviewed the latest patch with Amrit offline today.
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399224#comment-16399224
]
Varun Thacker commented on SOLR-12083:
--
Until INFRA-15850 is resolved the user tagged with the commit
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399205#comment-16399205
]
Varun Thacker commented on SOLR-12083:
--
precommit, all tests, beasted 10 rounds of
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12083:
-
Attachment: SOLR-12083.patch
> RealTimeGetComponent fails for INPLACE_UPDATE when Cdcr enabled
>
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399065#comment-16399065
]
Varun Thacker commented on SOLR-12083:
--
Final patch which I think is ready! Thanks Amrit
Running
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12083:
-
Attachment: SOLR-12083.patch
> RealTimeGetComponent fails for INPLACE_UPDATE when Cdcr enabled
>
[
https://issues.apache.org/jira/browse/SOLR-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398115#comment-16398115
]
Varun Thacker commented on SOLR-12063:
--
Okay let's commit SOLR-12083 first and then use the
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398107#comment-16398107
]
Varun Thacker edited comment on SOLR-12083 at 3/14/18 5:21 AM:
---
Thanks Amrit
[
https://issues.apache.org/jira/browse/SOLR-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398113#comment-16398113
]
Varun Thacker commented on SOLR-12063:
--
{quote}{{TestStressRecovery}} throws the {{Unexpected log
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398107#comment-16398107
]
Varun Thacker edited comment on SOLR-12083 at 3/14/18 5:07 AM:
---
Thanks Amrit
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12083:
-
Description:
When we were adding bi-directional sync support in CDCR ( SOLR-11003 ) we
changed
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398107#comment-16398107
]
Varun Thacker commented on SOLR-12083:
--
Thanks Amrit for working on this!
I kind of like the
[
https://issues.apache.org/jira/browse/SOLR-12088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398092#comment-16398092
]
Varun Thacker commented on SOLR-12088:
--
Hi Jerry,
So if I was to put it in another way if this was
Varun Thacker created SOLR-12089:
Summary: FileBasedSpellChecker docs have some missing params
Key: SOLR-12089
URL: https://issues.apache.org/jira/browse/SOLR-12089
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-12087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398058#comment-16398058
]
Varun Thacker commented on SOLR-12087:
--
What's the error from the logs during the delete call?
>
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396602#comment-16396602
]
Varun Thacker commented on SOLR-12083:
--
I'll think about this more but what if we starting
[
https://issues.apache.org/jira/browse/SOLR-11331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-11331:
-
Attachment: SOLR-11331.patch
> Ability to Debug Solr With Eclipse IDE
>
[
https://issues.apache.org/jira/browse/SOLR-11331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396597#comment-16396597
]
Varun Thacker commented on SOLR-11331:
--
Thanks Karthik!
Update the patch with some whitepsace and
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12083:
-
Affects Version/s: 7.3
> RealTimeGetComponent fails for INPLACE_UPDATE when Cdcr enabled
>
[
https://issues.apache.org/jira/browse/SOLR-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12063:
-
Affects Version/s: 7.2.1
> Fix tlog entry indexes in UpdateLog for CDCR to work smoothly.
>
[
https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker reassigned SOLR-12083:
Assignee: Varun Thacker
> RealTimeGetComponent fails for INPLACE_UPDATE when Cdcr enabled
[
https://issues.apache.org/jira/browse/SOLR-11331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-11331:
-
Attachment: SOLR-11331.patch
> Ability to Debug Solr With Eclipse IDE
>
[
https://issues.apache.org/jira/browse/SOLR-11331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker reassigned SOLR-11331:
Assignee: Varun Thacker
> Ability to Debug Solr With Eclipse IDE
>
[
https://issues.apache.org/jira/browse/SOLR-11331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396131#comment-16396131
]
Varun Thacker commented on SOLR-11331:
--
Hi Karthik,
I reviewed your latest patch which folds in the
[
https://issues.apache.org/jira/browse/SOLR-11331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-11331:
-
Attachment: UI.png
> Ability to Debug Solr With Eclipse IDE
>
[
https://issues.apache.org/jira/browse/SOLR-11331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395869#comment-16395869
]
Varun Thacker commented on SOLR-11331:
--
Thanks Karthik for the patch
I applied it locally and I
[
https://issues.apache.org/jira/browse/SOLR-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395728#comment-16395728
]
Varun Thacker commented on SOLR-12063:
--
Hi Amrit,
I'm trying to understand your latest patch.
[
https://issues.apache.org/jira/browse/SOLR-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395644#comment-16395644
]
Varun Thacker commented on SOLR-12076:
--
Until INFRA-15850 is resolved the user tagged with the commit
[
https://issues.apache.org/jira/browse/SOLR-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker reassigned SOLR-12076:
Assignee: Varun Thacker
> Remove more usages of printLayout in CDCR tests
>
[
https://issues.apache.org/jira/browse/SOLR-12051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393888#comment-16393888
]
Varun Thacker commented on SOLR-12051:
--
This might have broken precommit because of an unused import
[
https://issues.apache.org/jira/browse/SOLR-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393840#comment-16393840
]
Varun Thacker edited comment on SOLR-12066 at 3/10/18 12:13 AM:
Here is
[
https://issues.apache.org/jira/browse/SOLR-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393840#comment-16393840
]
Varun Thacker commented on SOLR-12066:
--
Here is another scenario where this happens
* Start a 2
[
https://issues.apache.org/jira/browse/SOLR-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393709#comment-16393709
]
Varun Thacker commented on SOLR-12063:
--
{quote}Somewhere in the test case we are printing all the
[
https://issues.apache.org/jira/browse/SOLR-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393708#comment-16393708
]
Varun Thacker commented on SOLR-12076:
--
Simple patch. I'll run tests and preccommit and then commit
[
https://issues.apache.org/jira/browse/SOLR-12076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12076:
-
Attachment: SOLR-12076.patch
> Remove more usages of printLayout in CDCR tests
>
Varun Thacker created SOLR-12076:
Summary: Remove more usages of printLayout in CDCR tests
Key: SOLR-12076
URL: https://issues.apache.org/jira/browse/SOLR-12076
Project: Solr
Issue Type: Bug
[
https://issues.apache.org/jira/browse/SOLR-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker reassigned SOLR-12071:
Assignee: Varun Thacker
> PULL replica cores initialisation fails when Cdcr enabled
>
[
https://issues.apache.org/jira/browse/SOLR-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393422#comment-16393422
]
Varun Thacker commented on SOLR-12063:
--
Somewhere in the test case we are printing all the data in
601 - 700 of 2287 matches
Mail list logo