[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-15 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722302#comment-16722302 ] Mike Sokolov commented on LUCENE-8609: -- Thanks, [~simonw], I had already made the changes locally,

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-15 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722290#comment-16722290 ] Simon Willnauer commented on LUCENE-8609: - [~sokolov] I opened

Re: [jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-15 Thread Alan Woodward
I’m guessing Mike means the luceneutil benchmarks, which do have some of their own Java code, some of which calls IndexWriter#numDocs() > On 15 Dec 2018, at 10:04, Simon Willnauer wrote: > > > > What benchmarks are you talking about? Can you link them? > >> On 14. Dec 2018, at 23:47, Mike

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722089#comment-16722089 ] ASF subversion and git services commented on LUCENE-8609: - Commit

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722088#comment-16722088 ] ASF subversion and git services commented on LUCENE-8609: - Commit

Re: [jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-15 Thread Simon Willnauer
What benchmarks are you talking about? Can you link them? > On 14. Dec 2018, at 23:47, Mike Sokolov (JIRA) wrote: > > >[ > https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721848#comment-16721848 > ] > > Mike

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-14 Thread Mike Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721848#comment-16721848 ] Mike Sokolov commented on LUCENE-8609: -- I think this will break nightly benchmarks? Anyway I'm

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721699#comment-16721699 ] ASF subversion and git services commented on LUCENE-8609: - Commit

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721673#comment-16721673 ] ASF subversion and git services commented on LUCENE-8609: - Commit

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-14 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721672#comment-16721672 ] ASF subversion and git services commented on LUCENE-8609: - Commit

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-14 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721587#comment-16721587 ] Simon Willnauer commented on LUCENE-8609: - [~mikemccand] [~jpountz] [~dnhatn] I pushed new

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721299#comment-16721299 ] Michael McCandless commented on LUCENE-8609: Yeah +1 to deprecate! > Allow getting

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721085#comment-16721085 ] Adrien Grand commented on LUCENE-8609: -- +1 to deprecate > Allow getting consistent docstats from

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-13 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720453#comment-16720453 ] Nhat Nguyen commented on LUCENE-8609: - +1 to deprecate  maxDoc and numDocs. > Allow getting

[jira] [Commented] (LUCENE-8609) Allow getting consistent docstats from IndexWriter

2018-12-13 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720279#comment-16720279 ] Simon Willnauer commented on LUCENE-8609: - one question here is if we should deprecate the