[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885154#comment-16885154
]
ASF subversion and git services commented on LUCENE-8811:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885121#comment-16885121
]
ASF subversion and git services commented on LUCENE-8811:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885120#comment-16885120
]
ASF subversion and git services commented on LUCENE-8811:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884944#comment-16884944
]
Adrien Grand commented on LUCENE-8811:
--
Thanks! I'll revert this change from 8.x and 8.2 in the
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884939#comment-16884939
]
Atri Sharma commented on LUCENE-8811:
-
[~jpountz] Yeah, that is what I was thinking of, but I see
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884932#comment-16884932
]
Adrien Grand commented on LUCENE-8811:
--
[~atris] If the patch you are thinking of is the one on
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884930#comment-16884930
]
Atri Sharma commented on LUCENE-8811:
-
[~jpountz] I had originally raised a patch which implemented
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884904#comment-16884904
]
Adrien Grand commented on LUCENE-8811:
--
I was reviewing the changelog for 8.2, this change looks a
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873207#comment-16873207
]
Atri Sharma commented on LUCENE-8811:
-
Thanks [~romseygeek] for pushing!
A small nit: I think
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873168#comment-16873168
]
ASF subversion and git services commented on LUCENE-8811:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873169#comment-16873169
]
ASF subversion and git services commented on LUCENE-8811:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873167#comment-16873167
]
ASF subversion and git services commented on LUCENE-8811:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872550#comment-16872550
]
Atri Sharma commented on LUCENE-8811:
-
Any chance we could push this one? Happy to make any changes
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866456#comment-16866456
]
Adrien Grand commented on LUCENE-8811:
--
+1 from me, I'd like [~romseygeek] to have a look at the
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863752#comment-16863752
]
Atri Sharma commented on LUCENE-8811:
-
Please let me know if the patch looks fine. Happy to iterate
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862005#comment-16862005
]
Atri Sharma commented on LUCENE-8811:
-
Thanks [~jpountz], attached is an updated patch
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861964#comment-16861964
]
Adrien Grand commented on LUCENE-8811:
--
In general this looks good to me, I'd like to give
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860937#comment-16860937
]
Atri Sharma commented on LUCENE-8811:
-
[~romseygeek] Please let me know if this looks fine. Thanks
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858721#comment-16858721
]
Atri Sharma commented on LUCENE-8811:
-
[~romseygeek] Please let me know if the current iteration
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858677#comment-16858677
]
Alan Woodward commented on LUCENE-8811:
---
> Check the code, Query.visit by default always calls
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858669#comment-16858669
]
Uwe Schindler commented on LUCENE-8811:
---
This is why I am asking. I had a project and I
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858661#comment-16858661
]
Atri Sharma commented on LUCENE-8811:
-
[~thetaphi] Arent consumeTerms and visitLeaf mutually
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858655#comment-16858655
]
Uwe Schindler commented on LUCENE-8811:
---
I am not sure if it's correct to count in both visitTerms
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858657#comment-16858657
]
Uwe Schindler commented on LUCENE-8811:
---
Otherwise it's a great idea to use visitors.
> Add
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858654#comment-16858654
]
Atri Sharma commented on LUCENE-8811:
-
[~romseygeek] Thanks, attached is an updated patch.
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858641#comment-16858641
]
Alan Woodward commented on LUCENE-8811:
---
That's correct, yes.
> Add maximum clause count check to
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858623#comment-16858623
]
Atri Sharma commented on LUCENE-8811:
-
[~romseygeek] Ok, I misinterpreted your previous comment to
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858602#comment-16858602
]
Alan Woodward commented on LUCENE-8811:
---
Sorry, I wasn't clear - can you move the BooleanQuery max
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858459#comment-16858459
]
Atri Sharma commented on LUCENE-8811:
-
[~romseygeek] Attached is a patch which does just that and
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858414#comment-16858414
]
Alan Woodward commented on LUCENE-8811:
---
Thanks [~atris], this looks very close! I know I said
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858272#comment-16858272
]
Atri Sharma commented on LUCENE-8811:
-
The last patch had an unintentional type: attached is a fixed
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857957#comment-16857957
]
Atri Sharma commented on LUCENE-8811:
-
[~jpountz] [~romseygeek] Attached patch implements a
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852882#comment-16852882
]
Alan Woodward commented on LUCENE-8811:
---
You'd need to count calls to visitLeaf() and
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850635#comment-16850635
]
Adrien Grand commented on LUCENE-8811:
--
I'm wondering whether IndexSearcher could return "this" in
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850621#comment-16850621
]
Atri Sharma commented on LUCENE-8811:
-
[^LUCENE-8811.patch]
[~jpountz] Attached is a patch
[
https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847334#comment-16847334
]
Atri Sharma commented on LUCENE-8811:
-
[~jpountz] Thanks for opening this.
I posted a patch in
36 matches
Mail list logo
