[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864263#comment-16864263
]
Atri Sharma commented on LUCENE-8829:
-
[~jpountz] [~simonw] I have updated LUCENE-8857 to remove
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863946#comment-16863946
]
Atri Sharma commented on LUCENE-8829:
-
+1, I agree
Do you think we should pursue LUCENE-8857 as
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863944#comment-16863944
]
Adrien Grand commented on LUCENE-8829:
--
I'm fine with dropping the ability to set shard indices on
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863075#comment-16863075
]
Atri Sharma commented on LUCENE-8829:
-
bq. I am not sure we have to. Can't a user initialize it
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863067#comment-16863067
]
Simon Willnauer commented on LUCENE-8829:
-
{quote}
Simon Willnauer That is a fun idea, although
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862914#comment-16862914
]
Atri Sharma commented on LUCENE-8829:
-
[~simonw] That is a fun idea, although it would still need a
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861848#comment-16861848
]
Simon Willnauer commented on LUCENE-8829:
-
I'd remove the _ setShardIndex_ parameter alltogether
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861835#comment-16861835
]
Atri Sharma commented on LUCENE-8829:
-
[~simonw] Essentially, allow users to pass in the tie breaker
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861821#comment-16861821
]
Simon Willnauer commented on LUCENE-8829:
-
I do wonder if we can simplify this API now that we
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860923#comment-16860923
]
Atri Sharma commented on LUCENE-8829:
-
[~jpountz] Attached is an updated patch.
I have moved the
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860713#comment-16860713
]
Atri Sharma commented on LUCENE-8829:
-
bq. I mean ordering on score or sort fields, then shardIndex,
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860697#comment-16860697
]
Adrien Grand commented on LUCENE-8829:
--
bq. You mean that use docID based tie breaking iff
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860679#comment-16860679
]
Atri Sharma commented on LUCENE-8829:
-
bq. I wonder whether we could rely on the fact that ScoreDoc
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860649#comment-16860649
]
Adrien Grand commented on LUCENE-8829:
--
bq. However, if setShardIndex = false, then that also
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860621#comment-16860621
]
Atri Sharma commented on LUCENE-8829:
-
[~jpountz] Agreed that the API is a bit weird in the proposed
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860111#comment-16860111
]
Adrien Grand commented on LUCENE-8829:
--
The change makes sense to me logically but the API is a bit
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859212#comment-16859212
]
Atri Sharma commented on LUCENE-8829:
-
[~jpountz] Does it make sense to backport this to earlier
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857501#comment-16857501
]
Atri Sharma commented on LUCENE-8829:
-
Attached is an updated patch with additional tests. I was
[
https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856478#comment-16856478
]
Atri Sharma commented on LUCENE-8829:
-
Attached is a patch implementing a fix for this. Note that
19 matches
Mail list logo
