See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2571/changes
Thanks!
On Nov 18, 2014, at 2:10 AM, Timothy Chen tnac...@apache.org wrote:
On Nov. 17, 2014, 5:37 p.m., Timothy Chen wrote:
Ship It!
I ran the tests on linux too and they passed, going to merge this patch in.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28088/#review61936
---
out of curiousity, did you try running clang-format using the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28088/#review61937
---
out of curiousity, did you try running clang-format using the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28154/#review61938
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28155/#review61939
---
src/common/http.cpp
On Nov. 18, 2014, 9:12 a.m., Dominic Hamon wrote:
include/mesos/mesos.proto, line 601
https://reviews.apache.org/r/28154/diff/1/?file=766841#file766841line601
where is this Parameters struct defined?
should it be
repeated Parameter parameters
to
On Nov. 17, 2014, 9:38 p.m., Timothy Chen wrote:
include/mesos/mesos.proto, line 601
https://reviews.apache.org/r/28154/diff/1/?file=766841#file766841line601
I feel like parameters as the field name on TaskInfo made it sounds
like the parameters required to run this task, but
On Nov. 18, 2014, 9:14 a.m., Dominic Hamon wrote:
src/common/http.cpp, line 133
https://reviews.apache.org/r/28155/diff/1/?file=766843#file766843line133
or:
object.values[parameters] = (task.has_parameters() ?
task.parameters() : );
Will that work when return
On Nov. 18, 2014, 9:14 a.m., Dominic Hamon wrote:
src/common/http.cpp, line 133
https://reviews.apache.org/r/28155/diff/1/?file=766843#file766843line133
or:
object.values[parameters] = (task.has_parameters() ?
task.parameters() : );
Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28142/#review61945
---
src/common/values.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19176/#review61953
---
Adam, do you still want this in? It has been inactive for a while,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17873/#review61954
---
This won't apply with the io changes for libevent; want to close
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19176/#review61955
---
Bad patch!
Reviews applied: [19176]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/
---
(Updated Nov. 18, 2014, 10:41 a.m.)
Review request for mesos and Vinod Kone.
On Nov. 18, 2014, 5:36 p.m., Dominic Hamon wrote:
src/common/values.cpp, line 559
https://reviews.apache.org/r/28142/diff/1/?file=70#file70line559
is there no test for this?
It will be tested in review 28143. But yeah, we should have a test for that.
I'll add one.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28058/#review61991
---
src/tests/metrics_tests.cpp
On Nov. 5, 2014, 12:01 a.m., Vinod Kone wrote:
include/mesos/mesos.proto, line 399
https://reviews.apache.org/r/27550/diff/1/?file=747884#file747884line399
why is this optional instead of required?
Per our discussion. volume can also be used to express non-persistent disks.
See
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27550/
---
(Updated Nov. 18, 2014, 8 p.m.)
Review request for mesos, Ben Mahler and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28141/#review61986
---
Thanks for the clean up! Please (in the future) separate these
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27923/
---
(Updated Nov. 18, 2014, noon)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27550/
---
(Updated Nov. 18, 2014, 8:05 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27550/
---
(Updated Nov. 18, 2014, 8:05 p.m.)
Review request for mesos, Adam B, Benjamin
On Nov. 18, 2014, 11:49 a.m., Vinod Kone wrote:
src/tests/metrics_tests.cpp, lines 152-153
https://reviews.apache.org/r/28058/diff/2/?file=767560#file767560line152
Why start the master?
when i didn't, the slave complained that no master could be found and the test
failed.
-
On Nov. 18, 2014, 7:49 p.m., Vinod Kone wrote:
src/tests/metrics_tests.cpp, lines 152-153
https://reviews.apache.org/r/28058/diff/2/?file=767560#file767560line152
Why start the master?
Dominic Hamon wrote:
when i didn't, the slave complained that no master could be found and
On Nov. 18, 2014, 11:49 a.m., Vinod Kone wrote:
src/tests/metrics_tests.cpp, lines 152-153
https://reviews.apache.org/r/28058/diff/2/?file=767560#file767560line152
Why start the master?
Dominic Hamon wrote:
when i didn't, the slave complained that no master could be found
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28184/
---
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28184/
---
(Updated Nov. 18, 2014, 9:11 p.m.)
Review request for mesos, Benjamin Hindman
On Nov. 4, 2014, 4:48 p.m., Ian Downes wrote:
include/mesos/mesos.proto, line 393
https://reviews.apache.org/r/27550/diff/1/?file=747884#file747884line393
DiskInfo is a very generic name; it's not clear that it's a
*persistent* disk resource. Is there a possible need for Resource
On Nov. 18, 2014, 7:49 p.m., Vinod Kone wrote:
src/tests/metrics_tests.cpp, lines 152-153
https://reviews.apache.org/r/28058/diff/2/?file=767560#file767560line152
Why start the master?
Dominic Hamon wrote:
when i didn't, the slave complained that no master could be found and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28091/#review61825
---
Ship it!
Modulo comments. Looks like this could have been broken
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28154/
---
(Updated Nov. 18, 2014, 2:39 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28156/
---
(Updated Nov. 18, 2014, 2:39 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28155/
---
(Updated Nov. 18, 2014, 2:39 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28157/
---
(Updated Nov. 18, 2014, 2:40 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28188/
---
Review request for mesos.
Repository: mesos-git
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28184/#review62029
---
Patch looks great!
Reviews applied: [28184]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28154/#review62030
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28155/#review62031
---
Ship it!
Ship It!
- Timothy Chen
On Nov. 18, 2014, 10:39 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28156/#review62032
---
Ship it!
Ship It!
- Timothy Chen
On Nov. 18, 2014, 10:39 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27660/#review62035
---
Ship it!
Ship It!
- Adam B
On Nov. 6, 2014, 8:44 a.m., Cody
On Nov. 18, 2014, 2:43 p.m., Timothy Chen wrote:
include/mesos/mesos.proto, line 600
https://reviews.apache.org/r/28154/diff/2/?file=768090#file768090line600
s/end-points/endpoints/g
Thanks - done.
On Nov. 18, 2014, 2:43 p.m., Timothy Chen wrote:
include/mesos/mesos.proto,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28154/#review62038
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28155/#review62040
---
src/common/http.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28157/#review62033
---
src/tests/master_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28158/#review62041
---
src/tests/slave_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28189/
---
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1718
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28188/#review62042
---
Ship it!
Ship It!
- Timothy Chen
On Nov. 18, 2014, 10:40 p.m.,
On Nov. 18, 2014, 2:52 p.m., Timothy Chen wrote:
src/common/http.cpp, line 133
https://reviews.apache.org/r/28155/diff/2/?file=768091#file768091line133
Actually looking at the labels representation, it's much truly
represented as a list of labels, instead of a json object.
On Nov. 18, 2014, 2:50 p.m., Benjamin Hindman wrote:
include/mesos/mesos.proto, line 939
https://reviews.apache.org/r/28154/diff/2/?file=768090#file768090line939
I recall recently I wanted to use Parameters but without having to set
the value. Do you forsee something similar?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28184/#review62045
---
3rdparty/libprocess/src/libev.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Nov. 18, 2014, 3:14 p.m.)
Review request for mesos, Tobias
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28092/#review62048
---
I would actually leave these for now given there's nothing to stop
On Nov. 18, 2014, 11:10 p.m., Dominic Hamon wrote:
3rdparty/libprocess/src/libev.hpp, line 38
https://reviews.apache.org/r/28184/diff/2/?file=767746#file767746line38
double underscores in names are reserved.
I am using the pattern for thread local storage from process.hpp L396 and
On Nov. 18, 2014, 3:10 p.m., Dominic Hamon wrote:
3rdparty/libprocess/src/libev.hpp, line 38
https://reviews.apache.org/r/28184/diff/2/?file=767746#file767746line38
double underscores in names are reserved.
Joris Van Remoortere wrote:
I am using the pattern for thread local
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27923/#review62051
---
I don't think you looked over your diff before you published.. ;)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28188/#review62052
---
Patch looks great!
Reviews applied: [28154, 28155, 28156, 28157,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28143/#review62053
---
Ship it!
Ship It!
- Ben Mahler
On Nov. 18, 2014, 1:35 a.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27550/#review62047
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28142/#review62054
---
Ship it!
Great, I can throw away my branch now! ;)
- Ben Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27550/#review62056
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28195/
---
Review request for mesos, Benjamin Hindman, Dominic Hamon, Niklas Nielsen, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28196/
---
Review request for mesos, Benjamin Hindman, Dominic Hamon, Niklas Nielsen, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28196/
---
(Updated Nov. 19, 2014, 12:06 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28154/
---
(Updated Nov. 18, 2014, 4:06 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28155/
---
(Updated Nov. 18, 2014, 4:07 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28156/
---
(Updated Nov. 18, 2014, 4:07 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28157/
---
(Updated Nov. 18, 2014, 4:08 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28158/
---
(Updated Nov. 18, 2014, 4:08 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28190/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1886
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28154/#review62061
---
Ship it!
Ship It!
- Timothy Chen
On Nov. 19, 2014, 12:06 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28158/#review62064
---
Ship it!
Ship It!
- Timothy Chen
On Nov. 19, 2014, 12:08 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28189/#review62065
---
Bad patch!
Reviews applied: [27923]
Failed command:
On Nov. 18, 2014, 11:55 p.m., Benjamin Hindman wrote:
include/mesos/mesos.proto, line 403
https://reviews.apache.org/r/27550/diff/3/?file=767713#file767713line403
I'm kind of going back and forth about whether or not we should have a
Persistence nested protobuf message. At first
I'd like to propose changes to the protobuf:
1) Correct mem_rss_bytes to report rss from mem.stat, not the total memory
usage!
2) Naming should be consistent with the mem.stat source
3) Source actual limits from the cgroup, not from the desired resource
4) Include swap usage
(1) is particularly
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28195/#review62069
---
Ship it!
Ship It!
3rdparty/libprocess/include/process/future.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28196/#review62070
---
3rdparty/libprocess/include/process/future.hpp
On Nov. 19, 2014, 12:29 a.m., Dominic Hamon wrote:
3rdparty/libprocess/include/process/future.hpp, line 1643
https://reviews.apache.org/r/28196/diff/2/?file=768245#file768245line1643
foreach?
I played around with foreach to test whether it is safe under container
modification (for
On Nov. 8, 2014, 8:14 a.m., Mesos ReviewBot wrote:
Patch looks great!
Reviews applied: [27670]
All tests passed.
Bump: Is there any more review suggestion that need to be incorporated to get
this patch in?
- Ankur
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28154/#review62080
---
include/mesos/mesos.proto
On Nov. 19, 2014, 12:45 a.m., Benjamin Hindman wrote:
include/mesos/mesos.proto, line 937
https://reviews.apache.org/r/28154/diff/3/?file=768237#file768237line937
Why no Labels like Parameters?
The reason we've had these in the past is then we don't have to pass
On Nov. 18, 2014, 4:29 p.m., Dominic Hamon wrote:
3rdparty/libprocess/include/process/future.hpp, line 1643
https://reviews.apache.org/r/28196/diff/2/?file=768245#file768245line1643
foreach?
Joris Van Remoortere wrote:
I played around with foreach to test whether it is safe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28196/#review62089
---
Ship it!
Ship It!
- Dominic Hamon
On Nov. 18, 2014, 4:06 p.m.,
On Nov. 18, 2014, 8 p.m., Ian Downes wrote:
src/slave/containerizer/mesos/containerizer.cpp, line 547
https://reviews.apache.org/r/28141/diff/1/?file=766640#file766640line547
wrap here (and elsewhere) in CHECK_NOTNULL?
All the places already has containers_.contains(containerId)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review62093
---
Patch looks great!
Reviews applied: [27531]
All tests passed.
-
On Nov. 18, 2014, 8 p.m., Ian Downes wrote:
src/tests/containerizer_tests.cpp, line 336
https://reviews.apache.org/r/28141/diff/1/?file=766641#file766641line336
Is it feasible to add a test that verifies the fetcher is killed under
these circumstances? Otherwise, this test would
On Nov. 18, 2014, 8 p.m., Ian Downes wrote:
src/tests/containerizer_tests.cpp, line 336
https://reviews.apache.org/r/28141/diff/1/?file=766641#file766641line336
Is it feasible to add a test that verifies the fetcher is killed under
these circumstances? Otherwise, this test would
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28205/
---
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28190/#review62109
---
Patch looks great!
Reviews applied: [28190]
All tests passed.
-
On Nov. 8, 2014, 8:14 a.m., Mesos ReviewBot wrote:
Patch looks great!
Reviews applied: [27670]
All tests passed.
Ankur Chauhan wrote:
Bump: Is there any more review suggestion that need to be incorporated to
get this patch in?
i was waiting for @benh to ship.
- Vinod
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2574/changes
Changes:
[tnachen] Fixed typo in DockerInfo comment.
--
[...truncated 16796 lines...]
I1119 02:59:31.912489 15758 slave.cpp:323]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28196/#review62117
---
Patch looks great!
Reviews applied: [28195, 28196]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28205/#review62124
---
Patch looks great!
Reviews applied: [28205]
All tests passed.
-
On Nov. 17, 2014, 12:30 p.m., Dominic Hamon wrote:
when we have the HTTP API, there will be no need for a shared libmesos. In
fact, we're considering having wholly static slave and master executables
to avoid some deployment issues we have with partial updates[1].
i understand this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28218/
---
Review request for mesos, Ben Mahler and Niklas Nielsen.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28218/
---
(Updated Nov. 19, 2014, 6:27 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28218/
---
(Updated Nov. 19, 2014, 6:33 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28218/#review62137
---
Patch looks great!
Reviews applied: [28218]
All tests passed.
-
Thanks, Nils!
So far we have five volunteers on the stand proposal; the more the merrier!
I plan to submit the proposal later today so please add your name if you're
interested.
Dave
On Mon, Nov 17, 2014 at 8:57 AM, Nils De Moor nils.de.m...@gmail.com
wrote:
Joined the CFP.
I'm Belgium
On Nov. 18, 2014, 10:28 p.m., Ben Mahler wrote:
src/common/resources.cpp, line 809
https://reviews.apache.org/r/28091/diff/3/?file=766050#file766050line809
Why do we need the !empty guard? Seems like the += below should work
even if it's empty..?
I would prefer to keep them.
100 matches
Mail list logo
