Re: Increase indentation limit from 100 to 120 characters

2018-01-05 Thread Tianqi Chen
An argument against such change would be the coding style standard is people already get used to it, and there is less benefit of making the change. PEP and Google C style suggest 80 chars as limit, I usually write with that in mind and try to break multiple arguments into multiple lines when

Re: Join the slack channel

2018-01-05 Thread Marco de Abreu
Done. Don't forget to join #mxnet and #mxnet-builds On Sat, Jan 6, 2018 at 2:04 AM, Carin Meier wrote: > Could I please get an invite to the slack too? > > Thanks, > Carin Meier > > On Fri, Jan 5, 2018 at 7:14 PM, Chris Olivier > wrote: > > > Invite

Re: Join the slack channel

2018-01-05 Thread Carin Meier
Could I please get an invite to the slack too? Thanks, Carin Meier On Fri, Jan 5, 2018 at 7:14 PM, Chris Olivier wrote: > Invite sent > > On Wed, Jan 3, 2018 at 6:30 AM, Rand Xie wrote: > > > Hi, > > > > I would like to join the slack channel and

Re: Join the slack channel

2018-01-05 Thread Yuan Tang
Apologize. Please ignore my last email that I replied to dev email instead of individual. Rand - let’s chat offline. On Fri, Jan 5, 2018 at 7:25 PM Yuan Tang wrote: > Hey there! Does Uptake uses MXNet nowadays? > > On Fri, Jan 5, 2018 at 7:05 PM Rand Xie

Re: Join the slack channel

2018-01-05 Thread Yuan Tang
Hey there! Does Uptake uses MXNet nowadays? On Fri, Jan 5, 2018 at 7:05 PM Rand Xie wrote: > Hi, > > I would like to join the slack channel and contribute my knowledge to the > mxnet project. Please let me know how to get the invitation link. > > Best regards, > Yuyang

Re: Join the slack channel

2018-01-05 Thread Chris Olivier
Invite sent On Wed, Jan 3, 2018 at 6:30 AM, Rand Xie wrote: > Hi, > > I would like to join the slack channel and contribute my knowledge to the > mxnet project. Please let me know how to get the invitation link. > > Best regards, > Yuyang Xie >

Join the slack channel

2018-01-05 Thread Rand Xie
Hi, I would like to join the slack channel and contribute my knowledge to the mxnet project. Please let me know how to get the invitation link. Best regards, Yuyang Xie

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Naveen Swamy
this sounds fine to me as long as there is at least one MXNet committer who is also an admin. thanks Marco for making this happen :) - Naveen On Fri, Jan 5, 2018 at 2:54 PM, Marco de Abreu wrote: > I'm proposing following permissions:

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Marco de Abreu
I'm proposing following permissions: https://i.imgur.com/uiFBtuW.png. The meaning of every permission is explained at https://wiki.jenkins.io/ display/JENKINS/Matrix-based+security. Any objections? On Fri, Jan 5, 2018 at 11:03 PM, Marco de Abreu < marco.g.ab...@googlemail.com> wrote: > I'm

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Marco de Abreu
I'm currently working on a prototype of SSO based on GitHub and a few issues arose: We are not able to use the permission strategy which determines the access rights based on the read/write permission to a project as the Jenkins-plugin is not able to resolve the link between Jenkins-jobs and

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Chris Olivier
+1 On Fri, Jan 5, 2018 at 1:41 PM, Indhu wrote: > Objective is to make sure committers has access to CI. As far as that > objective is met, it shouldn't matter whether the auth mechanism uses > GitHub or Apache SSO. > > If GitHub SSO is easier to implement, let's go

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Indhu
Objective is to make sure committers has access to CI. As far as that objective is met, it shouldn't matter whether the auth mechanism uses GitHub or Apache SSO. If GitHub SSO is easier to implement, let's go ahead and do that unless someone in the list objects. On Fri, Jan 5, 2018 at 11:21 AM

Re: Increase indentation limit from 100 to 120 characters

2018-01-05 Thread Nan Zhu
wellmax line length as 100 is adopted in many projects (nearly all projects I have been involved or used or looked at, spark/flink/bahir/atlas, etc. companies which using scala intensively also sets it to 100 (e.g. netflix, you can check their atlas project)) one of the reasons is that all

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Chris Olivier
I am fine without a vote unless a vote is required? Any objections, anyone? You're sort of adding functionality here, not changing or restricting... We can always change to Apache later. On Fri, Jan 5, 2018 at 11:18 AM, Marco de Abreu < marco.g.ab...@googlemail.com> wrote: > I'd be in favour

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Marco de Abreu
I'd be in favour of GitHub. Shall we open a vote or would you like me to create a POC with GitHub first and afterwards we can check if that's enough? -Marco On Fri, Jan 5, 2018 at 8:13 PM, Chris Olivier wrote: > Apparently Apache supports OATH, so I am open to either. >

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Chris Olivier
Apparently Apache supports OATH, so I am open to either. Good idea for the docker thing. On Fri, Jan 5, 2018 at 11:02 AM, Marco de Abreu < marco.g.ab...@googlemail.com> wrote: > GitHub SSO allows the neat feature that login and permission can be > selected depending on the access rights a user

Re: Increase indentation limit from 100 to 120 characters

2018-01-05 Thread Chris Olivier
Why -1? On Fri, Jan 5, 2018 at 11:03 AM, Nan Zhu wrote: > -1 for scala part > > On Fri, Jan 5, 2018 at 9:48 AM, Marco de Abreu < > marco.g.ab...@googlemail.com > > wrote: > > > +1 > > > > Am 05.01.2018 5:49 nachm. schrieb "Chris Olivier" >: > > >

Re: Increase indentation limit from 100 to 120 characters

2018-01-05 Thread Nan Zhu
-1 for scala part On Fri, Jan 5, 2018 at 9:48 AM, Marco de Abreu wrote: > +1 > > Am 05.01.2018 5:49 nachm. schrieb "Chris Olivier" : > > +1 > > On Fri, Jan 5, 2018 at 8:00 AM, Pedro Larroy > > wrote: > > > Hi

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Marco de Abreu
GitHub SSO allows the neat feature that login and permission can be selected depending on the access rights a user has to a project. Somebody with write access (committers) would be get different permissions than somebody with only read access. We could check back with Apache for SSO, but this

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Naveen Swamy
SSO is enough. On Fri, Jan 5, 2018 at 10:51 AM, Chris Olivier wrote: > Well, login to the Jenkins server, I would imagine. > > github or Apache SSO (does Apache support OAUTH?) seems like a good idea as > long as there's a way to not let everyone with a github account log

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Chris Olivier
Well, login to the Jenkins server, I would imagine. github or Apache SSO (does Apache support OAUTH?) seems like a good idea as long as there's a way to not let everyone with a github account log in. Access to actual slave machines could be more restricted, I imagine. Eventually, a public

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Marco de Abreu
Would it be an acceptable solution if we add SSO or do you also want access to the actual AWS account and all machines? Yes, the build jobs are automatically getting created for new branches. -Marco Am 05.01.2018 7:35 nachm. schrieb "Marco de Abreu" < marco.g.ab...@googlemail.com>: I totally

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Marco de Abreu
I totally agree, this is not the way it should work in an Apache Project. It's running on an isengard account, meaning it is only accessible for Amazon employees. The problem is that a compromised account could cause damage up to 170,000$ per day. There are alarms in place to notice those cases,

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Naveen Swamy
I would like this access as well. for start/stop and also replay parts of the build. It was very convenient when i am trying to a make a small change to the Jenkins file and be able to test that and not have to go through the entire build cycle. Also If I am working on a branch, do you

Re: Commiter access to Jenkins Sevrer

2018-01-05 Thread Marco de Abreu
Hello Chris, At the moment this is not possible due Amazon AppSec (Application security) restrictions which does not permit user data and credentials on these machines. I have been thinking about adding single sign on bound to GitHub, but we would have to check back with AppSec. Is the reason

Commiter access to Jenkins Sevrer

2018-01-05 Thread Chris Olivier
Marco, Are all committers able to get login access to the Jenkins Server? If not, why? -Chris

Re: Increase indentation limit from 100 to 120 characters

2018-01-05 Thread Marco de Abreu
+1 Am 05.01.2018 5:49 nachm. schrieb "Chris Olivier" : +1 On Fri, Jan 5, 2018 at 8:00 AM, Pedro Larroy wrote: > Hi > > Can we please increase the indent limit from 100 to 120? I find 100 > too low for current standards and today's monitors.

Increase indentation limit from 100 to 120 characters

2018-01-05 Thread Pedro Larroy
Hi Can we please increase the indent limit from 100 to 120? I find 100 too low for current standards and today's monitors. Default CLion line limit is also 120. I'm having to split some long templates and I wish we had a longer line limit. Thanks a lot. Pedro