Re: Okay to manage ComponentLog via ThreadLocal?

2020-12-11 Thread Mark Payne
Mark, Thanks for reminding me to look into that. I’d seen it but hadn’t had a chance to dig in. Just made some comments. Thanks -Mark > On Dec 9, 2020, at 11:27 AM, Mark Bean wrote: > > This conversation reminded me I have a JIRA ticket [1] and corresponding > pull request [2] out there.

Re: Okay to manage ComponentLog via ThreadLocal?

2020-12-09 Thread Mark Bean
This conversation reminded me I have a JIRA ticket [1] and corresponding pull request [2] out there. It's been sitting idle for some time. Mark, there was a question directed at you for thoughts. Any takers? [1] https://issues.apache.org/jira/browse/NIFI-7387 [2]

Re: Okay to manage ComponentLog via ThreadLocal?

2020-12-08 Thread Russell Bateman
Yes, well, I would consider that I had out-foxed myself, but it's probably due to not quite having all my fingers around the scope of the processor. I guess there's only one component logger for the currently executing NiFi instance? Yeah, I was thinking really hard about per-thread stuff,

Re: Okay to manage ComponentLog via ThreadLocal?

2020-12-08 Thread Mark Payne
Russ, Why not just use: Public class Foo { public void bar() { ComponentLogger logger = CustomProcessor.getLogger(); logger.warn( “This is a warning!” ); } } Perhaps I’m missing something - or perhaps you made things simpler than they really are

Okay to manage ComponentLog via ThreadLocal?

2020-12-08 Thread Russell Bateman
Because it's so onerous to pass a reference to the logger down through parameters lists, I thought I might try using Java's thread-local store. I haven't been using it for anything else either, but I thought I'd start. For now, the logger is the only thing that tempts me. In past lives as a