Hi. This is the qmail-send program at internet.moew.government.bg.
I'm afraid I wasn't able to deliver your message to the following addresses.
This is a permanent error; I've given up. Sorry it didn't work out.
georgi...@moew.government.bg:
Sorry, no mailbox here by that name. (#5.1.1)
---
Thanks for the review. I've supplied an incremental below. The series has
changed enough that I'm going to resend the entire thing for completeness.
Let's add a requirement that pad[] in struct nx_action_output_reg be
all-bytes-zero, in case we want to extend it later.
I was wondering about
---
lib/classifier.c |6 +++---
lib/flow.c |4 ++--
lib/learning-switch.c |2 +-
lib/netdev.c |2 +-
lib/odp-util.c |2 +-
lib/util.c |2 +-
ofproto/netflow.c |2 +-
ofproto/ofproto-dpif.c |6 +++---
Changing struct flow or its wildcards requires minor adjustments
in many places in the code. This patch adds a new FLOW_WC_SEQ
sequence number which when incremented will cause build assertion
failures aiding the developer in finding code which needs to
change.
---
lib/classifier.c |6 --
---
tests/.gitignore |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tests/.gitignore b/tests/.gitignore
index 9f939c2..1454dac 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -22,6 +22,7 @@
/test-list
/test-lockfile
/test-multipath
+/test-odp
/test-openflowd
This patch fixes a bug introduced in Commit 43edca57 nx-match: New
helpers., which caused the move action to improperly handle bit
ranges.
---
lib/nx-match.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/nx-match.c b/lib/nx-match.c
index ecc284e..cccf6fe 100644
---
---
tests/ofproto-dpif.at | 25 +
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 846eccb..38ffc08 100644
--- a/tests/ofproto-dpif.at
+++ b/tests/ofproto-dpif.at
@@ -17,3 +17,28 @@ AT_CHECK([tail -1
The NXAST_OUTPUT_REG action outputs to the OpenFlow port contained
in a supplied NXM field.
---
NEWS |3 +++
include/openflow/nicira-ext.h | 33 -
lib/ofp-parse.c | 23 ++-
lib/ofp-print.c
On Fri, Aug 12, 2011 at 11:48:42AM -0700, Ethan Jackson wrote:
Thanks for the review. I've supplied an incremental below. The series has
changed enough that I'm going to resend the entire thing for completeness.
Thanks, I would appreciate that.
Let's add a requirement that pad[] in struct
Just to be clear, before this is merged I think I need a review on the
following patches.
nx-match: Fix bug in move action.
tests: test load and move actions.
And the updates to the following patches:
nx-match: New function nxm_read_field_bits().
nicra-ext: New action
I applied patches 1-5 to the current master and get the following test
failure from the new test. Does it pass for you?
## -- ##
## openvswitch 1.2.90 test suite. ##
## -- ##
379. ofproto-dpif.at:21: testing ofproto-dpif - registers ...
In bundle_check(), this:
+error = nxm_dst_check(nab-dst, ofs, n_bits, flow) || error;
will assign 'error' either 0 or 1, not 0 or an OpenFlow error code.
Otherwise this looks good to me.
___
dev mailing list
dev@openvswitch.org
On Fri, Aug 12, 2011 at 11:53:00AM -0700, Ethan Jackson wrote:
nxm_read_field_bits() simplifies reading of NXM fields with an
ofs_nbits parameter. This patch updates nxm_execute_reg_move() to
use the new function. A user outside of the nx-match module will
be added in future patches.
It
I sent some feedback on patches 5 through 8. The others look good to
me.
Thanks,
Ben.
On Fri, Aug 12, 2011 at 11:57:06AM -0700, Ethan Jackson wrote:
Just to be clear, before this is merged I think I need a review on the
following patches.
nx-match: Fix bug in move action.
tests:
Eh, silly mistake. Thanks.
Ethan
On Fri, Aug 12, 2011 at 12:06, Ben Pfaff b...@nicira.com wrote:
In bundle_check(), this:
+ error = nxm_dst_check(nab-dst, ofs, n_bits, flow) || error;
will assign 'error' either 0 or 1, not 0 or an OpenFlow error code.
Otherwise this looks good
I'm able to reproduce it now. It doesn't work with -m32 and does with
-m64, I'll figure out whats wrong and fix it before merging, probably
something minor.
Ethan
On Fri, Aug 12, 2011 at 13:45, Ben Pfaff b...@nicira.com wrote:
I used the latest version of your series. I'm running 32-bit
Reported-by: Ethan Jackson et...@nicira.com
---
Ethan, does this fix the problem that you reported?
diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
index e6a6af1..5c7feb2 100644
--- a/lib/ofp-parse.c
+++ b/lib/ofp-parse.c
@@ -812,14 +812,20 @@ parse_field_value(struct cls_rule *rule, enum
OK, it passes now that I pushed that commit:
commit 72f7976600581cc9c57915dad150f7984c33e18b
Author: Ben Pfaff b...@nicira.com
Date: Fri Aug 12 14:59:11 2011 -0700
ofp-parse: Fix parsing of register values 2**31 and greater.
Reported-by: Ethan Jackson et...@nicira.com
On Fri,
I found this patch useful in tracking down a bug recently.
---
ofproto/ofproto-dpif.c | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index fdef4af..edc9ccb 100644
--- a/ofproto/ofproto-dpif.c
+++
On Fri, Aug 12, 2011 at 03:22:52PM -0700, Ethan Jackson wrote:
I found this patch useful in tracking down a bug recently.
Good idea.
Regs have type uint32_t so the right format specifier is %PRIx32 (not
%x).
I think you probably don't want to make it print trailing white space in
case we ever
Thanks for the review, I pushed this.
Ethan
On Fri, Aug 12, 2011 at 15:26, Ben Pfaff b...@nicira.com wrote:
On Fri, Aug 12, 2011 at 03:22:52PM -0700, Ethan Jackson wrote:
I found this patch useful in tracking down a bug recently.
Good idea.
Regs have type uint32_t so the right format
Looks good.
--Justin
On Aug 10, 2011, at 3:05 PM, Ben Pfaff wrote:
'n_ports' was only used for testing for nonzero, and we can rewrite the
code that does that to more straightforwardly use LIST_FOR_EACH_SAFE.
---
lib/dpif-netdev.c |9 +++--
1 files changed, 3 insertions(+), 6
22 matches
Mail list logo
