Re: [ovs-dev] [patch_v6] vtep: add source node replication support.

2016-04-27 Thread Bruce Davie
> > On Apr 27, 2016, at 5:51 PM, Darrell Ball wrote: > > This patch series updates the vtep schema, vtep-ctl commands and vtep > simulator to support source node replication in addition to service node > replication per logical switch. The default replication mode is service

[ovs-dev] [patch_v6] vtep: add source node replication support.

2016-04-27 Thread Darrell Ball
This patch series updates the vtep schema, vtep-ctl commands and vtep simulator to support source node replication in addition to service node replication per logical switch. The default replication mode is service node as that was the only mode previously supported. Source node replication mode

[ovs-dev] [patch_v6] vtep: add source node replication support.

2016-04-27 Thread Darrell Ball
Offline discussion is documented in v1->v2 below. There are various considerations to what kind of replication configuration is needed and what is "better" varies with the specific requirements. Feel free to suggest otherwise. This patch series updates the vtep schema to support source node

[ovs-dev] [PATCH] datapath-windows: Add support for UDP and ICMP to Conntrack Module

2016-04-27 Thread Sairam Venugopal
Enable support for UDP and ICMP in the connection tracking module on Hyper-V. Signed-off-by: Sairam Venugopal --- datapath-windows/automake.mk | 1 + datapath-windows/ovsext/Conntrack-other.c | 78 ++ datapath-windows/ovsext/Conntrack.c |

Re: [ovs-dev] [PATCH v3] stt: linearize for CONFIG_SLUB case

2016-04-27 Thread pravin shelar
On Wed, Apr 27, 2016 at 3:49 PM, Jesse Gross wrote: > On Wed, Apr 27, 2016 at 2:57 PM, Pravin B Shelar wrote: >> STT implementation I saw performance improvements with linearizing >> skb for SLUB case. So following patch skips zero copy operation >> for such a

Re: [ovs-dev] [PATCH v3] stt: linearize for CONFIG_SLUB case

2016-04-27 Thread Jesse Gross
On Wed, Apr 27, 2016 at 2:57 PM, Pravin B Shelar wrote: > STT implementation I saw performance improvements with linearizing > skb for SLUB case. So following patch skips zero copy operation > for such a case. > First change is to reassembly code where in-order packet is merged

Re: [ovs-dev] [PATCH] Remove "VLAN splinters" feature.

2016-04-27 Thread pravin shelar
On Wed, Apr 27, 2016 at 6:29 AM, Ben Pfaff wrote: > On Mon, Apr 25, 2016 at 11:27:58AM -0700, Pravin B Shelar wrote: >> The "VLAN splinters" feature works around buggy device drivers in >> old Linux versions. But support for the old kernel is dropped, So >> now all supported kernel

Re: [ovs-dev] [PATCH v2] stt: linearize for CONFIG_SLUB case

2016-04-27 Thread pravin shelar
On Tue, Apr 26, 2016 at 6:04 PM, Jesse Gross wrote: > On Mon, Apr 25, 2016 at 2:35 PM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c >> index eb397e8..a1b309a 100644 >> --- a/datapath/linux/compat/stt.c >> +++

[ovs-dev] [PATCH v3] stt: linearize for CONFIG_SLUB case

2016-04-27 Thread Pravin B Shelar
STT implementation I saw performance improvements with linearizing skb for SLUB case. So following patch skips zero copy operation for such a case. First change is to reassembly code where in-order packet is merged to head, if there is no room to merge it then combined packet is linearized.

[ovs-dev] [patch_v5] vtep: add source node replication support.

2016-04-27 Thread Darrell Ball
This patch series updates the vtep schema, vtep-ctl commands and vtep simulator to support source node replication in addition to service node replication per logical switch. The default replication mode is service node as that was the only mode previously supported. Source node replication mode

[ovs-dev] [patch_v5] vtep: add source node replication support.

2016-04-27 Thread Darrell Ball
Offline discussion is documented in v1->v2 below. There are various considerations to what kind of replication configuration is needed and what is "better" varies with the specific requirements. Feel free to suggest otherwise. This patch series updates the vtep schema to support source node

[ovs-dev] Price list

2016-04-27 Thread Weldon Stout
The March and April invoices are outstanding, please make a paymentasap. Thank you. Weldon Stout Director Audit Services ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Price list

2016-04-27 Thread Shannon Mcintosh
The March and April invoices are outstanding, please make a paymentasap. Thank you. Shannon Mcintosh Vice President Finance ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH V5 1/1] ovn-northd: Add support for static_routes.

2016-04-27 Thread Guru Shetty
On 24 April 2016 at 02:49, steve.ruan wrote: Thank you for working through this. I have a few comments. With this patch, your author name becomes "steve.ruan". Did you intend it to be Steve Ruan instead? Your email address in the author name (gmail) is different than the email

Re: [ovs-dev] [PATCH net-next v2] taskstats: fix nl parsing in accounting/getdelays.c

2016-04-27 Thread David Miller
From: Nicolas Dichtel Date: Wed, 27 Apr 2016 17:53:08 +0200 > The type TASKSTATS_TYPE_NULL should always be ignored. > > When jumping to the next attribute, only the length of the current > attribute should be added, not the length of all nested attributes. > This

Re: [ovs-dev] [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit

2016-04-27 Thread Nicolas Dichtel
Le 27/04/2016 14:29, Balbir Singh a écrit : [snip] > Please try > > https://www.kernel.org/doc/Documentation/accounting/getdelays.c A patch follows this mail to fix that. > > iotop uses it as well. My concern is ABI breakage of user space. My test is ok here, I didn't see a problem. Code review

[ovs-dev] [PATCH net-next v2] taskstats: fix nl parsing in accounting/getdelays.c

2016-04-27 Thread Nicolas Dichtel
The type TASKSTATS_TYPE_NULL should always be ignored. When jumping to the next attribute, only the length of the current attribute should be added, not the length of all nested attributes. This last bug was not visible before commit 80df554275c2, because the kernel didn't put more than two

Re: [ovs-dev] [PATCH net-next] taskstats: fix nl parsing in accounting/getdelays.c

2016-04-27 Thread Nicolas Dichtel
Le 27/04/2016 17:47, Nicolas Dichtel a écrit : > The type TASKSTATS_TYPE_NULL should always be ignored. > > When jumping to the next attribute, only the length of the current > attribute should be added, not the length of all nested attributes. > This last bug was not visible before commit

[ovs-dev] [PATCH net-next] taskstats: fix nl parsing in accounting/getdelays.c

2016-04-27 Thread Nicolas Dichtel
The type TASKSTATS_TYPE_NULL should always be ignored. When jumping to the next attribute, only the length of the current attribute should be added, not the length of all nested attributes. This last bug was not visible before commit 80df554275c2, because the kernel didn't put more than two

[ovs-dev] [PATCH] ovn-controller: add local address setting for ovn-remote connection

2016-04-27 Thread Huang Lei
From: Huang Lei In some environments, an interface may have multiple IP addresses in same subnet, if TCP client socket doesn't call bind() explicitly, OS will chooses an local IP and port for it, usually the primary IP of the subnet will be chosen. With this patch, a secondary

[ovs-dev] Price list

2016-04-27 Thread Aileen Snider
The March and April invoices are outstanding, please make a paymentasap. Thank you. Aileen Snider Vice President of Operations ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 0/2] ovn: QOS updates with DSCP support

2016-04-27 Thread Babu Shanmugam
On Tuesday 26 April 2016 08:43 PM, Ben Pfaff wrote: On Mon, Apr 25, 2016 at 04:41:40PM +0530, Babu Shanmugam wrote: On Friday 22 April 2016 10:51 PM, Ben Pfaff wrote: On Fri, Apr 22, 2016 at 12:44:12PM +0530, bscha...@redhat.com wrote: From: Babu Shanmugam Following

[ovs-dev] Price list

2016-04-27 Thread Edwardo Manning
Thank you. Our latest price list is attached. For additional information, please contact your local ITT office. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] Remove "VLAN splinters" feature.

2016-04-27 Thread Ben Pfaff
On Mon, Apr 25, 2016 at 11:27:58AM -0700, Pravin B Shelar wrote: > The "VLAN splinters" feature works around buggy device drivers in > old Linux versions. But support for the old kernel is dropped, So > now all supported kernel vlan drivers should be working fine with > OVS kernel datapath. >

Re: [ovs-dev] [PATCH] datapath-windows: Fix recirculation when it is not the last attribute

2016-04-27 Thread Ben Pfaff
On Tue, Apr 26, 2016 at 04:53:30PM -0700, Sairam Venugopal wrote: > When the recirc action is in middle, the current code creates a clone of > the NBL. However, it overwrites the pointer to point to the cloned NBL > without completing it. This causes a memory leak that crashes the kernel. > >

Re: [ovs-dev] [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit

2016-04-27 Thread Balbir Singh
On 27/04/16 17:29, Nicolas Dichtel wrote: > Le 27/04/2016 03:14, Balbir Singh a écrit : >> >> >> On 23/04/16 01:31, Nicolas Dichtel wrote: >>> Goal of this patch is to use the new libnl API to align netlink attribute >>> when needed. >>> The layout of the netlink message will be a bit different

[ovs-dev] Status

2016-04-27 Thread questblr
The original message was received at Wed, 27 Apr 2016 17:26:48 +0530 from vsnl.com [85.227.247.60] - The following addresses had permanent fatal errors - ___ dev mailing list dev@openvswitch.org

[ovs-dev] Short Call Request for Online Website

2016-04-27 Thread Kuber Mahesh
Hi, I am Kuber Malik , Online Marketing Consultant. We have a good creative team to design & develop an eye catching & user friendly website for your business. We are offering a great offer to get a new business website or re-design your website. Please let me know if you are

[ovs-dev] Price list

2016-04-27 Thread Opal Kerr
Thank you. Our latest price list is attached. For additional information, please contact your local ITT office. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [CudaMailTagged] Listing all rules of a flow table

2016-04-27 Thread Amrane Ait Zeouay
Hi, I want to show all rules of a flow table, and i want to know which function do it because i was looking in the source code but i found that the rules are in hmap if i'm right, and then i couldn't find how to extract them from hmap. Thank you. -- Amrane Ait Zeouay Engineer Student in The

[ovs-dev] Mail System Error - Returned Mail

2016-04-27 Thread cian
This message was not delivered due to the following reason(s): Your message could not be delivered because the destination computer was unreachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most

Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-04-27 Thread Fischetti, Antonio
Hi Daniele, few comments inline. > -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Wednesday, April 27, 2016 7:36 AM > To: Fischetti, Antonio > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2 04/15] conntrack:

[ovs-dev] [PATCH V2] datapath-windows: Validate netlink packets integrity

2016-04-27 Thread Paul Boca
Solved access violation when trying to acces netling message - obtained with forged IOCTLs Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: Fixed alignement problems --- datapath-windows/ovsext/Datapath.c

Re: [ovs-dev] [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit

2016-04-27 Thread Nicolas Dichtel
Le 27/04/2016 03:14, Balbir Singh a écrit : > > > On 23/04/16 01:31, Nicolas Dichtel wrote: >> Goal of this patch is to use the new libnl API to align netlink attribute >> when needed. >> The layout of the netlink message will be a bit different after the patch, >> because the padattr

[ovs-dev] [PATCH V3] datapath-windows: Improved offloading on STT tunnel

2016-04-27 Thread Paul Boca
Added OvsExtractLayers - populates only the layers field without unnecessary memory operations for flow part If in STT header the flags are 0 then force packets checksums calculation Ensure correct pseudo checksum is set for LSO both on send and receive Signed-off-by: Paul-Daniel Boca

[ovs-dev] Delivery reports about your e-mail

2016-04-27 Thread The Post Office
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath-windows: Fix bug in OvsTcpGetWscale().

2016-04-27 Thread Daniele Di Proietto
Thanks, pushed this to master! On 20/04/2016 21:06, "Sairam Venugopal" wrote: >Acked-by: Sairam Venugopal > > >On 4/15/16, 5:04 PM, "Daniele Di Proietto" wrote: > >>The userspace conntrack had a bug in tcp_wscale_get(), where

Re: [ovs-dev] [PATCH v2 13/15] system-tests: Disable offloads in userspace tests.

2016-04-27 Thread Daniele Di Proietto
On 26/04/2016 16:38, "Flavio Leitner" wrote: >On Fri, Apr 15, 2016 at 05:02:45PM -0700, Daniele Di Proietto wrote: >> The system userspace testsuite uses the userspace datapath with >> netdev-linux devices, connected to veth pairs with the AF_PACKET socket: >> >>

Re: [ovs-dev] [PATCH v9 06/15] hmap: Add HMAP_FOR_EACH_POP.

2016-04-27 Thread Daniele Di Proietto
On 26/04/2016 08:24, "Ben Pfaff" wrote: >On Fri, Apr 22, 2016 at 06:02:58PM -0700, Daniele Di Proietto wrote: >> Makes popping each member of the hmap a bit easier. >> >> Signed-off-by: Daniele Di Proietto > >Much better, thank you! > >Acked-by: Ben

Re: [ovs-dev] [PATCH v2 14/15] system-tests: Add tcp simple test.

2016-04-27 Thread Daniele Di Proietto
On 26/04/2016 16:38, "Flavio Leitner" wrote: >On Fri, Apr 15, 2016 at 05:02:46PM -0700, Daniele Di Proietto wrote: >> Useful to test the datapath ability to forward tcp packets without the >> complexity of connection tracking. >> >> Signed-off-by: Daniele Di Proietto

Re: [ovs-dev] [PATCH v2 09/15] dpif-netdev: Execute conntrack action.

2016-04-27 Thread Daniele Di Proietto
On 26/04/2016 16:37, "Flavio Leitner" wrote: >On Fri, Apr 15, 2016 at 05:02:41PM -0700, Daniele Di Proietto wrote: >> This commit implements the OVS_ACTION_ATTR_CT action in dpif-netdev. >> >> To allow ofproto-dpif to detect the conntrack feature, flow_put will not >>

Re: [ovs-dev] [PATCH v2 00/15] Userspace (DPDK) connection tracker

2016-04-27 Thread Daniele Di Proietto
Hi Antonio, great, thank you very much for performing this tests and share the results On 25/04/2016 07:00, "Fischetti, Antonio" wrote: >Hi Daniele, >below are > - Regression Tests results > - ALWAYS_INLINE check > > >Regression Tests on Performance

Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-04-27 Thread Daniele Di Proietto
Thank you for your comments, Flavio! On 26/04/2016 16:35, "Flavio Leitner" wrote: >On Fri, Apr 15, 2016 at 05:02:36PM -0700, Daniele Di Proietto wrote: >> This commit adds the conntrack module. >> >> It is a connection tracker that resides entirely in userspace. Its >>

Re: [ovs-dev] [PATCH v2 11/15] dpif-netdev: Implement conntrack flush interface.

2016-04-27 Thread Daniele Di Proietto
On 26/04/2016 16:38, "Flavio Leitner" wrote: >On Fri, Apr 15, 2016 at 05:02:43PM -0700, Daniele Di Proietto wrote: >> Signed-off-by: Daniele Di Proietto > >This could be squashed with "[07/15] conntrack: Implement flush >function" > >Just a

Re: [ovs-dev] [PATCH v2 05/15] tests: Add very simple conntrack benchmark.

2016-04-27 Thread Daniele Di Proietto
On 26/04/2016 16:36, "Flavio Leitner" wrote: >On Fri, Apr 15, 2016 at 05:02:37PM -0700, Daniele Di Proietto wrote: >> This introduces a very limited but simple benchmark for >> conntrack_execute(). It just sends repeatedly the same batch of packets >> through the

Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-04-27 Thread Daniele Di Proietto
Hi Antonio, Thank you for your comments, replies inline On 25/04/2016 09:14, "Fischetti, Antonio" wrote: >Hi Daniele, >some comments inline prefixed with [Antonio F]. > >Regards, >Antonio > >> -Original Message- >> From: dev

Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-04-27 Thread Daniele Di Proietto
Thanks for the detailed review Joe, replies inline On 19/04/2016 14:36, "Joe Stringer" wrote: >On 15 April 2016 at 17:02, Daniele Di Proietto wrote: >> This commit adds the conntrack module. >> >> It is a connection tracker that resides entirely in

Re: [ovs-dev] [PATCH v2 13/15] system-tests: Disable offloads in userspace tests.

2016-04-27 Thread Daniele Di Proietto
On 19/04/2016 15:15, "Joe Stringer" wrote: >On 15 April 2016 at 17:02, Daniele Di Proietto wrote: >> The system userspace testsuite uses the userspace datapath with >> netdev-linux devices, connected to veth pairs with the AF_PACKET socket: >> >>

Re: [ovs-dev] [PATCH v2 15/15] system-tests: Run conntrack tests with userspace

2016-04-27 Thread Daniele Di Proietto
On 19/04/2016 17:24, "Joe Stringer" wrote: >On 19 April 2016 at 16:53, Joe Stringer wrote: >> On 15 April 2016 at 17:02, Daniele Di Proietto >> wrote: >>> The userspace connection tracker doesn't support ALGs, frag reassembly >>> or NAT

Re: [ovs-dev] [PATCH v2 03/15] flow: Introduce parse_dl_type().

2016-04-27 Thread Daniele Di Proietto
On 26/04/2016 16:35, "Flavio Leitner" wrote: >On Fri, Apr 15, 2016 at 05:02:35PM -0700, Daniele Di Proietto wrote: >> The function simply returns the ethernet type of the packet (after >> eventually discarding the VLAN tag). It will be used by a following >> commit. >>

Re: [ovs-dev] [PATCH v2 02/15] flow: Export parse_ipv6_ext_hdrs().

2016-04-27 Thread Daniele Di Proietto
On 19/04/2016 13:03, "Joe Stringer" wrote: >On 15 April 2016 at 17:02, Daniele Di Proietto wrote: >> This will be used by a future commit. >> >> Signed-off-by: Daniele Di Proietto >> --- >> lib/flow.c | 140 >>

Re: [ovs-dev] [PATCH v2 09/15] dpif-netdev: Execute conntrack action.

2016-04-27 Thread Daniele Di Proietto
On 19/04/2016 14:52, "Joe Stringer" wrote: >On 15 April 2016 at 17:02, Daniele Di Proietto wrote: >> This commit implements the OVS_ACTION_ATTR_CT action in dpif-netdev. >> >> To allow ofproto-dpif to detect the conntrack feature, flow_put will not >>

Re: [ovs-dev] [PATCH v2 10/15] dpif-netdev: Implement conntrack dump functions.

2016-04-27 Thread Daniele Di Proietto
On 19/04/2016 14:54, "Joe Stringer" wrote: >On 15 April 2016 at 17:02, Daniele Di Proietto wrote: >> Signed-off-by: Daniele Di Proietto > >Could be combined with the earlier patch that provides the actual >implementation? Done,

Re: [ovs-dev] [PATCH v2 08/15] conntrack: Implement dumping to ct_entry.

2016-04-27 Thread Daniele Di Proietto
On 19/04/2016 14:49, "Joe Stringer" wrote: >On 15 April 2016 at 17:02, Daniele Di Proietto wrote: >> Signed-off-by: Daniele Di Proietto > > > >> +static void >> +conn_key_to_tuple(const struct conn_key *key, struct

Re: [ovs-dev] [PATCH v2 07/15] conntrack: Implement flush function.

2016-04-27 Thread Daniele Di Proietto
Good idea, I'll combine them Thanks for the review! On 19/04/2016 14:40, "Joe Stringer" wrote: >On 15 April 2016 at 17:02, Daniele Di Proietto wrote: >> Signed-off-by: Daniele Di Proietto > >Looks like this can be combined with