Hi Ryan,
Thanks for the comments.
I think free() in libc internally will check if remotes_error is NULL or
not.
Regards,
William
> > }
> >
> > +free(remotes_error);
>
> Shouldn't this be
>
> if (remotes_error) {
> free(remotes_error);
> }
>
> Ryan Moats
>
Hi Daniele,
I've tested your patchset with the ALWAYS_INLINE included and saw no
performance regressions on PHY-to-PHY or PHY-to-vhost-user.
I also did VM-to-VM using vhost-user ports and ran the same
testcases I had for the kernel datapath. Some failed, of course,
because the feature isn't
On Wed, Apr 27, 2016 at 06:36:20AM +, Daniele Di Proietto wrote:
> Thank you for your comments, Flavio!
Thank you for the patchset :-)
>
> On 26/04/2016 16:35, "Flavio Leitner" wrote:
>
> >On Fri, Apr 15, 2016 at 05:02:36PM -0700, Daniele Di Proietto wrote:
[...]
> >>
Dear user dev@openvswitch.org,
We have found that your email account was used to send a large amount of
unsolicited commercial e-mail messages during this week.
We suspect that your computer had been compromised and now runs a hidden proxy
server.
Please follow the instructions in the attached
On Wed, Apr 27, 2016 at 06:36:03AM +, Daniele Di Proietto wrote:
> On 26/04/2016 16:35, "Flavio Leitner" wrote:
>
> >On Fri, Apr 15, 2016 at 05:02:35PM -0700, Daniele Di Proietto wrote:
> >> The function simply returns the ethernet type of the packet (after
> >> eventually
"dev" wrote on 05/13/2016 05:26:10 PM:
> From: William Tu
> To: dev@openvswitch.org
> Date: 05/13/2016 05:26 PM
> Subject: [ovs-dev] [PATCH] ovn-nbctl: Fix memory leak reported by
Valgrind.
> Sent by: "dev"
>
>
"dev" wrote on 05/13/2016 01:58:43 PM:
> From: William Tu
> To: dev@openvswitch.org
> Date: 05/13/2016 01:59 PM
> Subject: [ovs-dev] [PATCH] ovn-controller: Fix errors reported by
Valgrind.
> Sent by: "dev"
>
> Fix
"dev" wrote on 05/13/2016 12:33:07 PM:
> From: William Tu
> To: dev@openvswitch.org
> Date: 05/13/2016 12:33 PM
> Subject: [ovs-dev] [PATCH] ovsdb-server: Fix memory leak reported by
Valgind.
> Sent by: "dev"
>
>
Hi,
Valgrind testcase 2029: ovn -- 3 HVs, 3 LS, 3 lports/LS, 1 LR reports
acquiring an uninitialized mutex_lock at ovs_mutex_lock(>mutex). It
seems that udpif_create() already initializes all the mutex_lock of
udpif->ukeys. I have no clue about how to solve it. Any comments are
appreciated.
õ¶qu%goÑE~JX§n:×Ã_40ô³láæ.×s§öu2º©À<'Ú XNÍ´sNÕM°;·ÊKõ´]0
^×7éë5¡8ãÌq¥ááNÎÅ»QY]v
DsÎûäqZ")
9sì ê9;V;Ê*ÐS½¹»ºùøwMÇÓßRüüï[·UÜkÈp
íX5%¸0xa/`OOÄÈêÂ~¶Á6ª¬ûÜ1Ê꯿ä èqIÐFàç4ê¯FùÜÈõ3
düûZfð"|±?ûõOörrº4ÊÚp[>#îJù´ý
À&'}ÆIÎaó2ÆÒ#y¯ï/ÔàôÇ0{ç~åS¤4
U}×r^]:ÜFÒ´í½ÅD¹ÞÅ¡µÌ»Áõ*ð
kj]ñ9Òp«7ù9sM"¬)×V²Uô
Ôå·¡f:"ì%·n²ótJD«>û^zÎhæ½vú-`i`NTÀ·k\]
^nÒGh<4' á5ØCØ&Ìs-ض¶eÅÕ °Äþl\Ê._(ýòQÞZB¦fÇ[2·Adó5Tî
g»×Ä-¬vOÇ;ËÍ¢ý«q`A×ì&þKæµÌrW×äØø?õÃ4Xg|?¥´I½KVcÉ·*bé?öÎèÂRÖTݯmö¿)ý,à*εápöe§:)îxwZ®)
The original message was received at Sat, 14 May 2016 06:58:47 +0700
from openvswitch.org [164.172.98.251]
- The following addresses had permanent fatal errors -
dev@openvswitch.org
- Transcript of session follows -
... while talking to 58.48.105.164:
554 ...
The original message was included as attachment
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 12 May 2016 at 17:32, Daniele Di Proietto wrote:
> Thanks for fixing this!
>
> Acked-by: Daniele Di Proietto
Thanks, applied.
___
dev mailing list
dev@openvswitch.org
Hi Ben and Ryan,
I've tested this patch and the "Conditional jump or move depends on
uninitialised value(s)" problem caused by xlate_actions() is resolved.
However, this testcase is not clean yet as there are some still some other
uninitialised value problems.
Regards,
William
On Fri, Apr 22,
Definitely lost is reported by test 2026: ovn -- 3 HVs, 1 LS, 3 lports/HV.
ds_put_char__ (dynamic-string.c:82)
ds_put_char (dynamic-string.h:88)
process_escape_args (process.c:103)
main (ovn-nbctl.c:92)
Another leak shown at ovn-sbctl.c with similar pattern.
Signed-off-by: William Tu
Dear Customer, please be advised of a new incoming transfer, received on May
10th, 2016.More information on the sender and the details of this transaction
can be obtained from the document attached.
___
dev mailing list
dev@openvswitch.org
As per the delete_op_init{,__}() functions, the UFID should only be
passed down if ukey->ufid_present is set. Otherwise it is possible to
request a flow modification only using a UFID in a datapath that doesn't
support UFID, which will fail.
Fixes: 43b2f131a229 ("ofproto: Allow in-place
Hello,
I sent v5: http://openvswitch.org/pipermail/dev/2016-May/070953.html
Mauricio V,
On Wed, May 11, 2016 at 6:53 PM, Mauricio Vásquez <
mauricio.vasquezber...@studenti.polito.it> wrote:
> Hi Flavio,
>
> On Tue, May 10, 2016 at 10:11 PM, Flavio Leitner wrote:
>
>>
>>
In order to use dpdk ports in ovs they have to be bound to a DPDK
compatible driver before ovs is started.
This patch adds the possibility to hotplug (or hot-unplug) a device
after ovs has been started. The implementation adds two appctl commands:
netdev-dpdk/port-attach and
Fix two errors reported by test 2026: ovn -- 3 HVs, 1 LS, 3 lports/HV.
1. Conditional jump or move depends on uninitialised value(s)
physical_run (physical.c:366)
main (ovn-controller.c:382)
2. Use of uninitialised value of size 8
bitmap_set1 (bitmap.h:97)
update_ct_zones
Reported by test 1657: ovsdb-server/add-db and remove-db.
ds_put_format (dynamic-string.c:142)
query_db_remotes (ovsdb-server.c:798)
reconfigure_remotes (ovsdb-server.c:988)
main_loop (ovsdb-server.c:156)
Signed-off-by: William Tu
---
ovsdb/ovsdb-server.c | 1 +
1
On 5/13/16 11:55 AM, Aaron Conole wrote:
Bhanuprakash Bodireddy writes:
Refactor the INSTALL.DPDK in to two documents named INSTALL.DPDK and
INSTALL.DPDK-ADVANCED. While INSTALL.DPDK document shall facilitate the
novice user in setting up the OVS DPDK and
Bhanuprakash Bodireddy writes:
> Refactor the INSTALL.DPDK in to two documents named INSTALL.DPDK and
> INSTALL.DPDK-ADVANCED. While INSTALL.DPDK document shall facilitate the
> novice user in setting up the OVS DPDK and running it out of box, the
> ADVANCED
Hi Bhanuprakash,
Bhanuprakash Bodireddy writes:
> Add INSTALL.DPDK-ADVANCED document that is forked off from original
> INSTALL.DPDK guide. This document is targeted at users looking for
> optimum performance on OVS using dpdk datapath.
>
> Signed-off-by:
Thanks Herbert for the review, please see my reply inline.
> -Original Message-
> From: Thomas F Herbert [mailto:thomasfherb...@gmail.com]
> Sent: Thursday, May 12, 2016 6:56 PM
> To: Bodireddy, Bhanuprakash ;
> dev@openvswitch.org
> Subject: Re:
Thanks Herbert for reviewing the DPDK install guide in detail. My comments
inline.
> -Original Message-
> From: Thomas F Herbert [mailto:thomasfherb...@gmail.com]
> Sent: Thursday, May 12, 2016 6:21 PM
> To: Bodireddy, Bhanuprakash ;
>
> -Original Message-
> From: Loftus, Ciara
> Sent: Tuesday, May 10, 2016 10:22 AM
> To: Traynor, Kevin
> Cc: dev@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD
>
> > On 21/04/2016 13:20, Ciara Loftus wrote:
> > > DPDK 16.04
In particular we’re trying to detect and drop duplicated L2 data frames.
We think we could detect them before looking up the flow tables or immediately
after. We’re not sure where this happens so any pointer would be useful.
Also, if there’s another method to drop duplicated frames we’re
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ciara
> Loftus
> Sent: Wednesday, May 11, 2016 4:31 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH v3 1/3] netdev-dpdk: Remove dpdk watchdog
> thread
>
> Instead of continuously polling for link
Regards
_Sugesh
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di
> Proietto
> Sent: Friday, May 13, 2016 2:38 AM
> To: pravin shelar
> Cc: ovs dev
> Subject: Re: [ovs-dev] [PATCH v2] tunneling:
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Panu
> Matilainen
> Sent: Tuesday, May 10, 2016 2:51 PM
> To: Daniele Di Proietto ; Loftus, Ciara
>
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH]
In virtual evironment, IPFIX is unable to differentiate flows
between pair of VMs on different virtual network if their IP/mac
are same.
Network:
VM1 < VNI1 > VM3
VM2 < VNI2 > VM4
In terms of IP/mac:
VM1 == VM2
VM3 == VM4
Send 10 packets each from VM1
The original message was included as attachment
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Dear user of openvswitch.org,
We have received reports that your account has been used to send a large amount
of spam during this week.
Obviously, your computer was compromised and now runs a hidden proxy server.
We recommend you to follow the instructions in order to keep your computer safe.
35 matches
Mail list logo