Re: [ovs-dev] [PATCH] ovsdb-server: Fix memory leak reported by Valgind.

2016-05-13 Thread William Tu
Hi Ryan, Thanks for the comments. I think free() in libc internally will check if remotes_error is NULL or not. Regards, William > > } > > > > +free(remotes_error); > > Shouldn't this be > > if (remotes_error) { > free(remotes_error); > } > > Ryan Moats >

Re: [ovs-dev] [PATCH v2 00/15] Userspace (DPDK) connection tracker

2016-05-13 Thread Flavio Leitner
Hi Daniele, I've tested your patchset with the ALWAYS_INLINE included and saw no performance regressions on PHY-to-PHY or PHY-to-vhost-user. I also did VM-to-VM using vhost-user ports and ran the same testcases I had for the kernel datapath. Some failed, of course, because the feature isn't

Re: [ovs-dev] [PATCH v2 04/15] conntrack: New userspace connection tracker.

2016-05-13 Thread Flavio Leitner
On Wed, Apr 27, 2016 at 06:36:20AM +, Daniele Di Proietto wrote: > Thank you for your comments, Flavio! Thank you for the patchset :-) > > On 26/04/2016 16:35, "Flavio Leitner" wrote: > > >On Fri, Apr 15, 2016 at 05:02:36PM -0700, Daniele Di Proietto wrote: [...] > >>

[ovs-dev] Delivery reports about your e-mail

2016-05-13 Thread Mail Delivery Subsystem
Dear user dev@openvswitch.org, We have found that your email account was used to send a large amount of unsolicited commercial e-mail messages during this week. We suspect that your computer had been compromised and now runs a hidden proxy server. Please follow the instructions in the attached

Re: [ovs-dev] [PATCH v2 03/15] flow: Introduce parse_dl_type().

2016-05-13 Thread Flavio Leitner
On Wed, Apr 27, 2016 at 06:36:03AM +, Daniele Di Proietto wrote: > On 26/04/2016 16:35, "Flavio Leitner" wrote: > > >On Fri, Apr 15, 2016 at 05:02:35PM -0700, Daniele Di Proietto wrote: > >> The function simply returns the ethernet type of the packet (after > >> eventually

Re: [ovs-dev] [PATCH] ovn-nbctl: Fix memory leak reported by Valgrind.

2016-05-13 Thread Ryan Moats
"dev" wrote on 05/13/2016 05:26:10 PM: > From: William Tu > To: dev@openvswitch.org > Date: 05/13/2016 05:26 PM > Subject: [ovs-dev] [PATCH] ovn-nbctl: Fix memory leak reported by Valgrind. > Sent by: "dev" > >

Re: [ovs-dev] [PATCH] ovn-controller: Fix errors reported by Valgrind.

2016-05-13 Thread Ryan Moats
"dev" wrote on 05/13/2016 01:58:43 PM: > From: William Tu > To: dev@openvswitch.org > Date: 05/13/2016 01:59 PM > Subject: [ovs-dev] [PATCH] ovn-controller: Fix errors reported by Valgrind. > Sent by: "dev" > > Fix

Re: [ovs-dev] [PATCH] ovsdb-server: Fix memory leak reported by Valgind.

2016-05-13 Thread Ryan Moats
"dev" wrote on 05/13/2016 12:33:07 PM: > From: William Tu > To: dev@openvswitch.org > Date: 05/13/2016 12:33 PM > Subject: [ovs-dev] [PATCH] ovsdb-server: Fix memory leak reported by Valgind. > Sent by: "dev" > >

[ovs-dev] Use of uninitialized mutex_lock at udpif->ukeys[i].mutex

2016-05-13 Thread William Tu
Hi, Valgrind testcase 2029: ovn -- 3 HVs, 3 LS, 3 lports/LS, 1 LR reports acquiring an uninitialized mutex_lock at ovs_mutex_lock(>mutex). It seems that udpif_create() already initializes all the mutex_lock of udpif->ukeys. I have no clue about how to solve it. Any comments are appreciated.

[ovs-dev] Returned mail: see transcript for details

2016-05-13 Thread The Post Office
õ¶qu%g‡ˆo™ÑE†ƒ~JX§˜n:×Ã_40ôŽ³láæ.•×s§öu2º©À<'Ú XNšÍ´sNÕM°;·ÊKõš´]0 ^‰×7éëŸ5¡8ãÌq¥ááNÎ”Å»QY]š˜Ÿv DsÎûäqZ—") 9sì ê9;V;žÊ*ÐS½¹»ˆºùøwMÇÓßRüüï[·‡UœÜkÈp íX5%–—¸0xa/`OOÄȞêÂ~¶Á6ª¬û–Š‹Ü1ʖ꯿ä èqIÐFàç4ꯂFùÜÈõ3  düûZfð"|±?ûõOö”rrº4ÊÚp[>#îJù´ý’

[ovs-dev] Returned mail: see transcript for details

2016-05-13 Thread Automatic Email Delivery Software
À&'}ÆIÎaó2ÆÒ#y¯‚ï/ԙàôŠÇ0{ç~åS¤4 U}×r^]:ÜFÒ´í½ÅD¹ÞÅ¡µÌ»Áõ*ð ˜kj]ñ9Òp«7ùŒ9sM†"¬)×V²†šˆUô Ôå·¡f:"ì%·n²ó’tJD«>‹û^zÎhæ½vú-`i`NTœÀ·k“\] ^nÒGh<4' á5؉CØ&Ìs-ض¶eÅÕ °Äþl‘\Ê._(ýòQÞZB¦fÇ[†2·Adó5Tî g»×Ä-¬žvOÇ;˔͢ý«q`A×ì&þKæµÌrW‡×äؖø?õÃ4Xg|­‰?¥´”I„½KVcÉ·*b‘é?öÎèÂRÖTݯmö¿)ý,à*Ώµápöœe§:)îx–wZ®)  

[ovs-dev] Returned mail: Data format error

2016-05-13 Thread Automatic Email Delivery Software
The original message was received at Sat, 14 May 2016 06:58:47 +0700 from openvswitch.org [164.172.98.251] - The following addresses had permanent fatal errors - dev@openvswitch.org - Transcript of session follows - ... while talking to 58.48.105.164: 554 ...

[ovs-dev] Returned mail: see transcript for details

2016-05-13 Thread Bounced mail
The original message was included as attachment ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix locking during get_stats.

2016-05-13 Thread Joe Stringer
On 12 May 2016 at 17:32, Daniele Di Proietto wrote: > Thanks for fixing this! > > Acked-by: Daniele Di Proietto Thanks, applied. ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] Use of uninitialized value at testcase OVN 3 HVs, 3 LS, 3 lports/LS, 1 LR

2016-05-13 Thread William Tu
Hi Ben and Ryan, I've tested this patch and the "Conditional jump or move depends on uninitialised value(s)" problem caused by xlate_actions() is resolved. However, this testcase is not clean yet as there are some still some other uninitialised value problems. Regards, William On Fri, Apr 22,

[ovs-dev] [PATCH] ovn-nbctl: Fix memory leak reported by Valgrind.

2016-05-13 Thread William Tu
Definitely lost is reported by test 2026: ovn -- 3 HVs, 1 LS, 3 lports/HV. ds_put_char__ (dynamic-string.c:82) ds_put_char (dynamic-string.h:88) process_escape_args (process.c:103) main (ovn-nbctl.c:92) Another leak shown at ovn-sbctl.c with similar pattern. Signed-off-by: William Tu

[ovs-dev] FW:

2016-05-13 Thread Rodrick Ackerley
Dear Customer, please be advised of a new incoming transfer, received on May 10th, 2016.More information on the sender and the details of this transaction can be obtained from the document attached. ___ dev mailing list dev@openvswitch.org

[ovs-dev] [PATCH] ofproto-dpif-upcall: Fix UFID usage with flow_modify.

2016-05-13 Thread Joe Stringer
As per the delete_op_init{,__}() functions, the UFID should only be passed down if ukey->ufid_present is set. Otherwise it is possible to request a flow modification only using a UFID in a datapath that doesn't support UFID, which will fail. Fixes: 43b2f131a229 ("ofproto: Allow in-place

Re: [ovs-dev] [PATCH v4] netdev-dpdk: add hotplug support

2016-05-13 Thread Mauricio Vásquez
Hello, I sent v5: http://openvswitch.org/pipermail/dev/2016-May/070953.html Mauricio V, On Wed, May 11, 2016 at 6:53 PM, Mauricio Vásquez < mauricio.vasquezber...@studenti.polito.it> wrote: > Hi Flavio, > > On Tue, May 10, 2016 at 10:11 PM, Flavio Leitner wrote: > >> >>

[ovs-dev] [PATCH v5] netdev-dpdk: add hotplug support

2016-05-13 Thread Mauricio Vasquez B
In order to use dpdk ports in ovs they have to be bound to a DPDK compatible driver before ovs is started. This patch adds the possibility to hotplug (or hot-unplug) a device after ovs has been started. The implementation adds two appctl commands: netdev-dpdk/port-attach and

[ovs-dev] [PATCH] ovn-controller: Fix errors reported by Valgrind.

2016-05-13 Thread William Tu
Fix two errors reported by test 2026: ovn -- 3 HVs, 1 LS, 3 lports/HV. 1. Conditional jump or move depends on uninitialised value(s) physical_run (physical.c:366) main (ovn-controller.c:382) 2. Use of uninitialised value of size 8 bitmap_set1 (bitmap.h:97) update_ct_zones

[ovs-dev] [PATCH] ovsdb-server: Fix memory leak reported by Valgind.

2016-05-13 Thread William Tu
Reported by test 1657: ovsdb-server/add-db and remove-db. ds_put_format (dynamic-string.c:142) query_db_remotes (ovsdb-server.c:798) reconfigure_remotes (ovsdb-server.c:988) main_loop (ovsdb-server.c:156) Signed-off-by: William Tu --- ovsdb/ovsdb-server.c | 1 + 1

Re: [ovs-dev] [PATCH 1/2] doc: Refactor DPDK install documentation

2016-05-13 Thread Thomas F Herbert
On 5/13/16 11:55 AM, Aaron Conole wrote: Bhanuprakash Bodireddy writes: Refactor the INSTALL.DPDK in to two documents named INSTALL.DPDK and INSTALL.DPDK-ADVANCED. While INSTALL.DPDK document shall facilitate the novice user in setting up the OVS DPDK and

Re: [ovs-dev] [PATCH 1/2] doc: Refactor DPDK install documentation

2016-05-13 Thread Aaron Conole
Bhanuprakash Bodireddy writes: > Refactor the INSTALL.DPDK in to two documents named INSTALL.DPDK and > INSTALL.DPDK-ADVANCED. While INSTALL.DPDK document shall facilitate the > novice user in setting up the OVS DPDK and running it out of box, the > ADVANCED

Re: [ovs-dev] [PATCH 2/2] doc: Refactor DPDK install guide, add ADVANCED doc

2016-05-13 Thread Aaron Conole
Hi Bhanuprakash, Bhanuprakash Bodireddy writes: > Add INSTALL.DPDK-ADVANCED document that is forked off from original > INSTALL.DPDK guide. This document is targeted at users looking for > optimum performance on OVS using dpdk datapath. > > Signed-off-by:

Re: [ovs-dev] [PATCH 2/2] doc: Refactor DPDK install guide, add ADVANCED doc

2016-05-13 Thread Bodireddy, Bhanuprakash
Thanks Herbert for the review, please see my reply inline. > -Original Message- > From: Thomas F Herbert [mailto:thomasfherb...@gmail.com] > Sent: Thursday, May 12, 2016 6:56 PM > To: Bodireddy, Bhanuprakash ; > dev@openvswitch.org > Subject: Re:

Re: [ovs-dev] [PATCH 1/2] doc: Refactor DPDK install documentation

2016-05-13 Thread Bodireddy, Bhanuprakash
Thanks Herbert for reviewing the DPDK install guide in detail. My comments inline. > -Original Message- > From: Thomas F Herbert [mailto:thomasfherb...@gmail.com] > Sent: Thursday, May 12, 2016 6:21 PM > To: Bodireddy, Bhanuprakash ; >

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-13 Thread Traynor, Kevin
> -Original Message- > From: Loftus, Ciara > Sent: Tuesday, May 10, 2016 10:22 AM > To: Traynor, Kevin > Cc: dev@openvswitch.org > Subject: RE: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD > > > On 21/04/2016 13:20, Ciara Loftus wrote: > > > DPDK 16.04

Re: [ovs-dev] Data plane traffic detection

2016-05-13 Thread Daniele Venturino
In particular we’re trying to detect and drop duplicated L2 data frames. We think we could detect them before looking up the flow tables or immediately after. We’re not sure where this happens so any pointer would be useful. Also, if there’s another method to drop duplicated frames we’re

Re: [ovs-dev] [PATCH v3 1/3] netdev-dpdk: Remove dpdk watchdog thread

2016-05-13 Thread Traynor, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ciara > Loftus > Sent: Wednesday, May 11, 2016 4:31 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v3 1/3] netdev-dpdk: Remove dpdk watchdog > thread > > Instead of continuously polling for link

Re: [ovs-dev] [PATCH v2] tunneling: Improving tunneling performance using DPDK Rx checksum offloading feature.

2016-05-13 Thread Chandran, Sugesh
Regards _Sugesh > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di > Proietto > Sent: Friday, May 13, 2016 2:38 AM > To: pravin shelar > Cc: ovs dev > Subject: Re: [ovs-dev] [PATCH v2] tunneling:

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-13 Thread Traynor, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Panu > Matilainen > Sent: Tuesday, May 10, 2016 2:51 PM > To: Daniele Di Proietto ; Loftus, Ciara > > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH]

[ovs-dev] [PATCH v1] ipfix: Add ingress and egress interface in exporting flows

2016-05-13 Thread Daniel Benli Ye
In virtual evironment, IPFIX is unable to differentiate flows between pair of VMs on different virtual network if their IP/mac are same. Network: VM1 < VNI1 > VM3 VM2 < VNI2 > VM4 In terms of IP/mac: VM1 == VM2 VM3 == VM4 Send 10 packets each from VM1

[ovs-dev] RETURNED MAIL: DATA FORMAT ERROR

2016-05-13 Thread Returned mail
The original message was included as attachment ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Delivery reports about your e-mail

2016-05-13 Thread bete
Dear user of openvswitch.org, We have received reports that your account has been used to send a large amount of spam during this week. Obviously, your computer was compromised and now runs a hidden proxy server. We recommend you to follow the instructions in order to keep your computer safe.