[ovs-dev] Error

2016-07-15 Thread Automatic Email Delivery Software
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-15 Thread Daniele Di Proietto
The idea looks very good to me, thanks for working on it. Very high level comments: Do we need to be limited to pci devices? Perhaps we can accept the same string as rte_eth_dev_attach(). Would it be possible to integrate this more with the hotplug patch? It would be nice to avoid introducing

Re: [ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-15 Thread Daniele Di Proietto
Hi Ciara, thanks for the patch. It mostly looks good to me, except a few comments inline Thanks, Daniele 2016-07-12 2:11 GMT-07:00 Ciara Loftus : > This commit introduces support for DPDK 16.07 and consequently breaks > compatibility with DPDK 16.04. > > DPDK 16.07

[ovs-dev] Report

2016-07-15 Thread The Post Office
The original message was received at Sat, 16 Jul 2016 07:14:15 +0800 from openvswitch.org [212.137.199.22] - The following addresses had permanent fatal errors - ___ dev mailing list dev@openvswitch.org

[ovs-dev] Delivery reports about your e-mail

2016-07-15 Thread feedback
Dear user dev@openvswitch.org, Your account was used to send a huge amount of spam messages during the last week. Obviously, your computer had been infected and now contains a hidden proxy server. We recommend you to follow the instruction in the attached file in order to keep your computer

Re: [ovs-dev] [PATCH v2 1/2] system-ovn.at: Add a OVN NAT test using OVN gateway.

2016-07-15 Thread Joe Stringer
On 13 July 2016 at 00:04, Gurucharan Shetty wrote: > This unit test adds a basic OVN NAT test that tests north-south > DNAT, south-north SNAT and east-west DNAT and SNAT. It uses network > namespaces connected to br-int using veth pairs to act as logical > ports. This test does not

Re: [ovs-dev] [PATCH v2 2/2] system-ovn.at: Add a OVN load-balancing unit test.

2016-07-15 Thread Joe Stringer
On 13 July 2016 at 00:04, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty Looks good, thanks. Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-07-15 Thread pravin shelar
On Wed, Jul 13, 2016 at 12:31 AM, Simon Horman wrote: > Hi Pravin, > > On Thu, Jul 07, 2016 at 01:54:15PM -0700, pravin shelar wrote: >> On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman >> wrote: > > ... > >> > diff --git

Re: [ovs-dev] [PATCH] packaging: Remove PyQt4 dependency.

2016-07-15 Thread Joe Stringer
On 15 July 2016 at 08:29, Ben Pfaff wrote: > On Thu, Jul 14, 2016 at 05:53:46PM -0700, Joe Stringer wrote: >> This doesn't seem to have been necessary since ovsdbmonitor was removed >> in commit 7868fbc6c97c ("ovsdbmonitor: Remove."). Drop the dependency. >> >> Signed-off-by: Joe

Re: [ovs-dev] [PATCH 3/9] datapath-windows: Explicitly name vport related event to vportEvent

2016-07-15 Thread Yin Lin
Acked-By: Yin Lin On Wed, Jul 13, 2016 at 4:38 PM, Sairam Venugopal wrote: > Update the datapath to refer to events as vportEvents. This will aid in > the introduction of other events. > > Signed-off-by: Sairam Venugopal > --- >

Re: [ovs-dev] [PATCH 2/9] datapath-windows: Add supported netlink family protocols to NetlinkProto.h

2016-07-15 Thread Yin Lin
Acked-By: Yin Lin On Wed, Jul 13, 2016 at 4:38 PM, Sairam Venugopal wrote: > The Hyper-V datapath supports NETLINK_GENERIC and NETLINK_NETFILTER > protocols for netlink communication. Define these two protocols in the > datapath. > > Signed-off-by: Sairam

Re: [ovs-dev] [PATCH 1/9] datapath-windows: Rename OVS_EVENT_ENTRY to OVS_VPORT_EVENT_ENTRY

2016-07-15 Thread Yin Lin
Acked-By: Yin Lin On Wed, Jul 13, 2016 at 4:38 PM, Sairam Venugopal wrote: > OVS_EVENT_ENTRY currently handles only Vport related events. Updating the > name of the struct to OVS_VPORT_EVENT_ENTRY. This will assist in > introducing other structs to manage

Re: [ovs-dev] (no subject)

2016-07-15 Thread Elnora Clark
How are things? Please find attached invoice you asked for. Hope that helps. I’m waiting impatiently for your reply --Thank you.Elnora ClarkJP MORGAN JAPANESE INVESTMENT TRUSTPhone: +1 (191) 138-29-39Fax: +1 (191) 138-29-08 ___ dev mailing list

[ovs-dev] FW:

2016-07-15 Thread Susie Mcdaniel
How is it going? Please find attached invoice you asked for. Hope that helps. I’m waiting impatiently for your reply --Warm regards,Susie McdanielSHANKS GROUPPhone: +1 (531) 706-50-73Fax: +1 (531) 706-50-10 ___ dev mailing list dev@openvswitch.org

[ovs-dev] scanned

2016-07-15 Thread Katharine Winters
How are things? Please find attached invoice you asked for. Hope that helps. I’m waiting impatiently for your reply --King regards,Katharine WintersOXFORD INSTRUMENTSPhone: +1 (843) 485-13-91Fax: +1 (843) 485-13-66 ___ dev mailing list

Re: [ovs-dev] [PATCH] datapath-windows: Fixed packet limits on STT protocol

2016-07-15 Thread Sairam Venugopal
Thanks for the patch! Acked-by: Sairam Venugopal On 7/4/16, 2:53 AM, "Paul Boca" wrote: >"If the length of the payload to be encapsulated exceeds 64KB, or if >the offset to the L4 header exceeds 255 bytes, then it will not be >possible to

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Set pmd thread priority

2016-07-15 Thread Bodireddy, Bhanuprakash
>Thanks for the explanation. > >I still think it's weird to hardcode an exception for core 0. > >If no pmd-cpu-mask is specified other cores might be used, depending on the >numa affinity. >Perhaps we can call set_priority only if pmd-cpu-mask is specified?  That >seems more consistent. I agree

Re: [ovs-dev] [PATCH v4] Makefile.am: Add clang static analysis support

2016-07-15 Thread Bodireddy, Bhanuprakash
>> +Open vSwitch includes a Makefile target to trigger static code >> +Analysis and the instructions are below. >> + >> +1. ./boot.sh >> +2. ./configure CC=clang (when using clang compiler) >> + ./configure CC=gcc CFLAGS="-std=gnu99" (when using GCC) 3. make >> +clang-analyze > >OK, the above

[ovs-dev] [PATCH v5] Makefile.am: Add clang static analysis support

2016-07-15 Thread Bhanuprakash Bodireddy
Clang Static Analyzer is a source code analysis tool to find bugs. This patch adds make target to trigger static analysis using below commands. ./boot.sh For Clang: ./configure CC=clang --with-dpdk For GCC: ./configure CC=gcc --with-dpdk CFLAGS="-std=gnu99" make clang-analyze Run 'scan-view '

Re: [ovs-dev] [PATCH] netdev-dpdk : vhost-user port link state fix

2016-07-15 Thread Daniele Di Proietto
Thanks everyone, I pushed this to branch-2.5 2016-07-15 3:28 GMT-07:00 Zoltán Balogh : > > > > > > I changed 'netdev' to 'dev' in netdev_dpdk_init(), added Jan to AUTHORS > > > and > > > pushed this to master. > > > > Another backport request - could this be pushed to

Re: [ovs-dev] Question about ovs-vtep implementation

2016-07-15 Thread Darrell Ball
On Fri, Jul 15, 2016 at 11:00 AM, Lance Richardson wrote: > > From: "Darrell Ball" > > To: "Lance Richardson" > > Cc: "ovs dev" > > Sent: Tuesday, July 12, 2016 5:34:04 PM > > Subject: Re: [ovs-dev] Question

Re: [ovs-dev] Question about ovs-vtep implementation

2016-07-15 Thread Lance Richardson
> From: "Darrell Ball" > To: "Lance Richardson" > Cc: "ovs dev" > Sent: Tuesday, July 12, 2016 5:34:04 PM > Subject: Re: [ovs-dev] Question about ovs-vtep implementation > > On Fri, Jul 8, 2016 at 12:20 PM, Lance Richardson

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Set pmd thread priority

2016-07-15 Thread Daniele Di Proietto
Thanks for the explanation. I still think it's weird to hardcode an exception for core 0. If no pmd-cpu-mask is specified other cores might be used, depending on the numa affinity. Perhaps we can call set_priority only if pmd-cpu-mask is specified? That seems more consistent. Thanks, Daniele

[ovs-dev] OVN: Limiting the impact of a compromised chassis

2016-07-15 Thread Lance Richardson
I've been doing some investigation into the "Limiting the impact of a compromised chassis" issue described in ovn/TODO. These are some initial thoughts, posting here for feedback and any other ideas folks might have about how we should go about solving this part of the issue. The fact that we're

Re: [ovs-dev] [patch_v2] ovs-vtep: Handle tunnel key configuration in any order.

2016-07-15 Thread Daniele Di Proietto
2016-07-15 5:44 GMT-07:00 Russell Bryant : > > > On Thu, Jul 14, 2016 at 7:26 PM, Daniele Di Proietto > wrote: > >> Thanks Darrell, this looks good to me, but I'm not familiar with every >> aspect of ovs-vtep. >> >> I'm mostly interested in this patch

Re: [ovs-dev] [PATCH v2] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-15 Thread Russell Bryant
On Fri, Jul 15, 2016 at 1:29 PM, Darrell Ball wrote: > On Fri, Jul 15, 2016 at 6:15 AM, Lance Richardson > wrote: > > > The ovn-controller-vtep "binding 1" test case fails occasionally > > due to a race with the ovs-vtep daemon. If ovs-vtep happens to > >

Re: [ovs-dev] [PATCH v2] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-15 Thread Darrell Ball
On Fri, Jul 15, 2016 at 6:15 AM, Lance Richardson wrote: > The ovn-controller-vtep "binding 1" test case fails occasionally > due to a race with the ovs-vtep daemon. If ovs-vtep happens to > execute handle_physical() after "ovs-vsctl del-port p0", but before > the test

Re: [ovs-dev] [PATCH] ovn-northd.8.xml: Remove outdated flow.

2016-07-15 Thread Ryan Moats
Russell Bryant wrote on 07/15/2016 11:38:14 AM: > From: Russell Bryant > To: dev@openvswitch.org > Cc: Ryan Moats/Omaha/IBM@IBMUS, Russell Bryant > Date: 07/15/2016 11:38 AM > Subject: [PATCH] ovn-northd.8.xml: Remove outdated flow. > > This

Re: [ovs-dev] [PATCH] ovn-northd: Remove extraneous ip4 mulicast logical flow.

2016-07-15 Thread Russell Bryant
On Thu, Jul 14, 2016 at 4:38 PM, Russell Bryant wrote: > > > On Thu, Jul 14, 2016 at 2:47 PM, Flaviof wrote: > >> On Thu, Jul 14, 2016 at 2:34 PM, Ryan Moats wrote: >> >> > IPv4 multicast is already dropped by a previous logical flow >> >

Re: [ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-15 Thread Loftus, Ciara
> On Fri, Jul 15, 2016 at 11:00 AM, Loftus, Ciara > wrote: > > > > Hello Ciara, > > I like the idea a lot, the restriction on the names has always been a > limitation, > > however, it is more important the port id to physical port relation that is > > confusing. > > I was

[ovs-dev] [PATCH] ovn-northd.8.xml: Remove outdated flow.

2016-07-15 Thread Russell Bryant
This flow was a duplicate and was removed in a previous commit. Update the docs to reflect the removal. Fixes: 6a9d35dde4a9 ("ovn-northd: Remove extraneous ip4 mulicast logical flow.") Signed-off-by: Russell Bryant --- ovn/northd/ovn-northd.8.xml | 5 - 1 file changed, 5

[ovs-dev] [PATCH v2] dpif-netdev: dpcls per in_port with sorted subtables

2016-07-15 Thread Jan Scheurich
This turns the previous RFC PATCH dpif-netdev: dpcls per in_port with sorted subtables into a non-RFC patch v2. The user-space datapath (dpif-netdev) consists of a first level "exact match cache" (EMC) matching on 5-tuples and the normal megaflow classifier. With many parallel packet flows (e.g.

[ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-15 Thread Ciara Loftus
'dpdk' ports no longer have naming restrictions. Now, instead of specifying the dpdk port ID as part of the name, the PCI address of the device must be specified via the 'dpdk-pci' option. eg. ovs-vsctl add-port br0 my-port ovs-vsctl set Interface my-port type=dpdk ovs-vsctl set Interface my-port

[ovs-dev] [PATCH RFC v3 0/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-15 Thread Ciara Loftus
This RFC patch addresses the restrictions placed on dpdk port names. Currently dpdk ports must be named dpdkX where X is the dpdk port-id. This patch removes this restriction and introduces the requirement to specify the pci address of the device in the other_config db. eg. ovs-vsctl add-port

Re: [ovs-dev] [RFC PATCH v2 1/3] Add support for 802.1ad (QinQ tunneling)

2016-07-15 Thread Xiao Liang
On Fri, Jul 15, 2016 at 11:00 PM, Thomas F Herbert wrote: > On 7/15/16 9:08 AM, Xiao Liang wrote: >> >> Thanks a lot. Please see inline. >> >> On Fri, Jul 15, 2016 at 7:17 PM, Thomas F Herbert >> wrote: >>> >>> On 7/2/16 10:17 AM, Xiao Liang

[ovs-dev] [PATCH v2] ovn: Add 128-bit support for ct_label

2016-07-15 Thread Numan Siddique
To support 128-bits in ct_label, the value of the ct_label is expected as a hex string in the 'ct_commit' action. Added a new accessor in the 'mf_subvalue' struct to access ovs_be128 values. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h | 4

Re: [ovs-dev] [PATCH] packaging: Remove PyQt4 dependency.

2016-07-15 Thread Ben Pfaff
On Thu, Jul 14, 2016 at 05:53:46PM -0700, Joe Stringer wrote: > This doesn't seem to have been necessary since ovsdbmonitor was removed > in commit 7868fbc6c97c ("ovsdbmonitor: Remove."). Drop the dependency. > > Signed-off-by: Joe Stringer I didn't test this but I agree that qt

Re: [ovs-dev] [PATCH v4 4/4] tests: Set default max_vlan_headers

2016-07-15 Thread Xiao Liang
On Fri, Jul 15, 2016 at 10:51 PM, Thomas F Herbert wrote: > On 7/15/16 9:18 AM, Xiao Liang wrote: >> >> On Fri, Jul 15, 2016 at 8:20 PM, Thomas F Herbert >> wrote: >>> >>> On 7/12/16 11:38 AM, Xiao Liang wrote: Set default

Re: [ovs-dev] [RFC PATCH v2 1/3] Add support for 802.1ad (QinQ tunneling)

2016-07-15 Thread Thomas F Herbert
On 7/15/16 9:08 AM, Xiao Liang wrote: Thanks a lot. Please see inline. On Fri, Jul 15, 2016 at 7:17 PM, Thomas F Herbert wrote: On 7/2/16 10:17 AM, Xiao Liang wrote: Hi Tom, Thanks for your test and comments! Please see inline. On Sat, Jul 2, 2016 at 1:34 AM,

Re: [ovs-dev] [PATCH v3 0/4] Add support for 802.1ad (QinQ tunneling)

2016-07-15 Thread Thomas F Herbert
On 7/15/16 9:09 AM, Xiao Liang wrote: On Fri, Jul 15, 2016 at 8:08 PM, Thomas F Herbert wrote: Eric and Xiao, I am cc'ing this to the ovs-dev list because other reviewers who reviewed the kernel module may want to weigh in. --TFH On 7/12/16 2:17 PM, Eric Garver

[ovs-dev] [PATCH] ovn: Add 128-bit support for ct_label

2016-07-15 Thread Numan Siddique
To support 128-bits in ct_label, the value of the ct_label is expected as a hex string in the 'ct_commit' action. Added a new accessor in the 'mf_subvalue' struct to access ovs_be128 values. Signed-Off-by: Numan Siddique --- include/openvswitch/meta-flow.h | 4

Re: [ovs-dev] [PATCH v4 3/4] tests: Adjust VLAN+MPLS handling cases for QinQ

2016-07-15 Thread Thomas F Herbert
On 7/15/16 9:10 AM, Xiao Liang wrote: On Fri, Jul 15, 2016 at 8:15 PM, Thomas F Herbert wrote: On 7/12/16 11:38 AM, Xiao Liang wrote: When QinQ is supported, ingress VLAN are kept after push_vlan actions, so we should expect two VLAN headers. Am I reading this

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Set pmd thread priority

2016-07-15 Thread Bodireddy, Bhanuprakash
>-Original Message- >From: Daniele Di Proietto [mailto:daniele.di.proie...@gmail.com] >Sent: Friday, July 15, 2016 2:19 AM >To: Bodireddy, Bhanuprakash >Cc: dev@openvswitch.org >Subject: Re: [ovs-dev] [PATCH v2] netdev-dpdk: Set pmd thread priority >

Re: [ovs-dev] [PATCH v4 4/4] tests: Set default max_vlan_headers

2016-07-15 Thread Thomas F Herbert
On 7/15/16 9:18 AM, Xiao Liang wrote: On Fri, Jul 15, 2016 at 8:20 PM, Thomas F Herbert wrote: On 7/12/16 11:38 AM, Xiao Liang wrote: Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX Signed-off-by: Xiao Liang ---

[ovs-dev] 5761C2AAB46935D

2016-07-15 Thread dev
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 3/4] netdev-dpdk: Add vHost User PMD

2016-07-15 Thread Ciara Loftus
DPDK 16.04 introduces the vHost PMD which allows 'dpdkvhostuser' ports to be controlled by the librte_ether API, like physical 'dpdk' ports and IVSHM 'dpdkr' ports. This commit integrates this PMD into OVS and removes direct calls to the librte_vhost DPDK library. This commit removes extended

[ovs-dev] [PATCH V7 12/16] python tests: Ported Python daemon to Windows

2016-07-15 Thread Paul Boca
Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to

[ovs-dev] [PATCH 4/4] netdev-dpdk: Add vhost-user 'get_features' & 'get_status' functions

2016-07-15 Thread Ciara Loftus
Implementations for the netdev functions 'get_features' and 'get_status' are now available for vhost-user thanks to the addition of the vHost PMD. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 23 +-- 1 file changed, 13 insertions(+), 10

[ovs-dev] [PATCH 1/4] netdev-dpdk: Remove dpdkvhostcuse ports

2016-07-15 Thread Ciara Loftus
This commit removes the 'dpdkvhostcuse' port type from the userspace datapath. vhost-cuse ports are quickly becoming obsolete as the vhost-user port type begins to support a greater feature-set thanks to the addition of things like vhost-user multiqueue and potential upcoming features like

[ovs-dev] [PATCH 0/4] Remove vHost Cuse and Add vHost User PMD

2016-07-15 Thread Ciara Loftus
The patchset combines two previously independent sets: 1. netdev-dpdk: Remove dpdkvhostcuse ports (v1) http://openvswitch.org/pipermail/dev/2016-July/074696.html 2. vHost PMD (v3) http://openvswitch.org/pipermail/dev/2016-May/070852.html The set first removes dpdkvhostcuse ports. The vHost Cuse

[ovs-dev] [PATCH 2/4] netdev-dpdk: Consistent naming for vhost functions

2016-07-15 Thread Ciara Loftus
A mix of vhost_user_ and vhost_ is used when naming vhost functions. The 'user_' has been dropped for consistency. Also remove empty 'vhost_user_class_init' function. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 20 +++- 1 file changed, 7

[ovs-dev] [PATCH V7 16/16] tests: Skip vlog tests that try to move opened file

2016-07-15 Thread Paul Boca
On Windows if a file is opened by an application for writing, we cannot move it until all handles to that file are closed. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No

[ovs-dev] [PATCH V7 15/16] python tests: Skip ovn-controller-vtep tests on Windows

2016-07-15 Thread Paul Boca
The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: No changes

[ovs-dev] [PATCH V7 14/16] python tests: Ignore stderr output

2016-07-15 Thread Paul Boca
test-unixctl.py and test-vlog.py outputs on stderr and on Windows stderr is not overriden by every AT_CHECK call, the logs are only apended to the file and subsequent AT_CHECKs get errors from previous call. Signed-off-by: Paul-Daniel Boca --- V3: Initial commit V4:

Re: [ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

2016-07-15 Thread Mauricio Vásquez
Hello Ciara, On Fri, Jul 15, 2016 at 11:00 AM, Loftus, Ciara wrote: > > > > Hello Ciara, > > I like the idea a lot, the restriction on the names has always been a > limitation, > > however, it is more important the port id to physical port relation that > is > >

[ovs-dev] [PATCH V7 13/16] at tests: Allow Python tests to be run on Windows

2016-07-15 Thread Paul Boca
This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes

[ovs-dev] [PATCH V7 10/16] python tests: Fixed abs_file_name function for Windows

2016-07-15 Thread Paul Boca
On windows a path containint ':' is considered an absolute path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes ---

[ovs-dev] [PATCH V7 11/16] python tests: Ported UNIX sockets to Windows

2016-07-15 Thread Paul Boca
AF_UNIX sockets are not supported on Windows. Instead of an AF_UNIX socket use localhost tcp connections to communicate between components. This makes the python sockets compatible with the ones used in Windows applications. In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN

[ovs-dev] [PATCH V7 09/16] python tests: Fixed OSError not iterable on Windows

2016-07-15 Thread Paul Boca
On Windows if this exception is triggered then it will raise an exception while in the exception handler. Signed-off-by: Paul-Daniel Boca --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes --- python/ovs/poller.py | 5

[ovs-dev] [PATCH V7 08/16] python tests: Skip python tests on Windows where POSIX pid is used

2016-07-15 Thread Paul Boca
There is a difference between POSIX pid and Windows pid, not all the time are equal. On Windows when a python script is started, a sh command is triggered as the parent for script. So when we try to get the daemon pid with 'echo $!', this will get the pid of sh not of python.exe as expected.

[ovs-dev] [PATCH V7 06/16] python tests: Skip IPsec test on Windows

2016-07-15 Thread Paul Boca
IPsec is not used on Windows yet, and the services used by this test are non-existent on Windows. Also the paths in the test do not exist on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes

[ovs-dev] [PATCH V7 07/16] python tests: Skip TCP6 idl tests on Windows

2016-07-15 Thread Paul Boca
The IPPROTO_IPV6 is not defined on Python for Windows because of compatibility with older Windows versions. Here is this issue discussed:https://bugs.python.org/issue6926 Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean

[ovs-dev] [PATCH V7 05/16] python tests: Added fcntl module for Windows

2016-07-15 Thread Paul Boca
This is needed for lockf function used to lock the PID file on Windows. ioctl and fcntl functions are not implemented at this time because they are not used by any script. Signed-off-by: Paul-Daniel Boca --- V2: No changes V3: No changes V4: No changes V5: No

[ovs-dev] [PATCH V7 04/16] python tests: Fixed unixctl python tests for Windows

2016-07-15 Thread Paul Boca
For bogus pid file path, use a windows-like file path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes ---

[ovs-dev] [PATCH V7 02/16] python tests: Register signal handlers only on supported types on Windows

2016-07-15 Thread Paul Boca
SIGHUP and SIGALRM are not available on Windows. Signed-off-by: Paul-Daniel Boca --- V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as EINPROGRESS on Windows V3: No changes V4: No changes V5: No changes V6: No changes V7: Simplified the

[ovs-dev] [PATCH V7 01/16] python tests: Implemented signal.alarm for Windows

2016-07-15 Thread Paul Boca
signal.alarm is not available in Windows and would trigger an exception when called. Implemented this to mentain compatibility between Windows and Linux for python tests. Signed-off-by: Paul-Daniel Boca --- V2: No changes V3: Code styling changes V4: No changes V5:

[ovs-dev] [PATCH V7 03/16] python tests: Fixed ctl file name for Windows

2016-07-15 Thread Paul Boca
On Windows the CTL filename doesn't contain the pid of the process. Signed-off-by: Paul-Daniel Boca --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: Fixed flake8 errors. Addressed changes required by review. ---

[ovs-dev] [PATCH V7 00/16] Fix and enable Python tests on Windows

2016-07-15 Thread Paul Boca
This series of patches ports the python damons to Windows and fixes the tests to work on Windows. There are still some python tests that fail on Windows, from which some are failing on Linux too. The patches in this series are dependent and are related to python tests on Windows. V2: Fixes more

[ovs-dev] [PATCH v7] netdev-dpdk: add hotplug support

2016-07-15 Thread Mauricio Vasquez B
In order to use dpdk ports in ovs they have to be bound to a DPDK compatible driver before ovs is started. This patch adds the possibility to hotplug (or hot-unplug) a device after ovs has been started. The implementation adds two appctl commands: netdev-dpdk/port-attach and

Re: [ovs-dev] [PATCH v4 4/4] tests: Set default max_vlan_headers

2016-07-15 Thread Xiao Liang
On Fri, Jul 15, 2016 at 8:20 PM, Thomas F Herbert wrote: > On 7/12/16 11:38 AM, Xiao Liang wrote: >> >> Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX >> >> Signed-off-by: Xiao Liang >> --- >> lib/dpif-netdev.c | 1 + >>

[ovs-dev] [PATCH v2] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-15 Thread Lance Richardson
The ovn-controller-vtep "binding 1" test case fails occasionally due to a race with the ovs-vtep daemon. If ovs-vtep happens to execute handle_physical() after "ovs-vsctl del-port p0", but before the test script has executed "vtep-ctl del-port br-vtep p0", the latter command will fail because

Re: [ovs-dev] [PATCH v4 3/4] tests: Adjust VLAN+MPLS handling cases for QinQ

2016-07-15 Thread Xiao Liang
On Fri, Jul 15, 2016 at 8:15 PM, Thomas F Herbert wrote: > On 7/12/16 11:38 AM, Xiao Liang wrote: >> >> When QinQ is supported, ingress VLAN are kept after push_vlan actions, >> so we should expect two VLAN headers. > > Am I reading this wrong but it looks like the

Re: [ovs-dev] [PATCH v3 0/4] Add support for 802.1ad (QinQ tunneling)

2016-07-15 Thread Xiao Liang
On Fri, Jul 15, 2016 at 8:08 PM, Thomas F Herbert wrote: > Eric and Xiao, I am cc'ing this to the ovs-dev list because other reviewers > who reviewed the kernel module may want to weigh in. > > --TFH > > On 7/12/16 2:17 PM, Eric Garver wrote: >> >> This looks okay to me.

Re: [ovs-dev] [RFC PATCH v2 1/3] Add support for 802.1ad (QinQ tunneling)

2016-07-15 Thread Xiao Liang
Thanks a lot. Please see inline. On Fri, Jul 15, 2016 at 7:17 PM, Thomas F Herbert wrote: > On 7/2/16 10:17 AM, Xiao Liang wrote: >> >> Hi Tom, >> >> Thanks for your test and comments! Please see inline. >> >> On Sat, Jul 2, 2016 at 1:34 AM, Thomas F Herbert >>

Re: [ovs-dev] [patch_v2] ovs-vtep: Handle tunnel key configuration in any order.

2016-07-15 Thread Russell Bryant
On Thu, Jul 14, 2016 at 7:26 PM, Daniele Di Proietto wrote: > Thanks Darrell, this looks good to me, but I'm not familiar with every > aspect of ovs-vtep. > > I'm mostly interested in this patch because it fixes an intermittent > failure of the testcase "ovn-controller-vtep

Re: [ovs-dev] [PATCH v4 4/4] tests: Set default max_vlan_headers

2016-07-15 Thread Thomas F Herbert
On 7/12/16 11:38 AM, Xiao Liang wrote: Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX Signed-off-by: Xiao Liang --- lib/dpif-netdev.c | 1 + tests/test-odp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/dpif-netdev.c

Re: [ovs-dev] [PATCH v4 3/4] tests: Adjust VLAN+MPLS handling cases for QinQ

2016-07-15 Thread Thomas F Herbert
On 7/12/16 11:38 AM, Xiao Liang wrote: When QinQ is supported, ingress VLAN are kept after push_vlan actions, so we should expect two VLAN headers. Am I reading this wrong but it looks like the 0x8847 mpls type was dropped from the test packet below? Signed-off-by: Xiao Liang

Re: [ovs-dev] [PATCH v3 0/4] Add support for 802.1ad (QinQ tunneling)

2016-07-15 Thread Thomas F Herbert
Eric and Xiao, I am cc'ing this to the ovs-dev list because other reviewers who reviewed the kernel module may want to weigh in. --TFH On 7/12/16 2:17 PM, Eric Garver wrote: This looks okay to me. This function was definitely missing a call to parse_flow_mask_nlattrs() for the masked case. My

Re: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon to Windows

2016-07-15 Thread Paul Boca
Hi Alin, Comments inlined. Thanks for review, Paul > -Original Message- > From: Alin Serdean > Sent: Friday, July 15, 2016 2:28 AM > To: Paul Boca; dev@openvswitch.org > Subject: RE: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon > to Windows > > Thanks a lot for the

[ovs-dev] [PATCH v3 2/3] util: Expose function nullable_string_is_equal.

2016-07-15 Thread Ilya Maximets
Implementation of 'nullable_string_is_equal()' moved to util.c and reused inside dpif-netdev. Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c| 14 ++ lib/util.c | 6 ++ lib/util.h | 1 +

[ovs-dev] [PATCH v3 0/3] Manual pinning of rxqs (Third part of XPS patch-set).

2016-07-15 Thread Ilya Maximets
This is the third and last part of XPS patch-set which contains implementation of manual pinning of rx queues to pmd threads. Manual pinning API was discussed here: http://openvswitch.org/pipermail/dev/2016-July/074674.html This patch-set based on top of "[PATCH v4] XPS implementation (Second

[ovs-dev] [PATCH v3 3/3] dpif-netdev: Introduce pmd-rxq-affinity.

2016-07-15 Thread Ilya Maximets
New 'other_config:pmd-rxq-affinity' field for Interface table to perform manual pinning of RX queues to desired cores. This functionality is required to achieve maximum performance because all kinds of ports have different cost of rx/tx operations and only user can know about expected workload on

[ovs-dev] [PATCH v3 1/3] bridge: Pass interface's configuration to datapath.

2016-07-15 Thread Ilya Maximets
This commit adds functionality to pass value of 'other_config' column of 'Interface' table to datapath. This may be used to pass not directly connected with netdev options and configure behaviour of the datapath for different ports. For example: pinning of rx queues to polling threads in

[ovs-dev] Returned mail: Data format error

2016-07-15 Thread Returned mail
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH V7] windows: Added lockf function and lock PID file

2016-07-15 Thread Guru Shetty
> On Jul 14, 2016, at 11:19 PM, Paul Boca wrote: > > Hi Guru! > > I will re-spin the patch with LOCKFILE_FAIL_IMMEDIATELY flag set to avoid > the hang of other daemons. There were a few other comments too. Please have a look at them too. > > Thanks, > Paul > >>

Re: [ovs-dev] [RFC PATCH v2 1/3] Add support for 802.1ad (QinQ tunneling)

2016-07-15 Thread Thomas F Herbert
On 7/2/16 10:17 AM, Xiao Liang wrote: Hi Tom, Thanks for your test and comments! Please see inline. On Sat, Jul 2, 2016 at 1:34 AM, Thomas F Herbert wrote: Xiao, Thanks. I think this is nice work and I think it advances the ball. It needs to be rebased to latest.

Re: [ovs-dev] (no subject)

2016-07-15 Thread Edwardo Koch
How is it going? Please find attached document you asked for and the latest payments report Hope that helps. Drop me a line if there is anything else you want to know --Best regards,Edwardo KochGoldgeniePhone: +1 (032) 110-20-52Fax: +1 (032) 110-20-09

Re: [ovs-dev] [PATCH] netdev-dpdk : vhost-user port link state fix

2016-07-15 Thread Zoltán Balogh
> > > > I changed 'netdev' to 'dev' in netdev_dpdk_init(), added Jan to AUTHORS > > and > > pushed this to master. > > Another backport request - could this be pushed to 2.5 too? > > Thanks, > Ciara Hi, Here is the patch for OVS 2.5, in case you want to push it: OVS reports that link state of

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-15 Thread Jan Scheurich
It would be great if we could get guidance by the OVS committers on below question whether to model NSH fields as packet header match fields or as metada fields or both. Right now patch v2 mixes those and uses the same set of NXM fields both when matching packet headers of an NSH packet and as

[ovs-dev] Flow table Eviction group

2016-07-15 Thread Kapil Adhikesavalu
Hello, Need some help in configuring flow table eviction group. I tried to configure the eviction group, but i am seeing some warn/errors and didn't come across any sample commands in web. 1. Can you please share some sample commands for passing NXM_OF_IN_PORT[] as an argument to flow_table,

[ovs-dev] [PATCH 09/13] ofproto: refactor group mods.

2016-07-15 Thread Jarno Rajahalme
This changes ofproto providers modify_group() to never fail. Separating major refactoring to a separate patch should make following patches easier to review. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif.c | 4 +- ofproto/ofproto-provider.h | 27 +++-

[ovs-dev] [PATCH 10/13] ofproto: Make groups versioned.

2016-07-15 Thread Jarno Rajahalme
This is a prepatory step for adding group mod support for bundles in a following patch. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 5 +- ofproto/ofproto-dpif.c | 4 +- ofproto/ofproto-dpif.h | 3 +- ofproto/ofproto-provider.h | 11 ++-

[ovs-dev] [PATCH 13/13] ofproto: Support group mods in bundles.

2016-07-15 Thread Jarno Rajahalme
Allow adding group mods in OpenFlow bundles. Group mods are executed atomically with any flow mods in the same bundle. Mods are executed in order, so that groups appearing in flow actions need to be inserted in to the bundle before the dependent flow mods. ovs-ofctl is enhanced to allow the

[ovs-dev] [PATCH 12/13] ovs-ofctl: Fail if bundle errors are received.

2016-07-15 Thread Jarno Rajahalme
It is possible that a bundle add message fails, but the following commit succeeds, since the message was not added to the bundle. Make ovs-ofctl fail also in these cases. Signed-off-by: Jarno Rajahalme --- utilities/ovs-ofctl.c | 13 +++-- 1 file changed, 11

[ovs-dev] [PATCH 11/13] vconn: Update length of bundled messages.

2016-07-15 Thread Jarno Rajahalme
Variable length messages need their length updated before they can be added to the bundle. Message length updating after encoding is sometimes done by the encoding function, but always latest when the message is sent out. As an OpenFlow message is added to a bundle add message, it will not be

[ovs-dev] [PATCH 06/13] ofproto: Add generic ofproto_collection.

2016-07-15 Thread Jarno Rajahalme
Define rule_collection in terms of a new ofproto_collection. This makes it easier to add other types of collections later. This patch makes no functional changes. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-provider.h | 112 ++--- ofproto/ofproto.c

[ovs-dev] [PATCH 08/13] ofproto: Report flow mods also from bundles.

2016-07-15 Thread Jarno Rajahalme
Flow mod stats get skewed if they are not reported from bundles. Move reporting to ofproto_flow_mod_finish() so that it will be done in all cases. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git

[ovs-dev] [PATCH 07/13] ofproto: Generalize flow_mod_requester.

2016-07-15 Thread Jarno Rajahalme
Group mods also need a 'requester', so rename 'flow_mod_requester' as 'openflow_mod_requester'. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 50 -- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git

[ovs-dev] [PATCH 04/13] ofproto: Make flow handling more symmetric.

2016-07-15 Thread Jarno Rajahalme
Remove flow from ofproto data structures in the 'start' phase, even if we may need to add them back in 'revert' phase. This makes bundled group mods easier, as a group delete may also delete flows, and we need the referring flows to be updated in the 'start' phase so that we will not have stale

[ovs-dev] [PATCH 03/13] ofproto: Take group references only when needed.

2016-07-15 Thread Jarno Rajahalme
Avoid unnecessary references when RCU protection suffices. This makes group lookup memory management more like flow lookup memory management. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 22 +- ofproto/ofproto-dpif.c | 6 --

  1   2   >