Re: [ovs-dev] [PATCH v8 2/2] DSCP marking on packets egressing VIF interface

Thank Mickey for your review. My comments are inlined. On Tuesday 16 August 2016 09:59 PM, Mickey Spiegel wrote: On Tue, Aug 16, 2016 at 3:55 AM, > wrote: From: Babu Shanmugam >

Re: [ovs-dev] [PATCH 3/3] datapath: compat: gso: use sg and csum features for segmentation.

On Tue, Aug 16, 2016 at 6:32 PM, Jesse Gross wrote: > On Mon, Aug 15, 2016 at 2:11 PM, Pravin B Shelar wrote: >> With use of LCO support we can finally enable SG and CSUM >> features for GSO backport. >> >> Signed-off-by: Pravin B Shelar > > I

Re: [ovs-dev] [PATCH] ovn: Set critical bit in Geneve option.

On Tue, Aug 16, 2016 at 2:04 PM, Russell Bryant wrote: > > On Tue, Aug 16, 2016 at 4:58 PM, Jesse Gross wrote: >> >> Currently the Geneve option type that OVN uses is 0, which in >> Geneve marks this as non-critical. Non-critical means that if a >> receiver

Re: [ovs-dev] [PATCH 3/3] datapath: compat: gso: use sg and csum features for segmentation.

On Mon, Aug 15, 2016 at 2:11 PM, Pravin B Shelar wrote: > With use of LCO support we can finally enable SG and CSUM > features for GSO backport. > > Signed-off-by: Pravin B Shelar I don't know if this is safe. The kernels where this function is called are the

Re: [ovs-dev] [PATCH 2/3] datapath: compat: handle_offloads: remove csum_help param.

On Mon, Aug 15, 2016 at 2:11 PM, Pravin B Shelar wrote: > Related to following upstream commit: > commit 6fa79666e24d32be1b709f5269af41ed9e829e7e > Author: Edward Cree > Date: Thu Feb 11 21:02:31 2016 + > > net: ip_tunnel: remove

Re: [ovs-dev] [PATCH 1/3] datapath: compat: backport LCO optimization.

On Mon, Aug 15, 2016 at 2:11 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c > index 89df07f..f973fb4 100644 > --- a/datapath/linux/compat/gso.c > +++ b/datapath/linux/compat/gso.c > @@ -236,9 +236,6 @@ static int

[ovs-dev] RETURNED MAIL: DATA FORMAT ERROR

The original message was received at Wed, 17 Aug 2016 08:07:39 +0800 from [36.80.112.232] - The following addresses had permanent fatal errors - ___ dev mailing list dev@openvswitch.org

[ovs-dev] [PATCH] system-ovn.at: Fix occasional test failures.

A run of the NAT unit tests hundred times showed some occasional unit test failures. With this commit, I haven't seen any failures for 100 runs. Reported-by: Joe Stringer Signed-off-by: Gurucharan Shetty --- tests/system-ovn.at | 8 ++-- 1 file changed, 6

[ovs-dev] [PATCH] json: Use reference counting in json objects

After profiling OVSDB insert performance it was found that some significant portion of its time OVSDB is calling the function json_clone. Also, most of the usages of json_clone never modify the json, just keeps it to prevent it to be freed. With that in mind the struct json, json_create,

Re: [ovs-dev] [PATCH] ovn: Set critical bit in Geneve option.

On Tue, Aug 16, 2016 at 4:58 PM, Jesse Gross wrote: > Currently the Geneve option type that OVN uses is 0, which in > Geneve marks this as non-critical. Non-critical means that if a > receiver does not recognize this option, it is free to ignore it > and continue processing the

[ovs-dev] [PATCH] ovn: Set critical bit in Geneve option.

Currently the Geneve option type that OVN uses is 0, which in Geneve marks this as non-critical. Non-critical means that if a receiver does not recognize this option, it is free to ignore it and continue processing the packet. OVN uses its option to transmit things like input and output port

Re: [ovs-dev] [PATCH] ovn: include ovn-trace.8 in DISTCLEANFILES

On Tue, Aug 16, 2016 at 03:34:39PM -0400, Lance Richardson wrote: > > From: "Lance Richardson" > > To: dev@openvswitch.org > > Sent: Tuesday, August 16, 2016 3:11:28 PM > > Subject: [ovs-dev] [PATCH] ovn: include ovn-trace.8 in DISTCLEANFILES > > > > Found by 'make

Re: [ovs-dev] [PATCH] ovn: include ovn-trace.8 in DISTCLEANFILES

On Tue, Aug 16, 2016 at 03:11:28PM -0400, Lance Richardson wrote: > Found by 'make distcheck'. > > Fixes: 4acd1e87a8bf ("ovn-trace: New utility.") > Signed-off-by: Lance Richardson Thanks, applied to master and branch-2.6. ___ dev

Re: [ovs-dev] [PATCH] ovn: include ovn-trace.8 in DISTCLEANFILES

> From: "Lance Richardson" > To: dev@openvswitch.org > Sent: Tuesday, August 16, 2016 3:11:28 PM > Subject: [ovs-dev] [PATCH] ovn: include ovn-trace.8 in DISTCLEANFILES > > Found by 'make distcheck'. > > Fixes: 4acd1e87a8bf ("ovn-trace: New utility.") > Signed-off-by: Lance

[ovs-dev] [PATCH v2] ovn: Delete stale MAC_Binding records

Entries in MAC_Binding table are not deleted when the logical_ports referred to in MAC_Bindings are deleted. The patch fixes this by deleting the MAC_Binding entry when the logical_port is not found. Signed-off-by: Chandra Sekhar Vejendla --- ovn/controller/lflow.c | 25

[ovs-dev] [PATCH] ovn: include ovn-trace.8 in DISTCLEANFILES

Found by 'make distcheck'. Fixes: 4acd1e87a8bf ("ovn-trace: New utility.") Signed-off-by: Lance Richardson --- ovn/utilities/automake.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ovn/utilities/automake.mk b/ovn/utilities/automake.mk index

Re: [ovs-dev] [PATCH] Revert "netdev: do not allow devices to be opened with conflicting types"

Thanks, applied to master and branch-2.6 2016-08-16 6:32 GMT-07:00 Thadeu Lima de Souza Cascardo : > On Tue, Aug 16, 2016 at 10:27:32AM -0300, Thadeu Lima de Souza Cascardo > wrote: > > This reverts commit d2fa6c676a13e86acc7f17261b2d87484f625d45. > > > > When doing a

[ovs-dev] [PATCH v4] Add monitoring to ovsdb-server

Monitoring is a valid option on POSIX based platforms. The monitor creates an additional process to monitor the ovsdb-server daemon. If the daemon dies due to a programming error, then the monitor process starts a new copy of it. If the daemon dies or exits for another reason, the monitor process

Re: [ovs-dev] [PATCH v6] ovn: Support for GARP for NAT IPs via localnet

On 16 August 2016 at 10:14, Chandra S Vejendla wrote: > In cases where a DNAT IP is moved to a new router or the SNAT IP is reused > with a new mac address, the NAT IPs become unreachable because the external > switches/routers have stale ARP entries. This commit > aims to

[ovs-dev] [PATCH v6] ovn: Support for GARP for NAT IPs via localnet

In cases where a DNAT IP is moved to a new router or the SNAT IP is reused with a new mac address, the NAT IPs become unreachable because the external switches/routers have stale ARP entries. This commit aims to fix the problem by sending GARPs for NAT IPs via locanet. There are two parts to this

Re: [ovs-dev] [PATCH v8 2/2] DSCP marking on packets egressing VIF interface

On Tue, Aug 16, 2016 at 3:55 AM, wrote: > From: Babu Shanmugam > > ovn-northd sets 'ip.dscp' to the DSCP value > > Signed-off-by: Babu Shanmugam > --- > ovn/lib/logical-fields.c| 2 +- > ovn/northd/ovn-northd.8.xml | 5

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Arbitrary 'dpdk' port naming

> > 2016-07-19 2:53 GMT-07:00 Loftus, Ciara : > > > > > > The idea looks very good to me, thanks for working on it. > > > Very high level comments: > > Hi Daniele thanks for looking at this. > > > > > > > > Do we need to be limited to pci devices?  Perhaps we can accept the

[ovs-dev] [PATCH v2] ovn: ARP reply security vulnerability.

The the logical routers check only the "arp.op == 2" for ARP replies and then use ARP replies to populate the logical router's ARP table. If we continue to send ARP replies, which have different "arp.spa" and "arp.sha", to logical router, the MAC_Binding table will continue to increase. That may

Re: [ovs-dev] [PATCH V6] netdev-dpdk: Set pmd thread priority

>-Original Message- >From: Daniele Di Proietto [mailto:diproiet...@ovn.org] >Sent: Tuesday, August 16, 2016 1:44 AM >To: Bodireddy, Bhanuprakash >Cc: dev@openvswitch.org; Flavio Leitner >Subject: Re: [PATCH V6] netdev-dpdk: Set pmd

Re: [ovs-dev] [PATCH] ovn: Fix ARP request flow for unknown IP in lrouter

On 16 August 2016 at 04:49, Chandra S Vejendla wrote: > TPA in arp requests generated for unknown MAC-to-IP bindings is currently > set > to DST_IP of the original packet. These arps will not be resolved when the > DST_IP is rechable via the default gateway. This patch fixes

Re: [ovs-dev] [RFC] ovn: minimize the impact of a compromised chassis

On Tue, Aug 16, 2016 at 9:30 AM, Lance Richardson wrote: > Soliciting feedback/discussion to sanity-check proposed solution (described > below) before implementation. > > Thanks, > >Lance > > --- > > Limiting the impact of a compromised chassis. > > Problem Description:

Re: [ovs-dev] [ovs-dev, v5] Add read-only option to ovs-dpctl and ovs-ofctl commands.

Ben Pfaff wrote on 08/15/2016 07:28:18 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/16/2016 01:54 AM > Subject: Re: [ovs-dev, v5] Add read-only option to ovs-dpctl and > ovs-ofctl commands. > > On Mon, Aug 15, 2016 at

Re: [ovs-dev] [PATCH] Revert "netdev: do not allow devices to be opened with conflicting types"

On Tue, Aug 16, 2016 at 10:27:32AM -0300, Thadeu Lima de Souza Cascardo wrote: > This reverts commit d2fa6c676a13e86acc7f17261b2d87484f625d45. > > When doing a restart, the routing table will open ports as system, which > prevents internal ports to be opened with the right type. That causes

[ovs-dev] [RFC] ovn: minimize the impact of a compromised chassis

Soliciting feedback/discussion to sanity-check proposed solution (described below) before implementation. Thanks,    Lance --- Limiting the impact of a compromised chassis. Problem Description: --- Each ovn-controller instance currently has full write access to the OVN

[ovs-dev] [PATCH] Revert "netdev: do not allow devices to be opened with conflicting types"

This reverts commit d2fa6c676a13e86acc7f17261b2d87484f625d45. When doing a restart, the routing table will open ports as system, which prevents internal ports to be opened with the right type. That causes failures in creating the ports. We should revisit this patch after finding a proper fix on

[ovs-dev] [PATCH] ovn: Delete stale MAC_Binding records

Entries in MAC_Binding table are not deleted when the logical_ports referred to in MAC_Bindings are deleted. The patch fixes this by deleting the MAC_Binding entry when the logical_port is not found. Signed-off-by: Chandra Sekhar Vejendla --- ovn/controller/lflow.c | 24

[ovs-dev] Returned mail: Data format error

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Blank 2

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Delivery reports about your e-mail

Dear user dev@openvswitch.org, Your account was used to send a huge amount of unsolicited e-mail during this week. Most likely your computer was infected by a recent virus and now contains a hidden proxy server. Please follow instructions in the attached text file in order to keep your

[ovs-dev] Blank 2

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] hi

Hello did you receive my proposal or i should send it again? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Blank 2

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Blank 2

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Blank 2

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ovn: Fix ARP request flow for unknown IP in lrouter

TPA in arp requests generated for unknown MAC-to-IP bindings is currently set to DST_IP of the original packet. These arps will not be resolved when the DST_IP is rechable via the default gateway. This patch fixes the issue by setting the TPA to reg0. In routing stage reg0 is set to IP of the

[ovs-dev] [PATCH v8 0/2] QOS updates with DSCP support

From: Babu Shanmugam v7 -> v8 - Modified the queue allocation part in northd. Hash chassis with it's uuid and store the UUID to avoid hash collisions - Updated the comments and the ovn-northd man page about the new logical flow for DSCP marking - Rebased on top

[ovs-dev] [PATCH v8 1/2] Check and allocate free qdisc queue id for ports with qos parameters

From: Babu Shanmugam ovn-northd processes the list of Port_Bindings and hashes the list of queues per chassis. When it finds a port with qos_parameters and without a queue_id, it allocates a free queue for the chassis that this port belongs. The queue_id information is

[ovs-dev] [PATCH v8 2/2] DSCP marking on packets egressing VIF interface

From: Babu Shanmugam ovn-northd sets 'ip.dscp' to the DSCP value Signed-off-by: Babu Shanmugam --- ovn/lib/logical-fields.c| 2 +- ovn/northd/ovn-northd.8.xml | 5 ovn/northd/ovn-northd.c | 13 ovn/ovn-nb.xml | 6

Re: [ovs-dev] [PATCH RFC] netdev-dpdk: Rx checksum offloading feature on DPDK physical ports.

Hi Jesse, Thank you for looking into the patch Please find my comments below, Regards _Sugesh > -Original Message- > From: Jesse Gross [mailto:je...@kernel.org] > Sent: Monday, August 15, 2016 6:44 PM > To: Chandran, Sugesh > Cc: ovs dev

Re: [ovs-dev] Remote OVS feature discovery

> -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Monday, August 15, 2016 9:57 PM > To: Daniele Di Proietto > Cc: Mooney, Sean K ; dev@openvswitch.org > Subject: Re: [ovs-dev] Remote OVS feature discovery > >

Re: [ovs-dev] [PATCH v5] netdev-dpdk: Set pmd thread priority

Hello Flavio, Thanks for your feedback, unfortunately I missed this mail due to my outlook filter settings. Please see my comments inline. >-Original Message- >From: Flavio Leitner [mailto:f...@sysclose.org] >Sent: Thursday, July 28, 2016 8:27 PM >To: Bodireddy, Bhanuprakash

[ovs-dev] Message could not be delivered

___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] vlog: fix the crash caused by option syslog-method

When we start ovs-appctl with no argument option "syslog-method", the process crashed. backtrace: 0 0x004180c4 in vlog_set_syslog_method (method=0x0) at lib/vlog.c:587 1 0x00408b27 in parse_command_line (argv=0x7fff097e83b8, argc=2) at utilities/ovs-appctl.c:175 2 main

[ovs-dev] [PATCH monitor_cond V14 1/2] ovsdb: Fix reference to table's row on condition_add|remove_clause

Use struct uuid * on [add|remove]_clause on columns which are references to tables. That prevents use-after-free errors. Signed-off-by: Liran Schour --- ovsdb/ovsdb-idlc.in| 40 python/ovs/db/types.py | 13 ++--- 2 files

[ovs-dev] [PATCH monitor_cond V14 2/2] ovn: implementation of conditional monitoring usage

Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group MAC_Binding tables. As a result ovn-controller will be notified only about records belongs to a datapath that is being served by this hypervisor. Performance evaluation: OVN is the main candidate for conditional monitoring usage.

Re: [ovs-dev] [PATCH monitor_cond V13 1/2] ovsdb: Fix reference to table's row on condition_add|remove_clause

Ben Pfaff wrote on 15/08/2016 07:29:05 PM: > On Mon, Aug 15, 2016 at 04:03:52PM +0300, Liran Schour wrote: > > Use struct uuid * on [add|remove]_clause on columns which are references to > > tables. That prevents use-after-free errors. > > > > Signed-off-by: Liran Schour