Re: [ovs-dev] [PATCH v1] Python-IDL: getattr after mutate fix

2016-10-12 Thread Amitabha Biswas
Thanks! I reposted the patch with the update to the commit message. Amitabha > On Oct 12, 2016, at 1:16 PM, Russell Bryant wrote: > > > > On Wed, Oct 12, 2016 at 10:32 AM, Amitabha Biswas <mailto:azbis...@gmail.com>> wrote: > This commit returns the updated column

[ovs-dev] [PATCH v1] Python-IDL: getattr after mutate fix

2016-10-12 Thread Amitabha Biswas
This commit returns the updated column value when getattr is done after a mutate operation is performed (but before the commit). Signed-off-by: Amitabha Biswas Reported-by: Richard Theis Reported-at: http://openvswitch.org/pipermail/dev/2016-September/080120.html Fixes: a59912a0ee8e ("p

[ovs-dev] [PATCH v1] Python-IDL: getattr after mutate fix

2016-10-12 Thread Amitabha Biswas
This commit returns the updated column value when getattr is done after a mutate operation is performed (but before the commit). It addresses the bug reported in http://openvswitch.org/pipermail/dev/2016-September/080120.html Signed-off-by: Amitabha Biswas Reported-by: Richard Theis

Re: [ovs-dev] [PATCH v3 2/5] ovn: Introduce l3 gateway router.

2016-08-31 Thread Amitabha Biswas
Hi Steve, Here is the link to the networking-ovn patch: https://review.openstack.org/#/c/346646/ Thanks Amitabha From: "Shi Xin Ruan" To: Gurucharan Shetty Cc: dev@openvswitch.org Date: 08/31/2016 10:51 PM Subject:Re: [ovs-dev] [PATCH v3 2/5] ovn: Introduce l3 gateway ro

[ovs-dev] [PATCH v2] ovs-monitor-ipsec: Fix flake8-check semicolon error

2016-08-31 Thread Amitabha Biswas
Fixes: 19cd0a87 Signed-off-by: Amitabha Biswas Acked-by: Numan Siddique --- debian/ovs-monitor-ipsec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec index e6617b0..6bc26aa 100755 --- a/debian/ovs-monitor-ipsec +++ b/debian

[ovs-dev] [PATCH] ovs-monitor-ipsec: Fix flake8-check semicolon error

2016-08-30 Thread Amitabha Biswas
--- debian/ovs-monitor-ipsec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec index e6617b0..6bc26aa 100755 --- a/debian/ovs-monitor-ipsec +++ b/debian/ovs-monitor-ipsec @@ -333,7 +333,7 @@ class IPsec(object): self.ca

Re: [ovs-dev] [PATCH v2] ovsdb-idlc: Fix memory leaks in add and remove clause functions.

2016-08-26 Thread Amitabha Biswas
v2 addresses the concern I had about v1. So… Acked-by: Amitabha Biswas mailto:abis...@us.ibm.com>> > On Aug 26, 2016, at 2:18 PM, Ben Pfaff wrote: > > Found by inspection. > > Signed-off-by: Ben Pfaff > --- > v1->v2: Fix some more leaks. (Thanks to Amitabha Bis

Re: [ovs-dev] [PATCH] ovsdb-idlc: Fix memory leak in smap add and remove clause functions.

2016-08-26 Thread Amitabha Biswas
Hi Ben, This seems to take care of datums of type is_map, do we need to need to the same for type is_set()? Thanks Amitabha > On Aug 26, 2016, at 9:03 AM, Ben Pfaff wrote: > > Found by inspection. > > Signed-off-by: Ben Pfaff > --- > ovsdb/ovsdb-idlc.in | 4 > 1 file changed, 4 insertio

[ovs-dev] [PATCH v1] Python IDL Mutate Fix

2016-08-23 Thread Amitabha Biswas
s modified to use the named-uuid to identify a row created in the current transaction. Signed-off-by: Amitabha Biswas Suggested-by: Richard Theis --- python/ovs/db/idl.py | 8 +++- tests/ovsdb-idl.at | 14 ++ tests/test-ovsdb.py | 6 ++ 3 files changed, 23 insert

Re: [ovs-dev] [PATCH v2] ovn: Delete stale MAC_Binding records

2016-08-19 Thread Amitabha Biswas
;Datapath_Binding", + "refType": "weak"}, + "min": 0}}}, "indexes": [["logical_port", "ip"]], "isRoot": true}, &

[ovs-dev] [PATCH v2] Python IDL Partial Set and Map Updates

2016-08-15 Thread Amitabha Biswas
multiple map updates on the same column in a transaction. 2. Partial map Py3 IDL test can now support multiple elements. 3. SetAttr overrides pre-existing insert and remove updates. 4. addvalue/delvalue contains unique elements Signed-off-by: Amitabha Biswas --- python/ovs/db/idl.py | 118

[ovs-dev] [PATCH v2] Python IDL Partial Set and Map Updates

2016-08-15 Thread Amitabha Biswas
v1->v2: * Remove unused _init_mutations_if_needed function ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v1] Python IDL Partial Set and Map Updates

2016-08-15 Thread Amitabha Biswas
I must have overlooked removing that routine. It’s not needed. I’ll push v2. Thanks Amitabha > On Aug 15, 2016, at 9:22 AM, Ben Pfaff wrote: > > On Mon, Aug 15, 2016 at 02:21:55AM -0700, Amitabha Biswas wrote: >> This patch fixes a couple of bugs in commit a59912a0 >> (py

[ovs-dev] [PATCH v1] Python IDL Partial Set and Map Updates

2016-08-15 Thread Amitabha Biswas
multiple map updates on the same column in a transaction. 2. Partial map Py3 IDL test can now support multiple elements. 3. SetAttr overrides pre-existing insert and remove updates. 4. addvalue/delvalue contains unique elements Signed-off-by: Amitabha Biswas --- python/ovs/db/idl.py | 111

Re: [ovs-dev] [PATCH v1] Enable manager_option configuation for NB and SB

2016-07-28 Thread Amitabha Biswas
sounds reasonable? Thanks Amitabha > On Jul 27, 2016, at 11:45 AM, Ben Pfaff wrote: > > On Mon, Jul 18, 2016 at 10:21:09PM -0700, Amitabha Biswas wrote: >> NB and SB dbs are handled by separate ovsdb-server processes. The >> ovsdb-server processes manage dbs based on the schem

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 4.6

2016-07-26 Thread Amitabha Biswas
Typo in the previous ack Acked-by: Amitabha Biswas mailto:abis...@us.ibm.com>> > On Jul 26, 2016, at 4:22 PM, Amitabha Biswas wrote: > > I was able to compile the openvswitch modules on Linux 4.6 kernel and stacked > using OpenStack networking-ovn. > > The basic NAT

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 4.6

2016-07-26 Thread Amitabha Biswas
I was able to compile the openvswitch modules on Linux 4.6 kernel and stacked using OpenStack networking-ovn. The basic NAT system tests passed and the OVN test suite passed. Asked-by: Amitabha Biswas mailto:abis...@us.ibm.com>> > On Jul 26, 2016, at 2:07 PM, Jesse Gross wrote: &g

[ovs-dev] [PATCH v1] Enable manager_option configuation for NB and SB

2016-07-18 Thread Amitabha Biswas
itch/ovnnb_db.sock --no-wait set Manager $manager_uuid inactivity_probe=0 ovs-vsctl --db=unix:/usr/local/var/run/openvswitch/ovnnb_db.sock list Manager ovs-vsctl --db=unix:/usr/local/var/run/openvswitch/ovnnb_db.sock --no-wait set Manager $manager_uuid inactivity_probe=5 Signed-off-by:

Re: [ovs-dev] [PATCH] ovn-sbctl: Change lport-(un)bind to lsp-(un)bind.

2016-06-24 Thread Amitabha Biswas
orial/ovn/env5/setup.sh > @@ -61,7 +61,7 @@ ovs-vsctl add-port br-int lport2 -- set Interface lport2 > external_ids:iface-id=p > ovs-vsctl add-port br-int lport5 -- set Interface lport5 > external_ids:iface-id=provnet1-5-101-port1 > ovs-vsctl add-port br-in

Re: [ovs-dev] [PATCH v1] Add new column compute_types to OVN_Southbound

2016-06-24 Thread Amitabha Biswas
> On Jun 24, 2016, at 6:41 AM, Russell Bryant wrote: > > > On Wed, Jun 22, 2016 at 5:55 PM, Amitabha Biswas <mailto:azbis...@gmail.com>> wrote: > > On Jun 22, 2016, at 2:30 PM, Guru Shetty > <mailto:g...@ovn.org>> wrote: > > > >

Re: [ovs-dev] [PATCH v1] Add new column compute_types to OVN_Southbound

2016-06-22 Thread Amitabha Biswas
> On Jun 22, 2016, at 2:30 PM, Guru Shetty wrote: > > > > On 21 June 2016 at 12:20, Amitabha Biswas <mailto:azbis...@gmail.com>> wrote: > This patch allows a OVN hypervisor administator to specify the > type(s) of non-distributed logical port, the hyperv

[ovs-dev] [PATCH v1] Add new column compute_types to OVN_Southbound

2016-06-21 Thread Amitabha Biswas
ify that the ports it is hosting matches the its preference. Signed-off-by: Amitabha Biswas --- ovn/controller/chassis.c| 62 - ovn/controller/ovn-controller.8.xml | 19 ovn/controller/ovn-controller.c | 12 +++ ovn/controller

[ovs-dev] [v1 1/1] Add new column compute_types to OVN_Southbound

2016-06-21 Thread Amitabha Biswas
ify that the ports it is hosting matches the its preference. Signed-off-by: Amitabha Biswas --- ovn/controller/chassis.c| 62 - ovn/controller/ovn-controller.8.xml | 19 ovn/controller/ovn-controller.c | 12 +++ ovn/controller

Re: [ovs-dev] [PATCH] Function tracer to trace all function calls

2016-06-10 Thread Amitabha Biswas
Hi Nirapada, This patch doesn’t apply, please rebase on top of the master branch. The ovn-northd diff indicates deletion of gateway related code at the minimum. Thanks Amitabha > On Jun 9, 2016, at 11:12 AM, ngh...@us.ibm.com wrote: > > In some circumstances, we might need to figure out where

Re: [ovs-dev] OpenStack Proposal: Integration with OVN L3 Gateway

2016-06-08 Thread Amitabha Biswas
ue, Jun 7, 2016 at 3:50 PM, Amitabha Biswas wrote: >> This proposal outlines the modifications needed in networking-ovn (addresses >> https://bugs.launchpad.net/networking-ovn/+bug/1551717 >> <https://bugs.launchpad.net/networking-ovn/+bug/1551717>) to provide >> Fl

Re: [ovs-dev] OpenStack Proposal: Integration with OVN L3 Gateway

2016-06-08 Thread Amitabha Biswas
On Jun 8, 2016, at 7:18 AM, Brian Haley wrote: > > On 06/07/2016 04:50 PM, Amitabha Biswas wrote: >> This proposal outlines the modifications needed in networking-ovn (addresses >> https://bugs.launchpad.net/networking-ovn/+bug/1551717 >> <https://bugs.launchpad.

[ovs-dev] OpenStack Proposal: Integration with OVN L3 Gateway

2016-06-07 Thread Amitabha Biswas
This proposal outlines the modifications needed in networking-ovn (addresses https://bugs.launchpad.net/networking-ovn/+bug/1551717 ) to provide Floating IP (FIP) and SNAT using the L3 gateway router patches listed below: http://patchwork.

Re: [ovs-dev] [PATCH v8 1/2] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

2016-05-25 Thread Amitabha Biswas
One minor nit below - put_dchp_opts > > +/* > + * Parses the "put_dhcp_opts" action. > + * Format of the action is > + * - put_dchp_opts(R, offer_ip = , D1 = V1,..., Dn = Vn) > + * > + * Example: > + *put_dhcp_opts(reg0, offer_ip = 10.0.0.4, router = 10.0.0.1, > + * netmask

Re: [ovs-dev] [v1 1/1] Fix "raceful" E2E ovn tests

2016-05-20 Thread Amitabha Biswas
Thanks Jeff, 2035 : ovn -- 1 HVs, 2 LSs, 1 lport/LS, 1 LR I did have this test fail even without -j option (every 1 out around 25 runs) and the other tests involving Routers. Ben mentioned that this may be an artifact of the ARP tables not being populated on time, so I’d like his opinion on t

[ovs-dev] [v1 1/1] Fix "raceful" E2E ovn tests

2016-05-20 Thread Amitabha Biswas
ption must not be used under such circumstances. If a logical datapath doesn't exist on a particular hypervisor, the ovn-controller will not apply any OpenFlow rules associated with that datapath and not update the cur_cfg. Use caution with the "--wait" option. Signed-off-by: Amitabha Bi

Re: [ovs-dev] [RFC] OVN northbound address sets

2016-03-10 Thread Amitabha Biswas
It’s a great idea. From an OpenStack point of view, this will make NB ACL transaction sets O(1) instead of O(N) when combined with the delta ACL computation patch that is currently under review. I agree with Ryan’s SB extension. Since Address_Set will be a new table, the conditional_monitor cod

Re: [ovs-dev] weekly OVN report

2016-03-08 Thread Amitabha Biswas
I see a couple of distinct discussions occurring on this thread, maybe it’s time to deal with them independently. The Security/ACL aspect of the protocol - Is there some reason why existing SSL authentication and encryption mechanisms is not adequate enough for security. I am not opposed to bui

Re: [ovs-dev] OVN: Floating IP Support - Proposal

2016-02-03 Thread Amitabha Biswas
assumption. In such cases, there should not be a need for a L3 gateway (resulting in one less hop). The modified proposal can state this use case at the beginning of the proposal. Does this address your concern? Thanks Amitabha From: Han Zhou To: Amitabha Biswas/San Jose/IBM@IBMUS C

[ovs-dev] OVN: Floating IP Support - Proposal

2016-02-01 Thread Amitabha Biswas
This is a proposal regarding how Floating IP will be supported in OpenStack using OVN. The complete proposal can also be found at https://review.openstack.org/#/c/274274/. The additions proposed to the OVN Northbound Schema and Southbound Flows are outlined here as well. The proposal assumes t

Re: [ovs-dev] OVS/OVN: Interface with NAT

2016-01-04 Thread Amitabha Biswas
me wrote: > >> >> On Dec 16, 2015, at 2:15 PM, Amitabha Biswas > <mailto:azbis...@gmail.com>> wrote: >> >> Hi Jarno, >> >> As part of OVN integration in Openstack, I’ve been trying to setup OpenFlow >> NAT rules and run the system-tes

Re: [ovs-dev] OVS/OVN: Interface with NAT

2015-12-16 Thread Amitabha Biswas
> On Dec 16, 2015, at 4:42 PM, Jarno Rajahalme wrote: > > >> On Dec 16, 2015, at 2:15 PM, Amitabha Biswas > <mailto:azbis...@gmail.com>> wrote: >> >> Hi Jarno, >> >> As part of OVN integration in Openstack, I’ve been trying to setup Open

[ovs-dev] OVS/OVN: Interface with NAT

2015-12-16 Thread Amitabha Biswas
Hi Jarno, As part of OVN integration in Openstack, I’ve been trying to setup OpenFlow NAT rules and run the system-test-suite 33: system-traffic.at:1396 conntrack - simple SNAT. Using the latest (as of 12/15/2015) ovs master branch on Ubuntu Linux 4.3 kernels (from kernel.ubuntu.com

Re: [ovs-dev] [PATCH v2 1/3] ovn: Update TODO, ovn-northd flow table design, ovn-architecture for L3.

2015-10-01 Thread Amitabha Biswas
Hi, I have some initial questions in this design. > On Sep 30, 2015, at 1:56 PM, Ben Pfaff wrote: > > This is a proposed plan for logical L3 in OVN. It is not entirely > complete but it includes many important details and I believe that it moves > planning forward. > > +* L3 support > + > +**

Re: [ovs-dev] OVN - L3 Gap between NB schema and Neutron

2015-08-03 Thread Amitabha Biswas
Hi, I think Gal is saying the following - ml2 allows the following: VM (10.0.0.2) --- Logical_Switch (10.0.0.2) LogicalRouter | | | | VM (10.0.1.2) ++-(10.0.1.2) LogicalRouter