[ovs-dev] [RFC: fedora ovn packaging 5/5] rpms: Adding three additional OVN packages

Add ovn-northbound-database, ovn-southbound-database and ovn-northd as packages that can be installed independently. Signed-off-by: Andy Zhou <az...@ovn.org> --- rhel/automake.mk | 5 +- rhel/openvswitch-fedora.spec.in

[ovs-dev] [RFC: fedora ovn packaging 2/5] rpms: Style fixes

Replace a few tabs with spaces in the file to be more consistent with the rest of the file. Signed-off-by: Andy Zhou <az...@ovn.org> --- rhel/openvswitch-fedora.spec.in | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/rhel/openvswitch-fedora.spe

[ovs-dev] [RFC: fedora ovn packaging 0/5] RFC fedora ovn packaging

. ovn-central package is retained to be friendly to single host deployments. However ovn-central service is marked as exclusive with the other three services mentioned above. (I am not sure if this is necessary, and may more confusing than its worth) Andy Zhou (5): rpms: Seperate ovsdb-server

Re: [ovs-dev] [PATCH] datapath: Linux 4.9 compat.

sted with current Linux net-next (4.9) and 3.16. > > Signed-off-by: Jarno Rajahalme <ja...@ovn.org> > Tested building linux 4.0-4.9. Acked-by: Andy Zhou <az...@ovn.org> When compiling with 4.0, I got the following warnning. It does not seem to be related to this patch. /home/azh

[ovs-dev] [PATCH] rpms: Remove more OVN files form openvswitch rpm builds

OVN is packaged with openvswitch-fedora.spec.in, but not with openvswitch.spec.in. Remove OVN files from openvswitch.spec.in builds to make rpm build happy. Signed-off-by: Andy Zhou <az...@ovn.org> --- rhel/openvswitch.spec.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [ovs-dev] [PATCH] ovn: fix OVNDB process is stopped when master node demote to the slave by pacemaker

On Wed, Dec 7, 2016 at 11:42 PM, Guoshuai Li <l...@dtdream.com> wrote: > > On 2016/12/8 5:36, Andy Zhou wrote: > > > > On Tue, Dec 6, 2016 at 9:41 PM, Guoshuai Li <l...@dtdream.com> wrote: > >> When the master node's OVNDB process fails, the local node d

Re: [ovs-dev] [PATCH] ovn: fix OVNDB process is stopped when master node demote to the slave by pacemaker

On Tue, Dec 6, 2016 at 9:41 PM, Guoshuai Li wrote: > When the master node's OVNDB process fails, the local node demote to the > slave. > Failure cause is that the OVNDB process is stop, So the need to re-run the > process up. > if return $OCF_NOT_RUNNING will not demote the

Re: [ovs-dev] [PATCH V2] Fix ovndb_servers master and VirtualIP are not on the same node.

On Fri, Dec 2, 2016 at 11:38 PM, Guoshuai Li wrote: > PCS man page says role=Stopped/Started/Master/Slave. > A role can be master or slave (if no role is specified, it defaults to > 'started'). > > Command line "$pcs constraint colocation add ovndb_servers-master with > master

Re: [ovs-dev] [PATCH 4/4] configure: Enable new warning options added in GCC 6.

On Mon, Dec 5, 2016 at 2:38 PM, Ben Pfaff <b...@ovn.org> wrote: > -Wnull-dereference is also new in GCC 6 but upon testing it produces far > too many false positives to be usable for OVS. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-b

Re: [ovs-dev] [PATCH 3/4] configure: Enable new warning options added in GCC 5.

On Mon, Dec 5, 2016 at 2:38 PM, Ben Pfaff <b...@ovn.org> wrote: > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/4] configure: Use -Wformat-security with -Wformat.

a space in it, which obviously doesn't work. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovn: Fix pacemaker Master node does not monitor the OVSDB status

On Tue, Dec 6, 2016 at 4:35 AM, Guoshuai Li wrote: > OVSDB resource is multi-state resource, pacemaker monitor actions are > insufficient to monitor a multi-state resource. > the usual one will cover the slave role, so it is need to configure > monitoring for the master. > >

Re: [ovs-dev] [PATCH 1/4] acinclude: Fix -Wstrict-prototypes and -Wold-style-definition detection.

ototypes. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v6 0/4] High availability support for OVN DB servers using pacemaker

On Wed, Nov 16, 2016 at 2:13 AM, Babu Shanmugam <bscha...@redhat.com> wrote: > v5 -> v6: > - Added more text to the man page of ovn-ctl and some more information to > the integration guide. > Acked-by: Andy Zhou <az...@ovn.org> This ack applies to all 4 patches

Re: [ovs-dev] [PATCH v5 1/4] ovn: ovn-ctl support for HA ovn DB servers

On Mon, Nov 7, 2016 at 11:55 PM, Babu Shanmugam <bscha...@redhat.com> wrote: > > > On Monday 07 November 2016 06:49 PM, Andy Zhou wrote: > > This version is better, I am able to apply them. Thanks. > > I got the system running, but managed to get system into a state wh

Re: [ovs-dev] [PATCH v4 1/4] ovn: ovn-ctl support for HA ovn DB servers

On Wed, Nov 2, 2016 at 1:33 AM, Babu Shanmugam wrote: > This patch adds support to start_ovsdb() function in ovn-ctl to start the > ovn db servers in backup mode. This can be done in the following ways > 1. Use parameters --ovn-nb-sync-from-addr and --ovn-sb-sync-from-addr

Re: [ovs-dev] [PATCH] ovn-test: Fix 'test-ovn composition' crash

On Wed, Oct 19, 2016 at 12:58 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Oct 11, 2016 at 12:33:22PM -0700, Andy Zhou wrote: > > Without this fix, the added test will core dump. > > > > Signed-off-by: Andy Zhou <az...@ovn.org> > > Thanks! > >

Re: [ovs-dev] [PATCH 15/15] ovsdb-idl: Check internal graph in OVSDB tests.

n Pfaff <b...@ovn.org> > For all 15 patches in the series, Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 1/4] ovn: ovn-ctl support for HA ovn DB servers

On Fri, Oct 14, 2016 at 2:52 AM, Babu Shanmugam <bscha...@redhat.com> wrote: > > > On Friday 14 October 2016 04:00 AM, Andy Zhou wrote: > > > > Done. Now it shows the following. > > [root@h2 ovs]# crm configure show >> >> node 1: h1 \ >> >&

Re: [ovs-dev] [PATCH] stream-ssl: Fix memory leak on error path.

On Fri, Oct 14, 2016 at 11:12 AM, Ben Pfaff <b...@ovn.org> wrote: > The commit that this fixes is from 2009. > > Reported-by: Kai-Wei Fan <f...@vmware.com> > Fixes: 9467fe624698 ("Add SSL support to "stream" library and OVSDB.") > Signed-off-by:

Re: [ovs-dev] [PATCH v3 1/4] ovn: ovn-ctl support for HA ovn DB servers

On Wed, Oct 12, 2016 at 10:57 PM, Babu Shanmugam <bscha...@redhat.com> wrote: > > > On Thursday 13 October 2016 07:26 AM, Andy Zhou wrote: > > > > On Sun, Oct 9, 2016 at 12:02 AM, Babu Shanmugam <bscha...@redhat.com> > wrote: > >> >> >

Re: [ovs-dev] ovn: Improving southbound database security

On Thu, Oct 13, 2016 at 11:26 AM, Ben Pfaff wrote: > On Wed, Oct 12, 2016 at 01:51:39PM -0400, Russell Bryant wrote: > > 1) Add support to ovsdb-server for read-only remotes. The port reachable > > by ovn-controller would only accept read-only connections. > > Andy, is this

Re: [ovs-dev] [PATCH v3 1/4] ovn: ovn-ctl support for HA ovn DB servers

On Sun, Oct 9, 2016 at 12:02 AM, Babu Shanmugam <bscha...@redhat.com> wrote: > > > On Friday 07 October 2016 05:33 AM, Andy Zhou wrote: > >> Babu, Thank you for working on this. At a high level, it is not clear >> to me the boundary between ocf scripts and th

Re: [ovs-dev] [PATCH] tests: Get rid of overly specific --pidfile and --unixctl options.

to die without manual intervention. > However, a long time ago we introduced the "on_exit" mechanism that > obsoletes this. This commit eliminates a lot of the old litter of kill > invocations, which also makes those tests easier to read. > > Signed-off-by: Ben Pfaff <b...

Re: [ovs-dev] [PATCH] tests: Fix double-rebuild of testsuite for "check-valgrind".

ovn.org> > I was not clear to me either why the race happened, but the change looks good to me. Acked-by: Andy Zhou <az...@ovn.org> There are two additional targets that have the similar pattern, wonder if we should change them as well... diff --git a/tests/automake.mk b/tests/automake.mk

Re: [ovs-dev] [PATCH] lex: Treat formfeeds as white space.

On Fri, Oct 7, 2016 at 10:04 AM, Ben Pfaff <b...@ovn.org> wrote: > Also vertical tabs, whatever those are. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list dev@openvswi

[ovs-dev] [PATCH] ovn-test: Fix 'test-ovn composition' crash

Without this fix, the added test will core dump. Signed-off-by: Andy Zhou <az...@ovn.org> --- tests/ovn.at | 4 tests/test-ovn.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index caf9f98..1f65e75 100644 --- a/tests/ovn.at

Re: [ovs-dev] [PATCH 4/4] expr: Better simplify some special cases of expressions.

n Pfaff <b...@ovn.org> > Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/4] expr: Improve test so that it would have found the bugs I just fixed.

Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/4] expr: Fix abort when simplifying "x != 0/0".

On Thu, Oct 6, 2016 at 8:30 PM, Ben Pfaff <b...@ovn.org> wrote: > The test added by this commit is very specific to the particular problem, > whereas a more general test would be better. A later commit adds the > general test. > > Signed-off-by: Ben Pfaff <b...@ovn.org>

Re: [ovs-dev] [PATCH 1/4] expr: Simplify "x == 0/0" into 1.

tter. A later commit adds the > general test. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn: Fix "trace" test to wait for synchronization of southbound ports.

On Fri, Oct 7, 2016 at 9:23 AM, Ben Pfaff <b...@ovn.org> wrote: > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] ovn-trace: Include source file and line number reference in output.

On Fri, Oct 7, 2016 at 10:02 AM, Ben Pfaff <b...@ovn.org> wrote: > This should make it that much easier to track down the code that emitted > a particular flow. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Andy Zhou <az...@ovn.org>

Re: [ovs-dev] [PATCH 1/2] smap: New macro SMAP_CONST2 for an immutable map of 2 key-value pairs.

On Fri, Oct 7, 2016 at 10:02 AM, Ben Pfaff <b...@ovn.org> wrote: > Future commits will add a user. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Andy Zhou <az...@ovn.org> This is the first time I encountered a linked-list being bui

Re: [ovs-dev] [PATCH v3 1/4] ovn: ovn-ctl support for HA ovn DB servers

Babu, Thank you for working on this. At a high level, it is not clear to me the boundary between ocf scripts and the ovn-ctl script -- i.e. which aspect is managed by which entity. For example, 1) which scripts are responsible for starting the ovsdb servers. 2) Which script should manage the

Re: [ovs-dev] [PATCH v3 0/4] High availability support for OVN DB servers using pacemaker

On Tue, Oct 4, 2016 at 1:37 PM, Ben Pfaff wrote: > On Wed, Sep 28, 2016 at 10:00:19AM +0530, bscha...@redhat.com wrote: > > v2 -> v3: > > - Handling few edged cases in the OCF script as suggested by > > Andrew Beekhof > > > > This patch contains changes required to run a

Re: [ovs-dev] Status on etcd?

er this is still happening? >> > > I believe Andy Zhou was the one most actively researching approaches. > CC'd. > The integration did not make it into version 2.6 which is just released. I plan to spend time to evaluate (i.e. prototype) for OVN integr

Re: [ovs-dev] [PATCH] OVSDB: Fix segfalut during replication.

On Mon, Sep 26, 2016 at 8:30 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Sep 20, 2016 at 01:27:08PM -0700, Andy Zhou wrote: > > The newly added replication logic makes it possible for a monitor to > > receive delete and insertion of the same row back to back, which > &

Re: [ovs-dev] [PATCH] ovsdb: Fix memory leak when disposing 'replication_dbs'

On Mon, Sep 26, 2016 at 8:32 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Sep 20, 2016 at 05:49:47PM -0700, Andy Zhou wrote: > > Found by inspection. > > > > The 'replication_dbs' structure was not freed after use. > > Fix by adding a new function replication_d

[ovs-dev] [PATCH] ovsdb: Fix memory leak when disposing 'replication_dbs'

Found by inspection. The 'replication_dbs' structure was not freed after use. Fix by adding a new function replication_dbs_destroy(). Also remove unnecessary global pointer variables initializer. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/replication.c | 21 ++

Re: [ovs-dev] [PATCH] OVSDB: Fix segfalut during replication.

On Tue, Sep 20, 2016 at 4:39 PM, Joe Stringer <j...@ovn.org> wrote: > On 20 September 2016 at 13:27, Andy Zhou <az...@ovn.org> wrote: > > The newly added replication logic makes it possible for a monitor to > > receive delete and insertion of the same row back to back,

[ovs-dev] [PATCH] OVSDB: Fix segfalut during replication.

org> Reported-at: http://openvswitch.org/pipermail/dev/2016-September/079315.html Reported-by: Alin Serdean <aserd...@cloudbasesolutions.com> Reported-at: http://openvswitch.org/pipermail/dev/2016-September/079586.html Co-authored-by: Joe Stringer <j...@ovn.org> Signed-off-by: Andy Z

Re: [ovs-dev] [PATCH] replication: Be more careful about JSON parsing and simplify code.

of the problem, but this new implementation > leaves me more confident due to its simplicity. > > Reported-by: Joe Stringer <j...@ovn.org> > Reported-at: http://openvswitch.org/pipermail/dev/2016-September/ > 079315.html > Fixes: 60e0cd041958 ("ovsdb: Replication usability impr

Re: [ovs-dev] [PATCH] ovsdb-server: Fix memory leak in ovsdb_server_get_sync_exclude_tables().

const char *argv[] OVS_UNUSED, > void *arg_ OVS_UNUSED) > { > -unixctl_command_reply(conn, get_blacklist_tables()); > +char *reply = get_blacklist_tables(); > +unixctl_command_reply(conn, reply); > + free(reply); > } > &

Re: [ovs-dev] [PATCH v2] ovsdb-server: Add ovsdb-server/is-backup-server command in unixctl

On Fri, Aug 19, 2016 at 9:32 AM, Numan Siddique wrote: > This command will be useful to query if the ovsdb-server > instance is active or backup. > > Signed-off-by: Numan Siddique > --- > ovsdb/ovsdb-server.1.in | 4 > ovsdb/ovsdb-server.c|

Re: [ovs-dev] [v3] ovsdb: Replication usability improvements

On Fri, Sep 2, 2016 at 1:55 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Aug 31, 2016 at 07:32:41PM -0700, Andy Zhou wrote: > > Added the '--no-sync' option base on feedbacks of current > > implementation. > > > > Added appctl command "ovsdb-server/sync-sta

Re: [ovs-dev] [replication SMv2 7/7] ovsdb: Replication usability improvements

> > I tested the v3 version pulling from your github, and I am not seeing an >> crashes. >> > > > Thanks for testing. I added your name to tested-by in the V3 patch. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [v3] ovsdb: Replication usability improvements

able is updated from replication_run(). Added a test to simulate the integration of HA manager with OVSDB server using replication. Other documentation and API improvements. Tested-by: Numan Siddique <nusid...@redhat.com> Signed-off-by: Andy Zhou <az...@ovn.org> --- Documentation/OVSD

Re: [ovs-dev] [replication SMv2 6/7] OVSDB: Reimplement replication. Using a state machine.

On Tue, Aug 30, 2016 at 2:35 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Aug 26, 2016 at 04:15:53PM -0700, Andy Zhou wrote: > > Current replication uses blocking transactions, which are error prone > > in practice, especially in handling RPC connection flapping to

Re: [ovs-dev] [PATCH] ovn: ovn-ctl support to start ovn db servers in standby mode

On Thu, Aug 25, 2016 at 6:48 AM, wrote: > This patch adds support to start_ovsdb() function in ovn-ctl to start the > ovn db servers in standby mode. This can be done in the following ways > 1. Use parameters --ovn-nb-sync-from-addr and --ovn-sb-sync-from-addr to >set

Re: [ovs-dev] [replication SMv2 7/7] ovsdb: Replication usability improvements

On Tue, Aug 30, 2016 at 4:17 AM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Tue, Aug 30, 2016 at 1:11 AM, Andy Zhou <az...@ovn.org> wrote: > >> >> >> On Mon, Aug 29, 2016 at 3:14 AM, Numan Siddique <nusid...@redhat.com> >> wrote: >

Re: [ovs-dev] [replication SMv2 7/7] ovsdb: Replication usability improvements

On Mon, Aug 29, 2016 at 3:14 AM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Sat, Aug 27, 2016 at 4:45 AM, Andy Zhou <az...@ovn.org> wrote: > >> Added the '--no-sync' option base on feedbacks of current >> implementation. >> >> Added

Re: [ovs-dev] [Replication SM 0/7] Replication SM

On Thu, Aug 25, 2016 at 10:38 PM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Thu, Aug 25, 2016 at 5:37 AM, Andy Zhou <az...@ovn.org> wrote: > >> The main purpose of this series patch 6 (OVSDB: Reimplement >> replication. Using a state machine). P

[ovs-dev] [replication SMv2 7/7] ovsdb: Replication usability improvements

on and API improvements. Signed-off-by: Andy Zhou <az...@ovn.org> -- I hope to get some review comments on the command line and appctl interfaces for replication. Since 2.6 is the first release of those interfaces, it is easier to making changes, compare to future releases. v1->v2: Fi

[ovs-dev] [replication SMv2 6/7] OVSDB: Reimplement replication. Using a state machine.

Current replication uses blocking transactions, which are error prone in practice, especially in handling RPC connection flapping to the active server. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/ovsdb-server.c | 17 +- ovsdb/replication.c

[ovs-dev] [replication SMv2 1/7] ovsdb: Properly handle error returned from from reset_database()

Fix a memory leak in case of error. The error object was not properly disposed. Since the error to reset DB is not expected, log it and exit. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/replication.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a

[ovs-dev] [replication SMv2 4/7] ovsdb: (Re)hide struct db in ovsdb-server.c

It seems odd that the currently replication implementation moves the struct db from ovsdb-server.c (file private) to replication.h (global). This patch moves the 'struct db' defintion back into ovsdb-server.c, Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/ovsdb-server.c

[ovs-dev] [replication SMv2 0/7] replication SMv2

591.html Only the last patch (7) is changed from v1->v2 Andy Zhou (7): ovsdb: Properly handle error returned from from reset_database() ovsdb: Add blacklist_tables ovsdb: Add request_ids ovsdb: (Re)hide struct db in ovsdb-server.c test: Improve replication unit tests OVSDB: Reimp

[ovs-dev] [replication SMv2 5/7] test: Improve replication unit tests

Replication test currently uses many sleeps that slowes the test down and may not be reliable. Remove those sleeps when possible. OVSDB servers needs to be killed on test failure. Use on_exit() to ensure cleanup happens, so they don't have to be handled for each testing step. Signed-off-by: Andy

[ovs-dev] [replication SMv2 3/7] ovsdb: Add request_ids

will make use of this facility. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/replication.c | 84 ++--- 1 file changed, 80 insertions(+), 4 deletions(-) diff --git a/ovsdb/replication.c b/ovsdb/replication.c index ebd348c..815730d

[ovs-dev] [replication SMv2 2/7] ovsdb: Add blacklist_tables

to set_blacklist_tables() API to make this feature available to the command line option parsing and unixctl command parsing. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/ovsdb-server.c | 47 ovsdb/replication.c | 153 +-

[ovs-dev] [Replication SM 4/7] ovsdb: (Re)hide struct db in ovsdb-server.c

It seems odd that the currently replication implementation moves the struct db from ovsdb-server.c (file private) to replication.h (global). This patch moves the 'struct db' defintion back into ovsdb-server.c, Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/ovsdb-server.c

[ovs-dev] [Replication SM 7/7] ovsdb: Replication usability improvements

on and API improvements. Signed-off-by: Andy Zhou <az...@ovn.org> -- I hope to get some review comments on the command line and appctl interfaces for replication. Since 2.6 is the first release of those interfaces, it is easier to making changes, compare to future releases. --- Doc

[ovs-dev] [Replication SM 2/7] ovsdb: Add blacklist_tables

to set_blacklist_tables() API to make this feature available to the command line option parsing and unixctl command parsing. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/ovsdb-server.c | 47 ovsdb/replication.c | 153 +-

[ovs-dev] [Replication SM 0/7] Replication SM

The main purpose of this series patch 6 (OVSDB: Reimplement replication. Using a state machine). Patch 7 includes a few replication usability enhancements that has been requested on the mailing list. Andy Zhou (7): ovsdb: Properly handle error returned from from reset_database() ovsdb: Add

[ovs-dev] [Replication SM 5/7] test: Improve replication unit tests

Replication test currently uses many sleeps that slowes the test down and may not be reliable. Remove those sleeps when possible. OVSDB servers needs to be killed on test failure. Use on_exit() to ensure cleanup happens, so they don't have to be handled for each testing step. Signed-off-by: Andy

[ovs-dev] [Replication SM 6/7] OVSDB: Reimplement replication. Using a state machine.

Current replication uses blocking transactions, which are error prone in practice, especially in handling RPC connection flapping to the active server. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/ovsdb-server.c | 17 +- ovsdb/replication.c

[ovs-dev] [Replication SM 3/7] ovsdb: Add request_ids

will make use of this facility. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/replication.c | 84 ++--- 1 file changed, 80 insertions(+), 4 deletions(-) diff --git a/ovsdb/replication.c b/ovsdb/replication.c index ebd348c..815730d

Re: [ovs-dev] ovsdb active backup deployment

On Fri, Aug 19, 2016 at 11:48 AM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Wed, Aug 17, 2016 at 11:24 PM, Andy Zhou <az...@ovn.org> wrote: > >> >> >> On Wed, Aug 17, 2016 at 8:30 AM, Numan Siddique <nusid...@redhat.com> >&

Re: [ovs-dev] [PATCH] pinctrl: Fix memory leak for NAT IPs in send_garp_run().

m. > > > > CC: Chandra S Vejendla <csvej...@us.ibm.com> > > Reported-by: Ramu Ramamurthy <ramu.ramamur...@gmail.com> > > Fixes: 8439c2ebd823 ("ovn: Support for GARP for NAT IPs via localnet") > > Si

Re: [ovs-dev] ovsdb active backup deployment

On Fri, Aug 19, 2016 at 1:40 AM, Valentine Sinitsyn < valentine.sinit...@gmail.com> wrote: > On 19.08.2016 02:44, Andy Zhou wrote: > >> >> >> On Thu, Aug 18, 2016 at 1:41 PM, Valentine Sinitsyn >> <valentine.sinit...@gmail.com <mail

Re: [ovs-dev] ovsdb active backup deployment

On Thu, Aug 18, 2016 at 1:41 PM, Valentine Sinitsyn < valentine.sinit...@gmail.com> wrote: > On 18.08.2016 23:49, Andy Zhou wrote: > >> >> >> On Thu, Aug 18, 2016 at 8:34 AM, Valentine Sinitsyn >> <valentine.sinit...@gmail.com <mail

Re: [ovs-dev] ovsdb active backup deployment

On Thu, Aug 18, 2016 at 8:34 AM, Valentine Sinitsyn < valentine.sinit...@gmail.com> wrote: > On 18.08.2016 17:42, Russell Bryant wrote: > >> >> On Thu, Aug 18, 2016 at 2:30 AM, Valentine Sinitsyn >> > >> wrote: >> >> Hi

Re: [ovs-dev] ovsdb active backup deployment

On Wed, Aug 17, 2016 at 8:30 AM, Numan Siddique wrote: > ​Hi Andy, > I have started working on integrating ovsdb-server HA support with > pacemaker (via OCF heartbeat, i.e ocf:heartbeat). > Thanks for working on it. > > Few comments below. > > > >> >> >>> Thanks for

Re: [ovs-dev] [PATCH] sandbox: launch SB backup server when running in OVN mode

On Mon, Aug 15, 2016 at 1:50 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Mon, Aug 15, 2016 at 4:45 PM, Andy Zhou <az...@ovn.org> wrote: > >> >> >> On Mon, Aug 15, 2016 at 1:36 PM, Russell Bryant <russ...@ovn.org> wrote: >> >

Re: [ovs-dev] [PATCH] sandbox: launch SB backup server when running in OVN mode

On Mon, Aug 15, 2016 at 1:36 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Mon, Aug 15, 2016 at 2:54 PM, Andy Zhou <az...@ovn.org> wrote: > >> >> >> On Thu, Aug 11, 2016 at 1:22 PM, Russell Bryant <russ...@ovn.org> wrote: >> >

Re: [ovs-dev] [PATCH] ovsdb-idl: Fix double-remove in ovsdb_idl_condition_reset().

On Sat, Aug 13, 2016 at 5:37 PM, Ben Pfaff <b...@ovn.org> wrote: > Both ovsdb_idl_condition_reset() and ovsdb_idl_clause_free() call > ovs_list_remove() on the clause's 'node' member, but it should only be > called once. > > Signed-off-by: Ben Pfaff <b...@ovn.org>

Re: [ovs-dev] [PATCH] sandbox: launch SB backup server when running in OVN mode

On Thu, Aug 11, 2016 at 1:22 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Tue, Aug 9, 2016 at 7:49 PM, Andy Zhou <az...@ovn.org> wrote: > >> Automatically launch backup server for OVN SB database that replicates >> all transactions of

Re: [ovs-dev] [PATCH 4/4] ovsdb: Make OVSDB backup sever read only

On Sat, Aug 13, 2016 at 10:23 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Aug 03, 2016 at 04:57:05PM -0700, Andy Zhou wrote: > > When ovsdb-sever is running in the backup state, it would be nice to > > make sure there is no un-intended changes to the backup database. >

Re: [ovs-dev] [PATCH 3/4] ovsdb: Fix bug, set rpc to NULL after freeing.

On Sat, Aug 13, 2016 at 10:14 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Aug 03, 2016 at 04:57:04PM -0700, Andy Zhou wrote: > > Found by inspection > > > > Signed-off-by: Andy Zhou <az...@ovn.org> > > It's not obvious from the context that this can c

Re: [ovs-dev] [v2] ovs-vsctl: simply vsctl_parent_process_info()

On Wed, Aug 10, 2016 at 9:51 AM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Aug 09, 2016 at 12:50:31PM -0700, Andy Zhou wrote: > > Use ds_get_line() instead of hand rolling it. Rearrange the logic > > to removes some duplication. > > > > Signed-off-by: Andy Zhou &

[ovs-dev] [PATCH] sandbox: launch SB backup server when running in OVN mode

Automatically launch backup server for OVN SB database that replicates all transactions of the active server. This can be handy for experimenting with the newly added replication feature. Signed-off-by: Andy Zhou <az...@ovn.org> --- tutorial/ovs-sandbox | 15 +++ 1 file chang

[ovs-dev] [v2] ovs-vsctl: simply vsctl_parent_process_info()

Use ds_get_line() instead of hand rolling it. Rearrange the logic to removes some duplication. Signed-off-by: Andy Zhou <az...@ovn.org> --- v1->v2: rebase to current master. --- utilities/ovs-vsctl.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) d

Re: [ovs-dev] [PATCH] ovs-vsctl: Change log level of vsctl_parent_process_info

nd is probably the best option. > > [1] https://github.com/openvswitch/ovn-scale-test > [2] https://github.com/openvswitch/ovn-scale-test/ > blob/master/rally_ovs/plugins/ovs/scenarios/ovn.py#L255 > > Signed-off-by: Kyle Mestery <mest...@mestery.com> > > Than

Re: [ovs-dev] [ovs-dev, 3/4] ovsdb: Fix bug, set rpc to NULL after freeing.

On Fri, Aug 5, 2016 at 9:08 AM, Daniel Levy wrote: > Tested this and it works, however it needs a rebase. > The rebase may be caused by patches ahead of this one in the series. Thanks for testing and reporting. > > -- > Sincerely, > Daniel Levy >

Re: [ovs-dev] [PATCH 3/3] check-kernel: Remove '-d' from TESTSUITEFLAGS.

ssed explicitly. This is > more in line with other test make target ('check', > 'check-system-userspace'). > > CC: Andy Zhou <az...@ovn.org> > Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> > --- > tests/automake.mk | 2 +- > 1 file changed, 1 insertion(+

Re: [ovs-dev] ovsdb active backup deployment

On Thu, Aug 4, 2016 at 11:14 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Thu, Aug 4, 2016 at 8:17 PM, Andy Zhou <az...@ovn.org> wrote: > >> >> On Wed, Jul 27, 2016 at 1:04 PM, Andy Zhou <az...@ovn.org> wrote: >> >>> >>> &g

Re: [ovs-dev] ovsdb active backup deployment

On Wed, Jul 27, 2016 at 1:04 PM, Andy Zhou <az...@ovn.org> wrote: > > > On Tue, Jul 26, 2016 at 6:20 PM, Russell Bryant <russ...@ovn.org> wrote: > >> >> >> On Tue, Jul 26, 2016 at 3:48 PM, Andy Zhou <az...@ovn.org> wrote: >> >>>

Re: [ovs-dev] [PATCH] ovs-vsctl: Change log level of vsctl_parent_process_info

On Thu, Aug 4, 2016 at 11:39 AM, Kyle Mestery <mest...@mestery.com> wrote: > On Thu, Aug 4, 2016 at 12:56 PM, Andy Zhou <az...@ovn.org> wrote: > > > > > > On Thu, Aug 4, 2016 at 6:54 AM, Kyle Mestery <mest...@mestery.com> > wrote: > >> > >

[ovs-dev] [PATCH] ovs-vsctl: simply vsctl_parent_process_info()

Use ds_get_line() instead of hand rolling it. Rearrange the logic to removes some duplication. Signed-off-by: Andy Zhou <az...@ovn.org> --- utilities/ovs-vsctl.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/utilities/ovs-vsctl.c b/utiliti

Re: [ovs-dev] [PATCH] ovs-vsctl: Change log level of vsctl_parent_process_info

On Thu, Aug 4, 2016 at 6:54 AM, Kyle Mestery wrote: > While running the ovn-scale-test [1] port-binding tests [2], I notice a > continual stream of messages such as this: > > 2016-08-04 13:05:28.705 547 INFO rally_ovs.plugins.ovs.scenarios.ovn [-] > bind lport_0996bf_cikzNO

[ovs-dev] [PATCH 1/4] ovsdb: Rename replication related variable names.

option. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/ovsdb-server.1.in | 18 +++ ovsdb/ovsdb-server.c| 58 - ovsdb/replication.c | 34 ++--- ovsdb/replication.h | 8 +++ tests/ovsdb-ser

[ovs-dev] [PATCH 2/4] ovsdb: add replication wait

Pollblock requires the run() function to be paired with a wait() function. Add one for replication. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/ovsdb-server.c | 3 +++ ovsdb/replication.c | 8 ovsdb/replication.h | 1 + 3 files changed, 12 insertions(+) diff --git a

[ovs-dev] [PATCH 4/4] ovsdb: Make OVSDB backup sever read only

connections will be reset. After reconnect, all clinet transactions will then be accepted. Signed-off-by: Andy Zhou <az...@ovn.org> --- manpages.mk | 2 ++ ovsdb/active-backup.man | 14 ++ ovsdb/automake.mk| 1 + ovsdb/execution.c

[ovs-dev] [PATCH 3/4] ovsdb: Fix bug, set rpc to NULL after freeing.

Found by inspection Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/replication.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ovsdb/replication.c b/ovsdb/replication.c index 19626a5..de6eec1 100644 --- a/ovsdb/replication.c +++ b/ovsdb/replication.c @@ -150,6

Re: [ovs-dev] Replication feature bug

On Mon, Aug 1, 2016 at 2:44 PM, Andy Zhou <az...@ovn.org> wrote: > > > On Mon, Aug 1, 2016 at 10:07 AM, Cabrera Vega, Mario Alberto < > mario.cabr...@hpe.com> wrote: > >> Hi, >> >> The replication_init() function initializes the set that contains

Re: [ovs-dev] [PATCH] ovsdb: Fix memory leak in execute_update.

On Mon, Aug 1, 2016 at 10:08 AM, William Tu wrote: > Thanks, I've submitted v2 which removes the 'const'. > LGTM. Pushed to master. Thanks for working on this. > > ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH] ovsdb: Fix OVSDB disconnect replication bug

On Mon, Aug 1, 2016 at 5:00 PM, Andy Zhou <az...@ovn.org> wrote: > > > On Mon, Aug 1, 2016 at 2:41 PM, Andy Zhou <az...@ovn.org> wrote: > >> From: Mario Cabrera <mario.cabr...@hpe.com> >> >> Currently disconnecting from the replicator s

Re: [ovs-dev] [PATCH] ovsdb: Fix OVSDB disconnect replication bug

On Mon, Aug 1, 2016 at 2:41 PM, Andy Zhou <az...@ovn.org> wrote: > From: Mario Cabrera <mario.cabr...@hpe.com> > > Currently disconnecting from the replicator server means closing the > jsonrpc > connection and destroying the monitored table names and blacklisted ta

Re: [ovs-dev] Replication feature bug

On Mon, Aug 1, 2016 at 10:07 AM, Cabrera Vega, Mario Alberto < mario.cabr...@hpe.com> wrote: > Hi, > > The replication_init() function initializes the set that contains the > names of the > tables to be monitored and the set that contains the names of the tables > to be > excluded from

<    1   2   3   4   5   6   7   8   9   10   >