[ovs-dev] [PATCH] ovsdb: Fix OVSDB disconnect replication bug

From: Mario Cabrera Currently disconnecting from the replicator server means closing the jsonrpc connection and destroying the monitored table names and blacklisted table names. This patch makes a distition between disconnecting from the remote server, applicable when the

Re: [ovs-dev] [PATCH] travis: Fix flake8 failures from flake8 3.0.

; Signed-off-by: Russell Bryant <russ...@ovn.org> > Acked-by: Andy Zhou <az...@ovn.org> > > - Note: successfully tested in a run on travis-ci. > > Thanks for working on this. It should help the health of travis. I noticed master has been failing for a while. > > __

Re: [ovs-dev] [PATCH 2/3] ovsdb: Fix memory leak in replication logic

On Wed, Jul 27, 2016 at 12:48 PM, Andy Zhou <az...@ovn.org> wrote: > > > On Wed, Jul 27, 2016 at 12:43 PM, Ben Pfaff <b...@ovn.org> wrote: > >> On Tue, Jul 26, 2016 at 01:08:06PM -0700, Andy Zhou wrote: >> > Release the memory of reply message of the initia

Re: [ovs-dev] [PATCH] ovsdb: Fix memory leak in execute_update.

William Tu <u9012...@gmail.com> > Tested, it removed the memory leak reported. I think declare 'where' as 'struct json' instead of 'const struct json' will make the code easier to read. Acked-by: Andy Zhou <az...@ovn.org> > ___ dev mai

Re: [ovs-dev] ovsdb active backup deployment

On Tue, Jul 26, 2016 at 6:20 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Tue, Jul 26, 2016 at 3:48 PM, Andy Zhou <az...@ovn.org> wrote: > >> >> >> On Tue, Jul 26, 2016 at 11:59 AM, Russell Bryant <russ...@ovn.org> wrote: >> >

Re: [ovs-dev] [PATCH 2/3] ovsdb: Fix memory leak in replication logic

On Wed, Jul 27, 2016 at 12:43 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Jul 26, 2016 at 01:08:06PM -0700, Andy Zhou wrote: > > Release the memory of reply message of the initial "monitor" request. > > > > Reported-at: http://openvswitch.org/pipermail/dev

Re: [ovs-dev] [PATCH 1/3] ovsdb: Properly close replication rpc connection

able initializes to 0. > Right, I will drop the NULL initializations. > > Acked-by: William Tu <u9012...@gmail.com> > Thanks for the review. I will push to master in a minute. > > On Tue, Jul 26, 2016 at 1:08 PM, Andy Zhou <az...@ovn.org> wrote: > > This pat

[ovs-dev] [PATCH 3/3] test: Replication tests uses unix domain socket

Fix replication test titles to fit changes committed by 63b35ecc06cbd16bc0e93d1e26021d81c413a485. Signed-off-by: Andy Zhou <az...@ovn.org> --- tests/ovsdb-server.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at index e

[ovs-dev] [PATCH 2/3] ovsdb: Fix memory leak in replication logic

Release the memory of reply message of the initial "monitor" request. Reported-at: http://openvswitch.org/pipermail/dev/2016-July/076075.html Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/replication.c | 4 1 file changed, 4 insertions(+) diff --git a/ovsdb/repli

[ovs-dev] [PATCH 1/3] ovsdb: Properly close replication rpc connection

This patch removes rpc related memory leak reported below. Reported-at: http://openvswitch.org/pipermail/dev/2016-July/076075.html Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/ovsdb-server.c | 1 + ovsdb/replication.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff

Re: [ovs-dev] ovsdb active backup deployment

On Tue, Jul 26, 2016 at 11:59 AM, Russell Bryant <russ...@ovn.org> wrote: > > > On Tue, Jul 26, 2016 at 2:41 PM, Andy Zhou <az...@ovn.org> wrote: > >> >> >> On Tue, Jul 26, 2016 at 5:37 AM, Russell Bryant <russ...@ovn.org> wrote: >> >

Re: [ovs-dev] ovsdb active backup deployment

On Tue, Jul 26, 2016 at 5:37 AM, Russell Bryant <russ...@ovn.org> wrote: > > > On Mon, Jul 25, 2016 at 8:15 PM, Andy Zhou <az...@ovn.org> wrote: > >> Hi, Rayn and Russell, >> > > Can we move this discussion to the ovs dev mailing list? Feel free to >

Re: [ovs-dev] OVSDB replication related memory leak

On Mon, Jul 25, 2016 at 8:26 AM, William Tu wrote: > Hi, > > Valgrind reports definitely memory leak in the testcase > 1826: ovsdb-server.at:1081 insert monitored table, update excluded > table > Can someone take at look? Thank you~ > > ==52969== 144 (48 direct, 96

Re: [ovs-dev] [v2] test: change replication test to use unix domain socket

On Fri, Jul 22, 2016 at 5:02 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Jul 22, 2016 at 04:37:52PM -0700, Andy Zhou wrote: > > The ovsdb replication feature is not specific to the ovsdb socket types. > > Switching the tests to use Unix domain socket simplifies the test

[ovs-dev] [v2] test: change replication test to use unix domain socket

The ovsdb replication feature is not specific to the ovsdb socket types. Switching the tests to use Unix domain socket simplifies the tests. Signed-off-by: Andy Zhou <az...@ovn.org> --- tests/ovsdb-server.at | 70 ++- 1 file changed, 30 inse

Re: [ovs-dev] [add ovsdb lock tests 3/3] tests: add ovsdb lock tests

On Thu, Jun 23, 2016 at 12:31 PM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Jun 06, 2016 at 01:51:16PM -0700, Andy Zhou wrote: > > Add more ovsdb lock tests. > > > > Signed-off-by: Andy Zhou <az...@ovn.org> > > This test checks c1-output twice, I suspect t

Re: [ovs-dev] [add ovsdb lock tests 1/3] ovsdb: fix ovsdb-client --help output format

This patch no longer applies after cond_monitoring patches went in. I will drop it. On Fri, Jul 22, 2016 at 12:59 PM, Andy Zhou <az...@ovn.org> wrote: > Thanks for the reminder. I will get them committed soon. > > On Fri, Jul 22, 2016 at 12:49 PM, Ben Pfaff <b...@ovn.org> wr

Re: [ovs-dev] [add ovsdb lock tests 1/3] ovsdb: fix ovsdb-client --help output format

Thanks for the reminder. I will get them committed soon. On Fri, Jul 22, 2016 at 12:49 PM, Ben Pfaff wrote: > This series seems to be fully reviewed but it's been sitting unpushed at > the bottom of patchwork for a while. Are you going to apply it? > > Thanks, > > Ben. >

Re: [ovs-dev] [PATCH v2] ovn-controller: Fix potential null pointer dereferences.

On Wed, Jul 20, 2016 at 9:46 PM, Ben Pfaff <b...@ovn.org> wrote: > Found by inspection. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > v1->v2: Found another one to fix. Looks good. Acked-by: Andy Zhou <az...@ovn.org>

Re: [ovs-dev] [PATCH] tests: Make ovsdb test more robust and faster.

explicitly wait for > the transaction on ovsdb1 to become visible on ovsdb2. > > Also fix the name of the test. > > Signed-off-by: Jarno Rajahalme <ja...@ovn.org> > Nice! Acked-by: Andy Zhou <az...@ovn.org> I happened to have an outstanding patch that change the test to use unix-

[ovs-dev] [PATCH] test: change replication test to use unix domain socket

The ovsdb replication feature is not specific to the ovsdb socket types. Switching the tests to use Unix domain socket simplifies the tests. Signed-off-by: Andy Zhou <az...@ovn.org> Although they don't make any difference in my local testing, travis tests are less likely to

Re: [ovs-dev] [PATCH 4/4] ovsdb: Add unixctl commands for OVSDB replication

gt; > Disconnect from the remote server and stop replication, without dropping > the replicated data: > > ovsdb-server/disconnect-remote-ovsdb-server > > Signed-off-by: Mario Cabrera <mario.cabr...@hpe.com> Acked-by: Andy Zhou <az...@ovn.org> I was able

Re: [ovs-dev] [PATCH] system-traffic: Use NC_EOF_OPT in truncate tests.

On Mon, Jul 11, 2016 at 11:44 AM, Guru Shetty <g...@ovn.org> wrote: > > > On 11 July 2016 at 11:41, Andy Zhou <az...@ovn.org> wrote: > >> >> >> On Mon, Jul 11, 2016 at 11:28 AM, Guru Shetty <g...@ovn.org> wrote: >> >>&

Re: [ovs-dev] [PATCH] system-traffic: Use NC_EOF_OPT in truncate tests.

s the packet > then returns immediately. > > Signed-off-by: Joe Stringer <j...@ovn.org> > Looks good. Thanks for working on this. Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] lib: Remove extra API dependency for ovs_thread_create()

On Fri, Jul 1, 2016 at 8:15 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Jun 17, 2016 at 04:25:32PM -0700, Andy Zhou wrote: > > When calling ovs_thread_create() without calling fatal_signal_init() > > first, ovs_thread_create() some times asserts. This dependency is &g

Re: [ovs-dev] [PATCH] vagrant: Add 'nc' to installed programs.

On Tue, Jun 28, 2016 at 2:23 AM, Joe Stringer <j...@ovn.org> wrote: > netcat is used in several tests, but when creating a new vagrant VM we > haven't been installing it. Do so. > > Signed-off-by: Joe Stringer <j...@ovn.org> > Acked-b

[ovs-dev] [PATCH] lib: Remove extra API dependency for ovs_thread_create()

. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/ovs-thread.c | 2 +- tests/test-rcu.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ovs-thread.c b/lib/ovs-thread.c index 6e63452..c7dc7da 100644 --- a/lib/ovs-thread.c +++ b/lib/ovs-thread.c @@ -372,7

Re: [ovs-dev] [PATCH v2] ofp-util: Fix parsing of parenthesized values within key-value pairs.

On Mon, Jun 13, 2016 at 2:54 PM, Ben Pfaff <b...@ovn.org> wrote: > Reported-by: james hopper <jameshop...@email.com> > Reported-at: > http://openvswitch.org/pipermail/discuss/2016-June/021662.html > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: And

Re: [ovs-dev] [PATCH] ofp-util: Fix parsing of parenthesized values within key-value pairs.

On Sun, Jun 12, 2016 at 5:43 PM, Ben Pfaff wrote: > Reported-by: james hopper > Reported-at: > http://openvswitch.org/pipermail/discuss/2016-June/021662.html > Signed-off-by: Ben Pfaff > --- > AUTHORS | 1 + > lib/ofp-util.c

Re: [ovs-dev] [PATCH] ovs-vsctl: Support identifying Flow_Sample_Collector_Set records by id.

l. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Tested, it works. Acked-by: Andy Zhou <az...@ovn.org> > --- > lib/db-ctl-base.c | 35 --- > utilities/ovs-vsctl.c | 4 +++- > 2 files changed, 27 insertions(+), 12 deletions(-) >

Re: [ovs-dev] [PATCH 4/6] vagrant: Override box for libvirt provider.

On Fri, Jun 3, 2016 at 7:07 PM, Joe Stringer <j...@ovn.org> wrote: > On 23 May 2016 at 16:30, Andy Zhou <az...@ovn.org> wrote: > > > > > > On Fri, May 20, 2016 at 11:49 AM, Joe Stringer <j...@ovn.org> wrote: > >> > >> The default va

Re: [ovs-dev] [PATCH 5/6] vagrant: Ignore common ovs-dev.py paths for rsync.

On Fri, Jun 3, 2016 at 6:54 PM, Joe Stringer <j...@ovn.org> wrote: > On 23 May 2016 at 18:33, Joe Stringer <j...@ovn.org> wrote: > > On 23 May 2016 at 16:25, Andy Zhou <az...@ovn.org> wrote: > >> > >> > >> On Fri, May 20, 2016 at 11:49 AM, Joe

[ovs-dev] [add ovsdb lock tests 3/3] tests: add ovsdb lock tests

Add more ovsdb lock tests. Signed-off-by: Andy Zhou <az...@ovn.org> --- tests/automake.mk | 1 + tests/ovsdb-lock.at | 77 + tests/ovsdb.at | 1 + 3 files changed, 79 insertions(+) create mode 100644 tests/ovsdb-lock.at diff

[ovs-dev] [add ovsdb lock tests 2/3] ovsdb: Add ovsdb-client options for testing lock

. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/ovsdb-client.1.in | 22 ++ ovsdb/ovsdb-client.c| 196 2 files changed, 218 insertions(+) diff --git a/ovsdb/ovsdb-client.1.in b/ovsdb/ovsdb-client.1.in index 5d99f59..2a60469

[ovs-dev] [add ovsdb lock tests 1/3] ovsdb: fix ovsdb-client --help output format

Signed-off-by: Andy Zhou <az...@ovn.org> --- This patch should be backported. --- ovsdb/ovsdb-client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c index 80819a8..5fc7ad9 100644 --- a/ovsdb/ovsdb-client.c +++ b/ovsdb

Re: [ovs-dev] [PATCH] vswitch.xml: Document interface name length restrictions.

On Thu, May 26, 2016 at 10:30 AM, Ben Pfaff <b...@ovn.org> wrote: > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > vswitchd/vswitch.xml | 59 > +--- > 1 file changed, 47 insertions(+), 12 deletions(-) > > A

Re: [ovs-dev] [PATCH 3/6] vagrant: Update default box to Fedora-23.

On Fri, May 20, 2016 at 11:49 AM, Joe Stringer <j...@ovn.org> wrote: > This brings a newer kernel (4.2) and newer iproute2, allowing more of > the tests to run by default. > > Signed-off-by: Joe Stringer <j...@ovn.org> > Acked-by: Andy Z

Re: [ovs-dev] [PATCH 4/6] vagrant: Override box for libvirt provider.

On Fri, May 20, 2016 at 11:49 AM, Joe Stringer wrote: > The default vagrant box for fedora23 uses the images provided by Chef's > "bento" project, which has support for 3 backend providers: parallels, > virtualbox and vmware. However, they do not build boxes for the libvirt >

Re: [ovs-dev] [PATCH 5/6] vagrant: Ignore common ovs-dev.py paths for rsync.

On Fri, May 20, 2016 at 11:49 AM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > Vagrantfile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Vagrantfile b/Vagrantfile > index dab03de56fac..a3d444d366ba 100644 > --- a/Vagrantfile > +++

Re: [ovs-dev] [PATCH 2/6] Vagrant: Update dependencies.

On Fri, May 20, 2016 at 11:49 AM, Joe Stringer <j...@ovn.org> wrote: > Signed-off-by: Joe Stringer <j...@ovn.org> > Acked-by: Andy Zhou <az...@ovn.org> > --- > Vagrantfile | 1 + > 1 file changed, 1 insertion(+) > > _

Re: [ovs-dev] [PATCH 6/6] vagrant: Enable silent-rules for configure.

, the verbosity of > compilation is lowered and it is easier to identify these pieces of > information. > > Signed-off-by: Joe Stringer <j...@ovn.org> > Acked-by: Andy Zhou <az...@ovn.org> On a separate note, Should we consider using ovs-dev.py for Vagrant? For example, it may be useful

Re: [ovs-dev] [PATCH 1/6] INSTALL.md: Document system-traffic tests.

On Fri, May 20, 2016 at 11:49 AM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > Thanks for working on this! > INSTALL.md | 88 > +- > 1 file changed, 76 insertions(+), 12 deletions(-) > > diff

Re: [ovs-dev] [PATCH] check-kmod: Remove all OVS modules in this target.

itch > + modprobe -r -a vport-geneve vport-gre vport-lisp vport-stt > vport-vxlan openvswitch > $(MAKE) check-kernel > > check-system-userspace: all tests/atconfig tests/atlocal > $(SYSTEM_USERSPACE_TESTSUITE) > I am not sure if '-a' is required here

Re: [ovs-dev] [ovsdb-server multithreading RFC 6/9] ovsdb: Add IPC messages for thread communication

On Fri, Apr 1, 2016 at 11:45 AM, Ryan Moats wrote: > I gave this patch set a spin this week and I agree > that a less granular lock would be a good thing. > Thanks for the report. Really appreciate the feedback. I did some testing as well and reached the same conclusion. I am

Re: [ovs-dev] [ovsdb-server multithreading RFC 1/9] ovsdb: Do not group sessions by remote.

On Fri, Mar 18, 2016 at 5:15 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Mar 03, 2016 at 12:13:20AM -0800, Andy Zhou wrote: > > Currently ovsdb_jsonrpc_session are grouped together in a linked > > list within 'ovsdb_jsonrpc_remote'. This makes sense since most > >

Re: [ovs-dev] [ovsdb-server multithreading RFC 7/9] ovsdb: Add --max-num-threads commad line option

On Fri, Mar 18, 2016 at 6:31 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Mar 03, 2016 at 12:13:26AM -0800, Andy Zhou wrote: > > See ovsdb-server.1.in changes for details. > > > > Signed-off-by: Andy Zhou <az...@ovn.org> > > s/commad/command/ in the

Re: [ovs-dev] [ovsdb-server multithreading RFC 6/9] ovsdb: Add IPC messages for thread communication

On Fri, Mar 18, 2016 at 6:24 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Mar 03, 2016 at 12:13:25AM -0800, Andy Zhou wrote: > > Add a command queue for the main thread to pass commands to the > > sessions thread. > > > > Defined an implemented a set of IPC m

Re: [ovs-dev] [ovsdb-server multithreading RFC 5/9] ovsdb: Add a 'big lock' to serialize all OVSDB operations

On Fri, Mar 18, 2016 at 6:08 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Mar 03, 2016 at 12:13:24AM -0800, Andy Zhou wrote: > > Add a global lock to serialize all OVSDB operations. It is a simple > > locking scheme to implement and to reason about correctness, without >

Re: [ovs-dev] [ovsdb-server multithreading RFC 2/9] ovsdb: Make 'remote' opaque in ovsdb_jsonrpc_session

On Fri, Mar 18, 2016 at 5:20 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Mar 03, 2016 at 12:13:21AM -0800, Andy Zhou wrote: > > It turns out there is no need for ovsdb_jsonrcp_session to have access > > s/jsonrcp/jsonrpc/ > > > to the remote data structure. Make i

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 1/9] ovsdb: Do not group sessions by remote.

sions managed > > by a thread will have them linked together on a thread private > > linked list. At that time, the 'all_sessions' field in > > ovsdb_jsonrpc_server struct will have all session managed > > the main process. > > > > Signed-off-by: Andy Zhou &

Re: [ovs-dev] ovn: broadcast packets dropped with "drop recirc action"

On Wed, Mar 16, 2016 at 4:00 PM, Ramu Ramamurthy < srama...@linux.vnet.ibm.com> wrote: > On 2016-03-15 11:16, Andy Zhou wrote: > >> On Mon, Mar 14, 2016 at 12:11 PM, Ramu Ramamurthy < >> srama...@linux.vnet.ibm.com> wrote: >> >> When a logical switch (l

[ovs-dev] [net] openvswitch: Allow deferred action fifo to expand during run time

ama...@linux.vnet.ibm.com> Reported-at: http://openvswitch.org/pipermail/dev/2016-March/067672.html Signed-off-by: Andy Zhou <az...@ovn.org> --- net/openvswitch/actions.c | 45 - 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/net/openvswitch/act

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 9/9] test: Add an ovsdb-server multi-threading test

On Wed, Mar 16, 2016 at 1:27 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > Original Message > > Add a test that executes OVSDB transactions when OVSDB server is > > running with multiple threads. > > > > Signed-off-by: Andy Zhou <az...@ovn.org>

Re: [ovs-dev] [ovs-dev, ovsdb-server, multithreading, RFC, 1/9] ovsdb: Do not group sessions by remote.

On Wed, Mar 16, 2016 at 11:43 AM, Ryan Moats <rmo...@us.ibm.com> wrote: > > Andy Zhou <az...@ovn.org> wrote on 03/16/2016 01:20:48 PM: > > > From: Andy Zhou <az...@ovn.org> > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: ovs dev <dev@openvswitch.org>

Re: [ovs-dev] ovn: broadcast packets dropped with "drop recirc action"

On Mon, Mar 14, 2016 at 12:11 PM, Ramu Ramamurthy < srama...@linux.vnet.ibm.com> wrote: > When a logical switch (localnet) has lots of ports on a hypervisor, > I find that broadcast packets from one of the ports is only forwarded to > a subset of the other ports, and the kernel module shows the

[ovs-dev] [RFC] datapath: Allow deferred action fifo to expand during run time

com> Reported-at: http://openvswitch.org/pipermail/dev/2016-March/067672.html Signed-off-by: Andy Zhou <az...@ovn.org> --- datapath/actions.c | 45 - 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/datapath/actions.c b/datapath/act

Re: [ovs-dev] [Fix branch-2.4 travis builds] travis: Use container infrastructure.

On Thu, Mar 10, 2016 at 5:54 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Mar 10, 2016 at 04:09:54PM -0800, Andy Zhou wrote: > > On Thu, Mar 10, 2016 at 3:11 PM, Daniele Di Proietto < > diproiet...@vmware.com > > > wrote: > > > On 09/03/2016 19:55, "de

Re: [ovs-dev] [Fix branch-2.4 travis builds] travis: Use container infrastructure.

nks for fixing this. > > > >On 9 March 2016 at 18:05, Andy Zhou <az...@ovn.org> wrote: > >> From: Daniele Di Proietto <diproiet...@vmware.com> > > > >As a general rule, it's nice to have the commit id direct in the > >message to show the

Re: [ovs-dev] [PATCH] ovsdb-server: Add Json cache count to memory/show

On Thu, Mar 10, 2016 at 5:50 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Mar 08, 2016 at 11:54:45AM -0800, Andy Zhou wrote: > > Add the size of json cache to the data reported by ovsdb-server appctl > > "memory/show" command. > > > > Signed-off-by:

Re: [ovs-dev] [Fix branch-2.4 travis builds] travis: Use container infrastructure.

nks for fixing this. > > > >On 9 March 2016 at 18:05, Andy Zhou <az...@ovn.org> wrote: > >> From: Daniele Di Proietto <diproiet...@vmware.com> > > > >As a general rule, it's nice to have the commit id direct in the > >message to show the

Re: [ovs-dev] [PATCH] lib/ovs-thread: make use of the pthread_attr object

On Thu, Mar 10, 2016 at 2:30 PM, Ben Pfaff <b...@ovn.org> wrote: > Andy, can you transform the reference into a Fixes: tag? > Good point. Will do. > > Thanks, > > Ben. > > On Thu, Mar 10, 2016 at 02:14:03PM -0800, Andy Zhou wrote: > > LGTM, Acked-by:

Re: [ovs-dev] [PATCH] lib/ovs-thread: make use of the pthread_attr object

LGTM, Acked-by: Andy Zhou <az...@ovn.org> I will push it later today. Thanks. On Thu, Mar 10, 2016 at 8:37 AM, Alexandru Ardelean <ardeleana...@gmail.com> wrote: > Referencing this commit: >8147cec9ee8feea9440cf79365709ddc32ff57d5 > > My bad for not noticing th

[ovs-dev] [Fix branch-2.4 travis builds] travis: Use container infrastructure.

ci.org/ddiproietto/ovs/builds/81764972 [back ported to branch-2.4 by azhou] Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> CC: Joe Stringer <joestrin...@nicira.com> Acked-by: Ben Pfaff <b...@nicira.com> Signed-off-by: Andy Zhou <az...@ovn.org>

[ovs-dev] [Fix branch-2.4 travis builds]Fix branch-2.4 travis builds

Branch 2.4 travis builds have been failing for a while, due to infrastructure changes at the travis ends. However, with constant build failures, it is hard to tell if any newer patches pushed into branch-2.4 contain genuine build breakers. Back port the following patches to restore the build

[ovs-dev] [PATCH] ovsdb-server: Add Json cache count to memory/show

Add the size of json cache to the data reported by ovsdb-server appctl "memory/show" command. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/monitor.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c index 6b0d13d..f9cd965 10

Re: [ovs-dev] ovn northbound ovsdb-server’s memory usage problem

On Mon, Mar 7, 2016 at 1:57 PM, Han Zhou wrote: > > > On Sun, Mar 6, 2016 at 11:02 PM, Lei Huang wrote: > > > > Hi, > > > > > > During a scalability test, we found that the ovn northbound > ovsdb-server’s > > memory usage becomes very high while

[ovs-dev] [PATCH] ovsdb-server: Fix a reference count leak bug

g <huang.f@gmail.com> Reported-at: http://openvswitch.org/pipermail/dev/2016-March/067274.html Signed-off-by: Andy Zhou <az...@ovn.org> --- AUTHORS| 1 + ovsdb/jsonrpc-server.c | 4 ++-- ovsdb/monitor.c| 9 - ovsdb/monitor.h| 6 ++ 4 files change

Re: [ovs-dev] [poll group RFC 1/6] lib: Introduce poll group provider class

On Thu, Feb 25, 2016 at 12:49 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Feb 25, 2016 at 12:44:05PM -0800, Andy Zhou wrote: > > On Thu, Feb 25, 2016 at 11:40 AM, Ben Pfaff <b...@ovn.org> wrote: > > > > > On Fri, Feb 19, 2016 at 12:40:19PM -0800, Andy Zho

Re: [ovs-dev] [poll group RFC 6/6] ovsdb: Change jsonrpc server to make use of poll group

On Thu, Feb 25, 2016 at 12:44 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Feb 19, 2016 at 12:40:24PM -0800, Andy Zhou wrote: > > On Linux jsonrpc server now users poll group by default. It can > > be disabled by using an undocumented --disable-epoll command line > >

Re: [ovs-dev] [poll group RFC 1/6] lib: Introduce poll group provider class

On Thu, Feb 25, 2016 at 11:40 AM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Feb 19, 2016 at 12:40:19PM -0800, Andy Zhou wrote: > > Poll group is a new poll class that sits between application and > > the stream class. Poll group compliments the poll loop facility and the >

Re: [ovs-dev] [PATCH v2] ovn-controller: Add external-ids:ovn-remote-probe-interval

On Wed, Feb 24, 2016 at 7:34 PM, Huang, Lei wrote: > Comments line. > > On Mon, Feb 22, 2016 at 12:50 AM, Huang Lei <148012...@qq.com> wrote: > >> From: Huang Lei >> >> For setting the inactivity probe interval of the json session to the OVN >> southbound

Re: [ovs-dev] [ovsdb monitor fix v2 3/3] ovsdb: avoid unnecessary call to ovsdb_monitor_get_update()

On Wed, Feb 24, 2016 at 3:32 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Feb 24, 2016 at 02:58:25PM -0800, Andy Zhou wrote: > > On Wed, Feb 24, 2016 at 2:44 PM, Ben Pfaff <b...@ovn.org> wrote: > > > > > On Mon, Feb 22, 2016 at 04:28:14PM -0800, An

Re: [ovs-dev] [ovsdb monitor fix v2 3/3] ovsdb: avoid unnecessary call to ovsdb_monitor_get_update()

On Wed, Feb 24, 2016 at 2:44 PM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Feb 22, 2016 at 04:28:14PM -0800, Andy Zhou wrote: > > Avoid calling ovsdb_monitor_get_update() monitor has been flushed > > already. > > > > Reported-by: Liran Schour <lir...@il.ibm.c

Re: [ovs-dev] [PATCH 1/2] tests: Add ability to automatically rerun failed tests.

ake a reference to the "Self-Tests" section in the INSTALL.md? At any rate, the change is a nice, Thanks! Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] travis: Automatically recheck failed tests.

-off-by: Ben Pfaff <b...@ovn.org> > --- > .travis/build.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 1/2] ovsdb: fix a typo in ovs-vswitchd.conf.db(5).

Signed-off-by: Andy Zhou <az...@ovn.org> --- vswitchd/vswitch.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index c2ec914..bccea55 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -4281,7 +

[ovs-dev] [PATCH 2/2] ovsdb-server: Refactoring and clean up remote status reporting.

'n_connections' should be at least 2. Make the implementation match the description. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/jsonrpc-server.c | 60 -- vswitchd/vswitch.xml | 27 +-- 2 files changed, 64 insertions(

Re: [ovs-dev] [PATCH v2] ovn-controller: Add external-ids:ovn-remote-probe-interval

On Mon, Feb 22, 2016 at 12:50 AM, Huang Lei <148012...@qq.com> wrote: > From: Huang Lei > > For setting the inactivity probe interval of the json session to the OVN > southbound database. > > Signed-off-by: Huang Lei > --- > lib/jsonrpc.c

Re: [ovs-dev] [ovsdb monitor fix v2 1/3] ovsdb: Fix one off error in tracking monitor changes

t; optimization patch: "avoid unnecessary call to > ovsdb_monitor_get_update()." > > The lack of optimization means that the update is still generated > > when 'unflushed' equals to n_transactions + 1, which should have > > indicated the monitor has been flushed a

Re: [ovs-dev] [PATCH 1/3] ovsdb: Fix one off error in tracking monitor changes

Please ignore this series. An updated version has been posted at: http://openvswitch.org/pipermail/dev/2016-February/066596.html On Mon, Feb 22, 2016 at 1:06 AM, Andy Zhou <az...@ovn.org> wrote: > dbmon's changes should be stored with the new transaction number, > rather than

[ovs-dev] [ovsdb monitor fix v2 2/3] ovsdb: rename variables in ovsdb_monitor_get_update()

'prev_txn' and 'next_txn" are more confusing than 'unflushed' and 'unflushed_next'. Rename them. Signed-off-by: Andy Zhou <az...@ovn.org> --- v1->v2: no change. --- ovsdb/monitor.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/ovs

[ovs-dev] [ovsdb monitor fix v2 1/3] ovsdb: Fix one off error in tracking monitor changes

ed already. Signed-off-by: Andy Zhou <az...@ovn.org> --- v1->v2: *Explain the bug in more detail in the commit message. *roll back the n_transactions if possible. --- ovsdb/monitor.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/ovsdb/monitor.

[ovs-dev] [ovsdb monitor fix v2 3/3] ovsdb: avoid unnecessary call to ovsdb_monitor_get_update()

Avoid calling ovsdb_monitor_get_update() monitor has been flushed already. Reported-by: Liran Schour <lir...@il.ibm.com> Signed-off-by: Andy Zhou <az...@ovn.org> v1 -> v2: no change. --- ovsdb/jsonrpc-server.c | 4 1 file changed, 4 insertions(+) diff --git a/ovsdb/jso

Re: [ovs-dev] [PATCH 2/2] ovsdb: Return NULL if prev_txn == next_txn

On Mon, Feb 22, 2016 at 9:28 AM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Feb 22, 2016 at 01:13:07AM -0800, Andy Zhou wrote: > > On Sat, Feb 20, 2016 at 8:35 AM, Liran Schour <lir...@il.ibm.com> wrote: > > > > > In case that we flushed everything alrea

Re: [ovs-dev] [PATCH 2/2] ovsdb: Return NULL if prev_txn == next_txn

On Sat, Feb 20, 2016 at 8:35 AM, Liran Schour wrote: > In case that we flushed everything already, we can immeidately return NULL. > > Signed-off-by: Liran Schour > --- > ovsdb/monitor.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

[ovs-dev] [PATCH 3/3] ovsdb: avoid unnecessary call ovsdb_monitor_get_update()

Avoid calling ovsdb_monitor_get_update() if there aren't any unflushed transactions. Reported-by: Liran Schour <lir...@il.ibm.com> Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/jsonrpc-server.c | 4 1 file changed, 4 insertions(+) diff --git a/ovsdb/jsonrpc-server.c b/o

[ovs-dev] [PATCH 2/3] ovsdb: rename variables in ovsdb_monitor_get_update()

'prev_txn' and 'next_txn" are more confusing than 'unflushed' and 'unflushed_next'. Rename them. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/monitor.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c in

[ovs-dev] [PATCH 1/3] ovsdb: Fix one off error in tracking monitor changes

dbmon's changes should be stored with the new transaction number, rather than the current transaction number. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/monitor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c index 5

Re: [ovs-dev] [PATCH 1/2] tests: Fix inconsistency tests in monitor

On Sat, Feb 20, 2016 at 8:35 AM, Liran Schour wrote: > In case of delete only: !initial,!insert,!modify. We can not be sure that > we > will see X if we have: insert X, delete X. > In case of modify only: !initial,!insert,!delete. We can not be sure that > we > will see X

Re: [ovs-dev] [PATCH] ovn-controller: Add external-ids:ovn-remote-probe-interval

On Sun, Feb 21, 2016 at 1:26 PM, Huang Lei <148012...@qq.com> wrote: > From: Huang Lei > > For setting the inactivity probe interval of the json session to the OVN > southbound database. > > Signed-off-by: Huang Lei > Thanks for contributing!. Please see

Re: [ovs-dev] [poll group RFC 0/6] Poll group

The patches are also available at github. https://github.com/azhou-nicira/ovs-review/tree/poll-group On Fri, Feb 19, 2016 at 12:40 PM, Andy Zhou <az...@ovn.org> wrote: > Introduce a new 'poll group' feature to improve the efficiency of poll > loop in dealing with

Re: [ovs-dev] [poll group RFC 0/6] poll group RFC

On Thu, Feb 18, 2016 at 8:20 PM, Andy Zhou <az...@ovn.org> wrote: > This is the new 'poll group' feature I have been working on improve > the efficiency in dealing with large number of connections, and its > first application to improve ovsdb-sever. > > There

[ovs-dev] [poll group RFC 2/6] lib: Add epoll poll group implementation for the Linux platform

Add the first poll group implementation. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/automake.mk | 1 + lib/poll-group-epoll.c| 321 ++ lib/poll-group-provider.h | 4 + lib/poll-group.c | 9 +- 4 files change

[ovs-dev] [poll group RFC 3/6] lib: Update stream class to support poll group.

Add new APIs in stream class that works with poll group. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/stream-fd.c | 32 lib/stream-provider.h | 17 +++ lib/stream-ssl.c | 40 - lib/stream-tcp.c | 3 ++ lib/stream-

[ovs-dev] [poll group RFC 5/6] lib: add poll_block_waken_by_timer

--- lib/poll-loop.c | 11 +++ lib/poll-loop.h | 3 +++ 2 files changed, 14 insertions(+) diff --git a/lib/poll-loop.c b/lib/poll-loop.c index e83d989..63c7a42 100644 --- a/lib/poll-loop.c +++ b/lib/poll-loop.c @@ -53,6 +53,7 @@ struct poll_loop { * wake up immediately, or

[ovs-dev] [poll group RFC 1/6] lib: Introduce poll group provider class

. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/automake.mk | 3 + lib/poll-group-provider.h | 152 +++ lib/poll-group.c | 221 ++ lib/poll-group.h | 51 +++ 4 files changed, 427 inse

[ovs-dev] [poll group RFC 4/6] lib: Add poll group support in jsonrpc library.

Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/jsonrpc.c | 74 +++ lib/jsonrpc.h | 7 ++ 2 files changed, 77 insertions(+), 4 deletions(-) diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c index 35428a6..e8ea8b4 100644 --- a/lib/jso

[ovs-dev] [poll group RFC 0/6] Poll group

-server to maintain 1000 idle connections over TCP with the default 5s probe interval, the CPU load droped from 48% to 14%. Andy Zhou (6): lib: Introduce poll group provider class lib: Add epoll poll group implementation for the Linux platform lib: Update stream class to support poll group

[ovs-dev] [poll group RFC 6/6] ovsdb: Change jsonrpc server to make use of poll group

On Linux jsonrpc server now users poll group by default. It can be disabled by using an undocumented --disable-epoll command line options. For ovsdb-server to maintain 1000 idle connections over TCP with the default 5s probe interval, the CPU load dropped from 48% to 14%. Signed-off-by: Andy

[ovs-dev] [poll group RFC 5/6] lib: Add poll group support in jsonrpc library.

Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/jsonrpc.c | 74 +++ lib/jsonrpc.h | 7 ++ 2 files changed, 77 insertions(+), 4 deletions(-) diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c index 35428a6..e8ea8b4 100644 --- a/lib/jso

<    1   2   3   4   5   6   7   8   9   10   >