[ovs-dev] [poll group RFC 6/6] ovsdb: Change jsonrpc server to make use of poll group

When enabled, jsonrpc server creates a poll group for all jsonrpc sessions it created. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/jsonrpc-server.c | 67 ++ 1 file changed, 62 insertions(+), 5 deletions(-) diff --git a/ovsdb/j

[ovs-dev] [poll group RFC 4/6] lib: Update stream class to support poll group.

Add new APIs in stream class that works with poll group. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/stream-fd.c | 32 lib/stream-provider.h | 17 +++ lib/stream-ssl.c | 40 - lib/stream-tcp.c | 3 ++ lib/stream-

[ovs-dev] [poll group RFC 3/6] lib: Add epoll poll group implementation for the Linux platform

Add the first poll group implementation. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/automake.mk | 1 + lib/poll-group-epoll.c| 321 ++ lib/poll-group-provider.h | 4 + lib/poll-group.c | 9 +- 4 files change

[ovs-dev] [poll group RFC 0/6] poll group RFC

attractive. Subject: [poll group RFC 0/6] *** SUBJECT HERE *** Andy Zhou (6): ovsdb-server: add --disable-epoll command line option lib: Introduce poll group provider class lib: Add epoll poll group implementation for the Linux platform lib: Update stream class to support poll group. lib

[ovs-dev] [poll group RFC 2/6] lib: Introduce poll group provider class

. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/automake.mk | 3 + lib/poll-group-provider.h | 153 lib/poll-group.c | 221 ++ lib/poll-group.h | 51 +++ 4 files change

[ovs-dev] [poll group RFC 1/6] ovsdb-server: add --disable-epoll command line option

Signed-off-by: Andy Zhou <az...@ovn.org> --- May be poll-mode=["default" | "epoll"] is better? --- ovsdb/jsonrpc-server.c | 9 +++-- ovsdb/jsonrpc-server.h | 2 +- ovsdb/ovsdb-server.c | 43 --- 3 files changed, 40 i

Re: [ovs-dev] Need a probe_interval option for jsonrpc session to southbound ovsdb-server in ovn-controller

On Tue, Feb 16, 2016 at 11:29 PM, Huang, Lei wrote: > Hi Andy, > > I has configured ovn southbound ovsdb-server's inactivity_probe option to > 0 by Open_vSwitch Manger table, and the ovsdb-server doesn’t set inactivity > probe messages anymore. > > But I found ovn-contorller

[ovs-dev] [PATCH] lib: Remove unused function prototypes

Found by inspection. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/stream.h | 4 1 file changed, 4 deletions(-) diff --git a/lib/stream.h b/lib/stream.h index 0db50da..f8e1891 100644 --- a/lib/stream.h +++ b/lib/stream.h @@ -37,10 +37,6 @@ int stream_open(const char *name, struct

Re: [ovs-dev] [PATCH] lib: Remove unused function prototypes

On Fri, Feb 12, 2016 at 11:05 AM, Russell Bryant <russ...@ovn.org> wrote: > On 02/12/2016 02:04 PM, Andy Zhou wrote: > > Found by inspection. > > > > Signed-off-by: Andy Zhou <az...@ovn.org> > > --- > > lib/stream.h | 4 > > 1 file changed,

[ovs-dev] [PATCH] ovsdb-server: Eliminating max session limit

large of number of sessions is important for OVN, Removing this limit makes scalability testing possible. Signed-off-by: Andy Zhou <az...@ovn.org> --- NEWS | 3 +++ ovsdb/jsonrpc-server.c | 35 ++- 2 files changed, 17 insertions(+), 21 del

Re: [ovs-dev] [PATCH] ovsdb-server: Eliminating max session limit

On Wed, Feb 10, 2016 at 3:34 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Feb 10, 2016 at 02:33:45PM -0800, Andy Zhou wrote: > > This patch removes limits on number of concurrent sessions > > allowed by ovsdb-server. Historically, it was not an design > > goal for O

Re: [ovs-dev] [PATCH monitor_cond V3 01/10] ovsdb: create column index mapping between ovsdb row to monitor row

On Tue, Feb 9, 2016 at 6:41 AM, Liran Schour <lir...@il.ibm.com> wrote: > Liran Schour/Haifa/IBM wrote on 09/02/2016 08:19:45 AM: > > > From: Liran Schour/Haifa/IBM > > To: Andy Zhou <az...@ovn.org> > > Cc: "<dev@openvswitch.org>"<dev@openvsw

Re: [ovs-dev] [PATCH monitor_cond V3 03/10] ovsdb: allow non-monitored columns for condition evaluation

On Tue, Feb 9, 2016 at 12:06 AM, Liran Schour <lir...@il.ibm.com> wrote: > Andy Zhou <az...@ovn.org> wrote on 08/02/2016 09:16:18 PM: > > > On Mon, Feb 8, 2016 at 2:41 AM, Liran Schour <lir...@il.ibm.com> wrote: > > I see that my reply was blocked again at t

Re: [ovs-dev] [PATCH 1/3] util: New macro BUILD_ASSERT_TYPE.

(-) > This is clever! Acked-by: Andy Zhou <az...@ovn.org> > > ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] hmap: Add extra build-time iteration checks for types derived from hmap.

radeoff. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > I find the the comments for *_INIT macro to be very helpful. Thanks. Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH monitor_cond V3 01/10] ovsdb: create column index mapping between ovsdb row to monitor row

On Sun, Feb 7, 2016 at 12:08 AM, Liran Schour <lir...@il.ibm.com> wrote: > Andy Zhou <az...@ovn.org> wrote on 04/02/2016 11:54:06 PM: > > > On Sun, Jan 31, 2016 at 11:03 PM, Liran Schour <lir...@il.ibm.com> > wrote: > > Columns indexing is different in ovsd

Re: [ovs-dev] [PATCH monitor_cond V3 01/10] ovsdb: create column index mapping between ovsdb row to monitor row

On Mon, Feb 8, 2016 at 12:43 PM, Liran Schour <lir...@il.ibm.com> wrote: > Andy Zhou <az...@ovn.org> wrote on 08/02/2016 09:41:47 PM: > > > On Sun, Feb 7, 2016 at 12:08 AM, Liran Schour <lir...@il.ibm.com> wrote: > > Andy Zhou <az...@ovn.org> wrote on 04/

[ovs-dev] ovsdb-server servicing large number of idle connections

Hi, Han, This is to follow up on the Thursday OVN IRC chat. After the meeting, I was able replicate the test condition you mentioned where a single ovsdb-server services 1000 ovsdb-client connections. When there is no ovsdb transactions going on, large number of CPU cycles are used ( on my

Re: [ovs-dev] [PATCH monitor_cond V3 01/10] ovsdb: create column index mapping between ovsdb row to monitor row

On Sat, Feb 6, 2016 at 8:30 AM, Liran Schour <lir...@il.ibm.com> wrote: > Andy Zhou <az...@ovn.org> wrote on 04/02/2016 08:29:32 PM: > > > > > in ovs sandbox, I started two monitor-cond sessions: > > > > 1: ovsdb-client monitor-cond '[["name&qu

Re: [ovs-dev] [PATCH] ovsdb-server: fix monitor counters reported by memory/show

On Fri, Feb 5, 2016 at 11:02 AM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Feb 03, 2016 at 09:35:36PM -0800, Andy Zhou wrote: > > Commit 4c2809787cdbc774 (ovsdb-monitor: add json cache) introduced > > an optimization that allows jsonrpc session to share monitors. > &g

Re: [ovs-dev] [PATCH monitor_cond V3 03/10] ovsdb: allow non-monitored columns for condition evaluation

On Wed, Feb 3, 2016 at 5:53 AM, Liran Schour wrote: > This commit allows to add non-monitored columns to a monitored table. > It will be used to evaluate conditions on non-monitored columns. > Update notification includes only monitored columns. > > Signed-off-by: Liran Schour

Re: [ovs-dev] [PATCH monitor_cond V3 08/10] lib: add monitor_cond_update API to C IDL lib

On Wed, Feb 3, 2016 at 5:53 AM, Liran Schour wrote: > Add API that allows the user to create condition iteratively > and send condition_update to the server. > > Signed-off-by: Liran Schour > --- > v2->v3: > * Simplify API to allow iteratively adding

Re: [ovs-dev] [PATCH monitor_cond V3 04/10] ovsdb: generate update notifications for monitor_cond session

Only a few small comments in line. On Wed, Feb 3, 2016 at 5:53 AM, Liran Schour wrote: > Hold session's conditions in ovsdb_monitor_session_condition. Pass it > to ovsdb_monitor for generating "update2" notifications. > Add functions that can generate "update2" notification

Re: [ovs-dev] [PATCH monitor_cond V3 06/10] ovsdb: enable jsonrpc-server to service "monitor_cond_update" request

On Wed, Feb 3, 2016 at 5:53 AM, Liran Schour wrote: > ovsdb-server now accepts "monitor_cond_update" request. On conditions > update > we insert all rows of table in a new changes list - OVSDB_MONITOR_ALL that > are > being indexed by the transaction-id at the moment of

Re: [ovs-dev] [PATCH monitor_cond V3 09/10] python: move Python idl to work with monitor_cond

On Wed, Feb 3, 2016 at 5:53 AM, Liran Schour wrote: > Python idl works now with "monitor_cond" method. Add test > for backward compatibility with old "monitor" method. > > Signed-off-by: Liran Schour > I glanced through the logic of most of the changes.

Re: [ovs-dev] [PATCH monitor_cond V3 07/10] lib: add to ovsdb-idl monitor_id

On Wed, Feb 3, 2016 at 5:53 AM, Liran Schour wrote: > IDL uses now a uuid to specify a monitoring session that is being > sent to the server on "monitor_cond" request. > This uuid will be used to issue ongoing "monitor_cond_change" requests > for this monitoring session. > >

Re: [ovs-dev] [PATCH monitor_cond V3 05/10] ovsdb-client: support monitor-cond

On Wed, Feb 3, 2016 at 9:42 AM, Liran Schour wrote: > Add monitor_cond method to ovsdb-client. Add unit tests. > See ovsdb-client(1) man page for details. > Replace monitor2 with monitor_cond. > > Signed-off-by: Liran Schour > > Found a small bug during

Re: [ovs-dev] [PATCH monitor_cond V3 01/10] ovsdb: create column index mapping between ovsdb row to monitor row

On Sun, Jan 31, 2016 at 11:03 PM, Liran Schour wrote: > Columns indexing is different in ovsdb_row then in ovsdb_monitor_row. > We need mapping between the 2 for condition evaluation. > > signed-off-by: Liran Schour > It may be simpler to and more

Re: [ovs-dev] Benchmarking tools for OVSDB

There is not one that's publicly available that I am aware of. I know some people are testing it, may be not specific to OVSDB, but in the context of OVN scale in general. Are you interested in contributing? On Thu, Feb 4, 2016 at 2:49 PM, Srinivasan Srivatsan wrote: > Hi,

Re: [ovs-dev] Benchmarking tools for OVSDB

sted in chiming in, if there's a way for me to get > involved in that conversation. Could you please help me connect with the > people who are trying something similar ? > > -Srinivasan > > On Thu, Feb 4, 2016 at 6:34 PM, Andy Zhou <az...@ovn.org> wrote: > >> There is not one

Re: [ovs-dev] [PATCH monitor_cond V3 01/10] ovsdb: create column index mapping between ovsdb row to monitor row

in ovs sandbox, I started two monitor-cond sessions: 1: ovsdb-client monitor-cond '[["name", "!=", "xx"]]' Interface ifindex 2: ovsdb-client monitor-cond '[["ifindex", "!=", 99]]' Interface name I'd think that both sessions should be able share a single monitor, but found that there are

Re: [ovs-dev] [PATCH v8 0/5] Convert DPDK configuration from command line to DB based

Sorry for jumping in late in the review cycle. But I am not sure if there is significant advantage in store dpdk options in OVSDB. On Fri, Jan 29, 2016 at 9:56 AM, Aaron Conole wrote: > Currently, configuration of DPDK parameters is done via the command line > through a

[ovs-dev] [PATCH] ovsdb-server: fix monitor counters reported by memory/show

to over reporting the number. This patch fix the bug and reports the actual number of monitor used by the ovsdb-server. Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/jsonrpc-server.c | 1 - ovsdb/monitor.c| 8 ovsdb/monitor.h| 2 ++ ovsdb/ovsdb-server.c | 2

Re: [ovs-dev] [RFC] ovn-controller: Only process lflows for local datapaths.

On Wednesday, February 3, 2016, Russell Bryant <russ...@ovn.org> wrote: > On 02/02/2016 08:36 PM, Andy Zhou wrote: > > > > Would it be possible to separate the nb/sb ovsdb-server so we can get a > > rough idea where performance bottlenecks are? they suppose to be

Re: [ovs-dev] [emc processing optimization v2 (rebase) 1/2] dpif-netdev: Load packet pointer only once in emc_processing()

On Mon, Feb 1, 2016 at 7:00 PM, Daniele Di Proietto <diproiet...@vmware.com> wrote: > > > On 01/02/2016 12:46, "Andy Zhou" <az...@ovn.org> wrote: > > >For the machines I have access to, Reloading the same pointer from > >memory s

Re: [ovs-dev] [emc processing optimization v2 (rebase) 2/2] dpif-netdev: optmizing emc_processing()

On Mon, Feb 1, 2016 at 7:02 PM, Daniele Di Proietto <diproiet...@vmware.com> wrote: > Thanks for the patch! > > Acked-by: Daniele Di Proietto <diproiet...@vmware.com> > > On 01/02/2016 12:46, "Andy Zhou" <az...@ovn.org> wrote: > > >Commit

Re: [ovs-dev] [PATCH monitor_cond V3 01/10] ovsdb: create column index mapping between ovsdb row to monitor row

Is there any reason the ovsdb-client tool modification is dropped from v2 to v3? I find it difficult to properly review and test the changes without it. Do you mind repost this series that includes the modification? Thanks for includes IDL tests in series. It would be also nice to have more tests

Re: [ovs-dev] [RFC] ovn-controller: Only process lflows for local datapaths.

On Tue, Feb 2, 2016 at 4:41 PM, Han Zhou wrote: > > > On Tue, Feb 2, 2016 at 2:01 PM, Russell Bryant wrote: > > > > On 02/02/2016 04:49 PM, Ben Pfaff wrote: > > > On Thu, Jan 21, 2016 at 03:21:00PM -0500, Russell Bryant wrote: > > >> Previously,

Re: [ovs-dev] [PATCH] dpif-netdev: Correctly update 'key' in emc_processing().

On Tue, Feb 2, 2016 at 9:14 PM, Daniele Di Proietto <diproiet...@vmware.com> wrote: > The 'key' pointer must point at the first unused element in the key > array. > > Fixes: b89c678b7a26 ("dpif-netdev: optmizing emc_processing()") > CC: Andy Zhou <az...@ov

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Avoid copying netdev_flow_key in emc_processing()

On Mon, Feb 1, 2016 at 11:15 AM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Jan 29, 2016 at 07:14:35PM -0800, Andy Zhou wrote: >> This is essentially the same patch as the original patched posted at: >> http://openvswitch.org/pipermail/dev/2016-January/064971.html >> >

[ovs-dev] [emc processing optimization v2 (rebase) 2/2] dpif-netdev: optmizing emc_processing()

Commit d262ac2c60ce1da7b477737f70e8efd38b32502d introduced a slight performance drop for the fast path, where every packets hits the emc cache. This patch removes that performance drop by only reloading the key pointer on emc cache miss. Sgned-off-by: Andy Zhou <az...@ovn.org> --- li

[ovs-dev] [emc processing optimization v2 (rebase) 1/2] dpif-netdev: Load packet pointer only once in emc_processing()

packets, with the base line of 12.2 Mpps). Besides improving performance, this patch should also improves code readability. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dpif-netdev.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/dpif-netdev.c b/li

Re: [ovs-dev] [PATCH] dpif-netdev: Delay packets' metadata initialization.

ing rate. I was able to verify line rate forwarding of 64 byte packets over a 10G NIC. Nice job! Acked-by: Andy Zhou <az...@ovn.org> In comments inline : s/and them/and then/. Unfortunately, the code reality dropped. May be it is a small price to pay for optimizing fast path code? The foll

Re: [ovs-dev] [PATCH] build: Fix for rename of MAINTAINERS file.

On Fri, Jan 29, 2016 at 4:53 PM, Russell Bryant <russ...@ovn.org> wrote: > I renamed MAINTAINERS to MAINTAINERS.md, but forgot to update > Makefile.am to reflect the new name. > > Signed-off-by: Russell Bryant <russ...@ovn.org> > Just ran into it. Timely fix. Thank

[ovs-dev] [PATCH 2/2] dpif-netdev: Avoid copying netdev_flow_key in emc_processing()

hah...@cs.princeton.edu> Signed-off-by: Ben Pfaff <b...@ovn.org> Sgned-off-by: Andy Zhou <az...@ovn.org> --- lib/dpif-netdev.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 205176a..94fa5ad 100644 --- a/lib/dpif-

[ovs-dev] [PATCH 1/2] dpif-netdev: Load packet pointer only once in emc_processing()

packets, with the base line of 12.2 Mpps). Besides improving performance, this patch should also improves code readability. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dpif-netdev.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/dpif-netdev.c b/li

Re: [ovs-dev] [PATCH 3/3] dpif-netdev: Reduce code duplication

On Wed, Jan 27, 2016 at 5:01 PM, Daniele Di Proietto wrote: > For the series: > > Acked-by: Daniele Di Proietto > > I didn't observe any performance regressions. > > Thanks! > Thanks for the review and testing. Pushed to master.

[ovs-dev] [PATCH 1/3] dpif-netdev: properly maintain exact match cache hit counter

Current logic counts dropped packet as cache hit which is not correct. This patch removes dropped packet to improve accuracy. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dpif-netdev.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/dpif-netdev.c

[ovs-dev] [PATCH 3/3] dpif-netdev: Reduce code duplication

Code clean up to reduce code duplication. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/dpif-netdev.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index a7e15aa..8d72e27 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-ne

[ovs-dev] [PATCH 2/3] dpif-netdev: drop swapping

emc_processing() moves all the missed packets towards the beginning of packet array; matched packets are queued up into flow queues. Since the remaining of the packet array is not used anymore, don't bother swap packet pointers to save cycles and simplify logic. Signed-off-by: Andy Zhou <

Re: [ovs-dev] [PATCH monitor_cond V2 02/12] ovsdb: add conditions utilities to support monitor_cond

On Mon, Jan 25, 2016 at 3:09 AM, Liran Schour wrote: > The proposed API for monitor_cond_update that accepts 2 different > conditions: added and removed is too complex and does not simplify client > usage. > Seems like changing monitor_cond_update to receive a single

Re: [ovs-dev] [PATCH] dpif-netdev: Avoid copying netdev_flow_key in emc_processing().

...@cs.princeton.edu> > Signed-off-by: Ben Pfaff <b...@ovn.org> > Logic looks good to me. Acked-by: Andy Zhou <az...@ovn.org> I think Daniele is testing on performance impact on this patch. so it is may be worthwhile to wait for his input before pushing the cha

Re: [ovs-dev] [PATCH monitor_cond V2 02/12] ovsdb: add conditions utilities to support monitor_cond

On Fri, Jan 22, 2016 at 12:24 AM, Liran Schour <lir...@il.ibm.com> wrote: > Andy Zhou <az...@ovn.org> wrote on 21/01/2016 11:32:54 PM: > > > On Thu, Jan 21, 2016 at 4:41 AM, Liran Schour <lir...@il.ibm.com> wrote: > > Andy Zhou <az...@ovn.org> wrote on 21

Re: [ovs-dev] [PATCH monitor_cond V2 06/12] ovsdb: add API for changing monitor session's conditions

On Fri, Jan 22, 2016 at 1:41 AM, Liran Schour <lir...@il.ibm.com> wrote: > Andy Zhou <az...@ovn.org> wrote on 22/01/2016 04:09:47 AM: > > > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour <lir...@il.ibm.com> > wrote: > > That will be used to by jsonrpc-server

Re: [ovs-dev] [PATCH monitor_cond V2 08/12] lib: add to ovsdb-idl monitor_id

On Fri, Jan 22, 2016 at 1:59 AM, Liran Schour <lir...@il.ibm.com> wrote: > Andy Zhou <az...@ovn.org> wrote on 22/01/2016 05:27:56 AM: > > > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour <lir...@il.ibm.com> > wrote: > > That will be used later

Re: [ovs-dev] [PATCH monitor_cond V2 03/12] ovsdb: generate update notifications for monitor_cond session

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Hold session's conditions in ovsdb_monitor_session_conditon. Pass it > to ovsdb_monitor for generating "update2" notifications. > Add functions that can generate "update2" notification for a > "monitor_cond" session. >

Re: [ovs-dev] [PATCH monitor_cond V2 02/12] ovsdb: add conditions utilities to support monitor_cond

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > now is a 3-element json array or a boolean value, see > ovsdb-server(1) man page. This functions will be used for > conditional monitoring sessions. > > Signed-off-by: Liran Schour > --- >

Re: [ovs-dev] [PATCH monitor_cond V2 02/12] ovsdb: add conditions utilities to support monitor_cond

On Thu, Jan 21, 2016 at 4:41 AM, Liran Schour <lir...@il.ibm.com> wrote: > Andy Zhou <az...@ovn.org> wrote on 21/01/2016 11:27:42 AM: > > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour <lir...@il.ibm.com> > wrote: > > > now is a 3-element json array or

Re: [ovs-dev] [PATCH monitor_cond V2 08/12] lib: add to ovsdb-idl monitor_id

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > That will be used later to issue "monitor_cond_change" commands. > this commit message is not very helpful. > > Signed-off-by: Liran Schour > --- > lib/ovsdb-idl.c | 19 ++- >

Re: [ovs-dev] [PATCH monitor_cond V2 09/12] ovsdb: look for monitor id on all jsonrpc monitor sessions

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > That will be used later to issue "monitor_cond_change" command. > > This commit message is the same as the last patch. I don't think it explains the reason for this patch. > Signed-off-by: Liran Schour

Re: [ovs-dev] [PATCH monitor_cond V2 11/12] python: move Python idl to work with monitor_cond

I am not much of a python person. Hope some one more knowledgable with python can review this. On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Python idl works now with "monitor_cond" method. Add test > for backward compatibility with old "monitor" method. > >

Re: [ovs-dev] [PATCH monitor_cond V2 07/12] ovsdb: enable jsonrpc-server to service "monitor_cond_update" request

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > ovsdb-server now accepts "monitor_cond_update" request. On conditions > update > we record all rows of table in a new changes list - OVSDB_MONITOR_ALL that > are > being indexed by the transaction-id at the moment of

Re: [ovs-dev] [PATCH monitor_cond V2 10/12] lib: add monitor_cond_update to idl session

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Implement function for changing condition in an idl session. > > Signed-off-by: Liran Schour > Tabs are used in this file. > --- > lib/ovsdb-idl-provider.h | 33 > lib/ovsdb-idl.c |

Re: [ovs-dev] [PATCH monitor_cond V2 04/12] ovsdb-client: support monitor-cond

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Add monitor_cond method to ovsdb-client. Add unit tests. > See ovsdb-client(1) man page for details. > > Signed-off-by: Liran Schour > --- > NEWS| 3 +- > ovsdb/ovsdb-client.1.in

Re: [ovs-dev] [PATCH monitor_cond V2 06/12] ovsdb: add API for changing monitor session's conditions

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > That will be used to by jsonrpc-server for monitor_cond_change > method See ovsdb-server (1) man page. > > Signed-off-by: Liran Schour > --- > ovsdb/monitor.c | 52

Re: [ovs-dev] [PATCH monitor_cond V2 05/12] lib: replace monitor2 with monitor_cond

I think this patch should be folded into the last one. On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Replace monitor2 with monitor_cond with empty condition. > > Signed-off-by: Liran Schour > --- > lib/ovsdb-idl.c| 28

Re: [ovs-dev] [PATCH monitor_cond V2 11/12] python: move Python idl to work with monitor_cond

On Thu, Jan 21, 2016 at 8:04 PM, Russell Bryant <russ...@ovn.org> wrote: > On 01/21/2016 10:58 PM, Andy Zhou wrote: > > I am not much of a python person. Hope some one more knowledgable with > > python can review this. > > I'm happy to do Python reviews. I

Re: [ovs-dev] [PATCH] ofp-util: Make decoding switch features harder to misuse (and fix leak).

064771.html > Signed-off-by: Ben Pfaff <b...@ovn.org> > > Nice! Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH monitor_cond V2 01/12] ovsdb: create column index mapping between ovsdb row to monitor row

Please also see my comments for the next patch. On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Indexing is different between ovsdb_row to ovsdb_monitor_row. To be > able to evaluate conditions on ovsdb_monitor_row we need this mapping. > > signed-off-by: Liran Schour

Re: [ovs-dev] [PATCH] lib: remove unused function

On Tue, Jan 12, 2016 at 12:37 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Jan 12, 2016 at 12:34:58PM -0800, Andy Zhou wrote: > > Remove unused implementation of ovsdb_idl_row_apply_diff(). > > > > Reported-by: Ben Pfaff <b...@ovn.org> > > Signed-off-b

[ovs-dev] [PATCH] lib: remove unused function

Remove unused implementation of ovsdb_idl_row_apply_diff(). Reported-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/ovsdb-idl.c | 57 - 1 file changed, 57 deletions(-) diff --git a/lib/ovsdb-idl.c

Re: [ovs-dev] #if 0'd code in lib/ovsdb-idl.c

On Tue, Jan 12, 2016 at 11:21 AM, Ben Pfaff wrote: > There's an entire function that's #if 0'd out in ovsdb-idl.c. Why? > Sorry, this should have been deleted. I sent out a patch that removes this unused function. https://patchwork.ozlabs.org/patch/566735

Re: [ovs-dev] possible memory leak at add_monitored_table()

ccidentally changed >> it to yourself.) >> >> On Thu, Jan 07, 2016 at 02:01:32PM -0800, Andy Zhou wrote: >> > Hi, William, >> > >> > I have posted a patch at >> > https://patchwork.ozlabs.org/patch/564472/ >> > >> > W

Re: [ovs-dev] [PATCH monitor_cond 00/12] Implement conditional monitoring

On Mon, Jan 11, 2016 at 5:05 AM, Liran Schour <lir...@il.ibm.com> wrote: > Andy Zhou <az...@ovn.org> wrote on 09/01/2016 02:02:32 AM: > > > > On Fri, Jan 8, 2016 at 8:58 AM, Liran Schour <lir...@il.ibm.com> wrote: > > Andy Zhou <az...@ovn.org> wrote

Re: [ovs-dev] [PATCH monitor_cond 00/12] Implement conditional monitoring

On Fri, Jan 8, 2016 at 8:58 AM, Liran Schour <lir...@il.ibm.com> wrote: > Andy Zhou <az...@ovn.org> wrote on 07/01/2016 01:04:17 AM: > > > > I have some comments on the patch series. > > > > Instead of "monitor_cond_change", why not just have a mor

Re: [ovs-dev] [PATCH 2/2] ovsdb-client: fix memory leak reported by valgrind

json_create (json.c:1406) > json_integer_create (json.c:262) > json_clone (json.c:413) > do_monitor__ (ovsdb-client.c:958) > > Signed-off-by: William Tu <u9012...@gmail.com> > Acked-by: Andy Zhou <az...@ovn.org> ___

[ovs-dev] [PATCH] ovsdb-client: fix monitored table memory leak

Properly free memory used monitored_tables to reduce valgrind noises. Reported-by: William Tu <u9012...@gmail.com> Reported-at: http://openvswitch.org/pipermail/dev/2016-January/064161.html Signed-off-by: Andy Zhou <az...@ovn.org> --- ovsdb/ovsdb-client.c | 15 +++ 1 file

Re: [ovs-dev] possible memory leak at add_monitored_table()

Hi, William, I have posted a patch at https://patchwork.ozlabs.org/patch/564472/ Would you please review and test the changes? Thanks! --andy On Thu, Jan 7, 2016 at 11:48 AM, William Tu wrote: > Hi, > > I'm running valgrind on testcase 1427: ovsdb-server combines

Re: [ovs-dev] [PATCH monitor_cond 00/12] Implement conditional monitoring

ion.[ch] It may make the code simpler if we keep the 3 term "condition" also for true and false functions, but normalize the column and data to some known values. ovsdb-server man page section 4.1.13 says monitor_cond_change should use . Is this a typo? We should be using instead. O

Re: [ovs-dev] [PATCH repost] Better abstract OFPT_SET_CONFIG and OFPT_GET_CONFIG_REPLY, make stricter.

at extension. > > Reported-by: Manpreet Singh <er.manpree...@gmail.com> > Signed-off-by: Ben Pfaff <b...@nicira.com> > --- > Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH repost 1/2] ovs-ofctl: Generalize code for finding ports into general-purpose iterator.

On Mon, Dec 21, 2015 at 3:26 PM, Ben Pfaff <b...@ovn.org> wrote: > From: Ben Pfaff <b...@nicira.com> > > The port_iterator will acquire another user in an upcoming commit. > > Signed-off-by: Ben Pfaff <b...@nicira.com> > ---

Re: [ovs-dev] [PATCH] ofp-util: Avoid use-after-free error in ofputil_append_meter_config()

Thanks! On Mon, Jan 4, 2016 at 5:14 PM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Jan 04, 2016 at 05:06:04PM -0800, Ben Pfaff wrote: > > On Wed, Dec 23, 2015 at 01:37:23PM -0800, Andy Zhou wrote: > > > On Wed, Dec 23, 2015 at 9:26 AM, Ben Pfaff <b...@ovn.org> wrote

Re: [ovs-dev] [PATCH monitor_cond 00/12] Implement conditional monitoring

On Tue, Jan 5, 2016 at 5:13 AM, Liran Schour wrote: > This patch series implements conditional monitoring by introducing an OVSDB > RFC extension with 2 new JSON-RPC methods: "monitor_cond" and > "monitor_cond_change". Specification of this extension is defined in the >

Re: [ovs-dev] [PATCH] ofp-util: Avoid use-after-free error in ofputil_append_meter_config()

On Wed, Dec 23, 2015 at 9:26 AM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Dec 18, 2015 at 02:51:43PM -0800, Andy Zhou wrote: > > On Tue, Dec 15, 2015 at 10:51 PM, Ben Pfaff <b...@ovn.org> wrote: > > > Reported-by: weizj <334965...@qq.com> > > > Re

Re: [ovs-dev] [PATCH] ofp-util: Avoid use-after-free error in ofputil_append_meter_config()

On Tue, Dec 15, 2015 at 10:51 PM, Ben Pfaff <b...@ovn.org> wrote: > Reported-by: weizj <334965...@qq.com> > Reported-at: https://github.com/openvswitch/ovs/pull/97 > Signed-off-by: Ben Pfaff <b...@ovn.org> This fix makes sense to me. Acked-by: Andy Zhou <az..

Re: [ovs-dev] [PATCH] ovsdb: separate json cache for different monitor versions

On Tue, Dec 15, 2015 at 7:06 PM, Han Zhou wrote: > Cached json objects were reused when sending notifications to > clients. This created a problem when there were different versions > of monitors coexiting. E.g. clients expecting version2 notification > would receive messages

Re: [ovs-dev] [PATCH] ovsdb: separate json cache for different monitor versions

On Tue, Dec 15, 2015 at 8:24 PM, Ben Pfaff wrote: > On Tue, Dec 15, 2015 at 07:06:34PM -0800, Han Zhou wrote: > > Cached json objects were reused when sending notifications to > > clients. This created a problem when there were different versions > > of monitors coexiting. E.g.

Re: [ovs-dev] [PATCH] lib: fix sparse warnings

On Tue, Dec 15, 2015 at 12:28 AM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Dec 14, 2015 at 03:08:15PM -0800, Andy Zhou wrote: > > Fixes the following sparse warning messages: > > > > lib/ovsdb-idl.c:146:12: error: symbol 'table_updates_names' was not > >

Re: [ovs-dev] [PATCH] lib: fix sparse warnings

On Tue, Dec 15, 2015 at 10:55 AM, Joe Stringer <j...@ovn.org> wrote: > On 14 December 2015 at 15:08, Andy Zhou <az...@ovn.org> wrote: > > Fixes the following sparse warning messages: > > > > lib/ovsdb-idl.c:146:12: error: symbol 'table_updates_names'

[ovs-dev] [PATCH] lib: fix sparse warnings

: symbol 'row_update_names' was not declared. Should it be static? Reported-by: Joe Perches <j...@perches.com> See: https://travis-ci.org/openvswitch/ovs/jobs/96737772#L870 Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/ovsdb-idl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deleti

Re: [ovs-dev] [PATCH] jsonrpc-server: Use prototype style for ovsdb_jsonrpc_disable_monitor2().

On Mon, Dec 14, 2015 at 3:09 AM, Ben Pfaff <b...@ovn.org> wrote: > Without "void", this is a pre-ANSI style function definition that has > subtly different semantics. > > Found by sparse. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > Thanks fo

Re: [ovs-dev] [monitor2 v2 7/9] ovsdb-client: support monitor2

On Tue, Dec 1, 2015 at 6:20 AM, Liran Schour <lir...@il.ibm.com> wrote: > "dev" <dev-boun...@openvswitch.org> wrote on 25/11/2015 12:16:01 AM: > > > From: Andy Zhou <az...@nicira.com> > > @@ -617,6 +621,101 @@ monitor_print(struct

Re: [ovs-dev] monitor2--delay past branch for 2.5?

On Mon, Nov 30, 2015 at 9:58 AM, Ben Pfaff wrote: > Hi Andy. I think that we're planning to branch for 2.5 pretty soon. At > the same time, I think that the monitor2 code is close to being ready. > However, since we want to add more functionality to monitor2 (conditions > for

Re: [ovs-dev] monitor2--delay past branch for 2.5?

On Mon, Nov 30, 2015 at 11:31 PM, Liran Schour wrote: > "dev" wrote on 30/11/2015 07:58:28 PM: > > > > > Hi Andy. I think that we're planning to branch for 2.5 pretty soon. At > > the same time, I think that the monitor2 code is close to being

[ovs-dev] [Debian-non-root v4 RFC 0/2] Based on RHEL changes

Rebase Debian distribution "--user" changes based on RHEL patched posted at: http://openvswitch.org/pipermail/dev/2015-November/062561.html Andy Zhou (2): Debian: require libcap-ng library for building packages Debian: start daemons as ovs(non-root) u

[ovs-dev] [Debian-non-root v4 RFC 2/2] Debian: start daemons as ovs(non-root) user

Changes to Debian packaging scripts to create the ovs user and group. Fix the permissions of ovs created files and directories so that they are accessible by users belong to the ovs group. Start daemons as the ovs user. Signed-off-by: Andy Zhou <az...@nicira.com> This patch does not i

[ovs-dev] [Debian-non-root v4 RFC 1/2] Debian: require libcap-ng library for building packages

libcap-ng is going to be required to build Debian packages. Daemons will run as the ovs user and group, instead of root, to improve security. Signed-off-by: Andy Zhou <az...@nicira.com> Acked-by: Ansis Atteka <aatt...@nicira.com> Acked-by: Ben Pfaff <b...@nicira.com> ---

[ovs-dev] [rhel --user v2 7/7] rhel: run daemons as the ovs user

Make RHEL systemd distributions start OVS and OVN daemons under user ovs. The 'ovs' user and group will be created at the openvswitch RPM installtion time. Signed-off-by: Andy Zhou <az...@ovn.org> Acked-by: Ben Pfaff <b...@ovn.org> --- rhel/openvswitch-fedora.spec.in

[ovs-dev] [rhel --user v2 1/7] ovs-ctl: Remove hard coded root user and group

Replace hard coded root user and group with OVS_USER and OVS_GROUP. Signed-off-by: Andy Zhou <az...@ovn.org> Acked-by: Ansis Atteka <aatt...@ovn.org> Acked-by: Ben Pfaff <b...@ovn.org> --- utilities/ovs-ctl.in | 3 +++ utilities/ovs-lib.in | 6 +++--- 2 files changed,

[ovs-dev] [rhel --user v2 4/7] ovn: add --user option to ovn-ctl.

ovs-ctl now takes --user option to start OVS daemons under the user specified. This is a similar change in OVN to launch OVN daemons under the specified user. Signed-off-by: Andy Zhou <az...@ovn.org> Acked-by: Ben Pfaff <b...@ovn.org> --- v1->v2: use USER[:GROUP] instead of USER i

<    1   2   3   4   5   6   7   8   9   10   >