Re: [ovs-dev] [PATCH v2] python: idl: Avoid pre-allocating column defaults

LGTM! Acked-by: Flavio Fernandes > -- Forwarded message - > From: Terry Wilson mailto:twil...@redhat.com>> > Date: Fri, Nov 5, 2021 at 10:14 AM > Subject: [ovs-dev] [PATCH v2] python: idl: Avoid pre-allocating column > defaults > To: mai

Re: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Access OVS Datapath table only if supported.

s://bugzilla.redhat.com/1992705 > Signed-off-by: Dumitru Ceara > --- > controller/ovn-controller.c | 32 +++- > lib/features.c |5 + > ovs |2 +- > 3 files changed, 25 insertions(+), 14 deletions(-) Test

Re: [ovs-dev] [PATCH ovn 1/2] Revert "Revert features detection and zero-snat patches."

; > The upgrade problem will be addressed as a separate patch. > > Signed-off-by: Dumitru Ceara Acked-by: Flavio Fernandes > --- > controller/ovn-controller.c | 115 +++-- > include/ovn/actions.h |1 > include/ovn/features.h| 1

Re: [ovs-dev] [PATCH ovn v2] Revert features detection and zero-snat patches.

gt; v2: > * Switched from reverting just one commit to reverting two, thereby >eliminating two issues. > --- > > Signed-off-by: Mark Michelson > --- Acked-by: Flavio Fernandes mailto:fla...@flaviof.com>> > controller/ovn-controller.c | 115 +

Re: [ovs-dev] [PATCH ovn] Revert "ovn-controller: Handle DNAT/no-NAT conntrack tuple collisions."

kwards compatible, agree? Acked-by: Flavio Fernandes > On Aug 27, 2021, at 11:29 AM, Mark Michelson wrote: > > This commit resulted in significant decreased dataplane performance when > testing a dense OpenShift cluster. This was pinpointed to be due to an > extra ct(nat(src)) t

[ovs-dev] [PATCH ovn v2 1/1] ovn-controller: Ensure br-int is using secure fail-mode

by the time ovn-controller starts. This change fixes that and logs a warning should the fail-mode ever needed to be corrected. Reported-at: https://bugzilla.redhat.com/1957025 Signed-off-by: Flavio Fernandes --- v1->v2: Changes from code review. Thanks, Frode! controller/ovn-controller.c

Re: [ovs-dev] [PATCH ovn v1 1/1] ovn-controller: Ensure br-int is using secure fail-mode

> On May 7, 2021, at 3:02 AM, Frode Nordahl wrote: > > > > fre. 7. mai 2021, 03:22 skrev Flavio Fernandes <mailto:fla...@flaviof.com>>: > By default, OVS bridges use standalone fail-mode, which means it is > configured with a single row with the NORMAL action

[ovs-dev] [PATCH ovn v1 1/1] ovn-controller: Ensure br-int is using secure fail-mode

by the time ovn-controller starts. This change fixes that and logs a warning should the fail-mode ever needed to be corrected. Reported-at: https://bugzilla.redhat.com/1957025 Signed-off-by: Flavio Fernandes --- controller/ovn-controller.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[ovs-dev] [PATCH V3 0/1] ofp-parse: Fix segfault due to bad meter n_bands

Note how n_bands should be set to 0. ^^ For sake of consistency, I'm also proposing that flags attribute be set to 0 as well. Flavio Fernandes (1): ofp-parse: Fix segfault due to bad meter n_bands tests/dpif-netdev.at | 2 ++ utilities/ovs-ofctl.c | 4 ++-- 2 files changed, 4 insertions(+), 2

[ovs-dev] [PATCH V3 1/1] ofp-parse: Fix segfault due to bad meter n_bands

pport.") Signed-off-by: Flavio Fernandes --- v3: - Nit: Fix commit message v2: - Use memset to initialize struct instead of setting individial members - Invoke del-meters in existing tests/dpif-netdev.at test --- tests/dpif-netdev.at | 2 ++ utilities/ovs-ofctl.c | 4 ++-- 2 files

[ovs-dev] [PATCH V2 1/1] ofp-parse: Fix segfault due to bad meter n_bands

meter support.") Signed-off-by: Flavio Fernandes --- v2: - Use memset to initialize struct instead of setting individial members - Invoke del-meters in existing tests/dpif-netdev.at test --- tests/dpif-netdev.at | 2 ++ utilities/ovs-ofctl.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletion

[ovs-dev] [PATCH V2 0/1] ofp-parse: Fix segfault due to bad meter n_bands

Note how n_bands should be set to 0. ^^ For sake of consistency, I'm also proposing that flags attribute be set to 0 as well. Flavio Fernandes (1): ofp-parse: Fix segfault due to bad meter n_bands tests/dpif-netdev.at | 2 ++ utilities/ovs-ofctl.c | 4 ++-- 2 files changed, 4 insertions(+), 2

Re: [ovs-dev] [PATCH 1/1] ofp-parse: Fix segfault due to bad meter n_bands

> On Mar 16, 2021, at 5:28 PM, Ilya Maximets wrote: > > On 3/16/21 10:27 PM, Ilya Maximets wrote: >> On 3/16/21 10:21 PM, Ilya Maximets wrote: >>> On 3/16/21 9:24 PM, Flavio Fernandes wrote: >>>> Meter commands internally use ofctl_meter_mod__ and o

[ovs-dev] [PATCH 1/1] ofp-parse: Fix segfault due to bad meter n_bands

: Add meter support.") Signed-off-by: Flavio Fernandes --- utilities/ovs-ofctl.c | 4 1 file changed, 4 insertions(+) diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index 3601890f4..bd1ba9222 100644 --- a/utilities/ovs-ofctl.c +++ b/utilities/ovs-ofctl.c @@ -4030

[ovs-dev] [PATCH 0/1] ofp-parse: Fix segfault due to bad meter n_bands

Note how n_bands should be set to 0. ^^ For sake of consistency, I'm also proposing that flags attribute beset to 0 as well. Flavio Fernandes (1): ofp-parse: Fix segfault due to bad meter n_bands utilities/ovs-ofctl.c | 4 1 file changed, 4 insertions(+)

Re: [ovs-dev] [PATCH v5] python: Send notifications after the transaction ends

Tested-by: Flavio Fernandes Used this change against Openstack's OVN Zuul : https://review.opendev.org/c/openstack/neutron/+/778595 <https://review.opendev.org/c/openstack/neutron/+/778595> > On Mar 4, 2021, at 11:18 AM, Terry Wilson wrote: > > The Python IDL notific

Re: [ovs-dev] [PATCH v5] python: Send notifications after the transaction ends

Acked-by: Flavio Fernandes mailto:fla...@flaviof.com>> > On Mar 4, 2021, at 11:18 AM, Terry Wilson wrote: > > The Python IDL notification mechanism was sending a notification > for each processed update in a transaction as it was processed. > This causes issues w

Re: [ovs-dev] [PATCH v3] python: Send notifications after the transaction ends

Acked-by: Flavio Fernandes LGTM! Only one nit in the commit message. Testing changes in Openstack Zuul: https://review.opendev.org/c/openstack/neutron/+/778595 > On Mar 3, 2021, at 4:49 PM, Terry Wilson wrote: > > The Python IDL notification mechanism was sending a notification &

[ovs-dev] [PATCH ovn 1/1] DNM: please ignore.. testing new server email send

Signed-off-by: Flavio Fernandes --- utilities/ovn-nbctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c index 2c77f4ba7..85298770f 100644 --- a/utilities/ovn-nbctl.c +++ b/utilities/ovn-nbctl.c @@ -2717,7 +2717,7

Re: [ovs-dev] [PATCH ovn] northd: Fix ACL fair log meters for Port_Group ACLs.

Acked-by: Flavio Fernandes mailto:fla...@flaviof.com>> > On Jan 15, 2021, at 8:41 AM, Dumitru Ceara wrote: > > Commit 880dca99eaf7 added support for fair meters but didn't cover the > case when an ACL is configured on a port group instead of a logical > switch. > &g

Re: [ovs-dev] [PATCH ovn] Fix OVN update issue when ovn-controller is updated first from 20.06 to 20.09.

Acked-by: Flavio Fernandes > On Nov 20, 2020, at 5:52 AM, num...@ovn.org wrote: > > From: Numan Siddique > > The commit in the Fixes tag changed the ct_commit signature from > ct_commit(..) to ct_commit{ ..}. When ovn-controllers are updated > to a vesion which has t

Re: [ovs-dev] [PATCH ovn] controller: Allow pinctrl thread to handle packet-ins when version mismatch with northd.

Acked-by: Flavio Fernandes mailto:fla...@flaviof.com>> Tested-by: Flavio Fernandes mailto:fla...@flaviof.com>> > On Nov 22, 2020, at 9:44 AM, num...@ovn.org wrote: > > From: Numan Siddique > > The commit 1dd27ea7aea4 added the support to pin ovn-controller to

Re: [ovs-dev] [PATCH ovn] controller: Allow pinctrl thread to handle packet-ins when version mismatch with northd.

Tested-by: Flavio Fernandes mailto:fla...@flaviof.com>> > On Nov 22, 2020, at 9:44 AM, num...@ovn.org wrote: > > From: Numan Siddique > > The commit 1dd27ea7aea4 added the support to pin ovn-controller to a > specific version of ovn-northd. This patch did not handle t

Re: [ovs-dev] [PATCH ovn] controller: Allow pinctrl thread to handle packet-ins when version mismatch with northd.

Acked-by: Flavio Fernandes mailto:fla...@flaviof.com>> > On Nov 22, 2020, at 9:44 AM, num...@ovn.org wrote: > > From: Numan Siddique > > The commit 1dd27ea7aea4 added the support to pin ovn-controller to a > specific version of ovn-northd. This patch did not handle t

Re: [ovs-dev] [PATCH v5 ovn 1/2] northd: Fair ACL log meters.

> On Nov 19, 2020, at 4:01 AM, Numan Siddique wrote: > > On Mon, Nov 16, 2020 at 9:20 PM Flavio Fernandes <mailto:fla...@flaviof.com>> wrote: >> >> When multiple ACL rows use the same Meter for log rate-limiting, the >> 'noisiest' ACL matches may com

Re: [ovs-dev] [PATCH v5 ovn 1/2] northd: Fair ACL log meters.

> On Nov 19, 2020, at 12:37 PM, Ben Pfaff wrote: > > On Thu, Nov 19, 2020 at 02:31:04PM +0530, Numan Siddique wrote: >> Thanks for v5. This patch doesn't apply cleanly on the latest master. >> >> I'd suggest to post the patch 1 was an independent patch rebased on on >> top of latest master

[ovs-dev] [PATCH v6 ovn 0/1] northd: Enhance the implementation of ACL log meters (pre-ddlog merge).

tps://github.com/flavio-fernandes/ovn/commits/acl-meters.v6 [1]: https://github.com/flavio-fernandes/ovsdbapp_playground/blob/acl_meter_issue/scripts/acl_meter.sh v5 -> v6: * Rebase master (4da6881b6). * Implement changes from Numan review. * Keep ddlog portion as a follow up after it merg

Re: [ovs-dev] [PATCH ovn v2] Provide the option to pin ovn-controller and ovn-northd to a specific version.

Hi Numan! A few nits I thought of mentioning [inline] > On Nov 17, 2020, at 6:57 AM, num...@ovn.org wrote: > > From: Numan Siddique > > OVN recommends updating/upgrading ovn-controllers first and then > ovn-northd and OVN DB ovsdb-servers. This is to ensure that any > new functionality

[ovs-dev] [PATCH v5.master ovn 0/2] northd: Fair ACL log meters (pre-ddlog merge).

tps://github.com/flavio-fernandes/ovn/commits/acl-meters.v5.ddlog [1]: https://github.com/flavio-fernandes/ovsdbapp_playground/blob/acl_meter_issue/scripts/acl_meter.sh Flavio Fernandes (1): northd: Enhance the implementation of ACL log meters. NEWS | 2 + northd/ovn-north

[ovs-dev] [PATCH v5 ovn 2/2] northd: Fair ACL log meters.

issues mentioned in that link. [1]: https://patchwork.ozlabs.org/project/ovn/patch/20201107213913.gc2753...@ovn.org/ Co-authored-by: Ben Pfaff Signed-off-by: Flavio Fernandes --- northd/ovn_northd.dl | 281 --- tests/ovn-northd.at | 2 + 2 files

[ovs-dev] [PATCH v5 ovn 0/2] northd: Fair ACL log meters.

tps://github.com/flavio-fernandes/ovn/commits/acl-meters.v5.ddlog [1]: https://github.com/flavio-fernandes/ovsdbapp_playground/blob/acl_meter_issue/scripts/acl_meter.sh Flavio Fernandes (2): northd: Enhance the implementation of ACL log meters. ddlog for ACL log meters N

[ovs-dev] [PATCH v4 ovn 2/2] northd: Fair ACL log meters.

issues mentioned in that link. [1]: https://patchwork.ozlabs.org/project/ovn/patch/20201107213913.gc2753...@ovn.org/ Co-authored-by: Ben Pfaff Signed-off-by: Flavio Fernandes --- northd/ovn_northd.dl | 281 --- tests/ovn-northd.at | 2 + 2 files

[ovs-dev] [PATCH v4 ovn 0/2] northd: Fair ACL log meters.

tps://github.com/flavio-fernandes/ovn/commits/acl-meters.v4.merge [1]: https://github.com/flavio-fernandes/ovsdbapp_playground/blob/acl_meter_issue/scripts/acl_meter.sh Flavio Fernandes (2): northd: Fair ACL log meters. ddlog for ACL log meters. NEWS | 2 + northd/

Re: [ovs-dev] [PATCH ovn v5 8/8] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

Hm.. Could it be that you inadvertently remove this change in V5 ? diff --git a/northd/automake.mk b/northd/automake.mk index 2717f59c5f3a..157b5d0df487 100644 --- a/northd/automake.mk +++ b/northd/automake.mk @@ -22,8 +22,7 @@ bin_PROGRAMS += northd/ovn-northd-ddlog

Re: [ovs-dev] ddlog for ACL log meters (was: [PATCH v3 ovn 1/1] northd: Enhance the implementation of ACL log meters.)

[cc Dimitru, Numan, MarkM] > On Nov 10, 2020, at 2:15 PM, Ben Pfaff wrote: > > On Mon, Nov 09, 2020 at 09:53:16AM -0500, Flavio Fernandes wrote: >>> On Nov 7, 2020, at 4:39 PM, Ben Pfaff wrote: >>> On Tue, Nov 03, 2020 at 10:18:34PM +, Flavio Fernandes wrote:

Re: [ovs-dev] ddlog for ACL log meters (was: [PATCH v3 ovn 1/1] northd: Enhance the implementation of ACL log meters.)

[inline] > On Nov 7, 2020, at 4:39 PM, Ben Pfaff wrote: > > On Tue, Nov 03, 2020 at 10:18:34PM +0000, Flavio Fernandes wrote: >> When multiple ACL rows use the same Meter for log rate-limiting, the >> 'noisiest' ACL matches may completely consume the Meter and sha

Re: [ovs-dev] [PATCH ovn] northd: fix lb_action when there are no active backends for lb health_check

Tested-by: Flavio Fernandes mailto:fla...@flaviof.com>> > On Nov 3, 2020, at 11:43 AM, Lorenzo Bianconi > wrote: > > Fix the following warning reported by ovn-controller when there are no > active backends for lb health_check and selection_fields have been > configu

[ovs-dev] [PATCH v3 ovn 0/1] northd: Enhance the implementation of ACL log meters.

tes of the original (aka template) meter except for its name has the ACL UUID appended to it. Last but not least, northd takes care of using the corresponding meter name as the action in the logging of the ACL. [1]: https://github.com/flavio-fernandes/ovsdbapp_playground/blob/acl_meter_is

[ovs-dev] [PATCH v2 ovn 1/1] northd: Enhance the implementation of ACL log meters.

: ovn-nbctl set nb_global . options:acl_shared_log_meters="${meter_name}" If more than one meter is wanted, simply use a comma to separate each name. Reported-by: Flavio Fernandes Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2020-October/050769.html Signed-off-

[ovs-dev] [PATCH v2 ovn 0/1] northd: Enhance the implementation of ACL log meters.

tes of the original (aka template) meter except for its name has the ACL UUID appended to it. Last but not least, northd takes care of using the corresponding meter name as the action in the logging of the ACL. [1]: https://github.com/flavio-fernandes/ovsdbapp_playground/blob/acl_meter_is

[ovs-dev] [PATCH v1 ovn] northd: Enhance the implementation of ACL log meters.

: ovn-nbctl set nb_global . options:acl_shared_log_meters="${meter_name}" If more than one Meter is wanted, simply use a comma to separate each name. Reported-by: Flavio Fernandes Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2020-October/050769.html Signed-off-

Re: [ovs-dev] [PATCH ovn] Add missing curly braces to bare ct_commits

Verified this fix on top of commit acd38429638c01afe1b2a1d15404e4724232ec1d . Tested-by: Flavio Fernandes > On Aug 6, 2020, at 9:38 AM, Mark Michelson wrote: > > In the fixes commit below, ct_commit was changed to use nested actions. > This requires that curly braces be pre

Re: [ovs-dev] [PATCH] ovs-ctl: Don't set hostname as external-id

Acked-by: Flavio Fernandes mailto:fla...@flaviof.com>> > On May 20, 2020, at 11:52 AM, Daniel Alvarez wrote: > > ovs-ctl started to add the hostname as external-id [0] at some point. > > However, this can be problematic as if it's already set by an external > entity

Re: [ovs-dev] [PATCH ovn] Add support for DHCP options 35 and 38

Acked-by: Flavio Fernandes mailto:fla...@flaviof.com>> > On Apr 23, 2020, at 10:32 AM, lmart...@redhat.com wrote: > > From: Lucas Alvares Gomes > > This patch is adding support for two new DHCP options: > > * Option 35, ARP timeout: One nit: call it "ARP Cac

[ovs-dev] [PATCH ovn v1] tests: Fix failures in 4 HV, 1 LS, 1 LR, packet test with HA dist rtr gw prt

01 76. ovn.at:8695: 76. ovn -- 4 HV, 1 LS, 1 LR, packet test with HA distributed router gateway port (ovn.at:8695): FAILED (ovn.at:8865) Reported-by: Dumitru Ceara Signed-off-by: Flavio Fernandes --- tests/ovn.at | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/ov

[ovs-dev] [PATCH ovn v4] tests: Fix failures in 1 LR with distributed router gateway port

000108000604000102010203ac100101ac100101 020102030806000108000604000102010203ac100101ac100101 78. ovn.at:9139: 78. ovn -- 1 LR with distributed router gateway port (ovn.at:9139): FAILED (ovn.at:9367) Signed-off-by: Flavio Fernandes --- V4: - Address Dumitru's comments: - Use test name instead of number because number may c

[ovs-dev] [PATCH ovn v1] NAT: port range cannot be stateless

Minor change to ovn-nbctl to prevent users from attempting to use port range and stateless together. That is so because port range uses conntrack to set the source port. Signed-off-by: Flavio Fernandes --- tests/ovn-nbctl.at| 4 utilities/ovn-nbctl.c | 6 ++ 2 files changed, 10

[ovs-dev] [PATCH ovn v3] tests: Fix occasional failures for test 78

39: 78. ovn -- 1 LR with distributed router gateway port (ovn.at:9139): FAILED (ovn.at:9367) Signed-off-by: Flavio Fernandes --- tests/ovn.at | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index f83d3f536..e73772300 100644 --- a/tests/ovn.at +

[ovs-dev] [PATCH ovn v2] tests: Fix occasional failures for test 78

000108000604000102010203ac100101ac100101 020102030806000108000604000102010203ac100101ac100101 78. ovn.at:9139: 78. ovn -- 1 LR with distributed router gateway port (ovn.at:9139): FAILED (ovn.at:9367) Signed-off-by: Flavio Fernandes --- tests/ovn.at | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)

[ovs-dev] [PATCH ovn] tests: Fix occasional failures for test 78

101ac100101 78. ovn.at:9139: 78. ovn -- 1 LR with distributed router gateway port (ovn.at:9139): FAILED (ovn.at:9367) Signed-off-by: Flavio Fernandes Signed-off-by: Flavio Fernandes --- tests/ovn.at | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests

Re: [ovs-dev] [PATCH ovn] tests: Fix occasional failures for test 85.

Tested-by: Flavio Fernandes > On Apr 17, 2020, at 10:57 AM, num...@ovn.org wrote: > > From: Numan Siddique > > The test case "85: ovn -- send gratuitous ARP for NAT rules on HA distributed > router" > fails occaionally. On faster systems, chances of fail

Re: [ovs-dev] [PATCH ovn] tests: Fix occasional failures for test 85.

Tested-by: Flavio Fernandes mailto:fla...@flaviof.com>> > On Apr 17, 2020, at 10:57 AM, num...@ovn.org wrote: > > From: Numan Siddique > > The test case "85: ovn -- send gratuitous ARP for NAT rules on HA distributed > router" > fails occaionally.

[ovs-dev] [PATCH ovn v1 0/1] NAT: Enhancements to external port range support

C LOGICAL_PORT dnat_and_snat172.16.0.110 8080 10.0.0.3 30:54:00:00:00:03sw0-port1 snat 172.16.0.100 123-456 10.0.0.0/24 snat 172.16.0.10020.0.0.0/24 Flavio Fernandes (1): NAT: Enhancements

[ovs-dev] [PATCH ovn v1 1/1] NAT: Enhancements to external port range support

Added line in NEWS to mention about this update to the NB schema; - Minor typo in description of external port range; - Instead of using "if (strlen(str))", use "if (str[0])" code convention. [1]: https://patchwork.ozlabs.org/project/openvswitch/list/?series=169084 Signed-off-by:

[ovs-dev] [PATCH ovn v1] vagrant: Increase memory sizes

[ 2303.350508] Killed process 10068 (ovstest) total-vm:419844kB, anon-rss:405848kB, file-rss:0kB, shmem-rss:0kB [ 2303.369933] oom_reaper: reaped process 10068 (ovstest), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB root@debian-10:/vagrant/ovn/tests/testsuite.dir/015# Signed-off-by: Flavio Fernandes

[ovs-dev] [PATCH ovn v1] ovn-openstack.rst: Account for networking-ovn-migration

that are no longer needed. [0]: https://review.opendev.org/#/c/658414/19/specs/ussuri/ml2ovs-ovn-convergence.rst Signed-off-by: Flavio Fernandes --- Documentation/tutorials/ovn-openstack.rst | 51 --- 1 file changed, 18 insertions(+), 33 deletions(-) diff --git a/Documentation/tutorials

Re: [ovs-dev] [PATCH 2/3] ovn-controller.c: Move the position of handling OVN-SB related settings.

idl_loop.idl)); >>> + > ofctrl_set_probe_interval(get_ofctrl_probe_interval(ovs_idl_loop.idl)); >>> + >>> struct ovsdb_idl_txn *ovnsb_idl_txn >>> = ovsdb_idl_loop_run(_idl_loop); >>> unsigned in

Re: [ovs-dev] [PATCH] [RFC] ovsdb-server: Allow OVSDB clients to specify the UUID for inserted rows.

> On Aug 26, 2019, at 5:00 PM, Ben Pfaff wrote: > > Requested-by: Leonid Ryzhyk > Signed-off-by: Ben Pfaff > --- > Documentation/ref/ovsdb-server.7.rst | 9 + > NEWS | 3 ++- > ovsdb/execution.c| 26 ++ >

[ovs-dev] [PATCH ovn v4] vagrant: Use centos-8 box from official location

From: Flavio Fernandes Prefer the usage of "vagrant box update" instead of "dnf update" to save provisioning time. Also, as part of provisioning centos-8, use pip to install packages twisted, zope-interface and six. Signed-off-by: Flavio Fernandes --- v2: Nit: Make dnf up

[ovs-dev] [PATCH ovn v3] vagrant: Use centos-8 box from official location

From: Flavio Fernandes Prefer the usage of "vagrant box update" instead of "dnf update" to save provisioning time. Also, as part of provisioning centos-8, use pip to install packages twisted, zope-interface and six. Signed-off-by: Flavio Fernandes --- Vagrantfile | 11

[ovs-dev] [PATCH ovn v2] vagrant: Use centos-8 box from official location

From: Flavio Fernandes Prefer the usage of "vagrant box update" instead of "dnf update" to save provisioning time. Also, as part of provisioning centos-8, use pip to install packages twisted, zope-interface and six. Signed-off-by: Flavio Fernandes --- v2: Nit: Make dnf up

[ovs-dev] [PATCH ovn] vagrant: Use centos-8 box from official location

From: Flavio Fernandes Prefer the usage of "vagrant box update" instead of "dnf update" to save provisioning time. Also, as part of provisioning centos-8, use pip to install packages twisted, zope-interface and six. Signed-off-by: Flavio Fernandes --- Vagrantfile | 11

[ovs-dev] [PATCH ovn v1] vagrant: Use python3 and newer linux distros

. The provisioning does not yet include building rpms+deb packages. [1]: https://github.com/ovn-org/ovn/issues/23 Signed-off-by: Flavio Fernandes --- Vagrantfile | 96 + 1 file changed, 68 insertions(+), 28 deletions(-) diff --git a/Vagrantfile b

[ovs-dev] [PATCH ovn v2] Utilities: add ovn-sim

. This patch renames these to ovn-sim. All in all, this change is nothing but porting over the OVN sections of ovs-sim from OVS version 2.12 (pre-split). Reported-by: Flavio Fernandes Reported-at: https://github.com/ovn-org/ovn/issues/21 (Fixes #21) Signed-off-by: Flavio Fernandes --- v1 -> v2: *

[ovs-dev] [PATCH ovn v1] utilities: add ovn-sim

. This patch renames these to ovn-sim. All in all, this change is nothing but porting over the OVN sections of ovs-sim from OVS version 2.12 (pre-split). Fixes #21 Reported-by: Flavio Fernandes Reported-at: https://github.com/ovn-org/ovn/issues/21 Signed-off-by: Flavio Fernandes --- Documentation

[ovs-dev] [PATCH ovn v1] Documentation cleanup: sandbox

Fix ovn-sandbox documentation with regards to SANDBOXFLAGS. That is, the sandbox in this repo will actually fail if we attempt to start it with the --ovn flag. Signed-off-by: Flavio Fernandes --- Documentation/tutorials/ovn-sandbox.rst | 10 -- 1 file changed, 4 insertions(+), 6

[ovs-dev] [PATCH ovn v1] vagrant: Port Vagrantfile to build and test OVN

source is located (i.e.: ../ovs). Provisioning makes no attempt to build and install openvswitch kernel modules, but it will build ovs on each VM in order to support OVN. Signed-off-by: Flavio Fernandes --- Items looking for feedback: - There is an OVN test failing, which needs a closer look

[ovs-dev] [PATCH ovn] ovn-openstack.rst: Add check for Gateway_Chassis table

dant route command when assigning an address to the br-ex interface. Signed-off-by: Flavio Fernandes --- Documentation/tutorials/ovn-openstack.rst | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/tutorials/ovn-openstack.rst b/Documentation/tut

[ovs-dev] [PATCH v3] ovn-openstack.rst: Miscelaneous fixes.

a temporary file to ensure datapath flow for recirc(0) is obtained; - Reword what to expect when tracing packet before logical router creation; - Fix minor mistake on the usage of netcat command; - Use MAC of logical router's IPv4 interface to make ACL example more realistic. Signed-off-by: Flavio

[ovs-dev] [PATCH v2] ovn-openstack.rst: Miscelaneous fixes.

a temporary file to ensure datapath flow for recirc(0) is obtained; - Reword what to expect when tracing packet before logical router creation; - Fix minor mistake on the usage of netcat command; - Use MAC of logical router's IPv4 interface to make ACL example more realistic. Signed-off-by: Flavio

[ovs-dev] [PATCH 1/1] ovn-openstack.rst: Miscelaneous fixes.

a temporary file to ensure datapath flow for recirc(0) is obtained; - Reword what to expect when tracing packet before logical router creation; - Fix minor mistake on the usage of netcat command; - Use MAC of logical router's IPv4 interface to make ACL example more realistic. Signed-off-by: Flavio

[ovs-dev] [PATCH v1 2/2] ovs-vsctl: Fix segfault when attempting to del-port from parent bridge.

The error message in the check for improper bridge param is de-referencing parent from the wrong bridge. Also, the message itself had the parent and child bridges reversed, so that got a small tweak as well. Signed-off-by: Flavio Fernandes <fla...@flaviof.com> --- utilities/ovs-vsctl

[ovs-dev] [PATCH v1 1/2] ovs-vsctl.at: deleting a port from fake bridge

This test will exercise the code path in ovs-vsctl where a del-port is attempted using the parent of a fake-bridge. It expects a message saying that user provided the wrong bridge. Not a segfault. Signed-off-by: Flavio Fernandes <fla...@flaviof.com> --- tests/ovs-vsctl.a

[ovs-dev] [PATCH v1 0/2] ovs-vsctl segfaults on del-port of fake-bridge when parent is provided

bridge->parent->name); 1754} else { (gdb) p ctx->argv[1] $1 = 0x7fffcba5 "br0" (gdb) p ctx->argv[2] $2 = 0x7fffcba9 "p1" (gdb) p port->bridge->name $3 = 0xc9a290 "br0c" (gdb) p bridge $4 = (struct vsctl_b

[ovs-dev] [PATCH 2/5] ovn: add sfc tables to northbound schema

Reported-at: http://openvswitch.org/pipermail/discuss/2016-March/020628.html Reported-at: http://openvswitch.org/pipermail/discuss/2016-May/thread.html#21201 Co-authored-by: John McDowall <jmcdow...@paloaltonetworks.com> Signed-off-by: Flavio Fernandes <fla...@flaviof.com>

[ovs-dev] [PATCH] ovn: fix ovn-northd leak in build_acls

Avoid leak due to missing ds_destroy in build_acl for non-stateful drop action. Found via inspection. I do not know that this fixes a common leak. Signed-off-by: Flavio Fernandes <fla...@flaviof.com> --- ovn/northd/ovn-northd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovn/nort

[ovs-dev] [PATCH v1] debian: Include ovn-trace in ovn-common package

Include the ovn-trace binary and it's man page in ovn-common package Fixes: 4acd1e87a8bf ("ovn-trace: New utility.") Fixes: f448e5a4bb1f ("rhel: Include ovn-trace in ovn-common package") Signed-off-by: Flavio Fernandes <fla...@flaviof.com> --- debian/ovn-common.

Re: [ovs-dev] [PATCH 1/3] tests: Use standard -q option to grep in place of GNU --quiet extension.

> On Sep 29, 2016, at 5:41 PM, Ben Pfaff <b...@ovn.org> wrote: > > Reported-by: Stuart Cardall <develo...@it-offshore.co.uk> > Reported-at: > http://openvswitch.org/pipermail/discuss/2016-September/022803.html > Signed-off-by: Ben Pfaff <b...@ovn.org&g

Re: [ovs-dev] [PATCH v9] ovn-nbctl: Add LB commands.

> On Sep 29, 2016, at 5:43 AM, nickcooper-zhangtonghao > wrote: > > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it to multiple > switches or routers. A single load balancer can

[ovs-dev] [PATCH v4] ovn: ensure datapath removal is proper

Adding a unit test in ovn.at, to exercise the cleanup of OF rules related to a logical datapath, when a logical switch is removed. Reported-by: Guru Shetty <g...@ovn.org> Reported-at: http://openvswitch.org/pipermail/discuss/2016-August/022478.html Signed-off-by: Flavio Fernande

[ovs-dev] [PATCH v1] lib: Create $(sysconfdir)/openvswitch upon install

scuss/2016-September/022673.html Fixes: f973f2af2fd4 ("Make the location of the database separately configurable.") Signed-off-by: Flavio Fernandes <fla...@flaviof.com> --- v0->v1: fix Reported-at tag lib/automake.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/automa

[ovs-dev] [PATCH v0] lib: Create $(sysconfdir)/openvswitch upon install

-September/TBD.html Fixes: f973f2af2fd4 ("Make the location of the database separately configurable.") Signed-off-by: Flavio Fernandes <fla...@flaviof.com> --- lib/automake.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/automake.mk b/lib/automake.mk index b00e90f

Re: [ovs-dev] [PATCH 3/3] ovsdb: Fix replication memory leak.

rver.c:429) > > Fixes: 60e0cd041958 ("ovsdb: Replication usability improvements") > Signed-off-by: Joe Stringer <j...@ovn.org> Acked-by: Flavio Fernandes <fla...@flaviof.com> > --- > This also affects branch-2.6. > --- > ovsdb/replication.c | 1 - > 1 file

Re: [ovs-dev] [PATCH] ofctrl: Fix logic for mff_ovn_geneve.

> On Sep 9, 2016, at 8:38 AM, Gurucharan Shetty <g...@ovn.org> wrote: > > Fixes: 7fa39c6b9376e99 ("Fix memory leak in recv_S_TLV_TABLE_REQUESTED().") > Signed-off-by: Gurucharan Shetty <g...@ovn.org> Acked-by: Flavio Fernandes <fla...@flaviof.com> &g

[ovs-dev] [PATCH v3] ovn: ensure datapath removal is proper

Adding a unit test in ovn.at, to exercise the cleanup of OF rules related to a logical datapath, when a logical switch is removed. Reported-by: Guru Shetty <g...@ovn.org> Reported-at: http://openvswitch.org/pipermail/discuss/2016-August/022478.html Signed-off-by: Flavio Fernande

Re: [ovs-dev] [PATCH v2] ovn: ensure datapath removal is proper

> On Sep 8, 2016, at 4:31 PM, Russell Bryant <russ...@ovn.org> wrote: > > > > On Thu, Sep 8, 2016 at 3:13 PM, Flavio Fernandes <fla...@flaviof.com> wrote: > Adding a unit test in ovn.at, to exercise the cleanup of > OF rules related to a logical datapath, w

[ovs-dev] [PATCH v2] ovn: ensure datapath removal is proper

Adding a unit test in ovn.at, to exercise the cleanup of OF rules related to a logical datapath, when a logical switch is removed. Reported-by: Guru Shetty <g...@ovn.org> Reported-at: http://openvswitch.org/pipermail/discuss/2016-August/022478.html Signed-off-by: Flavio Fernande

Re: [ovs-dev] [PATCH] ovn-controller: Fix memory leak in recv_S_TLV_TABLE_REQUESTED().

makes it possible to catch all paths out of the function so that 'reply' > can be freed in one place. > +1 for moving it into a function and calling "ofputil_uninit_tlv_table();" in a single place! > Reported-by: Ryan Moats <rmo...@us.ibm.com> > Signed-off-by: Be

Re: [ovs-dev] ovn-controller: Fix leak in patched_datapaths processing.

Ben Pfaff <b...@ovn.org> Acked-by: Flavio Fernandes <fla...@flaviof.com> > --- > ovn/controller/ovn-controller.c | 4 ++-- > ovn/controller/ovn-controller.h | 2 +- > ovn/controller/patch.c | 4 +--- > ovn/controller/physical.c | 4 +--- > ovn/lib/ovn-uti

Re: [ovs-dev] [PATCH] Fix leak in patched_datapaths processing.

> On Sep 1, 2016, at 10:29 AM, Ryan Moats <rmo...@us.ibm.com> wrote: > > When unpersisting patch_datapaths, missed that the key field > needed to be freed to avoid a memory leak. This patch fixes > same. > > Signed-off-by: Ryan Moats <rmo...@us.ibm.com>

Re: [ovs-dev] [PATCH] Close memory leak when processing S_TLV_TABLE_REQUESTED.

l_run (ofctrl.c:471) > by 0x406C8F: main (ovn-controller.c:439) > > Signed-off-by: Ryan Moats <rmo...@us.ibm.com> Acked-by: Flavio Fernandes <fla...@flaviof.com> > --- > ovn/controller/ofctrl.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/ovn/cont

Re: [ovs-dev] [PATCH v4] ovn-controller: Back out incremental processing

long with the persisting of OF flows, > logical ports, multicast groups, all_lports, local and patched > datapaths > > [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html > > Signed-off-by: Ryan Moats <rmo...@us.ibm.com> > Co-authored-by: Guru Shetty <g...@ov

[ovs-dev] [PATCH v6] ovn: Replace tabs with spaces and clean up alignment in unit tests.

Signed-off-by: Flavio Fernandes <fla...@flaviof.com> --- v1->v2: fix indentation issues introduced in v1 v2->v3: noop :P v3->v4: fix indentation issue introduced in v1, this time for real v4->v5: fix yet another -- and hopefully final?!? -- round of indentation issues v5->v6

Re: [ovs-dev] [RFC] ovn: minimize the impact of a compromised chassis

> On Aug 23, 2016, at 5:34 PM, Darrell Ball wrote: > > On Tue, Aug 23, 2016 at 2:20 PM, Russell Bryant > wrote: > >> >> >> On Tue, Aug 23, 2016 at 5:05 PM, Darrell Ball wrote: >> >>> >>> >>> On Mon, Aug

[ovs-dev] [PATCH v5] ovn: Replace tabs with spaces and clean up alignment in unit tests.

Signed-off-by: Flavio Fernandes <fla...@flaviof.com> --- v1->v2: fix indentation issues introduced in v1 v2->v3: noop :P v3->v4: fix indentation issue introduced in v1, this time for real v4->v5: fix yet another -- and hopefully final?!? -- round of indentation issues

[ovs-dev] [PATCH] ovn-trace: add generated files to .gitignore.

Signed-off-by: Flavio Fernandes <fla...@flaviof.com> --- ovn/utilities/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ovn/utilities/.gitignore b/ovn/utilities/.gitignore index 5832b6c..2c06825 100644 --- a/ovn/utilities/.gitignore +++ b/ovn/utilities/.gitignore @@ -3,

[ovs-dev] [PATCH v4] ovn: Replace tabs with spaces and clean up alignment in unit tests.

Signed-off-by: Flavio Fernandes <fla...@flaviof.com> --- v1->v2: fix indentation issues introduced in v1 v2->v3: noop :P v3->v4: fix indentation issue introduced in v1, this time for real tests/ovn.at | 154 +-- 1 file changed

[ovs-dev] [PATCH v3] ovn: Replace tabs with spaces and clean up alignment in unit tests.

Signed-off-by: Flavio Fernandes <fla...@flaviof.com> --- v1->v2: fix indentation issues introduced in v1 v2->v3: fix indentation issue introduced in v1 tests/ovn.at | 154 +-- 1 file changed, 77 insertions(+), 77 deletions(-)

[ovs-dev] [PATCH v2] ovn: Replace tabs with spaces and clean up alignment in unit tests.

Signed-off-by: Flavio Fernandes <fla...@flaviof.com> --- v1->v2: fix indentation issues introduced in v1 tests/ovn.at | 154 +-- 1 file changed, 77 insertions(+), 77 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at inde

[ovs-dev] [PATCH v1] ovn: ensure datapath removal is proper

Adding a unit test in ovn.at, to exercise the cleanup of OF rules related to a logical datapath, when a logical switch is removed. Reported-by: Guru Shetty <g...@ovn.org> Reported-at: http://openvswitch.org/pipermail/discuss/2016-August/022478.html Signed-off-by: Flavio Fernande

  1   2   >