Re: [ovs-dev] [PATCH v2] Backup and remove existing DB when joining cluster

LGTM! Acked-by: Flavio Fernandes On Fri, Nov 5, 2021 at 2:24 PM Terry Wilson wrote: > ovsdb-tool join-cluster requires a remote addr, so the existing > code that tried to join a cluster without it when there was an > existing $DB_FILE would fail. > > Instead, if we are trying to specifically

Re: [ovs-dev] [PATCH] ovsdb-idl: Style and comment improvements for conditional replication.

On Sun, Aug 14, 2016 at 12:52 AM, Ben Pfaff wrote: > The conditional replication code had hardly any comments. This adds some. > > This commit also fixes a number of style problems, factors out some code > into a helper function, and moves some struct declarations from a public >

Re: [ovs-dev] [PATCH] ovsdb-idl: Fix memory leak in ovsdb_idl_condition_add_clause().

On Sat, Aug 13, 2016 at 7:58 PM, Ben Pfaff wrote: > The function always allocated a clause but didn't use it if it was > going to be a duplicate. > > Signed-off-by: Ben Pfaff > Acked-by: Flavio Fernandes > --- > lib/ovsdb-idl.c | 2 +- > 1

Re: [ovs-dev] [PATCH v3] ovn-controller: Persist desired conntrack groups.

On Thu, Jul 28, 2016 at 5:17 PM, Ryan Moats wrote: > With incremental processing of logical flows desired conntrack groups > are not being persisted. This patch adds this capability, with the > side effect of adding a ds_clone method that this capability leverages. > >

Re: [ovs-dev] [PATCH 1/5] tests: Define trim_zeros in only one place.

On Wed, Jul 27, 2016 at 2:03 AM, Ben Pfaff wrote: > Defining trim_zeros in a common place allows us to skip defining it in > every test that needs it. > > Signed-off-by: Ben Pfaff > Acked-by: Flavio Fernandes > --- > tests/ovn.at | 61 >

Re: [ovs-dev] [PATCH 4/5] tests: Remove most packet-forwarding related"sleep"s from OVN tests.

On Thu, Jul 28, 2016 at 10:16 PM, Ryan Moats wrote: > "dev" wrote on 07/27/2016 02:03:24 AM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 07/27/2016 02:04 AM > > Subject: [ovs-dev]

Re: [ovs-dev] [PATCH 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

On Wed, Jul 20, 2016 at 4:21 PM, Aaron Conole wrote: > This commit allows the ovs-ctl command to spawn daemons without the > internal process monitor. This is useful when integrating with, > ex. systemd, which provides its own monitoring facilities. > > Signed-off-by: Aaron

Re: [ovs-dev] [patch_v6 2/2] ovn: Reformat some ovn design documentation.

Embarrassingly minor nitpicks follow... On Sat, Jul 23, 2016 at 3:18 PM, Darrell Ball wrote: > Some design micro-details (e.g.) register assignments) that may change > over time were moved from the ovn-architecture.7.xml document to the > OVN-DESIGN.md document. A table is

Re: [ovs-dev] [PATCH] ovn-controller: Add incremental processing for multicast groups

On Sun, Jul 24, 2016 at 8:20 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > Flaviof <fla...@flaviof.com> wrote on 07/24/2016 08:14:19 PM: > > > From: Flaviof <fla...@flaviof.com> > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: ovs dev <dev@openvswitch.org&g

Re: [ovs-dev] [PATCH] ovn-controller: Add incremental processing for multicast groups

On Sun, Jul 24, 2016 at 2:33 PM, Ryan Moats wrote: > The various fixes in handling physical and binding changes > have addressed the problems that the original attempt to > incrementally process the multicast group table ran into. > So, re-add incremental processing of the

Re: [ovs-dev] [PATCH] ovn.at: A "peer" is only for interconnected routers.

On Mon, Jul 18, 2016 at 3:00 AM, Gurucharan Shetty wrote: > We should not use "peer" while connecting a router to a switch. > (Doing so, will cause ovn-northd to constantly create and destroy > port_binding records which causes CPU utilization of ovn-controller to > spike up.) > >

Re: [ovs-dev] [PATCH] ovn-northd: Remove extraneous ip4 mulicast logical flow.

On Thu, Jul 14, 2016 at 2:34 PM, Ryan Moats wrote: > IPv4 multicast is already dropped by a previous logical flow > written for the logical router, so there is no reason to add > a lower priority rule for it. > > Signed-off-by: Ryan Moats > Acked-by:

Re: [ovs-dev] [PATCH v2] ovn-controller: Remove old address set after change.

On Thu, Jul 7, 2016 at 2:37 PM, Ryan Moats wrote: > Currently, when address set value changes, ovn controller > doesn't remove the old entry from the tracking hash, it > just adds the new one, leading to multiple entries for the > same symbol. > > Fix this behavior and add a

Re: [ovs-dev] [PATCH v3] Travis: Added python plugins flake8 and hacking.

On Wed, Jun 22, 2016 at 3:48 PM, William Townsend wrote: > Travis builds will now automatically run flake8 and hacking checks against > Python code and generate warnings. > > Signed-off-by: William Townsend > > Acked-by: Flavio Fernandes

Re: [ovs-dev] [PATCH v3 2/2] ovn: Add address_set() support for ACLs.

On Thu, Jun 23, 2016 at 1:05 AM, wrote: > From: Russell Bryant > > This feature was originally proposed here: > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > A common use case for OVN ACLs involves needing to match a set of IP >

Re: [ovs-dev] [PATCH v3 1/2] Add address set support.

On Thu, Jun 23, 2016 at 1:05 AM, wrote: > From: Russel Bryant > > Update the OVN expression parser to support address sets. Previously, > you could have a set of IP or MAC addresses in this form: > > {addr1, addr2, ..., addrN} > > This patch adds

Re: [ovs-dev] [PATCH v3 2/2] ovn: Add address_set() support for ACLs.

On Thu, Jun 23, 2016 at 1:05 AM, wrote: > From: Russell Bryant > > This feature was originally proposed here: > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > A common use case for OVN ACLs involves needing to match a set of IP >

Re: [ovs-dev] [PATCH v4] ovn: DNAT and SNAT on a gateway router.

On Tue, Jun 21, 2016 at 10:46 AM, Guru Shetty <g...@ovn.org> wrote: > > > On 20 June 2016 at 19:36, Flaviof <fla...@flaviof.com> wrote: > >> On Mon, Jun 13, 2016 at 6:45 AM, Gurucharan Shetty <g...@ovn.org> wrote: >> >> > For traffi

Re: [ovs-dev] [PATCH v4] ovn: DNAT and SNAT on a gateway router.

;; ct_dnat;' to all ip packets that do not have an explicit dnat mapping? SNAT: do we need ARP reply rules for the SNAT addresses, similar to the ones added for DNAT? SNAT: looking at the openflow table I see n mentioning of the address added to support SNAT. Ist that because that is all handled by

Re: [ovs-dev] [PATCH] Travis: added python plugins flake8 and hacking.

PATH=$PATH:$HOME/bin > > > +before_script: export PATH=$PATH:$HOME/bin:$HOME/.local/bin > > > > Nit: it's not 100% clear to me why the above is here > > > > ​WT: Using pip install with "--user" places the packages in > $HOME/.local/bin​ > > Hi Bill, I

Re: [ovs-dev] [PATCH] Travis: added python plugins flake8 and hacking.

On Wed, Jun 15, 2016 at 1:32 PM, William Townsend wrote: > Travis builds will now automatically run flake8 and hacking checks against > Python code and generate warnings. > > Signed-off-by: Willim Townsend > > Nitpick: fix typo in your name for the

[ovs-dev] cannot find v4 of DNAT changes in mailing list

Hi Guru, For some odd reason the v4 of your changes in patchwork [v4] does not seem to be visible via the mailing list. Is that because you submitted it via GitHub?!? Thanks, -- flaviof [v4]: https://patchwork.ozlabs.org/patch/633069/ ___ dev mailing

Re: [ovs-dev] [PATCH] ovn-northd: fix logical router icmp response for directed broadcasts

On Wed, Jun 8, 2016 at 5:51 PM, Flavio Fernandes wrote: > Responding to icmp queries where the L3 destination is a directed broadcast > was not being properly handled, causing the reply to be sent to all logical > ports except for the one port that should receive it. > >

Re: [ovs-dev] [PATCH] OVN: datalog man page

ra.spec.in (e.g. https://gist.github.com/61dadbd1a5cae27407012a418a154825) I will read/provide comments about the actual content of ovn-datalog.7 separately. -- flaviof > > diff --git a/ovn/lib/automake.mk b/ovn/lib/automake.mk > index 9e09352..4870505 100644 > --- a/ovn/lib/

Re: [ovs-dev] [PATCH v5] ovn-northd: logical router icmp response should not care about inport

On Fri, May 27, 2016 at 11:53 AM, Flavio Fernandes wrote: > When responding to icmp echo requests (aka ping) packets, the logical > router should not restrict responses based on the inport. > > Example diagram: > > vm: IP1.1 (subnet1) > logical_router: IP1.2 (subnet1) and

Re: [ovs-dev] [PATCH v3] ovn-northd: logical router icmp response should not care about inport

* update **: Darrell pointed out the excerpt in RFC that indicates that ttl checking is not to happen when packet is destined to the router. With that, there is no further discussion required on this particular topic. > I may be microoptimizing. I am open to that discussion. > Not a

Re: [ovs-dev] [PATCH v2] ovn-northd: logical router icmp response should not care about inport

s a separate packet from the ICMP request. > > The below is an excerpt from RFC 1812 and it also references RFC 791. > > 4.2.2.9 Time to Live: RFC 791 Section 3.2 > . > . > Note in particular that a router MUST NOT check the TTL of a packet > except when forwarding it. > . > .

Re: [ovs-dev] [PATCH] ovn-northd: Support connecting multiple routers to a switch.

ion on tests/ovn.at Given that the test is a little long -- and I can see why it needs to be -- would it be better if it was added in a separate [new] file, i.e. ovn-l3.at ? I ask because I see that this could be similar to what we have in regards to controller vtep: ovn-controller.at and ovn-contro