Re: [ovs-dev] [PATCH V2 02/10] python tests: Skip python tests that kill the python daemon

Hi Guru, There are other tests that check if the daemon is running fine. In my opinion we could skip this test on Windows and let it on Linux to run. Paul From: Guru Shetty [mailto:g...@ovn.org] Sent: Tuesday, August 30, 2016 6:18 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev

[ovs-dev] [PATCH V2 08/10] python tests: Ignore stderr output

test-unixctl.py and test-vlog.py outputs on stderr and on Windows stderr is not overriden by every AT_CHECK call, the logs are only apended to the file and subsequent AT_CHECKs get errors from previous call. Signed-off-by: Paul-Daniel Boca --- V2: No changes. ---

[ovs-dev] [PATCH V2 10/10] at tests: Allow Python tests to be run on Windows

This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Paul-Daniel Boca --- V2: No changes. --- tests/atlocal.in | 7 --- 1 file changed, 7 deletions(-) diff --git a/tests/atlocal.in b/tests/atlocal.in index

[ovs-dev] [PATCH V2 09/10] python tests: Skip ovn-controller-vtep tests on Windows

The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca --- V2: No changes. --- tests/ovn-controller-vtep.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH V2 04/10] python tests: Ported UNIX sockets to Windows

AF_UNIX sockets are not supported on Windows. Instead of an AF_UNIX socket use named pipes to communicate between components. This makes the python sockets compatible with the named pipe used in Windows applications. Added stream_windows.py with named pipe and localhost tcp connections support.

[ovs-dev] [PATCH V2 06/10] python tests: Implemented wrapper over daemon_unix.py

Implemented a wrapper over every function from daemon_unix. This will help on porting daemon to Windows. Signed-off-by: Paul-Daniel Boca --- V2: No changes. --- python/automake.mk | 1 + python/ovs/daemon.py | 77

[ovs-dev] [PATCH V2 07/10] python tests: Ported Python daemon to Windows

Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to

[ovs-dev] [PATCH V2 05/10] python tests: Rename daemon.py to daemon_unix.py

Prepare for porting unix daemon to Windows. Signed-off-by: Paul-Daniel Boca --- V2: No changes. --- python/automake.mk | 2 +- python/ovs/{daemon.py => daemon_unix.py} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename

[ovs-dev] [PATCH V2 03/10] python tests: Rename stream.py to stream_unix.py

Prepare for porting unix sockets to Windows named-pipes. Signed-off-by: Paul-Daniel Boca --- V2: Moved test-jsonrpc.py changes from next patch to current one. --- python/automake.mk | 2 +- python/ovs/jsonrpc.py| 14

[ovs-dev] [PATCH V2 02/10] python tests: Skip python tests that kill the python daemon

If the python script is killed with `kill` command, the atexit handler doesn't gets executed on Windows. The kill of the process is done using NtTerminateProcess which doesn't sends a signal to the process itself, if just terminates the process from kernel mode. Signed-off-by: Paul-Daniel Boca

[ovs-dev] [PATCH V2 01/10] python tests: Skip python tests specific to Linux

There is a difference between POSIX pid and Windows pid, not all the time are equal. On Windows when a python script is started, a sh command is triggered as the parent for script. So when we try to get the daemon pid with 'echo $!', this will get the pid of sh not of python.exe as expected.

[ovs-dev] [PATCH V2 00/10] Fixed Python tests for Windows

This series of patches ports python daemon and unixctl to Windows. All patches depend on each other. The the daemon was ported using pywin32 python library using Win32 API and unixctl was ported using named-pipes in order to be compatible with OVS Windows applications. Paul-Daniel Boca (10):

Re: [ovs-dev] [PATCH 09/12] python tests: Skip ovn-controller-vtep tests on Windows

] Sent: Friday, August 26, 2016 9:07 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 09/12] python tests: Skip ovn-controller-vtep tests on Windows On 26 August 2016 at 07:40, Paul Boca <pb...@cloudbasesolutions.com<mailto:pb...@cloudbasesolutions.com>> wrot

Re: [ovs-dev] [PATCH 11/12] ovsdb-monitor: Skip monitor-cond tests on Windows

Hi Guru, I will take this patch out from this series and will retest it. Thanks, Paul From: Guru Shetty [mailto:g...@ovn.org] Sent: Friday, August 26, 2016 9:12 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 11/12] ovsdb-monitor: Skip monitor-cond tests on Windows

[ovs-dev] [PATCH] datapath-windows: Fix connection state tracking in Conntrack

A connection can be both a reply and related. Signed-off-by: Paul-Daniel Boca --- datapath-windows/ovsext/Conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-windows/ovsext/Conntrack.c

[ovs-dev] [PATCH] datapath-windows: Fixed tcp flags byte order in conntrack

In user mode the flags are interpreted as little endian. This fix makes the kernel mode compatible with user mode. Signed-off-by: Paul-Daniel Boca --- datapath-windows/ovsext/Conntrack-tcp.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff

Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output

From: Guru Shetty [mailto:g...@ovn.org] Sent: Monday, August 29, 2016 8:44 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output On 29 August 2016 at 10:36, Paul Boca <pb...@cloudbasesolutions.com<mailto:pb...@cloudbasesolutio

Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output

Hi Guru, please see my comments inline. Thanks, Paul From: Guru Shetty [mailto:g...@ovn.org] Sent: Friday, August 26, 2016 9:04 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output On 26 August 2016 at 07:40, Paul Boca <

Re: [ovs-dev] [PATCH 01/12] python tests: Skip python tests specific to Linux

Hi Guru, please see my comment inline. Thanks, Paul From: Guru Shetty [mailto:g...@ovn.org] Sent: Friday, August 26, 2016 8:39 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 01/12] python tests: Skip python tests specific to Linux On 26 August 2016 at 07:40, Paul

Re: [ovs-dev] [PATCH 06/12] python tests: Fixed flake8 errors in daemon_unix

Hi Guru, I retested without this patch and indeed there is no flake error. For some reason it gave me some errors when I made the changes. I will get this changes out. Thanks, Paul From: Guru Shetty [mailto:g...@ovn.org] Sent: Friday, August 26, 2016 9:01 PM To: Paul Boca Cc: dev

Re: [ovs-dev] [PATCH 03/12] python tests: Ported UNIX sockets to Windows

Hi Guru, Thanks for suggestion. Paul From: Guru Shetty [mailto:g...@ovn.org] Sent: Friday, August 26, 2016 8:58 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 03/12] python tests: Ported UNIX sockets to Windows On 26 August 2016 at 07:40, Paul Boca <

[ovs-dev] [PATCH 12/12] at tests: Allow Python tests to be run on Windows

This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Paul-Daniel Boca --- tests/atlocal.in | 7 --- 1 file changed, 7 deletions(-) diff --git a/tests/atlocal.in b/tests/atlocal.in index 55070d8..6e744db 100644 ---

[ovs-dev] [PATCH 11/12] ovsdb-monitor: Skip monitor-cond tests on Windows

The ovsdb-client doesn't suport detach and listening on a local port on Windows. The --detach switch is ignored. Signed-off-by: Paul-Daniel Boca --- tests/ovsdb-monitor.at | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git

[ovs-dev] [PATCH 10/12] tunnel tests: Skip ipsec_gre tests on Windows

The ipsec feature is not implemented on windows. Signed-off-by: Paul-Daniel Boca --- tests/tunnel.at | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/tunnel.at b/tests/tunnel.at index 477517e..dbc6a11 100644 --- a/tests/tunnel.at +++ b/tests/tunnel.at

[ovs-dev] [PATCH 09/12] python tests: Skip ovn-controller-vtep tests on Windows

The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca --- tests/ovn-controller-vtep.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn-controller-vtep.at

[ovs-dev] [PATCH 08/12] python tests: Ignore stderr output

test-unixctl.py and test-vlog.py outputs on stderr and on Windows stderr is not overriden by every AT_CHECK call, the logs are only apended to the file and subsequent AT_CHECKs get errors from previous call. Signed-off-by: Paul-Daniel Boca --- tests/unixctl-py.at |

[ovs-dev] [PATCH 06/12] python tests: Fixed flake8 errors in daemon_unix

Fixed small alignement issues. Signed-off-by: Paul-Daniel Boca --- python/ovs/daemon_unix.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/python/ovs/daemon_unix.py b/python/ovs/daemon_unix.py index bd06195..0080677 100644 ---

[ovs-dev] [PATCH 07/12] python tests: Ported Python daemon to Windows

Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to

[ovs-dev] [PATCH 05/12] python tests: Implemented wrapper over daemon_unix.py

Implemented a wrapper over every function from daemon_unix. This will help on porting daemon to Windows. Signed-off-by: Paul-Daniel Boca --- python/automake.mk | 1 + python/ovs/daemon.py | 77 2 files

[ovs-dev] [PATCH 04/12] python tests: Rename daemon.py to daemon_unix.py

Prepare for porting unix daemon to Windows. Signed-off-by: Paul-Daniel Boca --- python/automake.mk | 2 +- python/ovs/{daemon.py => daemon_unix.py} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename python/ovs/{daemon.py =>

[ovs-dev] [PATCH 03/12] python tests: Ported UNIX sockets to Windows

AF_UNIX sockets are not supported on Windows. Instead of an AF_UNIX socket use named pipes to communicate between components. This makes the python sockets compatible with the named pipe used in Windows applications. Added stream_windows.py with named pipe and localhost tcp connections support.

[ovs-dev] [PATCH 02/12] python tests: Rename stream.py to stream_unix.py

Prepare for porting unix sockets to Windows named-pipes. Signed-off-by: Paul-Daniel Boca --- python/automake.mk | 2 +- python/ovs/jsonrpc.py| 14 +++--- python/ovs/{stream.py => stream_unix.py} | 0

[ovs-dev] [PATCH 00/12] Fixed Python tests for Windows

This series of patches ports python daemon and unixctl to Windows. All patches depend on each other. The the daemon was ported using pywin32 python library using Win32 API and unixctl was ported using named-pipes in order to be compatible with OVS Windows applications. Paul-Daniel Boca (12):

[ovs-dev] [PATCH 01/12] python tests: Skip python tests specific to Linux

There is a difference between POSIX pid and Windows pid, not all the time are equal. On Windows when a python script is started, a sh command is triggered as the parent for script. So when we try to get the daemon pid with 'echo $!', this will get the pid of sh not of python.exe as expected.

Re: [ovs-dev] [PATCH V11 08/17] python tests: Skip python tests on Windows where POSIX pid is used

Hi Guru! Indeed there are some cases where that comment doesn’t apply. Thanks for reporting this, I will update the comments accordingly. Paul From: Guru Shetty [mailto:g...@ovn.org] Sent: Wednesday, August 3, 2016 6:51 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH V11

Re: [ovs-dev] [PATCH V11 12/17] python tests: Prepare porting Python daemon on Windows

will include them in the commit description. I will resend this patch after I add [diff] renames = copies Thanks, Paul From: Guru Shetty [mailto:g...@ovn.org] Sent: Wednesday, August 3, 2016 7:07 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH V11 12/17] python tests: Prepare

[ovs-dev] [PATCH V11 17/17] tests: Skip vlog tests that try to move opened file

On Windows if a file is opened by an application for writing, we cannot move it until all handles to that file are closed. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No

[ovs-dev] [PATCH V11 16/17] python tests: Skip ovn-controller-vtep tests on Windows

The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: No changes

[ovs-dev] [PATCH V11 15/17] python tests: Ignore stderr output

test-unixctl.py and test-vlog.py outputs on stderr and on Windows stderr is not overriden by every AT_CHECK call, the logs are only apended to the file and subsequent AT_CHECKs get errors from previous call. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel

[ovs-dev] [PATCH V11 14/17] at tests: Allow Python tests to be run on Windows

This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes

[ovs-dev] [PATCH V11 13/17] python tests: Ported Python daemon to Windows

Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to

[ovs-dev] [PATCH V11 12/17] python tests: Prepare porting Python daemon on Windows

Renamed daemon.py to daemon_unix.py and implemented a wrapper over it. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V8: Initial commit. V9: No changes V10: Fixed exception on Unix V11: No changes ---

[ovs-dev] [PATCH V11 11/17] python tests: Ported UNIX sockets to Windows

AF_UNIX sockets are not supported on Windows. Instead of an AF_UNIX socket use localhost tcp connections to communicate between components. This makes the python sockets compatible with the ones used in Windows applications. In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN

[ovs-dev] [PATCH V11 08/17] python tests: Skip python tests on Windows where POSIX pid is used

There is a difference between POSIX pid and Windows pid, not all the time are equal. On Windows when a python script is started, a sh command is triggered as the parent for script. So when we try to get the daemon pid with 'echo $!', this will get the pid of sh not of python.exe as expected.

[ovs-dev] [PATCH V11 10/17] python tests: Fixed abs_file_name function for Windows

On windows a path containint ':' is considered an absolute path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No

[ovs-dev] [PATCH V11 06/17] python tests: Skip IPsec test on Windows

IPsec is not used on Windows yet, and the services used by this test are non-existent on Windows. Also the paths in the test do not exist on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes

[ovs-dev] [PATCH V11 09/17] python tests: Fixed OSError not iterable on Windows

On Windows if this exception is triggered then it will raise an exception while in the exception handler. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No

[ovs-dev] [PATCH V11 05/17] python tests: Added fcntl module for Windows

This is needed for lockf function used to lock the PID file on Windows. ioctl and fcntl functions are not implemented at this time because they are not used by any script. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean

[ovs-dev] [PATCH V11 07/17] python tests: Skip TCP6 idl tests on Windows

The IPPROTO_IPV6 is not defined on Python for Windows because of compatibility with older Windows versions. Here is this issue discussed:https://bugs.python.org/issue6926 Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean

[ovs-dev] [PATCH V11 04/17] python tests: Fixed unixctl python tests for Windows

For bogus pid file path, use a windows-like file path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes V9:

[ovs-dev] [PATCH V11 03/17] python tests: Fixed ctl file name for Windows

On Windows the CTL filename doesn't contain the pid of the process. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: Fixed flake8

[ovs-dev] [PATCH V11 02/17] python tests: Register signal handlers only on supported types on Windows

SIGHUP and SIGALRM are not available on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as EINPROGRESS on Windows V3: No changes

[ovs-dev] [PATCH V11 01/17] python tests: Implemented signal.alarm for Windows

signal.alarm is not available in Windows and would trigger an exception when called. Implemented this to mentain compatibility between Windows and Linux for python tests. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean

[ovs-dev] [PATCH V11 00/17] Fix and enable Python tests on Windows

This series of patches ports the python damons to Windows and fixes the tests to work on Windows. There are still some python tests that fail on Windows, from which some are failing on Linux too. The patches in this series are dependent and are related to python tests on Windows. V2: Fixes more

Re: [ovs-dev] Replication feature bug

. Thanks, Paul From: Cabrera Vega, Mario Alberto [mailto:mario.cabr...@hpe.com] Sent: Monday, August 1, 2016 8:08 PM To: Paul Boca Cc: dev@openvswitch.org Subject: RE: Replication feature bug Hi, The replication_init() function initializes the set that contains the names of the tables to be monitored

[ovs-dev] [PATCH V10 17/17] tests: Skip vlog tests that try to move opened file

On Windows if a file is opened by an application for writing, we cannot move it until all handles to that file are closed. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No

[ovs-dev] [PATCH V10 15/17] python tests: Ignore stderr output

test-unixctl.py and test-vlog.py outputs on stderr and on Windows stderr is not overriden by every AT_CHECK call, the logs are only apended to the file and subsequent AT_CHECKs get errors from previous call. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel

[ovs-dev] [PATCH V10 16/17] python tests: Skip ovn-controller-vtep tests on Windows

The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: No changes

[ovs-dev] [PATCH V10 12/17] python tests: Prepare porting Python daemon on Windows

Renamed daemon.py to daemon_unix.py and implemented a wrapper over it. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V8: Initial commit. V9: No changes V10: Fixed exception on Unix --- python/automake.mk

[ovs-dev] [PATCH V10 08/17] python tests: Skip python tests on Windows where POSIX pid is used

There is a difference between POSIX pid and Windows pid, not all the time are equal. On Windows when a python script is started, a sh command is triggered as the parent for script. So when we try to get the daemon pid with 'echo $!', this will get the pid of sh not of python.exe as expected.

[ovs-dev] [PATCH V10 10/17] python tests: Fixed abs_file_name function for Windows

On windows a path containint ':' is considered an absolute path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No

[ovs-dev] [PATCH V10 14/17] at tests: Allow Python tests to be run on Windows

This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes

[ovs-dev] [PATCH V10 11/17] python tests: Ported UNIX sockets to Windows

AF_UNIX sockets are not supported on Windows. Instead of an AF_UNIX socket use localhost tcp connections to communicate between components. This makes the python sockets compatible with the ones used in Windows applications. In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN

[ovs-dev] [PATCH V10 13/17] python tests: Ported Python daemon to Windows

Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to

[ovs-dev] [PATCH V10 05/17] python tests: Added fcntl module for Windows

This is needed for lockf function used to lock the PID file on Windows. ioctl and fcntl functions are not implemented at this time because they are not used by any script. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean

[ovs-dev] [PATCH V10 09/17] python tests: Fixed OSError not iterable on Windows

On Windows if this exception is triggered then it will raise an exception while in the exception handler. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No

[ovs-dev] [PATCH V10 06/17] python tests: Skip IPsec test on Windows

IPsec is not used on Windows yet, and the services used by this test are non-existent on Windows. Also the paths in the test do not exist on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes

[ovs-dev] [PATCH V10 07/17] python tests: Skip TCP6 idl tests on Windows

The IPPROTO_IPV6 is not defined on Python for Windows because of compatibility with older Windows versions. Here is this issue discussed:https://bugs.python.org/issue6926 Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean

[ovs-dev] [PATCH V10 03/17] python tests: Fixed ctl file name for Windows

On Windows the CTL filename doesn't contain the pid of the process. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: Fixed flake8

[ovs-dev] [PATCH V10 04/17] python tests: Fixed unixctl python tests for Windows

For bogus pid file path, use a windows-like file path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes V9:

[ovs-dev] [PATCH V10 02/17] python tests: Register signal handlers only on supported types on Windows

SIGHUP and SIGALRM are not available on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as EINPROGRESS on Windows V3: No changes

[ovs-dev] [PATCH V10 01/17] python tests: Implemented signal.alarm for Windows

signal.alarm is not available in Windows and would trigger an exception when called. Implemented this to mentain compatibility between Windows and Linux for python tests. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean

[ovs-dev] [PATCH V10 00/17] Fix and enable Python tests on Windows

This series of patches ports the python damons to Windows and fixes the tests to work on Windows. There are still some python tests that fail on Windows, from which some are failing on Linux too. The patches in this series are dependent and are related to python tests on Windows. V2: Fixes more

[ovs-dev] Replication feature bug

lob/master/ovsdb/ovsdb-server.c#L1451 If the replication is set using ovs-appctl, the replication is correctly initialized: https://github.com/openvswitch/ovs/blob/0cedc9dbc1e4d40f975617ccf4b63cb594783443/ovsdb/ovsdb-server.c#L1073 Thanks, Paul Boca ___ d

Re: [ovs-dev] [PATCH v2 4/4] datapath-windows: Fix VPORT when it is allocated by OVS

Acked-by: Paul Boca <pb...@cloudbasesolutions.com> > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Tuesday, July 26, 2016 6:45 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v2 4/4] datapath-wi

Re: [ovs-dev] [PATCH v2 3/4] windows: document multiple NIC support setup

Acked-by: Paul Boca <pb...@cloudbasesolutions.com> > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Tuesday, July 26, 2016 6:45 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v2 3/4] windows: document

Re: [ovs-dev] [PATCH v2 2/4] datapath-windows: Add multiple switch internal ports

Acked-by: Paul Boca <pb...@cloudbasesolutions.com> > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Tuesday, July 26, 2016 6:47 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v2 2/4] datapath-windows

Re: [ovs-dev] [PATCH] datapath-windows: Add Windows thread atomic APIs for x64 binaries.

m: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Paul Boca > Sent: Friday, July 8, 2016 6:25 PM > To: Ben Pfaff; Sorin Vinturis > Cc: dev@openvswitch.org; Guru Shetty > Subject: Re: [ovs-dev] [PATCH] datapath-windows: Add Windows thread > atomic APIs for x64 binaries. >

Re: [ovs-dev] [PATCH v2 1/4] windows: Add internal switch port per OVS bridge

Thanks for changes! Acked-by: Paul Boca <pb...@cloudbasesolutions.com> > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Tuesday, July 26, 2016 6:44 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH

[ovs-dev] [PATCH V9 16/17] python tests: Skip ovn-controller-vtep tests on Windows

The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: No changes

[ovs-dev] [PATCH V9 17/17] tests: Skip vlog tests that try to move opened file

On Windows if a file is opened by an application for writing, we cannot move it until all handles to that file are closed. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No

[ovs-dev] [PATCH V9 14/17] at tests: Allow Python tests to be run on Windows

This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes

[ovs-dev] [PATCH V9 13/17] python tests: Ported Python daemon to Windows

Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to

[ovs-dev] [PATCH V9 15/17] python tests: Ignore stderr output

test-unixctl.py and test-vlog.py outputs on stderr and on Windows stderr is not overriden by every AT_CHECK call, the logs are only apended to the file and subsequent AT_CHECKs get errors from previous call. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel

[ovs-dev] [PATCH V9 12/17] python tests: Prepare porting Python daemon on Windows

Renamed daemon.py to daemon_unix.py and implemented a wrapper over it. Signed-off-by: Paul-Daniel Boca --- V8: Initial commit. V9: No changes --- python/automake.mk| 1 + python/ovs/daemon.py | 489 ++

[ovs-dev] [PATCH V9 11/17] python tests: Ported UNIX sockets to Windows

AF_UNIX sockets are not supported on Windows. Instead of an AF_UNIX socket use localhost tcp connections to communicate between components. This makes the python sockets compatible with the ones used in Windows applications. In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN

[ovs-dev] [PATCH V9 10/17] python tests: Fixed abs_file_name function for Windows

On windows a path containint ':' is considered an absolute path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No

[ovs-dev] [PATCH V9 08/17] python tests: Skip python tests on Windows where POSIX pid is used

There is a difference between POSIX pid and Windows pid, not all the time are equal. On Windows when a python script is started, a sh command is triggered as the parent for script. So when we try to get the daemon pid with 'echo $!', this will get the pid of sh not of python.exe as expected.

[ovs-dev] [PATCH V9 09/17] python tests: Fixed OSError not iterable on Windows

On Windows if this exception is triggered then it will raise an exception while in the exception handler. Signed-off-by: Paul-Daniel Boca --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: Added comment when using

[ovs-dev] [PATCH V9 07/17] python tests: Skip TCP6 idl tests on Windows

The IPPROTO_IPV6 is not defined on Python for Windows because of compatibility with older Windows versions. Here is this issue discussed:https://bugs.python.org/issue6926 Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean

[ovs-dev] [PATCH V9 04/17] python tests: Fixed unixctl python tests for Windows

For bogus pid file path, use a windows-like file path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes V9:

[ovs-dev] [PATCH V9 05/17] python tests: Added fcntl module for Windows

This is needed for lockf function used to lock the PID file on Windows. ioctl and fcntl functions are not implemented at this time because they are not used by any script. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean

[ovs-dev] [PATCH V9 06/17] python tests: Skip IPsec test on Windows

IPsec is not used on Windows yet, and the services used by this test are non-existent on Windows. Also the paths in the test do not exist on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes

[ovs-dev] [PATCH V9 03/17] python tests: Fixed ctl file name for Windows

On Windows the CTL filename doesn't contain the pid of the process. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: Fixed flake8

[ovs-dev] [PATCH V9 02/17] python tests: Register signal handlers only on supported types on Windows

SIGHUP and SIGALRM are not available on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as EINPROGRESS on Windows V3: No changes

[ovs-dev] [PATCH V9 01/17] python tests: Implemented signal.alarm for Windows

signal.alarm is not available in Windows and would trigger an exception when called. Implemented this to mentain compatibility between Windows and Linux for python tests. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean

[ovs-dev] [PATCH V9 00/17] Fix and enable Python tests on Windows

This series of patches ports the python damons to Windows and fixes the tests to work on Windows. There are still some python tests that fail on Windows, from which some are failing on Linux too. The patches in this series are dependent and are related to python tests on Windows. V2: Fixes more

Re: [ovs-dev] [PATCH V8 00/17] Fix and enable Python tests on Windows

I will resend this series once again. I made a small mistake: " [PATCH V8 12/17] python tests: Ported Python daemon to Windows" should be 13/17. Thanks! > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Paul Boca > Sent: Tuesday, Ju

[ovs-dev] [PATCH V8 16/17] python tests: Skip ovn-controller-vtep tests on Windows

The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: No changes

[ovs-dev] [PATCH V8 17/17] tests: Skip vlog tests that try to move opened file

On Windows if a file is opened by an application for writing, we cannot move it until all handles to that file are closed. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No

  1   2   3   4   >