[ovs-dev] [PATCH] datapath: backport: vxlan: do not output confusing error message

2017-05-03 Thread Pravin B Shelar
g vxlan interface does not know. Signed-off-by: Jiri Benc <jb...@redhat.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/vxlan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/datapa

[ovs-dev] [PATCH] datapath: backport: vxlan: correctly handle ipv6.disable module parameter

2017-05-02 Thread Pravin B Shelar
ot;vxlan: support both IPv4 and IPv6 sockets in a single vxlan device") Signed-off-by: Jiri Benc <jb...@redhat.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/vxlan.c | 10 ++

[ovs-dev] [PATCH v2 2/3] routing-table: parse skb-mark from RTNETLINK msg

2017-01-24 Thread Pravin B Shelar
Keep track of skb-mark of given RTNL routing notification. This will be used by next commit. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> Acked-by: Jarno Rajahalme <ja...@ovn.org> --- lib/route-table.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/route-table.c

[ovs-dev] [PATCH v2 3/3] ovs-router: introduce pkt-mark.

2017-01-24 Thread Pravin B Shelar
OVS router is basically partial copy of linux kernel FIB. kernel routing table uses skb-mark along with usual routing parameters. Following patch brings in support for skb-mark to ovs-router so that we can lookup route for given skb-mark. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> ---

[ovs-dev] [PATCH v2 1/3] tunnel: Add support to configure ptk_mark

2017-01-24 Thread Pravin B Shelar
set skb-mark for given tunnel endpoint. OVS would set the mark according to the skb-mark option for all tunnel traffic including packets generated by vSwitchd like tunnel monitoring BFD packet. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- v1-v2: Handle zero egress_pkt_mark Adde

[ovs-dev] [PATCH v2 0/3] Tunnel: add support for packet marking

2017-01-24 Thread Pravin B Shelar
Following patch series adds support for setting packet mark for tunnel traffic. This allows better integration with linux networking stack. v1-v2: Fixed patch 1 an 3 according to comments from Jarno. Pravin B Shelar (3): tunnel: Add support to configure ptk_mark routing-table: parse skb-mark

[ovs-dev] [PATCH 3/3] ovs-router: introduce pkt-mark.

2016-12-28 Thread Pravin B Shelar
OVS router is basically partial copy of linux kernel FIB. kernel routing table use skb-mark along with usual routing parameters. Following patch brings in support for skb-mark to ovs-router so that we can lookup route according to flow skb-mark. Signed-off-by: Pravin B Shelar <pshe...@ovn.

[ovs-dev] [PATCH 2/3] routing-table: parse skb-mark from RTNETLINK msg

2016-12-28 Thread Pravin B Shelar
Keep track of skb-mark of given RTNL routing notification. This will be used by next commit. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- lib/route-table.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/route-table.c b/lib/route-table.c index 00f95e3..61c8cd8

[ovs-dev] [PATCH 0/3] Tunnel: add support for packet marking

2016-12-28 Thread Pravin B Shelar
Following patch series adds support for setting packet mark for tunnel traffic. This allows better integration with linux networking stack. Pravin B Shelar (3): tunnel: Add support to configure ptk_mark routing-table: parse skb-mark from RTNETLINK msg ovs-router: introduce pkt-mark. lib

[ovs-dev] [PATCH] netdev: Fix sockaddr cast warning.

2016-11-15 Thread Pravin B Shelar
ot;). Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- lib/netdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev.c b/lib/netdev.c index ad90ef6..ee9b461 100644 --- a/lib/netdev.c +++ b/lib/netdev.c @@ -1913,7 +1913,7 @@ netdev_get_addrs(const char

[ovs-dev] [PATCH v2] datapath: geneve: Handle vlan tag

2016-11-01 Thread Pravin B Shelar
The compat vlan code ignores vlan tag for inner packet on egress path. Following patch fixes this by inserting the tag for inner packet before tunnel encapsulation. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/geneve.c | 33 +++--

[ovs-dev] [PATCH] datapath: geneve: Handle vlan tag

2016-10-31 Thread Pravin B Shelar
The compat vlan code ignores vlan tag for inner packet on egress path. Following patch fixes this by inserting the tag for inner packet before tunnel encapsulation. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/geneve.c | 26 -- 1 file c

[ovs-dev] [PATCH v2] datapath: backport: vxlan: avoid using stale vxlan socket.

2016-10-31 Thread Pravin B Shelar
vxlan-xmit function which dereferences vxlan socket. Following patch uses RCU mechanism to avoid this situation. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --

[ovs-dev] [PATCH 3/3] lisp: avoid using stale lisp socket.

2016-10-29 Thread Pravin B Shelar
This patch is similar to earlier vxlan patch. Lisp device close operation frees lisp socket. This operation can race with lisp-xmit function which dereferences lisp socket. Following patch uses RCU mechanism to avoid this situation. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- da

[ovs-dev] [PATCH 2/3] datapath: backport: geneve: avoid using stale geneve socket.

2016-10-29 Thread Pravin B Shelar
frees geneve socket. This operation can race with geneve-xmit function which dereferences geneve socket. Following patch uses RCU mechanism to avoid this situation. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> Acked-by: John W. Linville <linvi...@tuxdriver.com> Si

[ovs-dev] [PATCH 1/3] datapath: backport: vxlan: avoid using stale vxlan socket.

2016-10-29 Thread Pravin B Shelar
vxlan-xmit function which dereferences vxlan socket. Following patch uses RCU mechanism to avoid this situation. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --

[ovs-dev] [PATCH v2] datapath: compat: tunnel: Check if device is UP.

2016-10-21 Thread Pravin B Shelar
+0x3a9/0x3c0 [] __sys_sendmsg+0x51/0x90 [] SyS_sendmsg+0x12/0x20 [] system_call_fastpath+0x16/0x1b Reported-by: Huanglili (lee) <huanglili.hu...@huawei.com> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- v1-v2: Use dev-kfree-skb() --- datapath/linux/compat/geneve.c

[ovs-dev] [PATCH] datapath: compat: tunnel: Check if device is UP.

2016-10-19 Thread Pravin B Shelar
+0x3a9/0x3c0 [] __sys_sendmsg+0x51/0x90 [] SyS_sendmsg+0x12/0x20 [] system_call_fastpath+0x16/0x1b Reported-by: Huanglili (lee) <huanglili.hu...@huawei.com> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/geneve.c | 6 ++ datapath/linux/compat/

[ovs-dev] [PATCH] testsuite: Ignore IPsec deprecation msg.

2016-09-26 Thread Pravin B Shelar
Fixes test failure seen due to the IPsec tunnel deprecation messages in test logs. Fixes: 9e9d0384910e ("openvswitch: deprecates support for IPsec tunnel port."). Reported-by: Joe Stringer <j...@ovn.org> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- tests/ofproto-m

[ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-25 Thread Pravin B Shelar
pipeline to set skb-mark and using xfrm to implement IPsec tunnels. xfrm can match on the skb-mark to encrypt selective tunnel traffic. VMware-BZ: 1710701 Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- This is targeted for OVS master branch only. --- NEWS

[ovs-dev] [PATCH] openvswitch: deprecates support for IPsec tunnel port.

2016-09-20 Thread Pravin B Shelar
OVS IPsec tunnel support has issues: 1. It only works for GRE. 2. only works on Debian. 3. It does not allow user to match on packet-mark on packet received on tunnel ports. This patch deprecates support for IPsec tunnel port. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> ---

[ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-20 Thread Pravin B Shelar
. This way user can use external daemon to manage IPsec tunnel traffic and stir it using skb-mark match action in OVS bridge. This patch deprecates support for IPsec tunnel port. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- NEWS| 2 ++ debian/changelog

[ovs-dev] [PATCH] datapath: compat: tunnels: Log error during initialization.

2016-09-15 Thread Pravin B Shelar
At present OVS compat tunneling can fail due to conflict with already loaded tunneling kernel module. In this case openvswitch kernel module loading fails silently. Following patch give more clues about what went wrong. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/

[ovs-dev] [PATCH] datapath: compat: geneve: use ovs specific device type for compat geneve module.

2016-09-12 Thread Pravin B Shelar
This allows openvswitch and geneve module co-exist kernel on newer kernels. Reported-by: Joe Stringer <j...@ovn.org> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/geneve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/

[ovs-dev] [PATCH] datapath: Add support for kernel 4.7

2016-08-22 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- .travis.yml| 1 + .travis/linux-build.sh | 12 FAQ.md | 2 +- NEWS | 2 +- acinclude.m4 | 4 ++-- 5 files changed, 17 insertions(+), 4 deletions(-) diff

[ovs-dev] [PATCH v2] datapath: compat: backport LCO optimization.

2016-08-17 Thread Pravin B Shelar
flare.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4 | 1 + datapath/linux/compat/gso.c | 12 ++-- datapath/linux/compat/inc

[ovs-dev] [PATCH 3/3] datapath: compat: gso: use sg and csum features for segmentation.

2016-08-15 Thread Pravin B Shelar
With use of LCO support we can finally enable SG and CSUM features for GSO backport. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/gso.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/datapath/linux/compat/gso.c b/datapath/linux/

[ovs-dev] [PATCH 1/3] datapath: compat: backport LCO optimization.

2016-08-15 Thread Pravin B Shelar
flare.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4 | 1 + datapath/linux/compat/gso.c | 6 -- datapath/linux/compat/inc

[ovs-dev] [PATCH 2/3] datapath: compat: handle_offloads: remove csum_help param.

2016-08-15 Thread Pravin B Shelar
we can remove it, and remove the code that was conditional upon it. Signed-off-by: Edward Cree <ec...@solarflare.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/include/net/ip_tun

[ovs-dev] [PATCH v2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-15 Thread Pravin B Shelar
giving the appearance that the tunnel vport creation completed successfully. Signed-off-by: Martynas Pumputis <martynas@weave.works> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@o

[ovs-dev] [PATCH 1/2] datapath: backport: OVS: Ignore negative headroom value

2016-08-12 Thread Pravin B Shelar
redhat.com> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1361414 Signed-off-by: Ian Wienand <iwien...@redhat.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/vport-internal_dev.c | 2 +-

[ovs-dev] [PATCH 2/2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-12 Thread Pravin B Shelar
giving the appearance that the tunnel vport creation completed successfully. Signed-off-by: Martynas Pumputis <martynas@weave.works> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@o

[ovs-dev] [PATCH] datapath: compat: keep skb mark across tunnel devices.

2016-08-11 Thread Pravin B Shelar
kbuff: Do not scrub skb mark within the same name space"). VMware-BZ: #1710701 Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4 | 2 -- datapath/linux/compat/include/linux/skbuff.h | 2 +- datapath/linux/compat/skbuff-openvswitch.c

[ovs-dev] [PATCH v2] datapath: compat: keep skb encapsulation zero on older kernel.

2016-08-11 Thread Pravin B Shelar
When using compat GSO there is no need to turn on skb encapsulation bit since OVS does not use any tunnel GSO functionality from the networking stack. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/gso.c | 7 +-- 1 file changed, 5 insertions(+), 2 del

[ovs-dev] [PATCH 2/3] datapath: compat: geneve: fix geneve_notify_add_rx_port()

2016-08-10 Thread Pravin B Shelar
Remove mutual exclusion between udp-gro registration and geneve receive port registration. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4 | 4 +++ datapath/linux/Modules.mk| 1 + datapath/linux/compat/ge

[ovs-dev] [PATCH 3/3] datapath: compat: vxlan: fix vxlan_notify_add_rx_port().

2016-08-10 Thread Pravin B Shelar
Same as earlier patch this fixes vxlan recieve offload implementation. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/vxlan.c | 43 +-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/datapath/linux/

[ovs-dev] [PATCH 1/3] datapath: compat: keep skb encapsulation zero on older kernel.

2016-08-10 Thread Pravin B Shelar
When using compat GSO there is no need to turn on skb encapsulation bit since OVS does not use any tunnel GSO functionality from the networking stack. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/ip_tunnels_core.c | 2 ++ 1 file changed, 2 insertions(+) diff

[ovs-dev] [PATCH 2/2] datapath: backport: net: vxlan: lwt: Use source ip address during route lookup.

2016-08-08 Thread Pravin B Shelar
off-by: Pravin B Shelar <pshe...@ovn.org> Acked-by: Jiri Benc <jb...@redhat.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/vxlan.c | 30 ++ 1 file changed,

[ovs-dev] [PATCH 1/2] datapath: backport: net: vxlan: lwt: Fix vxlan local traffic.

2016-08-08 Thread Pravin B Shelar
igned-off-by: Pravin B Shelar <pshe...@ovn.org> Acked-by: Jiri Benc <jb...@redhat.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/vxlan.c | 4 ++-- 1 file changed, 2 insertions(+

[ovs-dev] [PATCH 5/6] datapath: backport: geneve: fix max_mtu setting

2016-08-03 Thread Pravin B Shelar
pv6hdr), instead of sizeof(iphdr). Signed-off-by: Haishuang Yan <yanhaishu...@cmss.chinamobile.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/geneve.c | 9 +++-- 1 file changed, 7 in

[ovs-dev] [PATCH 4/6] datapath: backport: openvswitch: fix conntrack netlink event delivery

2016-08-03 Thread Pravin B Shelar
amuel.gauth...@6wind.com> Acked-by: Joe Stringer <j...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/conntrack.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff -

[ovs-dev] [PATCH 6/6] datapath: compat: gso: tighen checks for compat GSO code.

2016-08-03 Thread Pravin B Shelar
Few function can be compiled out for non GSO case. This patch make it bit cleaner to understand GSO compat code. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/gso.h| 2 +- datapath/linux/compat/include/net/udp_tunnel.h | 7 --- datapath

[ovs-dev] [PATCH 2/6] datapath: fix size of struct ovs_gso_cb

2016-08-03 Thread Pravin B Shelar
struct ovs_gso_cb is stored in skb->cd. avoid going beyond size of skb->cb. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/gso.c | 1 + datapath/linux/compat/gso.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/datapath/linux/co

[ovs-dev] [PATCH 3/6] datapath: compat: vxlan: fix udp-csum typo

2016-08-03 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/linux/compat/vxlan.c b/datapath/linux/compat/vxlan.c index 6d77527..836d96d 100644 --- a/datapath/linux/compat/vxlan.c +++ b/da

[ovs-dev] [PATCH 1/6] datapath: compat: Use udp-checksum function for compat case.

2016-08-03 Thread Pravin B Shelar
version. This is not bug, But it helps in code readability. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/include/net/udp.h | 2 +- datapath/linux/compat/udp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/linux/compat/i

[ovs-dev] [PATCH 5/6] datapath: compat: remove duplicate check.

2016-08-02 Thread Pravin B Shelar
The check for tunnel GSO packet is done at ip-handle-offloads. Remove same check from udp-handle-offloads. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/include/net/udp_tunnel.h | 4 1 file changed, 4 deletions(-) diff --git a/datapath/linux/compat/inclu

[ovs-dev] [PATCH 3/6] datapath: compat: cleanup ip-tunnels

2016-08-02 Thread Pravin B Shelar
Remove kernel version check related to unsupported kernel. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/ip_tunnels_core.c | 8 1 file changed, 8 deletions(-) diff --git a/datapath/linux/compat/ip_tunnels_core.c b/datapath/linux/compat/ip_tunnels_

[ovs-dev] [PATCH 6/6] datapath: Add support for kernel 4.7

2016-08-02 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- FAQ.md | 2 +- NEWS | 2 +- acinclude.m4 | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/FAQ.md b/FAQ.md index 40e3a22..cb9ef41 100644 --- a/FAQ.md +++ b/FAQ.md @@ -172,7 +172,7 @@ A: The following

[ovs-dev] [PATCH 4/6] datapath: compat: fix SKB_INIT_FILL_METADATA_DST definition

2016-08-02 Thread Pravin B Shelar
In case of OVS using compat fill metadata dst implementation we need to setup temperory dst. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/gso.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/linux/compat/gso.h b/datapath

[ovs-dev] [PATCH 2/6] datapath: compat: Use checksum offload for outer header.

2016-08-02 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/include/net/udp.h | 2 +- datapath/linux/compat/udp.c | 19 ++- datapath/linux/compat/udp_tunnel.c | 17 + 3 files changed, 4 insertions(+), 34 deletions(-) diff

[ovs-dev] [PATCH 1/6] datapath: compat: Detect GSO support at ovs configure

2016-08-02 Thread Pravin B Shelar
OVS turns on tunnel GSO backport statically for kernel older than 3.18. Some distributions kernels could backport tunnel GSO. To make use of device tunnel offload on such kernel detect the support at configure stage. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acincl

[ovs-dev] [PATCH 0/6] datapath: compatibility layer update.

2016-08-02 Thread Pravin B Shelar
Following patches brings in bug fixes and minor updates to compat layer. Last patch adds for latest released linux kernel support. Pravin B Shelar (6): datapath: compat: Detect GSO support at ovs configure datapath: compat: Use checksum offload for outer header. datapath: compat: cleanup ip

[ovs-dev] [PATCH branch-2.5] datapath: fix build failure.

2016-08-01 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/gso.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index 34e5b75..be41e6e 100644 --- a/datapath/linux/compat/gso.c +++ b/datapath/linux/

[ovs-dev] [PATCH v2 2/3] datapath: compat: unset skb encapsulation bit

2016-07-26 Thread Pravin B Shelar
t in case compat layer handles the packet. VMware-BZ: 1698877 Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/gso.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index 32790c3..3a73bcd 100644 --- a

[ovs-dev] [PATCH v2 0/3] datapath: tunneling fixes.

2016-07-26 Thread Pravin B Shelar
First two patches fixes to issues related to geneva and vxlan tunnel. Third patch is just code improvement. Pravin B Shelar (3): datapath: compat: fix udp checksum calculation datapath: compat: unset skb encapsulation bit datapath: compat: simplify ip_local_out(). acinclude.m4

[ovs-dev] [PATCH v2 1/3] datapath: compat: fix udp checksum calculation

2016-07-26 Thread Pravin B Shelar
In upstream linux kernel networking stack udp_set_csum() is called with only udp header applied but in case of compat layer it can be called with IP header. So following patch take the offset into account. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acincl

[ovs-dev] [PATCH v2 3/3] datapath: compat: simplify ip_local_out().

2016-07-26 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/gso.c | 82 ++--- 1 file changed, 33 insertions(+), 49 deletions(-) diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index 3a73bcd..fbbbc89

[ovs-dev] [PATCH] datapath: Add support for kernel 4.6

2016-07-25 Thread Pravin B Shelar
Most of patch iron out USE_UPSTREAM_TUNNEL case where datapath directly use upstream tunneling modules. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4 | 7 +++--- datapath/linux/compat/geneve.c | 4 ++-- datapath

[ovs-dev] [PATCH 3/3] datapath: compat: simplify ip_local_out().

2016-07-25 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/gso.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index 8368c6a..de9c8e1 100644 --- a/datapath/linux/compat/gso.c

[ovs-dev] [PATCH 2/3] datapath: compat: unset skb encapsulation bit

2016-07-25 Thread Pravin B Shelar
compat layer handles the packet. VMware-BZ: 1698877 Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/gso.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index 92f5441..8368c6a 100644 --- a/datapath/linux/

[ovs-dev] [PATCH 0/3] datapath: tunneling fixes.

2016-07-25 Thread Pravin B Shelar
First two patches fixes to issues related to geneva and vxlan tunnel. Third patch is just code improvement. Pravin B Shelar (3): datapath: compat: fix udp checksum calculation datapath: compat: unset skb encapsulation bit datapath: compat: simplify ip_local_out(). datapath/linux/compat

[ovs-dev] [PATCH 1/3] datapath: compat: fix udp checksum calculation

2016-07-25 Thread Pravin B Shelar
In upstream linux kernel networking stack udp_set_csum() is called with only udp header applied but in case of compat layer it can be called with IP header. So following patch take the offset into account. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/udp

[ovs-dev] [PATCH] datapath: Fix vxlan local traffic.

2016-07-20 Thread Pravin B Shelar
ed-off-by: Pravin B Shelar <pshe...@ovn.org> --- This patch is for testing only. I am planing on sending fix for upstream vxlan soon. --- datapath/linux/compat/vxlan.c | 71 ++- 1 file changed, 37 insertions(+), 34 deletions(-) diff --git a/datapath/

[ovs-dev] [PATCH] datapath: Add support for kernel 4.4

2016-07-18 Thread Pravin B Shelar
Most of changes are related to ip-fragment API and genetlink API changes. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- Fixed according to comments from Jesse. --- acinclude.m4 | 17 +++-- datapath/actions.c

[ovs-dev] [PATCH 1/8] datapath: Sync OVS recursive loop counter with upstream.

2016-07-17 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/actions.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/datapath/actions.c b/datapath/actions.c index abf7e3b..3f2ba4c 100644 --- a/datapath/actions.c +++ b/datapath/act

[ovs-dev] [PATCH 6/8] datapath: Add support for kernel 4.5

2016-07-17 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4| 8 ++-- datapath/linux/compat/include/linux/netdevice.h | 17 +++-- datapath/vport-netdev.c | 2 +- 3 files changed, 22 insertions(+), 5 del

[ovs-dev] [PATCH 5/8] datapath: Add support for kernel 4.4

2016-07-17 Thread Pravin B Shelar
Most of changes are related to ip-fragment API and genetlink API changes. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4 | 17 ++-- datapath/actions.c | 5 +++- datapath/data

[ovs-dev] [PATCH 0/8] datapath: Add support for latest kernel release.

2016-07-17 Thread Pravin B Shelar
This series contains patches to advance kernel datapath support for kernel upto 4.6. First three patches are from earlier series. Pravin B Shelar (8): datapath: Sync OVS recursive loop counter with upstream. datapath: genlmsg_new_unicast to genlmsg_new datapath: backport: allow output

[ovs-dev] [PATCH 8/8] travis: Update datapath target kernel list.

2016-07-17 Thread Pravin B Shelar
Update kernel list to latest stable release. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- .travis.yml | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 6c818cb..a46994d 100644 --- a/.travis.yml +++ b/.travis.yml @@

[ovs-dev] [PATCH 2/8] datapath: genlmsg_new_unicast to genlmsg_new

2016-07-17 Thread Pravin B Shelar
phal <f...@strlen.de> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4 | 1 - datapath/datapath.c | 22 -- datapath/lin

[ovs-dev] [PATCH 7/8] datapath: Add support for kernel 4.6

2016-07-17 Thread Pravin B Shelar
Most of patch iron out USE_UPSTREAM_TUNNEL case where datapath directly use upstream tunneling modules. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4 | 7 +++--- datapath/linux/compat/geneve.c | 4 ++-- datapath

[ovs-dev] [PATCH 4/8] dataoath: compat: Do not use upstream fill-meta-data function for compat tunnel

2016-07-17 Thread Pravin B Shelar
. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/dev-openvswitch.c | 2 +- datapath/linux/compat/geneve.c | 2 ++ datapath/linux/compat/include/linux/netdevice.h | 2 +- datapath/linux/compat/ip_gre.c | 2 ++ datapath/linux/

[ovs-dev] [PATCH 3/8] datapath: backport: allow output of MPLS packets on tunnel vports

2016-07-17 Thread Pravin B Shelar
by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jesse Gross <je...@kernel.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/flow_netlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

[ovs-dev] [PATCH 19/24] datapath: backport: ovs: do not allocate memory from offline numa node

2016-07-12 Thread Pravin B Shelar
kov <khlebni...@yandex-team.ru> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/flow_table.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

[ovs-dev] [PATCH 15/24] datapath: backport: ovs: propagate per dp max headroom to all vports

2016-07-12 Thread Pravin B Shelar
n said value changes, the underlying devs are notified via the ndo_set_rx_headroom method. This also increases the internal vports xmit performance. Signed-off-by: Paolo Abeni <pab...@redhat.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-b

[ovs-dev] [PATCH 16/24] datapath: backport: libnl: nla_put_be64(): align on a 64-bit area

2016-07-12 Thread Pravin B Shelar
added for nla_put_net64(). This function is removed in the next patch. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/flow_netlink.c

[ovs-dev] [PATCH 14/24] datapath: backport: ovs: use nla_put_u64_64bit()

2016-07-12 Thread Pravin B Shelar
et> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/datapath.c | 3 ++- datapath/linux/compat/include/net/netlink.h | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index bb6d33b..212ad

[ovs-dev] [PATCH 18/24] datapath: Move key memset to ovs_flow_key_extract_userspace()

2016-07-12 Thread Pravin B Shelar
Synchronize code with upstream ovs_nla_get_flow_metadata(). Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/flow.c | 2 ++ datapath/flow_netlink.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/datapath/flow.c b/datapath/flow.c index 4e6dfb2..3

[ovs-dev] [PATCH 13/24] datapath: backport: ovs: align nlattr properly when needed

2016-07-12 Thread Pravin B Shelar
Fixes: 8b32ab9e6ef1 ("ovs: use nla_put_u64_64bit()") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4

[ovs-dev] [PATCH 17/24] datapath: use PTR_ERR_OR_ZERO

2016-07-12 Thread Pravin B Shelar
Upstream commit: commit f35423c137b0e64155f52c166db1d13834a551f2 Author: Fabian Frederick <f...@skynet.be> openvswitch: use PTR_ERR_OR_ZERO Signed-off-by: Fabian Frederick <f...@skynet.be> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: D

[ovs-dev] [PATCH 10/24] datapath: backport: retain parsed IPv6 header fields in flow on error skipping extension headers

2016-07-12 Thread Pravin B Shelar
ackets with malformed extension headers. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/flow.c | 21 +++-- 1 file changed, 15 in

[ovs-dev] [PATCH 11/24] datapath: backport: allow output of MPLS packets on tunnel vports

2016-07-12 Thread Pravin B Shelar
by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jesse Gross <je...@kernel.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/flow_netlink.c | 3 --- 1 file changed, 3 deletions(-) diff --

[ovs-dev] [PATCH 12/24] datapath: backport: ovs: allow nl 'flow set' to use ufid without flow key

2016-07-12 Thread Pravin B Shelar
n <simon.hor...@netronome.com> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/datapath.c | 28 +--- 1 file changed, 17 insertions(+), 11

[ovs-dev] [PATCH 23/24] datapath: openvswitch: update checksum in {push, pop}_mpls

2016-07-12 Thread Pravin B Shelar
e type in the ethernet header. As suggested by Pravin Shelar. Cc: Pravin Shelar <pshe...@ovn.org> Fixes: 25cd9ba0abc0 ("openvswitch: Add basic MPLS support to kernel") Signed-off-by: Simon Horman <simon.hor...@netronome.com> Acked-by: Pravin B Shelar <

[ovs-dev] [PATCH 07/24] datapath: remove get_pcpu_ptr

2016-07-12 Thread Pravin B Shelar
There is no need to support old kernel so now we can use newer api to access per cpu data. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/actions.c | 4 ++-- datapath/linux/compat/include/linux/percpu.h | 6 -- 2 files changed, 2 insertions

[ovs-dev] [PATCH 20/24] datapath: backport: ovs: set name assign type of internal port

2016-07-12 Thread Pravin B Shelar
zhangshen...@cmss.chinamobile.com> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/vport-internal_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[ovs-dev] [PATCH 09/24] datapath: backport: openvswitch: allow management from inside user namespaces

2016-07-12 Thread Pravin B Shelar
uot;David S. Miller" <da...@davemloft.net> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin Shelar <pshe...@ovn.org> --- datapath/datapath.c | 20 ++--

[ovs-dev] [PATCH 06/24] datapath: Sync OVS recursive loop counter with upstream.

2016-07-12 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/actions.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/datapath/actions.c b/datapath/actions.c index ed44ead..3cd2922 100644 --- a/datapath/actions.c +++ b/datapath/act

[ovs-dev] [PATCH 21/24] datapath: internal-dev: set IFF_NO_QUEUE

2016-07-12 Thread Pravin B Shelar
Introduced by upstream commit 4272cc51a6d ("openvswitch: Convert to using IFF_NO_QUEUE"). Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/include/linux/netdevice.h | 6 ++ datapath/vport-internal_dev.c | 5 - 2 files change

[ovs-dev] [PATCH 00/24] datapath: various fixes and updates.

2016-07-12 Thread Pravin B Shelar
From: Pravin B Shelar <pshe...@nicira.com> Following patches brings in couple of fixes to recent tunneling changes. along with various other improvement and fixes. Pravin B Shelar (24): datapath: compat: clear skb IPCB block. datapath: tnl-segmentation: clone dst for each s

[ovs-dev] [PATCH 08/24] datapath: genlmsg_new_unicast to genlmsg_new

2016-07-12 Thread Pravin B Shelar
Use newer API which is consistent with upstream. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4 | 1 - datapath/datapath.c | 22 -- datapath/linux/compat/include/net/genetlink.h | 9 --

[ovs-dev] [PATCH 22/24] datapath: vxlan: enable zero checksum on recv.

2016-07-12 Thread Pravin B Shelar
partialy backport commit c868ee7063bdb5 ("lwt: fix rx checksum setting for lwt devices tunneling over ipv6"). Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/vport-vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/vport-vxlan.c

[ovs-dev] [PATCH 02/24] datapath: tnl-segmentation: clone dst for each segment.

2016-07-12 Thread Pravin B Shelar
Each skb segment needs a dst entry. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/gso.c | 5 + 1 file changed, 5 insertions(+) diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index 8812253..9d478f8 100644 --- a/datapath/linux/compat

[ovs-dev] [PATCH 04/24] datapath: compat: reset md_dst on recieve.

2016-07-12 Thread Pravin B Shelar
On transmit metadata dst is cleared, do same on recieve. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/geneve.c | 2 +- datapath/linux/compat/include/net/dst_metadata.h | 20 ++-- datapath/linux/compat/include/net/udp_tu

[ovs-dev] [PATCH 01/24] datapath: compat: clear skb IPCB block.

2016-07-12 Thread Pravin B Shelar
OVS compat ip_local_out/ip6_local_out clear out skb IPCB, we also need to do it for non compat version. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/gso.h | 16 1 file changed, 16 insertions(+) diff --git a/datapath/linux/compat/gso.h b/da

[ovs-dev] [PATCH 03/24] datapath: compat: Set OVS-GSO segment handler only for GSO packet.

2016-07-12 Thread Pravin B Shelar
This simplify OVS compat code where non gso packet can be directly sent to network stack. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/ip_tunnels_core.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/datapath/linux/

[ovs-dev] [PATCH 05/24] datapath: Use skb_postpush_rcsum()

2016-07-12 Thread Pravin B Shelar
Use kernel function to update checksum. Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4 | 1 + datapath/actions.c | 8 +++- datapath/linux/compat/include/linux/skbuff.h | 20 datapath

[ovs-dev] [PATCH] datapath: Fix ip tunnel compilation for newer kernel.

2016-07-11 Thread Pravin B Shelar
.@ovn.org> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/compat/include/net/ip_tunnels.h | 13 ++- datapath/linux/compat/include/net/udp_tunnel.h | 32 +++--- datapath/linux/compat/ip_tunnels_core.c| 7 ++ 3 files changed, 18

[ovs-dev] [PATCH v5 04/28] datapath: backport: net: add dst_cache support

2016-07-08 Thread Pravin B Shelar
ed-off-by: Paolo Abeni <pab...@redhat.com> Suggested-and-acked-by: Hannes Frederic Sowa <han...@stressinduktion.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- datapath/linux/Modules.mk

[ovs-dev] [PATCH v5 01/28] datapath: compat: Refactor egress tunnel info

2016-07-08 Thread Pravin B Shelar
("openvswitch: Fix egress tunnel info.") Signed-off-by: Pravin B Shelar <pshe...@ovn.org> --- acinclude.m4| 1 + datapath/actions.c | 18 +++--- datapath/datapath.c | 5 +- dat

  1   2   3   4   5   6   7   8   9   >