[ovs-dev] [PATCH v2] tests: Add test for later IPv6 fragments nw_proto=44

2022-07-08 Thread Rosemarie O'Riorden
and thus the wrong list of actions being applied to the packet. Therefore, OVS and the kernel must parse this field the same way to prevent this issue. OVS and the kernel both currently parse this field the same way for later IPv6 fragments, with nw_proto=44. Signed-off-by: Rosemarie O'Riorden --- v2

[ovs-dev] [PATCH] tests: Add test for later IPv6 fragments nw_proto=44

2022-07-08 Thread Rosemarie O'Riorden
and thus the wrong list of actions being applied to the packet. Therefore, OVS and the kernel must parse this field the same way to prevent this issue. OVS and the kernel both currently parse this field the same way for later IPv6 fragments, with nw_proto=44. Signed-off-by: Rosemarie O'Riorden

Re: [ovs-dev] [PATCH v4] ofproto-dpif-xlate: No clone when tunnel push is last action

2022-06-29 Thread Rosemarie O'Riorden
Hi Ilya, Thank you for reviewing my patch and suggesting a fix. It looks great to me. You can do as you said, and apply the changes to my patch. Rosemarie O'Riorden On 6/28/22 07:06, Ilya Maximets wrote: > On 6/3/22 17:31, Rosemarie O'Riorden wrote: >> When OVS sees a tu

[ovs-dev] [PATCH net] net: openvswitch: fix parsing of nw_proto for IPv6 fragments

2022-06-21 Thread Rosemarie O'Riorden
/en/latest/topics/design/#fragments Signed-off-by: Rosemarie O'Riorden --- net/openvswitch/flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c index 372bf54a0ca9..e20d1a973417 100644 --- a/net/openvswitch/flow.c +++ b/net/o

[ovs-dev] [PATCH v4] ofproto-dpif-xlate: No clone when tunnel push is last action

2022-06-03 Thread Rosemarie O'Riorden
, which is less efficient. Signed-off-by: Rosemarie O'Riorden --- v2: - Fixes tests that are affected by the change v3: - Adds support for hardware offloading v4: - Adds negative check in test - Fixes logic in function native_tunnel_output - Stylistic and organizational improvements lib

[ovs-dev] [PATCH v3] ofproto-dpif-xlate: No clone when tunnel push is last action

2022-05-19 Thread Rosemarie O'Riorden
, which is less efficient. Signed-off-by: Rosemarie O'Riorden --- v2: - Fixes tests that are affected by the change v3: - Adds support for hardware offloading lib/netdev-offload-dpdk.c | 36 +-- lib/netlink.c | 4 +- lib/netlink.h | 2 +- ofproto

[ovs-dev] [PATCH v2] tests: Properly kill ovsdb test processes

2022-05-10 Thread Rosemarie O'Riorden
d2 ("ovsdb: relay: Add support for transaction forwarding.") Fixes: e879d33e83 ("ovsdb/jsonrpc-server: ovsdb-server closes accepted connections immediately.") Fixes: 7ed9240836 ("ovsdb-client: Move ovsdb-client specific tests to new .at file.") Signed-off-by: Ros

[ovs-dev] [PATCH] tests: Properly kill test processes

2022-05-10 Thread Rosemarie O'Riorden
The FreeBSD CI builds keep timing out and failing because processes of tests are not properly killed. Signed-off-by: Rosemarie O'Riorden --- tests/ovsdb-server.at | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/tests/ovsdb-server.at b/tests

[ovs-dev] [PATCH] dpif-netdev: Replace loop iterating over packet batch with macro.

2022-04-26 Thread Rosemarie O'Riorden
BATCH is dereferenced allows the macro to expand properly. Parenthesizing arguments in macros is good practice to be able to handle whichever expressions are passed in. Signed-off-by: Rosemarie O'Riorden --- lib/dp-packet.h | 4 ++-- lib/dpif-netdev.c | 4 ++-- 2 files changed, 4 insertions

Re: [ovs-dev] [PATCH v2 1/3] ofproto-dpif-xlate: No clone when tunnel push is last action

2022-04-14 Thread Rosemarie O'Riorden
Hi Tao, Thank you for looking at my patch. Could you let me know where you saw this error so I can look into it? I didn't see any failed tests. Thanks, Rosemarie On Wed, Apr 13, 2022 at 10:44 PM Tao Liu wrote: > > On Wed, Apr 13, 2022 at 05:30:19PM -0400, Rosemarie O'Riorden wrote: &g

[ovs-dev] [PATCH] cirrus: Update FreeBSD versions.

2022-04-13 Thread Rosemarie O'Riorden
Updated 12.2 to 12.3 and 11.4 to 13.0. 'pkg update' fails on 12.2. 11.4 has reached end of life. Signed-off-by: Rosemarie O'Riorden --- .cirrus.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index a7ae793bc..a4d2a5bbc 100644

Re: [ovs-dev] [PATCH v2 1/3] ofproto-dpif-xlate: No clone when tunnel push is last action

2022-04-13 Thread Rosemarie O'Riorden
Please disregard the "1/3" in the title; it is an error. This is just a single patch. Rosemarie O'Riorden On 4/13/22 17:30, Rosemarie O'Riorden wrote: > When OVS sees a tunnel push with a nested list next, it will not > clone the packet, as a clone is not needed. However

[ovs-dev] [PATCH v2 1/3] ofproto-dpif-xlate: No clone when tunnel push is last action

2022-04-13 Thread Rosemarie O'Riorden
, which is less efficient. Signed-off-by: Rosemarie O'Riorden --- v2: - Fixes tests that are affected by this change ofproto/ofproto-dpif-xlate.c | 15 -- tests/nsh.at | 6 +-- tests/packet-type-aware.at| 24 - tests/tunnel-push-pop-ipv6.at | 20 tests

[ovs-dev] [PATCH] ofproto-dpif-xlate: No clone when tunnel push is last action

2022-04-12 Thread Rosemarie O'Riorden
, which is less efficient. Signed-off-by: Rosemarie O'Riorden --- ofproto/ofproto-dpif-xlate.c | 15 - tests/tunnel-push-pop.at | 43 2 files changed, 53 insertions(+), 5 deletions(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto

Re: [ovs-dev] [PATCH v2] netdev:clear out vlan flow fields while processing native tunnel

2022-04-06 Thread Rosemarie O'Riorden
ped unrelated changes. > > > ofproto/ofproto-dpif-xlate.c | 3 ++ > > tests/system-traffic.at | 54 > > I see you added a system test. That is OK, good to have one. > However, the issue doesn't require any actual network to be >

[ovs-dev] [PATCH v2] AUTHORS: Update email for Rosemarie O'Riorden.

2022-03-29 Thread Rosemarie O'Riorden
Signed-off-by: Rosemarie O'Riorden --- .mailmap| 1 + AUTHORS.rst | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 6cefe3cd4..4773c4a24 100644 --- a/.mailmap +++ b/.mailmap @@ -72,6 +72,7 @@ Robert Åkerblom-Andersson Romain Lenglet

[ovs-dev] [PATCH] AUTHORS: Update email for Rosemarie O'Riorden.

2022-03-29 Thread Rosemarie O'Riorden
--- .mailmap| 1 + AUTHORS.rst | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 6cefe3cd4..4773c4a24 100644 --- a/.mailmap +++ b/.mailmap @@ -72,6 +72,7 @@ Robert Åkerblom-Andersson Romain Lenglet Romain Lenglet +Rosemarie O'Riorden

[ovs-dev] [PATCH v2] json: Improve string parsing

2022-03-29 Thread Rosemarie O'Riorden
and S is probability (%) to be a special character ( < 32). Signed-off-by: Rosemarie O'Riorden --- Adds a local counter so p->start is no longer needed Moves contents of json_lex_input into json_parser_feed Adds function json_parser_account_byte Performs copy when parser state equals done lib/j

Re: [ovs-dev] [PATCH] json: Improve json parsing

2022-03-22 Thread Rosemarie O'Riorden
gt; > +json_lex_input(p, space); > > This can be: > > p->start = " "; > json_lex_input(p, " "); > I've updated this the way you suggested. Thank you, Rosemarie O'Riorden On Thu, Mar 3, 2022 at 11:14 AM Dumitru Ceara wrote: > > Hi Rosemarie,

[ovs-dev] [PATCH] json: Improve json parsing

2022-02-28 Thread Rosemarie O'Riorden
821.850 ms -30.0 % Here Q is probability (%) for a character to be a '\"' and S is probability (%) to be a special character ( < 32). Signed-off-by: Rosemarie O'Riorden --- lib/json.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/lib/

[ovs-dev] [PATCH] dpdk: Use --in-memory by default.

2021-08-06 Thread Rosemarie O'Riorden
ull of old memory. Here is an example of these crashes: https://inbox.dpdk.org/dev/20200910162407.12669-1-david.march...@redhat.com/ Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949849 Signed-off-by: Rosemarie O'Riorden --- NEWS | 1 + acinclude.m4 | 6 ++ lib/dpdk.c | 7

[ovs-dev] [PATCH v3 2/3] dpdk: Remove default values for socket-mem and limit.

2021-07-15 Thread Rosemarie O'Riorden
this change and fixed documentation. Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949850 Signed-off-by: Rosemarie O'Riorden --- Version 2: - Removes logs added in patch 1 that were not in v1. - Removes code added to lib/dpdk.c since v1 that conflicts with this patch series. Version 3

[ovs-dev] [PATCH v3 3/3] dpdk: Stop configuring socket-limit with the value of socket-mem.

2021-07-15 Thread Rosemarie O'Riorden
, the user can decide to set it or have no memory limit. Removed logs that announce this change and fixed documentation. Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949850 Signed-off-by: Rosemarie O'Riorden --- Version 1: - Removes logs added in patch 1 that were not in v1

[ovs-dev] [PATCH v3 1/3] dpdk: Logs to announce removal of defaults for socket-mem and limit.

2021-07-15 Thread Rosemarie O'Riorden
Deprecate current OVS provided defaults for DPDK socket-mem and socket-limit that are planned to be removed in OVS 2.17. At that point DPDK defaults will be used instead. Warnings have been added to alert users in advance. Signed-off-by: Rosemarie O'Riorden --- Version 3: - Fixed typo

[ovs-dev] [PATCH v3 0/3] Stop configuring '--socket-mem'/'--socket-limit' by default for DPDK if not requested.

2021-07-15 Thread Rosemarie O'Riorden
=1024,1024 --socket-limit=LIMIT" patch 1: "--socket-limit=LIMIT" patch 2: "--socket-limit=LIMIT" - dpdk-socket-mem=, dpdk-socket-limit= current: "--socket-mem=MEM --socket-limit=LIMIT" patch 1: "--socket-mem=MEM --socket-limit=LIMIT" patch 2: "

[ovs-dev] [PATCH v2 3/3] dpdk: Stop configuring socket-limit with the value of socket-mem.

2021-07-13 Thread Rosemarie O'Riorden
, the user can decide to set it or have no memory limit. Removed logs added in patch 1 that announce this change. Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949850 Signed-off-by: Rosemarie O'Riorden --- Removes logs added in patch 1 that were not in v1. NEWS | 2

[ovs-dev] [PATCH v2 2/3] dpdk: Remove default values for socket-mem and limit.

2021-07-13 Thread Rosemarie O'Riorden
that announce this change. Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949850 Signed-off-by: Rosemarie O'Riorden --- Removes logs added in patch 1 that were not in v1. Removes code added to lib/dpdk.c since v1 that conflicts with this patch series. Documentation/intro/install/dpdk.rst

[ovs-dev] [PATCH v2 1/3] dpdk: Logs to announce removal of defaults for socket-mem and limit.

2021-07-13 Thread Rosemarie O'Riorden
As the changes of patch 2 and 3 will be applied for the 2.17 release, warnings have been added to alert users in advance. Signed-off-by: Rosemarie O'Riorden --- Documentation/intro/install/dpdk.rst | 3 ++- NEWS | 2 ++ lib/dpdk.c | 11

[ovs-dev] [PATCH v2 0/3] Stop configuring '--socket-mem'/'--socket-limit' by default for DPDK if not requested.

2021-07-13 Thread Rosemarie O'Riorden
=1024,1024 --socket-limit=LIMIT" patch 1: "--socket-limit=LIMIT" patch 2: "--socket-limit=LIMIT" - dpdk-socket-mem=, dpdk-socket-limit= current: "--socket-mem=MEM --socket-limit=LIMIT" patch 1: "--socket-mem=MEM --socket-limit=LIMIT" patch 2: "

[ovs-dev] [PATCH 2/2] dpdk: Stop configuring socket-limit with the value of socket-mem.

2021-06-30 Thread Rosemarie O'Riorden
From: Rosemarie O'Riorden This change removes the automatic memory limit on start-up of OVS with DPDK. As DPDK supports dynamic memory allocation, there is no need to limit the amount of memory available, if not requested. Currently, if socket-limit is not configured, it is set to the value

[ovs-dev] [PATCH 1/2] dpdk: Remove default values for socket-mem and limit.

2021-06-30 Thread Rosemarie O'Riorden
From: Rosemarie O'Riorden This change removes the default values for EAL args socket-mem and socket-limit. As DPDK supports dynamic memory allocation, there is no need to allocate a certain amount of memory on start-up, nor limit the amount of memory available, if not requested. Currently

[ovs-dev] [PATCH 0/2] Stop configuring '--socket-mem'/'--socket-limit' by default for DPDK if not requested.

2021-06-30 Thread Rosemarie O'Riorden
From: Rosemarie O'Riorden Currently, there is a default value of 1024 for socket-mem if not configured. socket-limit automatically takes on the value of socket-mem unless otherwise specified. With these changes, memory allocation will be dynamically managed by DPDK, meaning that by default

[ovs-dev] [PATCH v4] Remove Python 2 leftovers.

2021-06-15 Thread Rosemarie O'Riorden
Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949875 Signed-off-by: Rosemarie O'Riorden --- Version 2: - Fixed import errors in v1. - Removed lines that indicate compatibility with python 2.

[ovs-dev] [PATCH v3] Remove Python 2 leftovers.

2021-06-14 Thread Rosemarie O'Riorden
Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949875 Signed-off-by: Rosemarie O'Riorden --- Version 2: - Fixed import errors in v1. - Removed lines that indicate compatibility with python 2.

[ovs-dev] [PATCH] Add missing argument in function call.

2021-06-10 Thread Rosemarie O'Riorden
This syntax error caused the script to crash. With the use of the correct argument in the function call, it runs and prints what is expected. Signed-off-by: Rosemarie O'Riorden --- ofproto/ipfix-gen-entities | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ipfix-gen

[ovs-dev] [PATCH v2 2/2] AUTHORS: Add Rosemarie O'Riorden.

2021-06-09 Thread Rosemarie O'Riorden
Signed-off-by: Rosemarie O'Riorden --- AUTHORS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index dbc3bde44..6c7f9efdb 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -344,6 +344,7 @@ Roi Dayan r...@nvidia.com Róbert Mulik

[ovs-dev] [PATCH v2 1/2] Remove Python 2 leftovers.

2021-06-09 Thread Rosemarie O'Riorden
Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949875 Signed-off-by: Rosemarie O'Riorden --- Fix import errors in v1. Remove lines that indicate compatibility with python 2. ofproto/ipfix-ge

[ovs-dev] [PATCH] Remove Python 2 leftovers.

2021-06-07 Thread Rosemarie O'Riorden
Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949875 Signed-off-by: Rosemarie O'Riorden --- python/ovstest/tests.py | 4 +--- python/ovstest/util.py | 2 +- pytho

[ovs-dev] photos

2016-08-31 Thread Rosemarie
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev