[ovs-dev] [PATCH v4] ovn-controller: add quiet mode

alculation to be performed. It does this by persisting a copy of the localvif_to_ofport and tunnel information in the controller module, rather than in the physical.c module as was the case with previous commits. [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan

Re: [ovs-dev] [ovs-dev,v2,2/4] ovn-controller: add quiet mode

"dev" <dev-boun...@openvswitch.org> wrote on 10/05/2016 01:19:34 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: Ben Pfaff <b...@ovn.org> > Cc: dev@openvswitch.org > Date: 10/05/2016 01:20 PM > Subject: Re: [ovs-dev] [ovs-dev,v2,2/4] ovn-controller: add

[ovs-dev] [PATCH] ovn-controller: honor ovs_idl_txn when calculating and installing flows.

ovs_idl_txn is checked before various routines (like patch_run) execute. However, flow calculation and installation does not also check this variable, which can lead to oscillations as described in [1]. [1] http://openvswitch.org/pipermail/dev/2016-October/080247.html Signed-off-by: Ryan Moats

Re: [ovs-dev] [ovs-dev,v2,2/4] ovn-controller: add quiet mode

Ben Pfaff <b...@ovn.org> wrote on 10/05/2016 01:04:36 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 10/05/2016 01:04 PM > Subject: Re: [ovs-dev,v2,2/4] ovn-controller: add quiet mode > > On Wed, Oct 05, 201

Re: [ovs-dev] [ovs-dev,v2,2/4] ovn-controller: add quiet mode

Ben Pfaff <b...@ovn.org> wrote on 10/05/2016 12:37:26 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 10/05/2016 12:37 PM > Subject: Re: [ovs-dev,v2,2/4] ovn-controller: add quiet mode > > On Tue, Oct 04, 201

[ovs-dev] [PATCH v3] ovn-controller: add quiet mode

alculation to be performed. It does this by persisting a copy of the localvif_to_ofport and tunnel information in the controller module, rather than in the physical.c module as was the case with previous commits. [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan

Re: [ovs-dev] [ovs-dev,v2,2/4] ovn-controller: add quiet mode

Ben Pfaff <b...@ovn.org> wrote on 10/04/2016 12:14:32 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 10/04/2016 12:14 PM > Subject: Re: [ovs-dev,v2,2/4] ovn-controller: add quiet mode > > On Wed, Aug 31, 201

[ovs-dev] [PATCH] ofproto-dpif-xlate: Fix memory leak in execute_controller_action.

ue is only seen in the master branch. Fixes: df70a7731 ("ofproto-dpif-xlate: Allow translating without side-effects.") Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ofproto/ofproto-dpif-xlate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ofproto/ofproto-dpif-xlate.c b/of

[ovs-dev] [PATCH] ovn-nbctl, tests: Clean up noisy memory leaks

When run with valgrind, ovn-nbctl.c and tests/test-ovn.c reveal memory leaks of their own. This patch cleans these up so that they don't create noise when looking for leaks in the OVN daemon processes. Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/utilities/ovn-nbctl.c | 1 + test

Re: [ovs-dev] [PATCH] ovn-controller: Fix match crieria for dynamic mac binding flows

Chandra Sekhar Vejendla/San Jose/IBM@IBMUS wrote on 09/02/2016 02:34:35 PM: > From: Chandra Sekhar Vejendla/San Jose/IBM@IBMUS > To: dev@openvswitch.org > Cc: Chandra Sekhar Vejendla/San Jose/IBM@IBMUS, Ryan Moats/Omaha/IBM@IBMUS > Date: 09/02/2016 02:35 PM > Subject: [PATCH]

Re: [ovs-dev] [PATCH] ovn: fix ovn-northd leaks in build_acl

"dev" wrote on 08/19/2016 08:06:50 PM: > From: Ramu Ramamurthy > To: dev@openvswitch.org > Cc: Suryanarayan Ramamurthy/San Jose/IBM@IBMUS > Date: 08/19/2016 08:07 PM > Subject: [ovs-dev] [PATCH] ovn: fix ovn-northd leaks in build_acl >

Re: [ovs-dev] [PATCH] ovn-controller: Fix memory leak in recv_S_TLV_TABLE_REQUESTED().

Ben Pfaff <b...@ovn.org> wrote on 09/01/2016 12:02:53 PM: > From: Ben Pfaff <b...@ovn.org> > To: dev@openvswitch.org > Cc: Ben Pfaff <b...@ovn.org>, Ryan Moats/Omaha/IBM@IBMUS > Date: 09/01/2016 12:04 PM > Subject: [PATCH] ovn-controller: Fix memory lea

[ovs-dev] [PATCH] Fix leak in patched_datapaths processing.

When unpersisting patch_datapaths, missed that the key field needed to be freed to avoid a memory leak. This patch fixes same. Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/controller/ovn-controller.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovn/controller/ovn-controll

[ovs-dev] [PATCH] Close memory leak when processing S_TLV_TABLE_REQUESTED.

pings (ofp-util.c:10077) by 0x472A3A: ofputil_decode_tlv_table_reply (ofp-util.c:10159) by 0x40C2B1: recv_S_TLV_TABLE_REQUESTED (ofctrl.c:209) by 0x40C2B1: ofctrl_run (ofctrl.c:471) by 0x406C8F: main (ovn-controller.c:439) Signed-off-by: Ryan Moats <rmo...@us.ibm.com> ---

Re: [ovs-dev] [PATCH] ovn-controller: Convert encaps module back to full processing

Ben Pfaff <b...@ovn.org> wrote on 08/31/2016 04:26:37 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev <dev@openvswitch.org>, Jesse Gross <je...@kernel.org> > Date: 08/31/2016 04:26 PM > Subject: Re: [ovs-dev] [PATCH] ovn-c

Re: [ovs-dev] [ovs-dev, v2, 3/4] Unpersist data structures for address sets.

Ben Pfaff <b...@ovn.org> wrote on 08/31/2016 02:45:36 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/31/2016 02:45 PM > Subject: Re: [ovs-dev] [ovs-dev, v2,3/4] Unpersist data structures > for address

Re: [ovs-dev] [ovs-dev, v2, 3/4] Unpersist data structures for address sets.

"dev" <dev-boun...@openvswitch.org> wrote on 08/31/2016 12:53:27 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: Ben Pfaff <b...@ovn.org> > Cc: dev@openvswitch.org > Date: 08/31/2016 12:53 PM > Subject: Re: [ovs-dev] [ovs-dev, v2, 3/4] Unpersist data structure

Re: [ovs-dev] [PATCH] ovn-controller: Convert encaps module back to full processing

Ben Pfaff <b...@ovn.org> wrote on 08/31/2016 12:46:17 PM: > From: Ben Pfaff <b...@ovn.org> > To: Jesse Gross <je...@kernel.org> > Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev <dev@openvswitch.org> > Date: 08/31/2016 12:46 PM > Subject: Re: [ovs-dev] [PATCH] ovn-c

Re: [ovs-dev] [ovs-dev, v2, 3/4] Unpersist data structures for address sets.

Ben Pfaff <b...@ovn.org> wrote on 08/31/2016 12:38:34 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/31/2016 12:38 PM > Subject: Re: [ovs-dev,v2,3/4] Unpersist data structures for address sets. > > O

[ovs-dev] [PATCH v2 4/4] ovn-controller: Convert encaps module back to full processing

This patch converts the encaps module back to full processing, but does not remove all persistence of associated data strcutures. Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/controller/encaps.c | 33 ++--- 1 file changed, 14 insertions(+), 19 del

[ovs-dev] [PATCH v2 3/4] Unpersist data structures for address sets.

With the removal of incremental processing, it is no longer necessary to persist the data structures for storing address sets. Simplify things by removing this complexity. Side effect: fixed a memory leak in expr_macros_destroy that is evidenced by this change. Signed-off-by: Ryan Moats <

[ovs-dev] [PATCH v2 2/4] ovn-controller: add quiet mode

alculation to be performed. It does this by persisting a copy of the localvif_to_ofport and tunnel information in the controller module, rather than in the physical.c module as was the case with previous commits. [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan

[ovs-dev] [PATCH v2 1/4] ovn-controller: Back out incremental processing

/controller/lflow.c module. [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- include/ovn/actions.h | 4 - ovn/controller/binding.c| 154 ++ ovn/controller/binding.h| 1 - ovn/cont

[ovs-dev] [PATCH v2 0/4] ovn-controller: Replace incremental processing with quiet mode

in the encaps.c module - it's not clear how to revert that while still maintaining 100% unit test pass. v1->v2: removed poll_immediate_wake() from encaps.c that will lead to ovn-controller pegging a cpu. Ryan Moats (4): ovn-controller: Back out incremental processing ovn-controller: add quiet m

[ovs-dev] [PATCH 3/4] Unpersist data structures for address sets.

("ovn-controller: Back out incremental processing"). Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/controller/lflow.c | 166 - ovn/lib/expr.c | 1 + 2 files changed, 42 insertions(+), 125 deletions(-) diff --git

[ovs-dev] [PATCH 4/4] ovn-controller: Convert encaps module back to full processing

16cb ("ovn-controller: Back out incremental processing"). Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/controller/encaps.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/ovn/controller/encaps.c b/ovn/controller/encap

[ovs-dev] [PATCH 2/4] ovn-controller: add quiet mode

ng"). [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/controller/ofctrl.c | 2 + ovn/controller/ovn-controller.c | 73 - ovn/controller/ovn-controller.h | 1 + ovn/controller/patch.c

[ovs-dev] [PATCH 1/4] ovn-controller: Back out incremental processing

/lflow.c module. [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- include/ovn/actions.h | 4 - ovn/controller/binding.c| 154 ++ ovn/controller/binding.h| 1 - ovn/controller/en

[ovs-dev] [PATCH 0/4] ovn-controller: Replace incremental processing with quiet mode

in the encaps.c module - it's not clear how to revert that while still maintaining 100% unit test pass. Note: these patches previously existed as individually versioned patches. There is no change from v7, v4, v1, and v1 (in order). Ryan Moats (4): ovn-controller: Back out incremental processing ovn

Re: [ovs-dev] patch series

Ben Pfaff <b...@ovn.org> wrote on 08/30/2016 05:05:14 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/30/2016 05:05 PM > Subject: patch series > > It looks like you have 4 separate patches that are c

Re: [ovs-dev] [PATCH] ovn-controller: Convert encaps module back to full processing

Ryan Moats/Omaha/IBM@IBMUS wrote on 08/28/2016 05:51:38 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: dev@openvswitch.org > Cc: b...@ovn.org, Ryan Moats/Omaha/IBM@IBMUS > Date: 08/28/2016 05:51 PM > Subject: [PATCH] ovn-controller: Convert encaps module back to full proces

Re: [ovs-dev] [PATCH] Unpersist data structures for address sets.

Ryan Moats/Omaha/IBM@IBMUS wrote on 08/28/2016 05:51:02 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: dev@openvswitch.org > Cc: b...@ovn.org, Ryan Moats/Omaha/IBM@IBMUS > Date: 08/28/2016 05:51 PM > Subject: [PATCH] Unpersist data structures for address sets. > > With the r

[ovs-dev] [PATCH] Unpersist data structures for address sets.

("ovn-controller: Back out incremental processing"). Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/controller/lflow.c | 166 - ovn/lib/expr.c | 1 + 2 files changed, 42 insertions(+), 125 deletions(-) diff --git

[ovs-dev] [PATCH] ovn-controller: Convert encaps module back to full processing

16cb ("ovn-controller: Back out incremental processing"). Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/controller/encaps.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/ovn/controller/encaps.c b/ovn/controller/encap

[ovs-dev] [PATCH] Unpersist data structures for address sets.

("ovn-controller: Back out incremental processing"). Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/controller/lflow.c | 166 - ovn/lib/expr.c | 1 + 2 files changed, 42 insertions(+), 125 deletions(-) diff --git

Re: [ovs-dev] [PATCH v3] ovn-controller: add quiet mode

Ben Pfaff <b...@ovn.org> wrote on 08/27/2016 11:45:57 AM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/27/2016 11:46 AM > Subject: Re: [PATCH v3] ovn-controller: add quiet mode > > On Fri, Aug 26, 2016 at 0

[ovs-dev] [PATCH v7] ovn-controller: Back out incremental processing

/lflow.c module. [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- v6->v7: corrected a memory leak found during follow-on patch testing include/ovn/actions.h | 4 - ovn/controller/binding.c

[ovs-dev] [PATCH v4] ovn-controller: add quiet mode

ng"). [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/controller/ofctrl.c | 2 + ovn/controller/ovn-controller.c | 73 - ovn/controller/ovn-controller.h | 1 + ovn/controller/patch.c

Re: [ovs-dev] [PATCH v3] ovn-controller: add quiet mode

Ryan Moats/Omaha/IBM@IBMUS wrote on 08/26/2016 04:36:20 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: dev@openvswitch.org > Cc: b...@ovn.org, Ryan Moats/Omaha/IBM@IBMUS > Date: 08/26/2016 04:36 PM > Subject: [PATCH v3] ovn-controller: add quiet mode > > As discussed in [1],

[ovs-dev] [PATCH v6] ovn-controller: Back out incremental processing

/lflow.c module. [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- include/ovn/actions.h | 4 - ovn/controller/binding.c| 154 ++ ovn/controller/binding.h| 1 - ovn/controller/en

Re: [ovs-dev] [ovs-dev, v5] ovn-controller: Back out incremental processing

Ben Pfaff <b...@ovn.org> wrote on 08/26/2016 06:23:57 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/26/2016 06:24 PM > Subject: Re: [ovs-dev,v5] ovn-controller: Back out incremental processing > > O

[ovs-dev] [PATCH v3] ovn-controller: add quiet mode

alculation to be performed. This commit depends on f5d916cb ("ovn-controller: Back out incremental processing") [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/controller/ofctrl.c | 2 ++ ovn/contro

Re: [ovs-dev] [ovs-dev,v2] ovn-controller: add quiet mode

Ben Pfaff <b...@ovn.org> wrote on 08/26/2016 03:37:07 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/26/2016 03:37 PM > Subject: Re: [ovs-dev,v2] ovn-controller: add quiet mode > > On Mon, Aug 22, 201

Re: [ovs-dev] [ovs-dev, v5] ovn-controller: Back out incremental processing

Ben Pfaff <b...@ovn.org> wrote on 08/26/2016 03:27:56 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/26/2016 03:28 PM > Subject: Re: [ovs-dev,v5] ovn-controller: Back out incremental processing > > O

[ovs-dev] [PATCH v5] ovn-controller: Back out incremental processing

] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- v1->v2: - removed some obvious memory leaks left behind in physical.c v2->v3: - removed some less obvious memory leaks created by non-persisting ofctrl.c v3->v

Re: [ovs-dev] ovsdb-server sb db restart causes ovn-controller to crash

ntroller > processes crash. > I recreated this problem using both an OpenStack DevStack and Vagrant > deployment > with networking-ovn. > > I briefly spoke with Ryan Moats about this problem and he plans to > investigate > further. > > - Richard Theis My analysis is that this

Re: [ovs-dev] [PATCH v4] ovn-controller: Back out incremental processing

Guru Shetty <g...@ovn.org> wrote on 08/25/2016 03:11:42 PM: > From: Guru Shetty <g...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev <dev@openvswitch.org> > Date: 08/25/2016 03:11 PM > Subject: Re: [ovs-dev] [PATCH v4] ovn-controller: Back out > inc

Re: [ovs-dev] [PATCH v4] ovn-controller: Back out incremental processing

Russell Bryant <russ...@ovn.org> wrote on 08/25/2016 12:45:44 PM: > From: Russell Bryant <russ...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev <dev@openvswitch.org> > Date: 08/25/2016 12:46 PM > Subject: Re: [ovs-dev] [PATCH v4] ovn-controller:

Re: [ovs-dev] [PATCH] ovn: fix ovn-northd leaks in build_acl

t; @@ -2350,6 +2351,7 @@ build_acls(struct ovn_datapath *od, struct hmap *lflows) > ovn_lflow_add( > lflows, od, S_SWITCH_OUT_ACL, 34000, ds_cstr (), > actions); > +ds_destroy(); > } > } > } > -- Looks good to me on inspection, but I've not tried it out... Acked-by: Ryan Moats <rmo...@us.ibm.com> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn-northd: Avoid excessive work to find routerports.

he ports in the entire database, which is > wasteful and duplicative work. This commit switches to using the array of > router ports. > > This change is best viewed ignoring white space only changes. LGTM Acked-by: Ryan Moats <rmo...@us.ibm.com> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] ovn/TODO: Update for items that have been completed.

gt; -receive only Logical_Flow rows for logical networks on its hypervisor. > - > -*** Reducing redundant data and code within ovsdb-server. > - > -Currently, ovsdb-server separately composes database update > -information to send to each of its clients. This is fine for a &g

Re: [ovs-dev] [PATCH] json: Use reference counting in json objects

"dev" wrote on 08/16/2016 04:50:37 PM: > From: "Rodriguez Betancourt, Esteban" > To: "dev@openvswitch.org" > Date: 08/16/2016 04:50 PM > Subject: [ovs-dev] [PATCH] json: Use reference counting in json objects > Sent by:

Re: [ovs-dev] [PATCH v2] ovn: Delete stale MAC_Binding records

"dev" wrote on 08/16/2016 02:27:30 PM: > From: Chandra Sekhar Vejendla/San Jose/IBM@IBMUS > To: dev@openvswitch.org > Date: 08/16/2016 02:33 PM > Subject: [ovs-dev] [PATCH v2] ovn: Delete stale MAC_Binding records > Sent by: "dev" > >

Re: [ovs-dev] [PATCH 2/3] daemon: Minor tweaking of man page fragment.

Ryan Moats/Omaha/IBM wrote on 08/25/2016 09:19:49 AM: > From: Ryan Moats/Omaha/IBM > To: Justin Pettit <jpet...@ovn.org> > Cc: dev@openvswitch.org > Date: 08/25/2016 09:19 AM > Subject: Re: [ovs-dev] [PATCH 2/3] daemon: Minor tweaking of man > page fragment. > > &quo

Re: [ovs-dev] [PATCH 2/3] daemon: Minor tweaking of man page fragment.

t; - the new user is root. > + Daemons that interact with a datapath, such as > + ovs-vswitchd, will be granted two additional > + capabilities, namely CAP_NET_ADMIN and > + CAP_NET_RAW. The capability change will apply even > + if the new user is root.

Re: [ovs-dev] [PATCH 1/3] NEWS: Add reference to OVN in the post-2.5 release.

RFC 7047. > -- Since patchsets 2 and 3 didn't make it to my mailbox, please consider this an ack for the entire series that this patch starts... Acked-by: Ryan Moats <rmo...@us.ibm.com> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v4] ovn-controller: Back out incremental processing

] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> Co-authored-by: Guru Shetty <g...@ovn.com> --- include/ovn/actions.h | 4 - ovn/controller/binding.c| 154 ++- ovn/controller/binding.h

Re: [ovs-dev] [PATCH v3] ovn-controller: Back out incremental processing

Guru Shetty <g...@ovn.org> wrote on 08/24/2016 03:57:41 PM: > From: Guru Shetty <g...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev <dev@openvswitch.org> > Date: 08/24/2016 03:58 PM > Subject: Re: [ovs-dev] [PATCH v3] ovn-controller: Back out > inc

Re: [ovs-dev] [PATCH v3] ovn-controller: Back out incremental processing

Guru Shetty <g...@ovn.org> wrote on 08/24/2016 01:07:47 PM: > From: Guru Shetty <g...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev <dev@openvswitch.org> > Date: 08/24/2016 01:08 PM > Subject: Re: [ovs-dev] [PATCH v3] ovn-controller: Back out > inc

Re: [ovs-dev] [PATCH v3] ovn-controller: Back out incremental processing

Guru Shetty <g...@ovn.org> wrote on 08/24/2016 12:46:55 PM: > From: Guru Shetty <g...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev <dev@openvswitch.org> > Date: 08/24/2016 12:47 PM > Subject: Re: [ovs-dev] [PATCH v3] ovn-controller: Back out > inc

[ovs-dev] [PATCH] ovn-controller: Fix memory leak when parsing lflow actions.

Parsing logical flow actions with ovnacts_parse* that include string constants current leak memory. Add calls to ovnacts_free to recapture said memory. Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/controller/lflow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ovn/cont

Re: [ovs-dev] [PATCH] ovn: Delete stale MAC_Bindings that result in Referential Integrity Violation

that all Datapath_Binding entries for routers created by rally are cleaned up correctly (i.e. there are no stale MAC_Binding entries), so... Acked-by: Ryan Moats <rmo...@us.ibm.com> Tested-by: Ryan Moats <rmo...@us.ibm.com> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v3] ovn-controller: Back out incremental processing

/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- v1->v2: - removed some obvious memory leaks left behind in physical.c v2->v3: - removed some less obvious memory leaks created by non-persisting ofctrl.c ovn/controller/binding.c| 120 +---

[ovs-dev] [PATCH v2] ovn-controller: Back out incremental processing

/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- v1->v2: removed some obvious memory leaks left behind in physical.c ovn/controller/binding.c| 120 +--- ovn/controller/binding.h| 1 - ovn/controller/encaps.c

Re: [ovs-dev] [PATCH v1] ovn: ensure datapath removal is proper

"dev" wrote on 08/22/2016 08:56:50 PM: > From: Flavio Fernandes > To: dev@openvswitch.org > Date: 08/22/2016 08:57 PM > Subject: [ovs-dev] [PATCH v1] ovn: ensure datapath removal is proper > Sent by: "dev" > > Adding

Re: [ovs-dev] [RFC] ovn: minimize the impact of a compromised chassis

Russell Bryant <rbry...@redhat.com> wrote on 08/22/2016 07:56:41 AM: > From: Russell Bryant <rbry...@redhat.com> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: Justin Pettit <jpet...@ovn.org>, ovs dev <dev@openvswitch.org> > Date: 08/22/2016 07:57 AM > Sub

[ovs-dev] [CudaMailTagged] Re: [PATCH] ovn-controller: add quiet mode

Hui Kang/Watson/IBM wrote on 08/21/2016 10:23:21 PM: > From: Hui Kang/Watson/IBM > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/21/2016 10:23 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: add quiet mode > > I did observe that the previous incre

[ovs-dev] [PATCH v2] ovn-controller: add quiet mode

alculation to be performed. This commit depends on f5d916cb ("ovn-controller: Back out incremental processing") [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- v2->v1: - moved calls to force_full_process in patch.c

Re: [ovs-dev] [RFC] ovn: minimize the impact of a compromisedchassis

"dev" wrote on 08/21/2016 03:02:12 PM: > From: Justin Pettit > To: Russell Bryant > Cc: ovs dev > Date: 08/21/2016 07:30 PM > Subject: Re: [ovs-dev] [RFC] ovn: minimize the impact of a compromised chassis >

Re: [ovs-dev] incremental updates (was: Re: [PATCH 2/2] ovn/TODO: Add items proposed for 2.7 in OVN IRC meeting.)

Ben Pfaff <b...@ovn.org> wrote on 08/19/2016 02:36:42 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev <dev@openvswitch.org>, Numan Siddique <nusid...@redhat.com> > Date: 08/19/2016 02:37 PM > Subject: Re: incremental

[ovs-dev] [PATCH] ovn-controller: add quiet mode

alculation to be performed. This commit depends on f5d916cb ("ovn-controller: Back out incremental processing") [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- ovn/controller/ofctrl.c | 2 ++ ovn/contro

Re: [ovs-dev] [PATCH] ovn-northd: Fix spelling error in comment.

action, which handles > * defragmentation, in order to match L4 headers. */ > if (has_stateful) { And would you believe it took me 3 readings to *find* it??? (#sadpanda) Acked-by: Ryan Moats <rmo...@us.ibm.com> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ovn-controller: Back out incremental processing

/dev/2016-August/078272.html Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- Note: while this passes all of the current ovn unit and e2e tests, I'm not 100% sure it is fully correct as a fair number of the reported issues are not captured in the test suite. ovn/controller/binding.c

Re: [ovs-dev] another possible cause of incremental update problems

Ben Pfaff <b...@ovn.org> wrote on 08/20/2016 10:32:50 AM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev <dev@openvswitch.org> > Date: 08/20/2016 10:33 AM > Subject: another possible cause of incremental update problems > &g

Re: [ovs-dev] [PATCH] ovn-controller: Fix memory leak of keep_local_datapath_by_uuid.

Ben Pfaff <b...@ovn.org> wrote on 08/19/2016 10:50:17 AM: > From: Ben Pfaff <b...@ovn.org> > To: dev@openvswitch.org > Cc: Ben Pfaff <b...@ovn.org>, Ryan Moats/Omaha/IBM@IBMUS, Ramu > Ramamurthy <ramu.ramamur...@gmail.com> > Date: 08/19/2016 10:50 AM > S

Re: [ovs-dev] incremental updates (was: Re: [PATCH 2/2] ovn/TODO: Add items proposed for 2.7 in OVN IRC meeting.)

Ben Pfaff <b...@ovn.org> wrote on 08/19/2016 10:11:59 AM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: Numan Siddique <nusid...@redhat.com>, ovs dev <dev@openvswitch.org> > Date: 08/19/2016 10:12 AM > Subject: incremental upda

Re: [ovs-dev] [PATCH 2/2] ovn/TODO: Add items proposed for 2.7 in OVN IRC meeting.

"dev" wrote on 08/19/2016 12:07:36 AM: > From: Numan Siddique > To: Ben Pfaff > Cc: ovs dev > Date: 08/19/2016 12:07 AM > Subject: Re: [ovs-dev] [PATCH 2/2] ovn/TODO: Add items proposed for > 2.7 in OVN IRC

Re: [ovs-dev] [ovs-dev, v5] Add read-only option to ovs-dpctl and ovs-ofctl commands.

Ben Pfaff <b...@ovn.org> wrote on 08/15/2016 07:28:18 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/16/2016 01:54 AM > Subject: Re: [ovs-dev, v5] Add read-only option to ovs-dpctl and > ovs-ofctl comm

[ovs-dev] [PATCH v5] Add read-only option to ovs-dpctl and ovs-ofctl commands.

ovs-dpctl and ovs-ofctl lack a read-only option to prevent running of commands that perform read-write operations. Add it and the necessary scaffolding to each. Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- lib/command-line.c | 51 + lib/command-

Re: [ovs-dev] [ovs-dev, v2] ovn-controller: Remove flows created for now deleted SB database rows.

Ben Pfaff <b...@ovn.org> wrote on 08/14/2016 10:06:41 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/14/2016 10:06 PM > Subject: Re: [ovs-dev, v2] ovn-controller: Remove flows created for > now deleted SB

[ovs-dev] [PATCH v3] ovn-controller: Remove flows created for now deleted SB database rows.

Ensure that rows created for deleted port binding and multicast group rows are cleared when doing full processing. Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- v2->v3: - correctly clear old hmap (that's what I get for not reading the hmap_clear code first) v1->v2: -

[ovs-dev] [PATCH v4 2/2] Add wrapper scripts for *ctl commands

modified to include the wrapper scripts as part of files to be installed. Tests have been added to make sure that the wrapper scripts don't actually do anything when asked to perform a write operation. Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- debian/openvswitch-common.install | 2 +

[ovs-dev] [PATCH v4 1/2] Add read-only option to ovs-dpctl and ovs-ofctl commands.

ovs-dpctl and ovs-ofctl lack a read-only option to prevent running of commands that perform read-write operations. Add it and the necessary scaffolding to each. Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- v1->v2: Fixed typo in usage string lib/command-line.c

[ovs-dev] [PATCH v4 0/2] Read only versions of the *ctl commands

appsetlog Added new scripts into approriate debian package definitions. Ryan Moats (2): Add read-only option to ovs-dpctl and ovs-ofctl commands. Add wrapper scripts for *ctl commands debian/openvswitch-common.install | 2 + debian/openvswitch-switch.install | 2 + debian/ovn-commo

Re: [ovs-dev] [ovs-dev, v3, 1/2] Add read-only option to ovs-dpctl and ovs-ofctl commands.

Ben Pfaff <b...@ovn.org> wrote on 08/14/2016 10:22:33 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/14/2016 10:22 PM > Subject: Re: [ovs-dev, v3, 1/2] Add read-only option to ovs-dpctl > and ovs-ofctl comm

[ovs-dev] [PATCH] Simplify partial map Py3 IDL test added by commit a59912a0

rm fix, do not use a dictionary with multiple elements for the partial map test case. Change-Id: Ibdec10ebd895051321b9bff7d9fe8a7e0bd9eb88 Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- tests/ovsdb-idl.at | 8 tests/test-ovsdb.py | 2 +- 2 files changed, 5 insertions(+), 5 de

Re: [ovs-dev] [PATCH] ovs-ctl: Properly handle shell quoting inos-release.

Ben Pfaff <b...@ovn.org> wrote on 08/14/2016 07:38:08 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org, Matthew Mulsow/Austin/IBM@IBMUS > Date: 08/14/2016 07:38 PM > Subject: Re: [ovs-dev] [PATCH] ovs-ctl: Properly handle s

[ovs-dev] [PATCH v3 2/2] Add wrapper scripts for *ctl commands

modified to include the wrapper scripts as part of files to be installed. Tests have been added to make sure that the wrapper scripts don't actually do anything when asked to perform a write operation. Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- debian/openvswitch-common.install | 2 +

[ovs-dev] [PATCH v3 1/2] Add read-only option to ovs-dpctl and ovs-ofctl commands.

ovs-dpctl and ovs-ofctl lack a read-only option to prevent running of commands that perform read-write operations. Add it and the necessary scaffolding to each. Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- v1->v2: Fixed typo in usage string lib/command-line.c

[ovs-dev] [PATCH v3 0/2] Read only versions of the *ctl commands

cripts into approriate debian package definitions. Ryan Moats (2): Add read-only option to ovs-dpctl and ovs-ofctl commands. Add wrapper scripts for *ctl commands debian/openvswitch-common.install | 2 + debian/openvswitch-switch.install | 2 + debian/ovn-common.install | 2

Re: [ovs-dev] [PATCH v2 1/2] Add dry-run option to ovs-dpctl and ovs-ofctl commands.

Ben Pfaff <b...@ovn.org> wrote on 08/14/2016 12:36:31 AM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/14/2016 12:36 AM > Subject: Re: [ovs-dev] [PATCH v2 1/2] Add dry-run option to ovs- > dpctl and ovs-ofct

Re: [ovs-dev] [PATCH] ovs-ctl: Properly handle shell quoting inos-release.

;& echo "$ID"` > +SYSTEM_VERSION=`. '@sysconfdir@/os-release' && echo "$VERSION_ID"` > elif (lsb_release --id) >/dev/null 2>&1; then > SYSTEM_TYPE=`lsb_release --id -s` > system_release=`lsb_release --release -s`

Re: [ovs-dev] [PATCH v5 1/2] ovsdb: Add/use partial set updates.

Ben Pfaff <b...@ovn.org> wrote on 08/14/2016 06:33:45 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: d...@openvswitch.com > Date: 08/14/2016 06:33 PM > Subject: Re: [ovs-dev] [PATCH v5 1/2] ovsdb: Add/use partial set updates. > > O

[ovs-dev] [PATCH] Fix copyright statements from commit f1ab6e06

Commit f1ab6e06 ("Add/user partial set updates.) incorrectly did not include HPE attribution for derived files lib/ovsdb-set-op.[ch]. Add the attribution to correct this. Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- lib/ovsdb-set-op.c | 3 ++- lib/ovsdb-set-op.h | 3 ++- 2 files

Re: [ovs-dev] [PATCH] ovn-controller: Remove flows created for now deleted SB database rows.

Ben Pfaff <b...@ovn.org> wrote on 08/12/2016 04:48:26 PM: > From: Ben Pfaff <b...@ovn.org> > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/12/2016 04:48 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Remove flows created > for now delete

[ovs-dev] [PATCH v2] ovn-controller: Remove flows created for now deleted SB database rows.

Ensure that rows created for deleted port binding and multicast group rows are cleared when doing full processing. Signed-off-by: Ryan Moats <rmo...@us.ibm.com> --- v1->v2: - replace use of ssets for storing UUIDs as strings with hmaps for storing the UUID structs themselves

Re: [ovs-dev] [PATCH rebase 3/3] ovn-controller: Use UDP checksums when creating Geneve tunnels.

made my mailbox, so I'm using this to comment on both patches While I understand patch 2/3 does and I like, I'd like it even better if it had test cases that would help me understand the changes that weren't picked up by the original code, because that's a

Re: [ovs-dev] [PATCH rebase 1/3] ovn-controller: Fix memory leak when updating tunnels.

Fixes: 1d45d5a9 ("ovn-controller: Change encaps_run to work incrementally.") > Signed-off-by: Jesse Gross <je...@kernel.org> > --- Good catch... Acked-by: Ryan Moats <rmo...@us.ibm.com> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] ovn-controller: Reset flow processing after (re)connection to switch

s patch fixes the issue and also adds a test case to test > this scenario. > > Signed-off-by: Numan Siddique <nusid...@redhat.com> > --- This all looks does what it promises, so let's get the immediate out of the way: Acked-by: Ryan Moats <rmo...@us.ibm.com> Having

Re: [ovs-dev] [PATCH] ovs-bugtool: Switch from MD5 to SHA-256.

adequate. On the other hand, there is > basically no cost and no disadvantage to switching to SHA-256, so why not > do it? That's why I think that this is a reasonable change. > > VMware-BZ: #1708786 > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- Yes, it's annoying,

  1   2   3   4   5   6   7   8   >