On Thu, Jun 29, 2023 at 08:25:35AM -0400, Aaron Conole wrote:
> Simon Horman writes:
>
> > On Wed, Jun 28, 2023 at 12:27:10PM -0400, Aaron Conole wrote:
> >> The openvswitch selftests currently contain a few cases for managing the
> >> datapath, which includes creat
On Thu, Jun 29, 2023 at 04:15:09PM +0200, Ilya Maximets wrote:
> On 6/6/23 13:35, Ivan Malov wrote:
> > Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead.
>
> AFAICT, not all drivers moved to a REPRESENTED_PORT action.
> I don't see support in NFP driver, for example.
>
> Are we
On Wed, Jun 14, 2023 at 02:36:39PM +0100, Kevin Traynor wrote:
> other_config:pmd-maxsleep is a config option to allow
> PMD thread cores to sleep under low or no load conditions.
>
> Rename it to 'pmd-sleep-max' to allow a more structured
> name and so that additional options or command can
On Tue, Jun 20, 2023 at 06:20:39PM +0100, Kevin Traynor wrote:
> get_log_next_line_num() was defined in alb.at.
>
> As it may be useful in other test files, move to
> ofproto-macros.at.
>
> Suggested-by: David Marchand
> Signed-off-by: Kevin Traynor
A
, use the dpif netdev, as before.
>
> Fixes: adbd4301a249 ("netdev-offload-dpdk: Use per-netdev offload metadata.")
> Signed-off-by: Eli Britstein
Acked-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
e.g. the netdev itself, or for physical devices, all vports.
>
> Fixes: adbd4301a249 ("netdev-offload-dpdk: Use per-netdev offload metadata.")
> Reported-by: 15895987278
> Signed-off-by: Eli Britstein
Acked-by: Simon Horman
_
On Tue, Jun 06, 2023 at 03:35:32PM +0400, Ivan Malov via dev wrote:
> This may be required by some PMDs in offload scenarios.
>
> Signed-off-by: Ivan Malov
> ---
> lib/netdev-dpdk.c | 50 +++
> 1 file changed, 50 insertions(+)
>
> diff --git
virtio features.
>
> This patch proposes to try and detect those vhost socket disconnection
> and fallback restoring the old virtio features (and disabling TSO for this
> vhost port).
>
> Signed-off-by: David Marchand
> Acked-by: Mike Pattrick
Acked-by: Simon Horman
__
On Thu, Jun 29, 2023 at 10:06:33AM +0800, .贺鹏 wrote:
> [You don't often get email from hepeng.0...@bytedance.com. Learn why this is
> important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On Mon, Jun 26, 2023 at 10:57 PM Simon Horman
> wrote:
> >
> > On
On Wed, Jun 28, 2023 at 12:27:10PM -0400, Aaron Conole wrote:
> The openvswitch selftests currently contain a few cases for managing the
> datapath, which includes creating datapath instances, adding interfaces,
> and doing some basic feature / upcall tests. This is useful to validate
> the
On Fri, Oct 09, 2020 at 08:15:03PM +0800, hepeng.0320 wrote:
> when running ovs-tcpdump -i ethX and the port is used as the incomming port
> for a vxlan port.
>
> The callstack for the upcall:
>
> mirror_ingress_packet
> mirror_packet
> output_normal
> compose_output_action
>
On Wed, Jul 08, 2020 at 09:10:36AM -0700, William Tu wrote:
> The patch adds VxLAN encap tc-offload support. The userspace datapath,
> dpif-netdev,
> flow format differs than the kernel datapath in case of tunnel encap. Unlike
> kernel,
> the dpif-netdev does not use set and output action, but
if you can try this change on your setup, that
> would be great.
>
> NEWS | 2 +
> lib/dpif-netdev.c | 250 +-
> 2 files changed, 140 insertions(+), 112 deletions(-)
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Jun 23, 2023 at 01:01:38PM +0200, Eelco Chaudron wrote:
>
>
> On 23 Jun 2023, at 12:57, Simon Horman wrote:
>
> > On Fri, Jun 23, 2023 at 11:16:50AM +0200, Eelco Chaudron wrote:
> >>
> >>
> >> On 19 Jun 2023, at 13:56, Roi Dayan wrote:
>
offloads
> > enabled ok
> >
> > Signed-off-by: Gavin Li
> > Reviewed-by: Roi Dayan
> > Reviewed-by: Simon Horman
> > ---
>
> Thanks for adding the test, however, there is one problem. If the kernel does
> not support this feature the test is not
Eelco Chaudron was elected by the Open vSwitch committers yesterday.
This formalises his status as an Open vSwitch committer.
Welcome Eelco!
Signed-off-by: Simon Horman
---
MAINTAINERS.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
index
On Wed, Jun 14, 2023 at 11:22:39AM +0300, Roi Dayan wrote:
> From: Gavin Li
>
> Add a vxlan gbp offload test case:
>
> vxlan offloads with gbp extention - ping between two ports - offloads
> enabled ok
>
> Signed-off-by: Gavin Li
R
ing the knowing ones.
>
> To solve the issue, probe and disallow inserting rules with vxlan gbp
> action/match if kernel does not support it.
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
___
dev mailin
On Wed, Jun 14, 2023 at 11:22:37AM +0300, Roi Dayan wrote:
> From: Gavin Li
>
> Add TC offload support for vxlan encap with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Roi Dayan
Revi
On Wed, Jun 14, 2023 at 11:22:35AM +0300, Roi Dayan wrote:
> From: Gavin Li
>
> Add TC offload support for filtering vxlan tunnels with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Roi Dayan
Revi
d is controlled by
> message policy. To avoid this, add NLA_F_NESTED explicitly for all
> nested netlink messages with a new function
> nl_msg_start_nested_with_flag().
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
__
.
>
> Signed-off-by: James Raphael Tiovalen
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
uch as Coverity, happy.
>
> Signed-off-by: James Raphael Tiovalen
Reviewed-by: Simon Horman
I do see a failure in the Intel test run [1][2],
but it seems unrelated to this patch.
[1]
https://patchwork.ozlabs.org/project/openvswitch/patch/20230613183443.31540-3-jamestio...@gmail.com/
[2] htt
On Tue, Jun 13, 2023 at 09:41:42AM +0800, Peng He wrote:
> Hi, Simon,
>
> I guess it's not related, as my patch fixes the code in dpif-netdev.c it
> should has any impact on the ovsdb side.
> But I am not sure that.
> Is this test case a spike test case? Is there any testsuite log?
* Please
On Wed, Jun 14, 2023 at 12:09:42AM +0800, James R T wrote:
> Hi Simon,
>
> On Mon, Jun 12, 2023 at 10:56 PM Simon Horman
> wrote:
> >
> > On Mon, Jun 05, 2023 at 01:30:03AM +0800, James Raphael Tiovalen wrote:
> > > This commit adds a few null pointer ass
On Fri, Jun 17, 2022 at 05:03:46PM +0200, Adrian Moreno wrote:
> If openvswitch is not installed in the default system's path ovs-save
> script will fail to find the tools it requires.
>
> Fix this by adding $bindir to the PATH.
> Refactor common path calculation into ovs-lib.
>
> Signed-off-by:
control flow will now be redirected to alternative paths which will
> output the appropriate error messages.
>
> Signed-off-by: James Raphael Tiovalen
> Reviewed-by: Simon Horman
Hi James,
unfortunately the CI is showing a number of failures with this patch
applied. I haven't dug
On Mon, Jun 12, 2023 at 02:10:17AM +, Peng He wrote:
> OVS allows overlapping megaflows, as long as the actions of these
> megaflows are equal. However, the current implementation of action
> modification relies on flow_lookup instead of ufid, this could result
> in looking up a wrong megaflow
On Thu, Jun 08, 2023 at 10:32:45PM +0800, Peng He wrote:
> This patch has a bug, it needs 2 patches to realize the purpose in fact. I
> can rebase if needed
I am unclear on any need.
Perhaps it's best to drop this for now.
And revisit if the need arises.
e change
> should not impact the current behavior.
>
> Signed-off-by: Eelco Chaudron
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Sat, Apr 06, 2019 at 01:59:13PM +, ? ? wrote:
> When we configured bond that use recirc and configure mirror, we
> observed that mirror destination has duplicated outputs. This is
> because bond's frozen_state is not updated to reflect the mirror
> already composed the output, and when the
On Wed, Jun 07, 2023 at 12:21:08PM +0200, David Marchand wrote:
> Hello,
>
> On Tue, Jun 6, 2023 at 7:10 AM Eli Britstein wrote:
> > >> >
> > >> > Vport's offloads are done on the tracked orig-in-port, but the flow
> > >> > itself is associated in the vport's map.
> > >> >
> > >> > Removing the
; and "cacert" columns.
>
> This patch adds configuration knob "--in-db-ssl", which has default
> behavior as it is now: run ovsdb server with ssl options.
>
> User must pass "--in-db-ssl=no" to run ovsdb-server without t
stem-ids are not set and transient ports are not deleted.
>
> Signed-off-by: Vladislav Odintsov
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
hat by destroying the initial change set every time new columns
> are added to the monitor. This will trigger re-generation of the
> change set and it will contain all the necessary columns afterwards.
>
> Fixes: 07c27226ee96 ("ovsdb: Monitor: Keep and maintain the initial change
On Sun, May 17, 2020 at 01:08:47PM +0800, hepeng.0320 wrote:
> From: hepeng
>
> if the tunnel is specified as "remote_ip=flow", we can try to generate a
> megaflow
> which ignores all source address, such as source mac, source IP address
> in the outter header of the packet. This can reduce the
On Thu, Mar 10, 2022 at 04:41:15AM +, Peng He wrote:
> the flow->in_port value is previously ignored. We normally use
> the the md->in_port of the first packet in the batch to get the
> value. However, since some actions might need to be redo due to
> the fix of ipf issues, we might have an
On Thu, Mar 10, 2022 at 01:55:30AM +, Peng He wrote:
> From: Peng He
>
> ipf_postprocess will emit packets into the datapath pipeline ignoring
> the conntrack context, this might casuse weird issues when a packet
> batch has less space to hold all the fragments belonging to single
> packet.
On Wed, Jun 07, 2023 at 11:09:58AM +0200, Eelco Chaudron wrote:
...
> >> We moved the per cpu upcall counter allocation to the existing vport
> >> alloc and free functions to solve this.
> >>
> >> Fixes: 95637d91fefd ("net: openvswitch: release vport resources on
> >> failure")
> >> Fixes:
upcall counter allocation to the existing vport
> alloc and free functions to solve this.
>
> Fixes: 95637d91fefd ("net: openvswitch: release vport resources on failure")
> Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall packets")
> Signe
On Mon, Jun 05, 2023 at 03:53:59PM +0200, Eelco Chaudron wrote:
>
>
> On 5 Jun 2023, at 15:07, Simon Horman wrote:
>
> > On Mon, Jun 05, 2023 at 02:54:35PM +0200, Eelco Chaudron wrote:
> >>
> >>
> >> On 5 Jun 2023, at 14:41, Simon Horman wrote:
On Mon, Jun 05, 2023 at 02:54:35PM +0200, Eelco Chaudron wrote:
>
>
> On 5 Jun 2023, at 14:41, Simon Horman wrote:
>
> > On Mon, Jun 05, 2023 at 10:59:50AM +0200, Eelco Chaudron wrote:
> >> Currently, the per cpu upcall counters are allocated after the vport i
On Mon, Jun 05, 2023 at 10:59:50AM +0200, Eelco Chaudron wrote:
> Currently, the per cpu upcall counters are allocated after the vport is
> created and inserted into the system. This could lead to the datapath
> accessing the counters before they are allocated resulting in a kernel
> Oops.
>
>
On Fri, May 26, 2023 at 06:57:09PM +0200, Ilya Maximets wrote:
> On 5/25/23 15:21, Simon Horman wrote:
> > On Wed, May 17, 2023 at 06:51:04PM +0200, Ilya Maximets wrote:
> >> OpenSSL 3.0 enabled alerts for unexpected EOF by default. It supposed
> >> to ale
On Fri, May 26, 2023 at 03:11:01PM +0200, Ilya Maximets wrote:
> On 5/25/23 15:20, Simon Horman wrote:
> > On Wed, May 17, 2023 at 06:51:05PM +0200, Ilya Maximets wrote:
> >> Many OVSDB tests are not checking the server log for warnings or
> >> errors. Some are not eve
On Fri, May 26, 2023 at 07:56:06PM +0200, Ilya Maximets wrote:
> My commit hook capitalized 'c' in the 'condition'. I can fix that
> before applying.
Sounds good.
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
On Fri, May 26, 2023 at 01:38:54PM +0200, Ales Musil wrote:
> On Fri, May 26, 2023 at 12:56 PM Simon Horman
> wrote:
>
> > On Thu, May 25, 2023 at 12:23:43PM -0400, Brian Haley wrote:
> > > Sorry for the top post, but I was wondering if there was a way to
> > re
eply traffic is never centralized. Fix the issue centralizing the
> traffic if it is the reply packet for the load balancer.
>
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2023609
> Signed-off-by: Lorenzo Bianconi
Reviewed-by: Simon Horman
___
The bare minimum change was done to inet_parse_active() to support
> sync/async dns, as there is no equivalent to
> parse_sockaddr_components(), inet_parse_passive(), etc. A TODO
> was added to bring socket_util.py up to equivalency to the C
> version.
>
> Signed-off-by: T
On Fri, May 26, 2023 at 12:43:52PM +0200, Eelco Chaudron wrote:
>
>
> On 15 May 2023, at 10:23, Roi Dayan wrote:
>
> > From: Gavin Li
> >
> > Add TC offload support for filtering vxlan tunnels with gbp option
> >
> > Signed-off-by: Gavin Li
> > Reviewed-by: Gavi Teitz
> > Reviewed-by: Roi
On Thu, May 25, 2023 at 12:23:43PM -0400, Brian Haley wrote:
> Sorry for the top post, but I was wondering if there was a way to re-trigger
> the bot testing action on a patch? Somehow the testing on the v2 one failed
> even though v1 passed [0]. Since the only change was in the commit message
>
at.com/show_bug.cgi?id=2104779
> Signed-off-by: Mike Pattrick
>
> ---
>
> Since v1:
> - Refactored code into specialized functions and renamed variables for
> improved readability.
> Since v2:
> - Removed inline keywords
Thanks!
Reviewed-by: Simon Horman
___
yant
> CC: Alin Serdean
> CC: Andy Zhou
> CC: Ansis Atteka
> CC: Daniele Di Proietto
> CC: Gurucharan Shetty
> CC: Ian Stokes
> CC: Ilya Maximets
> CC: Jarno Rajahalme
> CC: Jesse Gross
> CC: Justin Pettit
> CC: Pravin B Shelar
> CC: Simon Horman
On Wed, May 24, 2023 at 11:12:28AM +0200, Ihtisham ul Haq via dev wrote:
> Using cache improves performance of recomputation of lflows(by
> about 30%)
>
> Exising lflow cache for `matches` and `expressions` is adopted
> to include `actions` as well.
>
> Co-authored-by: Felix Huettner
>
rnings in the log.
>
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
Are there any plans to enhance the client-side behaviour?
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
detect some internal warnings if there are some.
>
> Moving the OVSDB_SERVER_SHUTDOWN macro to the common place, adding
> the call to check_logs into it and making OVSDB tests use this macro.
>
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
As an aside.
Some of
On Thu, May 18, 2023 at 02:14:25PM +0200, Ilya Maximets wrote:
> In most cases, after the condition change request, the new condition
> is the same as old one plus minus a few clauses. Today, ovsdb-server
> will evaluate every database row against all the old clauses and then
> against all the
; used by different threads within RCU grace period.
>
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Sat, May 20, 2023 at 02:31:19AM +0200, Ilya Maximets wrote:
> The address is not getting modified inside.
>
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.or
structure
> instead and using an atomic counter.
>
> Fixes: 04975308 ("userspace: add gre sequence number support.")
> Fixes: 7dc18ae96d33 ("userspace: add erspan tunnel support.")
> Fixes: 3c6d05a02e0f ("userspace: Add GTP-U
eported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2134880
> Reported-by: François Rigault
> CC: Ilya Maximets
> Signed-off-by: Dumitru Ceara
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, May 25, 2023 at 05:54:37PM +0800, yangchang wrote:
> Arp_spa and arp_tpa are IP addresses, their width should be 32 bits.
>
> Signed-off-by: yangchang
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.
On Thu, May 25, 2023 at 10:58:36AM +0200, Balazs Nemeth wrote:
> The only way that stats->{n_packets,n_bytes} would decrease is due to an
> overflow, or if there are bugs in how statistics are handled. In the
> past, there were multiple issues that caused a jump backward. A
> workaround was in
On Wed, May 24, 2023 at 09:23:59PM +0200, Ilya Maximets wrote:
> On 5/24/23 15:39, Frode Nordahl wrote:
> > The bareudp tests depend on specific kernel configuration to
> > succeed. Skip the test if the feature is not enabled in the
> > running kernel.
> >
> > Signed-off-by: Frode Nordahl
> >
decided to reuse it instead
> of adding a new one.
>
> Signed-off-by: Felix Huettner
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks Lorenzo,
a few suggestions from my side.
On Thu, May 18, 2023 at 10:20:34PM +0200, Lorenzo Bianconi wrote:
> In the current codebase for distributed gw router port use-case,
> it is not possible to add a load balancer that redirects the traffic
> to a backed if it is even the internal IP
On Thu, May 18, 2023 at 04:08:34PM -0400, Mike Pattrick wrote:
> Several xlate actions used in recursive translation currently store a
> large amount of information on the stack. This can result in handler
> threads quickly running out of stack space despite before
>
On Wed, May 24, 2023 at 03:39:53PM +0200, Frode Nordahl wrote:
> The bareudp tests depend on specific kernel configuration to
> succeed. Skip the test if the feature is not enabled in the
> running kernel.
>
> Signed-off-by: Frode Nordahl
Tested-by: Simon Horman
Reviewed-b
lue and log.
>
> Reported-at: https://bugzilla.redhat.com/2119876
> Signed-off-by: Kevin Traynor
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ximets
> Reviewed-by: David Marchand
> Signed-off-by: Kevin Traynor
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
g
> early or skipping some action if a null pointer is encountered.
>
> Signed-off-by: James Raphael Tiovalen
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, May 03, 2023 at 02:30:30AM +0800, James Raphael Tiovalen wrote:
> This commit adds non-null pointer assertions in some code that performs
> some decisions based on old and new input ovsdb_rows.
>
> Signed-off-by: James Raphael Tiovalen
Reviewed-by:
control flow will now be redirected to alternative paths which will
> output the appropriate error messages.
>
> Signed-off-by: James Raphael Tiovalen
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch
of `shash_sort`, `simap_sort`,
> or `smap_sort` are NULL, then the following for loops would not attempt
> to access the pointer, which might result in segmentation faults or
> undefined behavior.
>
> Signed-off-by: James Raphael Tioval
On Wed, May 03, 2023 at 02:30:27AM +0800, James Raphael Tiovalen wrote:
> This commit adds zero-initializations by changing `SFL_ALLOC` from
> `malloc` to `xzalloc`, adding a `memset` call to `sflAlloc`,
> initializing a `pollfd` struct variable with zeroes, and changing some
> calls to `xmalloc`
uch as Coverity, happy.
>
> Signed-off-by: James Raphael Tiovalen
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, May 15, 2023 at 11:23:56AM +0300, Roi Dayan via dev wrote:
> From: Gavin Li
>
> Add TC offload support for vxlan encap with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Roi Dayan
Revi
On Mon, May 15, 2023 at 11:23:54AM +0300, Roi Dayan via dev wrote:
> From: Gavin Li
>
> Add TC offload support for filtering vxlan tunnels with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Roi Dayan
Revi
eck is optional and is controlled by
> message policy. To avoid this, add NLA_F_NESTED explicitly for all
> nested netlink messages with a new function
> nl_msg_start_nested_with_flag().
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
__
at
> ../lib/dpif-netlink.c:2384
>
> Reported-At: https://launchpad.net/bugs/2018500
> Fixes f98e418fbdb6 (tc: Add tc flower functions)
> Fixes 407556ac6c90 (netlink-socket: Avoid forcing a reply for final message
> in a transaction.)
> Signed-off-by: Frode Nordahl
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, May 10, 2023 at 09:11:25PM +0200, Ilya Maximets wrote:
> On 5/9/23 12:05, Stefan Hoffmann wrote:
> > The failed pipeline is bfd-decay again, which seems to fail out of
> > reason sometimes. Test works on my machine.
> >
> > Is there a way to rerun the pipeline?
> >
> >
On Mon, May 08, 2023 at 01:14:55PM +0200, Dumitru Ceara wrote:
> It's not referenced anywhere and by the look of it it has never been.
>
> Signed-off-by: Dumitru Ceara
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.
Reported-by: Ilya Maximets
> Signed-off-by: Vladislav Odintsov
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
; assertions since it should be impossible for these calls to
> `dp_packet_data()` to return NULL.
>
> Signed-off-by: James Raphael Tiovalen
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, May 12, 2023 at 11:25:02AM +0200, Frode Nordahl wrote:
> On Fri, May 12, 2023 at 10:35 AM Simon Horman
> wrote:
> >
> > On Thu, May 11, 2023 at 12:03:50PM +0200, Frode Nordahl wrote:
> > > The tc module combines the use of the `tc_transact` helper
>
On Thu, May 11, 2023 at 12:03:50PM +0200, Frode Nordahl wrote:
> The tc module combines the use of the `tc_transact` helper
> function for communication with the in-kernel tc infrastructure
> with assertions on the reply data by `ofpbuf_at_assert` on the
> received data prior to further
On Wed, May 10, 2023 at 11:43:31PM +0800, miter wrote:
> Hi simon,
>
>
> Thanks for your reviewing.
>
>
> On 5/10/2023 10:34 PM, Simon Horman wrote:
> > On Mon, May 01, 2023 at 07:33:38PM +0800, mit...@outlook.com wrote:
> > > From: Lin Huang
...
>
On Tue, Apr 25, 2023 at 03:41:22PM +0300, Roi Dayan via dev wrote:
> From: Gavin Li
>
> Add TC offload support for vxlan encap with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Roi Dayan
No objections. But I guess this will also change wrt netlink
g added, expose encap as named
> struct and pass it entirely.
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Apr 25, 2023 at 03:41:20PM +0300, Roi Dayan via dev wrote:
> From: Gavin Li
>
> Add TC offload support for filtering vxlan tunnels with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
...
> @@ -3439,11 +3479,12 @@ nl_msg_put_flower_tunnel_opts(struct ofpbuf
On Tue, Apr 25, 2023 at 03:41:17PM +0300, Roi Dayan via dev wrote:
> From: Gavin Li
>
> Extract vxlan gbp option decoding to odp_decode_gbp_raw to be used in
> following commits.
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
Revi
On Tue, Apr 25, 2023 at 03:41:18PM +0300, Roi Dayan via dev wrote:
> From: Gavin Li
>
> Extract vxlan gbp option encoding to odp_encode_gbp_raw to be used in
> following commits.
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
Revi
ts to the function to support more vxlan
> options in the future, change the function arguments to pass tunnel
> entirely to it instead of keep adding new arguments.
>
> Signed-off-by: Gavin Li
> Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
_
On Wed, May 10, 2023 at 04:28:06PM +0200, Ilya Maximets wrote:
> On 5/10/23 16:10, Simon Horman wrote:
> > On Wed, Apr 26, 2023 at 06:39:22PM +0200, Ilya Maximets wrote:
> >> On 4/25/23 14:41, Roi Dayan wrote:
> >>> From: Gavin Li
> >>>
> >>&g
On Mon, May 01, 2023 at 07:33:38PM +0800, mit...@outlook.com wrote:
> From: Lin Huang
>
> OvS has supported packet-per-second policer which can be set at ingress
> and egress side in kernel datapath. But the userspace datapath dosen't
s/dosen't/doesn't/
> support for ingress and egress
On Wed, Apr 26, 2023 at 06:39:22PM +0200, Ilya Maximets wrote:
> On 4/25/23 14:41, Roi Dayan wrote:
> > From: Gavin Li
> >
> > Linux kernel netlink module added NLA_F_NESTED flag checking for nested
> > netlink messages in 5.2. A nested message without the flag set will be
> > treated as
On Tue, May 09, 2023 at 12:09:32PM +0200, Eelco Chaudron wrote:
>
>
> On 28 Apr 2023, at 9:01, Simon Horman wrote:
>
> > On Mon, Apr 24, 2023 at 12:37:04PM +0200, Simon Horman wrote:
> >> On Thu, Apr 20, 2023 at 09:39:28AM +0200, Eelco Chaudron wrote:
> >
On Sat, May 06, 2023 at 05:26:17AM +0200, Nole Zhang wrote:
>
>
> > -Original Message-
> > From: Ilya Maximets
> > Sent: Saturday, May 6, 2023 3:07 AM
> > To: Ivan Malov ; Simon Horman
> >
> > Cc: i.maxim...@ovn.org; d...@openvswitch.org; E
On Thu, May 04, 2023 at 04:15:31PM +0200, Adrian Moreno wrote:
>
>
> On 5/4/23 09:09, Simon Horman wrote:
> > On Wed, May 03, 2023 at 04:05:36PM +0200, Adrian Moreno wrote:
> > >
> > >
> > > On 4/25/23 14:51, Simon Horman wrote:
> > > > O
On Sat, May 06, 2023 at 06:04:16PM +0200, Christophe JAILLET wrote:
> Use struct_size() instead of hand writing it.
> This is less verbose and more informative.
>
> Signed-off-by: Christophe JAILLET
> ---
> It will also help scripts when __counted_by macro will be added.
> See [1].
>
> [1]:
501 - 600 of 4388 matches
Mail list logo
