On Wed, May 03, 2023 at 04:05:36PM +0200, Adrian Moreno wrote:
>
>
> On 4/25/23 14:51, Simon Horman wrote:
> > On Fri, Apr 21, 2023 at 05:16:48PM +0200, Adrian Moreno wrote:
> > > Currently, htb rates are capped at ~34Gbps because they are internally
> >
On Wed, May 03, 2023 at 03:53:14PM +0200, Adrian Moreno wrote:
>
>
> On 4/26/23 15:39, Simon Horman wrote:
> > On Fri, Apr 21, 2023 at 05:16:50PM +0200, Adrian Moreno wrote:
> > > In preparation for supporting 64-bit rates in tc policies, move the
> > > alloca
On Tue, May 02, 2023 at 02:29:51PM +0200, Dumitru Ceara wrote:
> On 4/20/23 16:28, Ihar Hrachyshka wrote:
> > I don't see how this is any better. Instead of calling to python that
> > imports GPL libraries, we now call to scapy that calls to python that
> > imports GPL libraries. In both cases we
On Mon, Apr 24, 2023 at 12:37:04PM +0200, Simon Horman wrote:
> On Thu, Apr 20, 2023 at 09:39:28AM +0200, Eelco Chaudron wrote:
> > When doing performance testing with OVS v3.1 we ran into a deadlock
> > situation with the netdev_hmap_rwlock read/write lock. After som
From: Peng Zhang
Add support of DPDK meter action logic. With flow add/destroy
from the HW, add/del the meter in the HW.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-offload-dpdk.c | 131
From: Peng Zhang
Add the meter algorithms. DPDK meter support three algorithms,
and OVS also can support these algorithms.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-dpdk.c | 58
node in the meter data hash table.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-dpdk.c | 191 ++
lib/netdev-dpdk.h | 41
lib/netdev-offload-dpdk.c | 191
From: Peng Zhang
Manage "transfer" flows via the corresponding mechanism.
Doing so requires that the traffic source be specified
explicitly, via the corresponding pattern item.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
From: Peng Zhang
By calling meter API, so it can offload meter to HW in netdev
datapath. Add the check for datapath in the meter API to avoid
the unnecessary error.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
Documentation/howto
Hi,
this series adds support for DPDK meter HW offload.
Changes between v3 and v4:
* Add hash to store meter data
* Offload metter with flow
* Use rte_flow for proxy id
Changes between v2 and v3:
* Use common API for DPDK and non-DPDK meter offloads
* Make use of netdev_ports_traverse to
On Fri, Apr 21, 2023 at 05:16:51PM +0200, Adrian Moreno wrote:
> Use TCA_POLICE_RATE64 if the rate cannot be expressed using 32bits.
>
> This breaks the 32Gbps barrier. The new barrier is ~4Tbps caused by
> netdev's API expressing kbps rates using 32-bit integers.
>
> Reported-at:
rtab(struct ofpbuf *msg, uint16_t type, const struct tc_ratespec
> *rate,
> +uint64_t bps);
Its unfortunate that there are now two parameters relating to the rate.
But I think this is a case of playing the hand we've been dealt.
And as I have no better idea I'm ok with this.
actual rates.
>
> Signed-off-by: Adrian Moreno
Tested-by: Simon Horman
> ---
> lib/netdev-linux.c | 37 ++---
> 1 file changed, 18 insertions(+), 19 deletions(-)
>
> diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
> index 8ee75981b..a2bae30
ied, but, FWIIW,
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Apr 24, 2023 at 02:06:53PM +0200, Ilya Maximets wrote:
> On 4/23/23 05:47, wangyunjian wrote:
> > Is there any issue with this patch? Why is it in the Superseded state?
>
> Hi. Not sure what happened here.
> I moved it back to 'New' for now.
That might have been me conflating things.
If
#9 0x40bcfd in bridge_reconfigure vswitchd/bridge.c:921
> #10 0x41f1a9 in bridge_run vswitchd/bridge.c:3313
> #11 0x42d4fb in main vswitchd/ovs-vswitchd.c:132
> #12 0x7f312fbbcc86 in __libc_start_main (/usr/lib64/libc.so.6+0x25c86)
>
> Fixes: fed8962aff57 ("Add new p
On Mon, Apr 24, 2023 at 02:01:03PM +0800, Wan Junjie via dev wrote:
> ovs-save will do replace-flows for ovs restart. For some reason, ovs
> could have an invalid action, like invalid meter. Then adding flows
> will be stopped at the position of the first invalid flow. This could
> happen when ovs
On Fri, Apr 21, 2023 at 05:16:48PM +0200, Adrian Moreno wrote:
> Currently, htb rates are capped at ~34Gbps because they are internally
> expressed as 32-bit fields.
>
> Move min and max rates to 64-bit fields and use TCA_HTB_RATE64 and
> TCA_HTB_CEIL64 to configure HTC classes to break this
On Fri, Apr 21, 2023 at 05:16:49PM +0200, Adrian Moreno wrote:
> It is equivalent to tc_policer_init() so remove the duplicated function.
>
> Signed-off-by: Adrian Moreno
Nice :)
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvs
On Fri, Apr 21, 2023 at 05:16:45PM +0200, Adrian Moreno wrote:
> Currently, the netdev's speed is being calculated by taking the link's
> feature bits (using netdev_get_features()) and transforming them into
> bps.
>
> This mechanism can be both inaccurate and difficult to maintain, mainly
>
On Thu, Apr 20, 2023 at 03:38:53PM +0200, Ales Musil wrote:
> The normalize_prefix_str returns NULL when it fails to
> normalize the specified string. Prevent UB with formatting
> NULL with %s and simplify the free pattern.
>
> Signed-off-by: Ales Musil
Reviewed-b
On Thu, Apr 20, 2023 at 01:24:08PM +0800, Tao Liu wrote:
> In vxlan mode with more than 2047 lrp in router, build_ports()
> prints "all port tunnel ids exhausted", and frees the lrp port.
>
> However, lsp of type "router" connected to the lrp still holds
> the pointer in port->peer. This leads to
aphael Tiovalen
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Sat, Apr 15, 2023 at 11:21:54PM +0800, James Raphael Tiovalen wrote:
> This commit adds various null pointer checks to some files in the `lib`
> and the `ovsdb` directories to fix several Coverity defects. These
> changes are grouped together as they perform similar checks, returning
> early or
ridge member is valid before attempting to access it. In the
> `check_conflicts` function, we print both the port name and the bridge
> name if routing is disabled and we only print the port name if routing
> is enabled.
>
> Signed-off-by: James Raphael Tiovalen
On Sat, Apr 15, 2023 at 11:21:52PM +0800, James Raphael Tiovalen wrote:
> This commit adds null pointer checks in some code that performs some
> decisions based on old and new input ovsdb_rows. The corresponding
> non-null assertion and early return are added if both the old and the
> new
On Sat, Apr 15, 2023 at 11:21:51PM +0800, James Raphael Tiovalen wrote:
> This commit adds more verbose logging in null-pointer check blocks by
> using `ovsdb_syntax_error` and `VLOG_ERR`. A few additional null pointer
> checks are also performed to accompany the additional logging. If a null
>
t; This ensures that if the return values of `shash_sort`, `simap_sort`,
> or `smap_sort` are NULL, then the following for loops would not attempt
> to access the pointer, which might result in segmentation faults or
> undefined behavior.
>
> Signed-off-by: James Raphael Tioval
On Thu, Apr 20, 2023 at 05:23:27AM -0400, wangchuanlei wrote:
Hi,
It might be useful to have some explanation of why this change is
being made.
> Signed-off-by: wangchuanlei
...
___
dev mailing list
d...@openvswitch.org
at.com/show_bug.cgi?id=2182541
> Fixes: 9fe21a4fc12a ("netdev-offload: replace netdev_hmap_mutex to
> netdev_hmap_rwlock")
> Signed-off-by: Eelco Chaudron
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
for older
> kernels.")
> Suggested-by: David Marchand
> Signed-off-by: Yunjian Wang
> ---
> v3: update commit log
Thanks for the update.
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Sat, Apr 15, 2023 at 11:21:49PM +0800, James Raphael Tiovalen wrote:
> This commit adds zero-initializations by changing `SFL_ALLOC` from
> `malloc` to `xzalloc`, initializing a `pollfd` struct variable with
> zeroes, and changing some calls to `xmalloc` to `xzalloc`. This is to
> prevent
On Sat, Apr 15, 2023 at 11:21:48PM +0800, James Raphael Tiovalen wrote:
> This commit adds some `ovs_assert()` checks to the return values of
> `dp_packet_data()` to ensure that they are not NULL and to prevent
> null-pointer dereferences, which might lead to unwanted crashes. We use
> assertions
> >
> > Reported-by: Nan Zhou
> > Signed-off-by: Yunjian Wang
>
> Thanks for addressing my comment. It looks good to me.
>
> Acked-by: Eelco Chaudron
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Apr 20, 2023 at 05:31:23PM +0200, Stefan Hoffmann wrote:
> On Thu, 2023-04-20 at 15:50 +0200, Simon Horman wrote:
> > On Thu, Apr 20, 2023 at 02:18:33PM +0200, David Marchand wrote:
> > > On Thu, Apr 20, 2023 at 2:06 PM Simon Horman
> > > wrote:
> >
On Thu, Apr 20, 2023 at 03:47:43PM +0200, Simon Horman wrote:
> On Wed, Apr 19, 2023 at 03:49:58PM +0800, Yunjian Wang via dev wrote:
>
> Hi Yunjian,
>
> Please add some text here describing why passing dp and buf is a proble:
> how it leads to a leak.
>
> Also, FYI,
t DPDK build requirements from OVS build
> requirements, like python dependencies,
> - building DPDK does not depend on how we will link OVS against it, so we
> can use a single cache entry regardless of DPDK_SHARED option,
>
> Signed-off-by: David Marchand
lue and log.
>
> Reported-at: https://bugzilla.redhat.com/2119876
> Signed-off-by: Kevin Traynor
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Apr 20, 2023 at 03:13:20PM +0200, Dumitru Ceara wrote:
> Hi Ihar, Simon,
>
> This is not very pretty but would it improve the situation (not even
> importing scapy anymore)?
IANAL, but I would be more comfortable with this approach.
>
> fmt_pkt() {
> echo "import binascii; \
>
On Thu, Apr 20, 2023 at 02:18:33PM +0200, David Marchand wrote:
> On Thu, Apr 20, 2023 at 2:06 PM Simon Horman
> wrote:
> > > I do see CI failures, but I think these are false negatives:
> > >
> > > *
> > > https://patc
On Wed, Apr 19, 2023 at 03:49:58PM +0800, Yunjian Wang via dev wrote:
Hi Yunjian,
Please add some text here describing why passing dp and buf is a proble:
how it leads to a leak.
Also, FYI, I notice that the CI run failed, which seems completely
unrelated to your patch:
*
On Fri, Apr 14, 2023 at 05:47:59PM +0800, Yunjian Wang via dev wrote:
> An unnecessarily overflow would occurs when the 'value' is longer than
> 4294967295. So it's required to check ranges to avoid uint32_t overflow.
Thanks, I see this is correct.
Perhaps it would be worth noting that it occurs
On Wed, Apr 12, 2023 at 01:29:48AM +, Ihar Hrachyshka wrote:
> Scapy allows to define packets in descriptive form that is easier to
> digest and debug.
>
> Signed-off-by: Ihar Hrachyshka
> ---
> tests/ovn-macros.at | 23 +++
> 1 file changed, 23 insertions(+)
>
> diff
On Thu, Apr 20, 2023 at 01:35:59PM +0200, Simon Horman wrote:
> On Thu, Apr 20, 2023 at 10:14:14AM +0200, Stefan Hoffmann wrote:
> > In some cases ovsdb server or relay gets restarted, ovsdb python clients
> > may keep the local socket open. Instead of reconnecting a
On Thu, Apr 20, 2023 at 10:14:14AM +0200, Stefan Hoffmann wrote:
> In some cases ovsdb server or relay gets restarted, ovsdb python clients
> may keep the local socket open. Instead of reconnecting a lot of failures
> will be logged.
> This can be reproduced with ssl connections to the
On Sun, Apr 09, 2023 at 07:15:09PM +0800, mit...@outlook.com wrote:
> From: Lin Huang
>
> OvS has supported packet-per-second policer which can be set at ingress and
> egress
> side in kernel datapath. But the userspace datapath dosen't support for
> ingress and
> egress packet-per-second
Hi Lin Huang,
thanks for your patch.
On Sun, Apr 09, 2023 at 07:15:08PM +0800, mit...@outlook.com wrote:
> From: Lin Huang
>
> OvS has supported packet-per-second policer which can be set at ingress and
> egress
> side in kernel datapath. But the userspace datapath dosen't support for
>
On Tue, Apr 26, 2022 at 07:15:59AM -0400, 0-day Robot wrote:
> Bleep bloop. Greetings lin huang, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> git-am:
> error: corrupt patch
On Wed, Apr 19, 2023 at 01:39:00PM +0200, Dumitru Ceara wrote:
> On 4/19/23 12:55, Simon Horman wrote:
> > On Wed, Apr 19, 2023 at 12:44:52PM +0200, Lorenzo Bianconi wrote:
> >>> On Tue, Apr 18, 2023 at 04:14:36PM +0200, Lorenzo Bianconi wrote:
> >>>> Re
On Wed, Apr 19, 2023 at 12:44:52PM +0200, Lorenzo Bianconi wrote:
> > On Tue, Apr 18, 2023 at 04:14:36PM +0200, Lorenzo Bianconi wrote:
> > > Remove ovn-egress-iface paramter since it is no longer used.
> >
> > Hi Lorenzo,
>
> Hi Simon,
>
> >
> > are there any backwards compatibility issues
On Tue, Apr 18, 2023 at 04:14:36PM +0200, Lorenzo Bianconi wrote:
> Remove ovn-egress-iface paramter since it is no longer used.
Hi Lorenzo,
are there any backwards compatibility issues from a user
perspective with this change?
___
dev mailing list
tc command directly bypassing OVS.
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=2129742
> > Tested-by: Rodolfo Alonso
> > Signed-off-by: Lorenzo Bianconi
...
Hi Lorenzo,
I am fine with this patch, modulo the issue below.
Reviewed-by: Simon Horman
> >
o Alonso
> Signed-off-by: Lorenzo Bianconi
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Apr 18, 2023 at 04:14:30PM +0200, Lorenzo Bianconi wrote:
> Remove tunnel interfaces from egress list in order to not shape them.
>
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2129742
> Tested-by: Rodolfo Alonso
> Signed-off-by: Lorenzo Bianconi
Reviewed-b
ures without enabling TSO too.
>
> Signed-off-by: Flavio Leitner
> Co-authored-by: Mike Pattrick
> Signed-off-by: Mike Pattrick
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
hen the packet is going to be sent over
> a device that doesn't support the feature.
>
> Linux devices don't support IP checksum offload alone, so the
> support is not enabled.
>
> Signed-off-by: Flavio Leitner
> Co-authored-by: Mike Pattrick
On Tue, Apr 18, 2023 at 02:58:07PM +0200, David Marchand wrote:
> Caught during some code review.
> SUPPORT_TC_INGRESS_PPS has been replaced with CHECK_TC_INGRESS_PPS().
>
> Fixes: 5f0fdf5e2c2e ("test: Move check for tc ingress pps support to test
> script.")
> Signed-off-by: David Marchand
On Tue, Apr 18, 2023 at 10:34:22AM +0200, David Marchand wrote:
> On Tue, Apr 18, 2023 at 10:20 AM Simon Horman
> wrote:
> >
> > On Mon, Apr 17, 2023 at 06:28:13PM +0200, David Marchand wrote:
> > > Caught during some code review.
> > > The incriminated co
On Mon, Apr 17, 2023 at 06:28:13PM +0200, David Marchand wrote:
> Caught during some code review.
> The incriminated commit had put an unneeded check on tc ingress support
> for the meter offloading test.
>
> Note: SUPPORT_TC_INGRESS_PPS had been reworked in the commit 5f0fdf5e2c2e
> ("test: Move
merge oneline to verbosity in parse_options
> ofp_to_string__ handle verbosity bits right
Thanks, this one looks good to me.
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Apr 10, 2023 at 01:26:12PM -0400, Mark Michelson wrote:
...
> diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c
...
> @@ -2390,6 +2394,16 @@ nbctl_acl_add(struct ctl_context *ctx)
> nbrec_acl_set_options(acl, );
> }
>
> +const char *tier_s =
On Mon, Apr 10, 2023 at 01:26:11PM -0400, Mark Michelson wrote:
> With this commit, ACLs can now be arranged in hierarchical tiers. A tier
> number can be assigned to an ACL. When evaluating ACLs, we first will
> consider ACLs at tier 0. If no matching ACL is found, then we move to
> tier 1. This
On Tue, Apr 11, 2023 at 11:03:46AM +0800, Wan Junjie wrote:
> put dump-meters' result in one line so add-meters can handle.
> save and restore meters when restart ovs.
> bundle functions are not implemented in this patch.
>
> Signed-off-by: Wan Junjie
>
> ---
> v9:
> fix verbosity mask bits for
On Mon, Apr 10, 2023 at 09:23:46PM +0800, Wan Junjie via dev wrote:
> put dump-meters' result in one line so add-meters can handle.
> save and restore meters when restart ovs.
> bundle functions are not implemented in this patch.
>
> Signed-off-by: Wan Junjie
Hi,
unfortunately this one doesn't
Musil
> ---
> v8: No change since v7.
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ceara
> > ---
> > NOTE: this should be applied to branches 22.09, 22.06 and 22.03 (LTS).
> > ---
> > .ci/ovn-kubernetes/Dockerfile| 2 +-
> > .github/workflows/ovn-kubernetes.yml | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
&
On Fri, Apr 07, 2023 at 02:59:04PM +0800, wanghanlin wrote:
> When 'cs' is not connected to a server, then
> ovsdb_cs_db_compose_lock_request__ will update
> 'cs_db' lock flag, but the lock flag will not
> be updated next.
>
> Signed-off-by: wanghanlin
Hi,
Are there also error conditions where
> at utilities/ovs-testcontroller.c:180
>
> Fix that by initing the flow metadata.
>
> Fixes: 35eb6326d5d0 ("ofp-util: Add flow metadata to ofputil_packet_out")
> Signed-off-by: Faicker Mo
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
is longer than 16 bytes, the thread
> name will fail to be set
>
> Signed-off-by: Songtao Zhan
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
gt;
> Reported-at: https://bugzilla.redhat.com/2173635
> Signed-off-by: Ales Musil
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Apr 07, 2023 at 10:44:35AM +0200, Simon Horman wrote:
> On Thu, Apr 06, 2023 at 07:05:13PM -0700, Jakub Kicinski wrote:
> > On Wed, 5 Apr 2023 07:53:41 + Felix Huettner wrote:
> > > assume the following setup on a single machine:
> > > 1. An openvswit
On Thu, Apr 06, 2023 at 07:05:13PM -0700, Jakub Kicinski wrote:
> On Wed, 5 Apr 2023 07:53:41 + Felix Huettner wrote:
> > assume the following setup on a single machine:
> > 1. An openvswitch instance with one bridge and default flows
> > 2. two network namespaces "server" and "client"
> > 3.
On Thu, Mar 30, 2023 at 08:17:18AM +, Naveen Yerramneni wrote:
> Add OpenFlow extn to set conntrack entries limit per zone.
> This extn will be used in future to set the zone level limit for
> drop zones used by OVN.
>
> Signed-off-by: Naveen Yerramneni
> Reviewe
On Thu, Apr 06, 2023 at 05:25:06PM +0200, Dumitru Ceara wrote:
> On 4/6/23 14:45, Simon Horman wrote:
> > On Thu, Apr 06, 2023 at 02:07:00PM +0200, Dumitru Ceara wrote:
> >> On 4/5/23 14:43, Simon Horman wrote:
> >>> On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo
lt reschedule time may be convenient in
> some conditions, like debugging.
> This patch introduces new commands allowing to get and set the sweep
> interval in ms.
>
> Signed-off-by: Paolo Valerio
Reviewed-by: Simon Horman
___
dev ma
On Mon, Apr 03, 2023 at 11:50:26AM +0200, Ales Musil wrote:
> After integration bridge change the tunnels would
> stay on the old bridge preventing new tunnels creation
> and disrupting traffic. Detect the bridge change
> and clear the tunnels from the old integration bridge.
>
> Reported-at:
On Thu, Apr 06, 2023 at 02:13:00PM +0200, Ilya Maximets wrote:
> On 4/6/23 08:38, Simon Horman wrote:
> > On Wed, Apr 05, 2023 at 02:07:42PM +, lin huang wrote:
> >> Hi Simon,
> >>
> >> : )
> >> Thanks for your reply.
> >>
> >>
On Thu, Apr 06, 2023 at 02:07:00PM +0200, Dumitru Ceara wrote:
> On 4/5/23 14:43, Simon Horman wrote:
> > On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo Bianconi wrote:
> >> Similar to qos_max_rate and qos_burst, take into account qos_min_rate in
> >>
On Wed, Apr 05, 2023 at 02:07:42PM +, lin huang wrote:
> Hi Simon,
>
> : )
> Thanks for your reply.
>
> There are some explanations about your comments.
>
> Best regards, Huang Lin.
>
> > -Original Message-
> > From: Simon Horman
>
Hi Wan Junjie,
On Tue, Apr 04, 2023 at 03:42:47PM +0800, Wan Junjie wrote:
> Hi Simon,
>
> On Wed, Mar 29, 2023 at 11:57 PM Simon Horman
> wrote:
> > On Fri, Mar 10, 2023 at 09:03:48PM +0800, Wan Junjie wrote:
...
> > > @@ -805,5 +831,73 @@ ofputil_format_meter_mod
ding a flow per load-balancer backend.
>
> Signed-off-by: Lorenzo Bianconi
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo Bianconi wrote:
> Similar to qos_max_rate and qos_burst, take into account qos_min_rate in
> port_has_qos_params routine.
>
> Fixes: dbf12e5fe1f7 ("qos: add support for port minimum bandwidth guarantee")
> Signed-off-by: Lorenzo Bianconi
Hi
On Tue, Apr 04, 2023 at 01:46:05PM +, lin huang wrote:
> Hi Ilya,
>
> Pls review my code.
>
> I want to add a new policer which is pps-based in netdev-dpdk module.
> The policer is divided into ingress and egress part. Both use the ovs native
> tocken bucket library as the counter.
>
is longer than 16 bytes, the thread
> name will fail to be set
>
> Signed-off-by: Songtao Zhan
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> at utilities/ovs-testcontroller.c:180
>
> Fix that by zeroing out the po variable.
>
> Fixes: 577bfa9f6879 ("ofp-util: Add OpenFlow 1.5 packet-out support")
> Signed-off-by: Faicker Mo
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
nd the loop has run the test 73014 times
without recording any failures.
I think we are good here :)
Reviewed-by: Simon Horman
Tested-by: Simon Horman
>
>
> > +])
> > +NS_CHECK_EXEC([at_ns0], [ping -q -c 2 -i 0.2 10.1.1.3 | FORMAT_PING], [0],
> > [dnl
> > +2 packet
On Fri, Mar 31, 2023 at 02:10:35PM +0200, Dumitru Ceara wrote:
> On 3/31/23 13:52, Simon Horman wrote:
> > On Tue, Mar 21, 2023 at 01:59:06PM -0400, Mark Michelson wrote:
> >> Prior to this commit, ACLs were evaluated and acted on in a single
> >> stage. With this
the storage.
>
> Keep the converted database from the first time around and use it
> after reading the request back from the storage. This cuts in half
> the conversion CPU cost.
>
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
end out all the monitor
> replies in the example above. So, it's a 40x performance improvement.
> On a more reasonable setup with 250 nodes, the process takes up to
> 8-10 seconds instead of 4-5 minutes.
>
> Conditional monitoring will benefit from this change as well, however
> Handled the same way as we did for the previous incompatible format
> change in 2.15 (column diffs).
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2022-December/052140.html
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
mmits targeting
> conversion speed increase.
>
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
, because we shouldn't blindly
> trust the storage.
>
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
t; data. The database file will not be that similar to the original,
> but there is no way to represent conversion in a standalone database
> file format otherwise.
>
> Fixes: 00de46f9ee42 ("ovsdb-tool: Convert clustered db to standalone db.")
> Sign
Signed-off-by: Flavio Leitner
> Co-authored-by: Mike Pattrick
> Signed-off-by: Mike Pattrick
> Reviewed-by: David Marchand
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Mar 27, 2023 at 06:50:10AM -0400, Mike Pattrick wrote:
> From: Flavio Leitner
>
> Document the implementation of netdev hardware offloading
> in userspace datapath.
>
> Signed-off-by: Flavio Leitner
> Co-authored-by: Mike Pattrick
> Signed-off-by: Mike Pattr
On Tue, Mar 21, 2023 at 01:59:06PM -0400, Mark Michelson wrote:
> Prior to this commit, ACLs were evaluated and acted on in a single
> stage. With this commit, evaluation of ACLs and acting on an ACL's
> decision are separated into two stages.
>
> The acl_eval stage checks the ACL match and will
On Fri, Mar 31, 2023 at 12:05:09PM +0200, Ilya Maximets wrote:
> On 3/31/23 11:07, Simon Horman wrote:
> > On Thu, Mar 30, 2023 at 09:04:02PM +0200, Ilya Maximets wrote:
> >> On 3/30/23 11:45, Simon Horman wrote:
> >>> On Fri, Mar 17, 2023 at 09:47:36PM +0100, Eelco
On Thu, Mar 30, 2023 at 05:27:23PM +0800, Faicker Mo wrote:
> The device may be deleted and added with ifindex changed.
> The tc rules on the device will be deleted if the device is deleted.
> The func tc_del_filter will fail when flow del. The mapping of
> ufid to tc will not be deleted.
> The
On Thu, Mar 30, 2023 at 09:04:02PM +0200, Ilya Maximets wrote:
> On 3/30/23 11:45, Simon Horman wrote:
> > On Fri, Mar 17, 2023 at 09:47:36PM +0100, Eelco Chaudron wrote:
> >>
> >>
> >> Send from my phone
> >>
> >>> Op 17 mrt. 2023 om
to HW.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
Documentation/howto/dpdk.rst | 5 +-
lib/netdev-offload-provider.h | 21 +-
lib/netdev-offload-tc.c | 9 ++-
lib/netdev-offload.c | 135
601 - 700 of 4388 matches
Mail list logo
