From: Peng Zhang
Add support of DPDK meter action logic.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-offload-dpdk.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/netdev-offload-dpdk.c b/lib
From: Peng Zhang
For dpif-netdev, meters are mapped by DPDK meter with one-to-one
relationship. Implement meter offload API to set/get/del the DPDK
meter with proxy port id.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev
From: Peng Zhang
Add the meter algorithms. DPDK meter support three algorithms,
and OVS also can support these algorithms.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-dpdk.c | 58
-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/dpif-netdev.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 2c08a71c8db2..e8d0ca6606de 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
From: Peng Zhang
Manage "transfer" flows via the corresponding mechanism.
Doing so requires that the traffic source be specified
explicitly, via the corresponding pattern item.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Co-authored-by: Jin Liu
Signed-off-by: Simon Horman
Hi,
this series adds support for DPDK meter HW offload.
Changes between v2 and v3.
* Use common API for DPDK and non-DPDK meter offloads
* Make use of netdev_ports_traverse to offload the meter
* Add dpdk-latest to subject prefix
Changes between v1 and v2:
* Add the prox mechanism: add the
ke_multinode setup
> by running 'ovn_cluster.sh start'.
>
> This test suite is also triggered for the newly added fake multinode CI
> job.
>
> The fake multinode system tests suite can be enhanced further for new
> features and to cover multi node scenarios.
>
> Signed-off-b
able for every push.
>
> [1] -
> https://github.com/ovn-org/ovn-fake-multinode/blob/main/.ci/test_basic.sh
>
> Signed-off-by: Numan Siddique
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Mar 17, 2023 at 09:47:36PM +0100, Eelco Chaudron wrote:
>
>
> Send from my phone
>
> > Op 17 mrt. 2023 om 21:11 heeft Marcelo Ricardo Leitner
> > het volgende geschreven:
> >
> > On Thu, Mar 16, 2023 at 09:51:34AM +0100, Eelco Chaudron wrote:
> >>
> >>
> >>> On 22 Dec 2022, at
On Wed, Mar 22, 2023 at 09:35:29PM +0100, Ilya Maximets wrote:
> On 3/9/23 14:02, Simon Horman wrote:
> > From: Peng Zhang
...
> > diff --git a/lib/netdev-offload-provider.h b/lib/netdev-offload-provider.h
> > index 9108856d18d1..7ecbb8d026f1 100644
> > --- a/li
On Thu, Mar 30, 2023 at 11:13:32AM +0800, Faicker Mo wrote:
> Thanks for your testing.
> Add the ignore msg "failed to offload flow" to OVS_TRAFFIC_VSWITCHD_STOP can
> pass the fail test.
> I'll post an update later.
Thanks. I'll look out for it.
> From: Simon Horman
On Fri, Mar 10, 2023 at 09:03:48PM +0800, Wan Junjie wrote:
> put dump-meters' result in one line so add-meters can handle.
> save and restore meters when restart ovs.
> bundle functions are not implemented in this patch.
>
> Signed-off-by: Wan Junjie
>
> ---
> v5:
> merge oneline to verbosity
On Tue, Mar 28, 2023 at 01:45:22PM +0200, Eelco Chaudron wrote:
>
>
> On 10 Mar 2023, at 17:20, Simon Horman wrote:
>
> > On Fri, Mar 10, 2023 at 10:15:44AM +0100, Simon Horman wrote:
> >> On Thu, Mar 09, 2023 at 05:22:43PM +0100, Eelco Chaudron wrote:
> >>&
lt reschedule time may be convenient in
> some conditions, like debugging.
> This patch introduces new commands allowing to get and set the sweep
> next run in ms.
>
> Signed-off-by: Paolo Valerio
Reviewed-by: Simon Horman
___
dev ma
.
The code looks good to me, thanks for addressing by review of v2.
> Signed-off-by: Naveen Yerramneni
> Reviewed-by: Simon Horman
> ---
> Notes:
> v1 -> v2
> - Fix memory leak and added logs
> v2 -> v3
> - Addressed nits
...
_
he rest succeeded:
a success rate of 99.95% :)
As it's not entirely clear how reliable such a setup is
(or our expectations for it) [1], I think I am ok with this patch.
Reviewed-by: Simon Horman
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2023-March/403164.html
For the record, of the failur
On Wed, Mar 15, 2023 at 05:11:01PM +0800, Faicker Mo wrote:
> Derivation cases of CVE-2020-35498:
> 1. invalid ipv4 header total-length field
> 2. invalid ipv6 header payload-length field
> These may cause unwanted flow to send to datapath.
>
>
> Signed-off-by: Faicker Mo
I think the immediate
On Fri, Mar 24, 2023 at 01:03:00PM +0100, Ilya Maximets wrote:
> On 3/23/23 03:57, Nobuhiro MIKI wrote:
> > On 2023/03/22 21:21, Simon Horman wrote:
> >> On Wed, Mar 15, 2023 at 03:07:23PM +0900, Nobuhiro MIKI wrote:
> >>> Checks whether IPPROTO_ROUTING exists
On Wed, Mar 15, 2023 at 03:07:23PM +0900, Nobuhiro MIKI wrote:
> Checks whether IPPROTO_ROUTING exists in the IPv6 extension headers.
> If it exists, the first address is retrieved.
>
> Signed-off-by: Nobuhiro MIKI
Hi Miki-san,
this also looks good to me.
I have made a few suggestions for
On Wed, Mar 15, 2023 at 03:07:22PM +0900, Nobuhiro MIKI wrote:
> In some tunnels, inner packet needs to support both IPv4
> and IPv6. Therefore, this patch improves to allow two
> protocols to be tied together in one tunneling.
>
> Signed-off-by: Nobuhiro MIKI
Hi Miki-san,
in general this
On Tue, Mar 21, 2023 at 06:05:20PM +0100, Ilya Maximets wrote:
> On 3/15/23 16:18, Marcelo Ricardo Leitner wrote:
> > On Wed, Mar 15, 2023 at 09:33:09AM +0100, Simon Horman wrote:
> >> On Tue, Mar 14, 2023 at 06:49:25PM +0100, Ilya Maximets wrote:
> >>> On 3/1
On Mon, Mar 20, 2023 at 09:51:48AM +0200, Roi Dayan wrote:
>
>
> On 14/03/2023 13:04, Simon Horman wrote:
> > On Mon, Mar 13, 2023 at 07:47:14PM +0200, Roi Dayan wrote:
> >>
> >>
> >> On 13/03/2023 14:16, Simon Horman wrote:
> >>> On
On Wed, Mar 15, 2023 at 11:52:16AM +0200, Oz Shlomo wrote:
>
> On 15/03/2023 11:00, Simon Horman wrote:
> > On Mon, Mar 13, 2023 at 12:27:51PM +0200, Roi Dayan wrote:
> > > From: Oz Shlomo
> > >
> > > Currently jumping over a output-to-port action
On Mon, Mar 13, 2023 at 08:16:35AM +0100, Ales Musil wrote:
> Fixes: 08146bf7d9b4 ("openflow: Add extension to flush CT by generic match.")
> Signed-off-by: Ales Musil
Reviewed-by: Simon Horman
___
dev mailing list
d...@openv
atapath as first argument
> and use it accordingly.
>
> Also add couple of test cases to ensure that everything works as
> expocted.
>
> Fixes: a9ae73b916ba ("ofp, dpif: Allow CT flush based on partial match.")
> Signed-off-by: Ales Musil
Reviewed-by: Simon Horman
___
On Mon, Mar 13, 2023 at 12:27:51PM +0200, Roi Dayan wrote:
> From: Oz Shlomo
>
> Currently jumping over a output-to-port action is translated to tc
> mirror action and stolen control action.
> However, the tc control action is not propagated to the hw offload action,
> thus the hardware action
;
>
> > On 14-Mar-2023, at 6:17 PM, Simon Horman wrote:
> >
> > On Tue, Mar 14, 2023 at 10:51:55AM +, Naveen Yerramneni wrote:
> >> Add OpenFlow extn to set conntrack entries limit per zone.
> >>
> >> Signed-off-by: Naveen Yerramneni
>
On Tue, Mar 14, 2023 at 06:49:25PM +0100, Ilya Maximets wrote:
> On 3/14/23 12:15, Simon Horman wrote:
> > On Mon, Mar 13, 2023 at 09:34:30PM +0100, Ilya Maximets wrote:
> >> On 3/13/23 11:27, Roi Dayan wrote:
> >>> From: Oz Shlomo
> >>>
> >&
On Tue, Mar 14, 2023 at 04:12:53PM +0100, Ales Musil wrote:
> On Tue, Mar 14, 2023 at 3:44 PM Simon Horman
> wrote:
>
> > On Tue, Mar 14, 2023 at 11:53:20AM +0100, Ales Musil wrote:
> > > In order to use the containers in CI add job
> > > that will bui
On Tue, Mar 14, 2023 at 11:53:20AM +0100, Ales Musil wrote:
> In order to use the containers in CI add job
> that will build the containers once every week.
>
> The job will automatically build for arm64
> and x86_64.
I am seeing a number of workflow job failures with this patchset applied:
On Tue, Mar 14, 2023 at 10:51:55AM +, Naveen Yerramneni wrote:
> Add OpenFlow extn to set conntrack entries limit per zone.
>
> Signed-off-by: Naveen Yerramneni
Hi Naveen,
There were 4 postings of this patchset yesterday, and one so far today.
Please consider allowing 24h between postings
On Mon, Mar 13, 2023 at 09:34:30PM +0100, Ilya Maximets wrote:
> On 3/13/23 11:27, Roi Dayan wrote:
> > From: Oz Shlomo
> >
> > Currently jumping over a output-to-port action is translated to tc
> > mirror action and stolen control action.
> > However, the tc control action is not propagated to
On Mon, Mar 13, 2023 at 07:47:14PM +0200, Roi Dayan wrote:
>
>
> On 13/03/2023 14:16, Simon Horman wrote:
> > On Mon, Mar 13, 2023 at 12:31:49PM +0200, Roi Dayan wrote:
> >>
> >>
> >> On 13/03/2023 11:01, Eelco Chaudron wrote:
> >>>
On Mon, Mar 13, 2023 at 03:29:19PM +0100, Ales Musil wrote:
> On Mon, Mar 13, 2023 at 1:08 PM Simon Horman
> wrote:
> > On Mon, Mar 13, 2023 at 08:20:32AM +0100, Ales Musil wrote:
> > > On Fri, Mar 10, 2023 at 2:25 PM Simon Horman
> > > wrote:
> > > >
On Mon, Mar 13, 2023 at 12:31:49PM +0200, Roi Dayan wrote:
>
>
> On 13/03/2023 11:01, Eelco Chaudron wrote:
> >
> >
> > On 13 Mar 2023, at 9:38, Roi Dayan wrote:
> >
> >> On 22/02/2023 12:30, Roi Dayan wrote:
> >>> Sometimes there is a need to clean empty chains as done in
> >>>
On Mon, Mar 13, 2023 at 10:21:03AM +0100, Ales Musil wrote:
> On Fri, Mar 10, 2023 at 11:11 AM Simon Horman
> wrote:
>
> > On Thu, Mar 09, 2023 at 07:17:15AM +0100, Ales Musil wrote:
> > > There was a race within packet buffering that could
> > > result in fi
On Mon, Mar 13, 2023 at 08:20:32AM +0100, Ales Musil wrote:
> On Fri, Mar 10, 2023 at 2:25 PM Simon Horman
> wrote:
>
> > On Thu, Mar 09, 2023 at 07:16:04AM +0100, Ales Musil wrote:
> > > There are essentially three problems with the current
> > > combination
On Fri, Mar 10, 2023 at 10:15:44AM +0100, Simon Horman wrote:
> On Thu, Mar 09, 2023 at 05:22:43PM +0100, Eelco Chaudron wrote:
> >
> >
> > On 9 Mar 2023, at 15:42, Simon Horman wrote:
> >
> > > On Wed, Mar 08, 2023 at 04:18:47PM +0100, Eelco Chaudron wr
On Thu, Mar 09, 2023 at 07:16:04AM +0100, Ales Musil wrote:
> There are essentially three problems with the current
> combination of DGP + SNAT + LB:
>
> 1) The first packet is being SNATed in common zone due
> to a problem with pinctrl not preserving ct_mark/ct_label.
> The commit would create a
On Fri, Mar 10, 2023 at 10:36:38AM +0100, Ales Musil wrote:
> On Fri, Mar 10, 2023 at 9:58 AM Simon Horman
> wrote:
>
> > On Thu, Mar 09, 2023 at 03:00:40PM +0100, Ales Musil wrote:
> > > Specifying datapath with "dpctl/flush-conntrack" didn't
> > > w
On Thu, Mar 09, 2023 at 07:17:15AM +0100, Ales Musil wrote:
> There was a race within packet buffering that could
> result in first packt being dropped. It could happen
> under following conditions and topology:
> S1 == R1 == public == R2 == S2
> SNAT on R1 and DGP on port connecting R1 with
gned-off-by: Eelco Chaudron
> ---
> v2: Moved time_msec() after udpif_get_n_flows().
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Mar 10, 2023 at 02:49:06PM +0900, Nobuhiro MIKI wrote:
> On 2023/01/17 18:41, Nobuhiro MIKI wrote:
> > SRv6 (Segment Routing IPv6) tunnel vport is responsible
> > for encapsulation and decapsulation the inner packets with
> > IPv6 header and an extended header called SRH
> > (Segment
On Fri, Mar 10, 2023 at 07:12:33AM +0100, Frode Nordahl wrote:
> On Thu, Mar 9, 2023 at 5:26 PM Ilya Maximets wrote:
...
> > > GHA is kind of hard to debug. Cirrus has a way to give you a console
> > > access to the running job, but GHA doesn't have that.
>
> fwiw; There are third party
On Thu, Mar 09, 2023 at 05:22:43PM +0100, Eelco Chaudron wrote:
>
>
> On 9 Mar 2023, at 15:42, Simon Horman wrote:
>
> > On Wed, Mar 08, 2023 at 04:18:47PM +0100, Eelco Chaudron wrote:
> >> Run "make check-offloads" as part of the GitHub actions tests.
>
?
> Signed-off-by: Lorenzo Bianconi
Reviewed-by: Simon Horman
> ---
> controller/lflow.c | 19 ++--
> tests/ovn.at | 115 +
> 2 files changed, 129 insertions(+), 5 deletions(-)
>
> diff --git a/controller/lflow.c b/controller/
On Thu, Mar 09, 2023 at 03:00:40PM +0100, Ales Musil wrote:
> Specifying datapath with "dpctl/flush-conntrack" didn't
> work as expected and caused error:
> ovs-dpctl: field system@ovs-system missing value (Invalid argument)
>
> To prevent that check if we have datapath as first argument
> and
On Wed, Mar 08, 2023 at 04:18:47PM +0100, Eelco Chaudron wrote:
> Run "make check-offloads" as part of the GitHub actions tests.
>
> This test was run 25 times using GitHub actions, and the
> failing rerun test cases where excluded. There are quite some
> first-run failures, but unfortunately,
On Wed, Mar 08, 2023 at 04:18:02PM +0100, Eelco Chaudron wrote:
> Combine the ASAN and UBSAN tests into a single sanitizer run.
>
> Signed-off-by: Eelco Chaudron
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.
L4
> destination in registers. Match directly on
> L3 and L4 destination for ct.new in DNAT stage.
>
> Populate the registers in LB affinity check stage
> as they are needed for LB affinity learn.
>
> Reported-at: https://bugzilla.redhat.com/2172048
> Report
On Wed, Mar 08, 2023 at 03:32:11PM +0100, Ales Musil wrote:
> The test with jemalloc and clang is redundant as
> we are already testing jemalloc with gcc. Replace
> it with system-test-userspace which runs system tests
> over userspace OvS datapath.
>
> Tested-by: Simon Ho
On Wed, Mar 08, 2023 at 03:32:10PM +0100, Ales Musil wrote:
> To be consistent moe the LB affinity tests into system-ovn-kmod
> for now as they are waiting currently not working with
> userspace datapath.
>
> Signed-off-by: Ales Musil
Reviewed-by: Simon Horman
Tested-b
On Wed, Mar 08, 2023 at 03:32:09PM +0100, Ales Musil wrote:
> The dpctl/del-flows shouldn't be used on running
> ofproto layer, use revalidator/purge instead.
>
> Signed-off-by: Ales Musil
Reviewed-by: Simon Horman
___
dev ma
DD_VETH instead. Also remove ADD_INT as it
> is not used anywhere else.
>
> Signed-off-by: Ales Musil
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
n represtend as error by the
> NS_CHECK_EXEC:
>
> ping6: sock4.fd: -1 (socktype: 0), sock6.fd: 3 (socktype: SOCK_RAW),
> hints.ai_family: AF_INET6
>
> There is also possibility to ignore
> the stderr, but it doesn't bring any value
> to the test.
>
> Si
On Wed, Mar 08, 2023 at 03:32:05PM +0100, Ales Musil wrote:
> Add support for running system tests with
> OvS userspace netdev.
>
> Signed-off-by: Ales Musil
Reviewed-by: Simon Horman
Reviewed-by: Simon Horman
___
dev ma
From: Peng Zhang
For dpif-netdev, meters are mapped by DPDK meter with one-to-one
relationship. Implement meter offload API to set/get/del the DPDK
meter with proxy port id.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-dpdk.c | 202
From: Peng Zhang
Add the meter algorithms. DPDK meter support three algorithms,
and OVS also can support these algorithms.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-dpdk.c | 58 +--
1 file changed
From: Peng Zhang
Add support of DPDK meter action logic.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-offload-dpdk.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index
-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/dpif-netdev.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 2c08a71c8db2..e8d0ca6606de 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -7277,6 +7277,11
Signed-off-by: Jin Liu
Signed-off-by: Simon Horman
---
Documentation/howto/dpdk.rst | 5 +-
lib/netdev-offload-provider.h | 30 +++
lib/netdev-offload.c | 99 +++
lib/netdev-offload.h | 9
4 files changed, 141 insertions(+), 2
Hi,
this series adds support for DPDK meter HW offload.
Peng Zhang (6):
netdev-offload-dpdk: use flow transfer proxy
netdev-offload: Add DPDK meter offload API
dpif-netdev: Offloading meter with DPDK
netdev-offload-dpdk: Implement meter offload API for DPDK
netdev-dpdk: add meter
From: Peng Zhang
Manage "transfer" flows via the corresponding mechanism.
Doing so requires that the traffic source be specified
explicitly, via the corresponding pattern item.
Signed-off-by: Peng Zhang
Signed-off-by: Jin Liu
Signed-off-by: Simon Horman
---
lib/netdev-d
> > >
> > >
> > > -Egress Table 5: Delivery
> > > +Egress Table 6: Delivery
> > >
> > >
> > >Packets that reach this table are ready for delivery. It contai
t;
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2170885
> Fixes: d91f359b7694 ("northd: Add VIP port to established flows in DNAT table
> for Load Balancers")
> Signed-off-by: Lorenzo Bianconi
Reviewed-by: Simon Horman
___
info (e.g.
> L4 protocol port) since they are not available in all IP fragment.
>
> Signed-off-by: Lorenzo Bianconi
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Mar 07, 2023 at 04:58:47PM +0100, Eelco Chaudron wrote:
>
>
> On 7 Mar 2023, at 16:32, Eelco Chaudron wrote:
>
> > On 3 Mar 2023, at 16:15, Simon Horman wrote:
> >
> >> On Tue, Feb 28, 2023 at 04:52:15PM +0100, Eelco Chaudron wrote:
> >>> Ru
On Tue, Mar 07, 2023 at 11:57:16AM +0100, Lorenzo Bianconi wrote:
> Drop ip packets with ct status set to invalid in post snat and
> lb_aff_learn router stages.
> Skip ICMPv{4,6} error messages packet in ct.inv rules in order to avoid
> to introduce too complicated code.
>
> Reported-at:
On Tue, Mar 07, 2023 at 12:24:55PM +0800, Wan Junjie wrote:
> Hi Simon Horman,
>
> Thanks for your review.
>
>
> On Mon, Mar 6, 2023 at 11:23 PM Simon Horman
> wrote:
> > On Sat, Mar 04, 2023 at 11:23:50AM +0800, Wan Junjie wrote:
...
> > > On Fri,
On Sat, Mar 04, 2023 at 11:23:50AM +0800, Wan Junjie wrote:
> Hi Simon,
>
> Thanks for the review.
Hi Wan Junjie,
Thanks for responding.
> On Fri, Mar 3, 2023 at 11:06 PM Simon Horman
> wrote:
> > On Wed, Mar 01, 2023 at 04:05:17PM +0800, Wan Junjie wrote:
...
> &g
ution specific ways to do capability
> management as well (using for example, systemd), but they are not
> as universal to the vswitchd as a flag.
>
> Signed-off-by: Aaron Conole
Fun times.
Minor nit below not withstanding this looks good to me,
within the context of the desc
On Tue, Feb 28, 2023 at 04:52:15PM +0100, Eelco Chaudron wrote:
> Run "make check-offloads" as part of the GitHub actions tests.
>
> This test was run 25 times using GitHub actions, and the
> failing rerun test cases where excluded. There are quite some
> first-run failures, but unfortunately,
On Wed, Mar 01, 2023 at 04:05:17PM +0800, Wan Junjie wrote:
> put dump-meters' result in one line so add-meters can handle.
> save and restore meters when restart ovs.
> bundle functions are not implemented in this patch.
>
> Signed-off-by: Wan Junjie
>
> ---
> v4:
> code refactor according to
On Thu, Mar 02, 2023 at 03:57:42PM +0800, Faicker Mo wrote:
> The device may be deleted and added with ifindex changed.
> The tc rules on the device will be deleted if the device is deleted.
> The func tc_del_filter will fail when flow del. The mapping of
> ufid to tc will not be deleted.
> The
On Thu, Mar 02, 2023 at 01:03:32PM +0100, Lorenzo Bianconi wrote:
> Drop ip packets with ct status set to invalid in post snat and
> lb_aff_learn router stages.
> Skip ICMPv{4,6} error messages packet in ct.inv rules in order to avoid
> to introduce too complicated code.
>
> Reported-at:
On Thu, Mar 02, 2023 at 09:08:49AM +0100, Ales Musil wrote:
> There is a bug in userspace datapath that causes
> failures within the LB affinity test [0].
> Skip the test until the bug is fixed.
>
> [0] https://bugzilla.redhat.com/2170828
> Tested-by: Simon Horman
> Sign
On Thu, Mar 02, 2023 at 09:08:51AM +0100, Ales Musil wrote:
> The test with jemalloc and clang is redundant as
> we are already testing jemalloc with gcc. Replace
> it with system-test-userspace which runs system tests
> over userspace OvS datapath.
>
> Tested-by: Simon Ho
use ADD_VETH instead. Also encourage this in
> documentation for ADD_INT, because there should
> be good reasoning behind using internal interface.
>
> Signed-off-by: Ales Musil
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
n represtend as error by the
> NS_CHECK_EXEC:
>
> ping6: sock4.fd: -1 (socktype: 0), sock6.fd: 3 (socktype: SOCK_RAW),
> hints.ai_family: AF_INET6
>
> There is also possibility to ignore
> the stderr, but it doesn't bring any value
> to the test.
>
> Si
On Thu, Mar 02, 2023 at 02:14:24PM +0100, Dumitru Ceara wrote:
> On 3/2/23 14:11, Ilya Maximets wrote:
> > This patch set optimizes usage of string operations and avoids parsing
> > same LSP addresses multiple times.
> >
> > Performance tests with ovn-heater show 5-10% improvement in high-scale
>
arse IPv4 twice.
>
> Signed-off-by: Ilya Maximets
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Mar 02, 2023 at 08:51:18AM +0100, Simon Horman wrote:
> On Wed, Mar 01, 2023 at 02:27:29PM -0800, Han Zhou wrote:
> > On Wed, Mar 1, 2023 at 1:50 AM Simon Horman
> > wrote:
> > >
> > > On Wed, Feb 22, 2023 at 10:35:25PM -0800, Han Zhou wrote:
> >
On Wed, Mar 01, 2023 at 02:27:29PM -0800, Han Zhou wrote:
> On Wed, Mar 1, 2023 at 1:50 AM Simon Horman
> wrote:
> >
> > On Wed, Feb 22, 2023 at 10:35:25PM -0800, Han Zhou wrote:
> >
> > Please add a patch description here.
>
> Thank Simon for reviewing. For t
is some discussion in another sub thread about
the best best approach to this problem from a consistency PoV.
That notwithstanding I did exercise this patch.
And it did work as expected.
Tested-by: Simon Horman
___
dev mailing list
d...@ope
On Wed, Mar 01, 2023 at 05:00:24PM +0100, Ales Musil wrote:
> On Wed, Mar 1, 2023 at 4:30 PM Simon Horman
> wrote:
>
> > On Tue, Feb 21, 2023 at 01:32:04PM +0100, Ales Musil wrote:
> > > The ADD_INT does not work very well with userspace datapath.
> > > To a
On Wed, Mar 01, 2023 at 04:53:57PM +0100, Ales Musil wrote:
> On Wed, Mar 1, 2023 at 3:47 PM Simon Horman
> wrote:
>
> > On Tue, Feb 21, 2023 at 01:32:03PM +0100, Ales Musil wrote:
> > > Newer versions of ping6 print some info to
> > > stderr when specified wit
On Wed, Mar 01, 2023 at 04:43:31PM +0100, Simon Horman wrote:
> On Tue, Feb 21, 2023 at 01:32:01PM +0100, Ales Musil wrote:
> > Add support for running system tests with
> > OvS userspace netdev.
> >
> > Signed-off-by: Ales Musil
>
> Reviewed-by: Simon Hor
l
FWIIW, I would prefer 2 patches, one for each change.
But in any case I did exercise this, and it did work.
Link: https://github.com/horms/ovn/actions/runs/4304595329
Tested-by: Simon Horman
> ---
> .github/workflows/test.yml | 6 +++---
> 1 file changed, 3 insertions(+), 3 d
On Tue, Feb 21, 2023 at 01:32:05PM +0100, Ales Musil wrote:
> The dpctl/del-flows shouldn't be used on running
> ofproto layer, use revalidator/purge instead.
>
> Signed-off-by: Ales Musil
Reviewed-by: Simon Horman
Tested-by: Simon Horman
___
On Tue, Feb 21, 2023 at 01:32:01PM +0100, Ales Musil wrote:
> Add support for running system tests with
> OvS userspace netdev.
>
> Signed-off-by: Ales Musil
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswit
On Wed, Mar 01, 2023 at 09:04:40AM -0500, Mark Michelson wrote:
> On 3/1/23 01:49, Simon Horman wrote:
> > On Wed, Mar 01, 2023 at 07:31:04AM +0100, Ales Musil wrote:
> > > On Tue, Feb 28, 2023 at 8:03 PM Mark Michelson
> > > wrote:
> > >
> > > >
On Tue, Feb 21, 2023 at 01:32:04PM +0100, Ales Musil wrote:
> The ADD_INT does not work very well with userspace datapath.
> To avoid any warnings that might fail the tests
> use ADD_VETH instead. Also encourage this in
> documentation for ADD_INT, because there should
> be good reasoning behind
On Tue, Feb 21, 2023 at 01:32:03PM +0100, Ales Musil wrote:
> Newer versions of ping6 print some info to
> stderr when specified with -v flag. This info
> causes tests to fail. Do not use the verbose
> output.
>
> Signed-off-by: Ales Musil
I think it would be useful to describe the difference
vS userspace netdev.
>
> Signed-off-by: Ales Musil
Reviewed-by: Simon Horman
Tested-by: Simon Horman
> ---
> ovs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovs b/ovs
> index 8986d4d55..b72a7f925 16
&g
will be the first entry,
> > and now the dp flow can't be deleted.
> >
> >
> > Signed-off-by: Faicker Mo
>
> Change looks good to me! Did some testing and found no issues.
>
> Acked-by: Eelco Chaudron
Looks good to me too.
Reviewed-by: Simon Horman
I
On Wed, Mar 01, 2023 at 11:21:02AM +0100, Eelco Chaudron wrote:
>
>
> On 28 Feb 2023, at 17:23, Simon Horman wrote:
>
> > On Tue, Feb 28, 2023 at 04:24:57PM +0100, Eelco Chaudron wrote:
> >>
> >>
> >> On 16 Feb 2023, at 13:21, Eelco Chaudron wro
On Wed, Feb 22, 2023 at 10:35:25PM -0800, Han Zhou wrote:
Please add a patch description here.
> Signed-off-by: Han Zhou
> ---
> tests/atlocal.in| 3 +
> tests/system-ovn.at | 146
> 2 files changed, 149 insertions(+)
...
>
s_not_present() would always fail.
>
> This patch corrects the table id and fixes the ACLs with proper IP
> protocol, and updates the check_virtual_offlows_xxx() functions so that
> only ipv4 flows are dumpped and checked which is what those func
ails. Change the condition
> to be greater or equal to one.
>
> Signed-off-by: Ales Musil
Thanks, this looks good to me.
Reviewed-by: Simon Horman
I have also tested that it significantly improves the reliability of:
check-kernel: 100 times without this failure mode [*]
check-system-userspa
On Wed, Mar 01, 2023 at 07:31:04AM +0100, Ales Musil wrote:
> On Tue, Feb 28, 2023 at 8:03 PM Mark Michelson wrote:
>
> > Hi Ales,
> >
>
> > May I suggest placing the tests that are failing with the userspace
> > datapath into the tests/system-ovn-kmod.at file? The current structure
> > of the
701 - 800 of 4388 matches
Mail list logo
