On Tue, May 28, 2024 at 7:46 AM Eelco Chaudron wrote:
>
> Fix unintentional integer overflow reported by Coverity by adding
> the ULL suffix to the numerical literals used in the multiplications.
>
> Fixes: ed2300cca0d3 ("netdev-linux: Refactor put police action netlink
> message")
>
On 24 May 2024, at 11:20, Emma Finn wrote:
> The AVX implementation for calcualting checksums was not
> handling carry-over addition correctly in some cases.
> This patch adds an additional shuffle to add 16-bit padding to
> the final part of the calculation to handle such cases. This
> commit
On 5/28/24 13:27, Eelco Chaudron wrote:
>
>
> On 28 May 2024, at 1:04, Neil McKee wrote:
>
>> Would it help if I set up a separate github project for this sFlow encoding
>> C code? Then we could make it easier to incorporate in OVS by fixing the
>> whitespace and indentation issues there, and
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 97 characters long (recommended limit is 79)
#38 FILE: lib/sflow_api.h:255:
This patch fixes an uninitialized gso_type case in
netdev_linux_prepend_vnet_hdr() by returning an error.
Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
Signed-off-by: Eelco Chaudron
---
lib/netdev-linux.c | 5 +
1 file changed, 5 insertions(+)
diff --git
Coverity was flagged that the uninitialized output variable was used
in the ctl_context_init_command() function. This patch initializes
the variable.
In addition it also destroys the ds string in ctl_context_done()
in case it's not cleared properly.
Fixes: 07ff77ccb82a ("db-ctl-base: Make common
Fix the warning from Coverity about potential truncation of the
time_t value when copying to a local variable by changing the
local variable's type to time_t.
ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static fdb
entry.")
Signed-off-by: Eelco Chaudron
---
Changed sFlowRcvrTimeout to a uint32_t to avoid time_t warnings
reported by Coverity. A uint32_t is more than large enough as
this is a (seconds) tick counter and OVS is not even using this.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
Signed-off-by: Eelco Chaudron
Fix unintentional integer overflow reported by Coverity by adding
the LL suffix to the numerical literals used in the multiplication.
Fixes: 5767a79a4059 ("cfm: Require ccm received in demand mode.")
Signed-off-by: Eelco Chaudron
---
lib/cfm.c | 2 +-
1 file changed, 1 insertion(+), 1
The sFlow library uses a uint32_t to configure timeout ticks, but
stores this value as a time_t. Although this doesn't cause functional
issues, it wastes space and confuses Coverity, potentially indicating
a Y2K38 problem when storing uint32_t values in time_t. This patch
updates the internal data
Coverity has flagged the use of a potentially unsafe function.
Although this is not a concern in this case since it's not used for
encryption, we should replace it with the OVS implementation to
achieve better randomness.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build
Fix unintentional integer overflow reported by Coverity by adding
the ULL suffix to the numerical literals used in the multiplications.
Fixes: ed2300cca0d3 ("netdev-linux: Refactor put police action netlink message")
Signed-off-by: Eelco Chaudron
---
lib/netdev-linux.c | 4 ++--
1 file changed,
This series addresses several high-priority Coverity issues.
Delta from v1 -> v2:
- Add cover letter.
- Split first patch and update commit subject.
- Added ds_destroy() to context_done().
- Changed invalid gso_type handling by returning an error + log message.
- Changed sFlowRcvrTimeout to be
On 28 May 2024, at 1:04, Neil McKee wrote:
> Would it help if I set up a separate github project for this sFlow encoding
> C code? Then we could make it easier to incorporate in OVS by fixing the
> whitespace and indentation issues there, and maybe change all the "time_t"
> variables to
On 27 May 2024, at 16:42, Ilya Maximets wrote:
> On 5/27/24 13:01, Eelco Chaudron wrote:
>> Instead of casting time_t to uint32_t for the 0x comparison,
>> define a TIME_T_MAX and use it for both setting and comparison.
>>
>> Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the
On 27 May 2024, at 16:56, Ilya Maximets wrote:
> On 5/27/24 13:01, Eelco Chaudron wrote:
>> This patch fixes a uninitialized gso_type case in
>> netdev_linux_prepend_vnet_hdr().
>>
>> Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
>> Signed-off-by: Eelco Chaudron
On 27 May 2024, at 16:50, Ilya Maximets wrote:
> On 5/27/24 13:01, Eelco Chaudron wrote:
>> Coverity was flagged that the uninitialized output variable was used
>> in the ctl_context_init_command() function. This patch initializes
>> the variable.
>>
>> Fixes: 07ff77ccb82a ("db-ctl-base: Make
Update the CI and docs to use DPDK 22.11.5.
Signed-off-by: Kevin Traynor
---
v2: no change
---
.github/workflows/build-and-test.yml | 2 +-
Documentation/faq/releases.rst | 6 +++---
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files
Update the CI and docs to use DPDK 23.11.1.
Signed-off-by: Kevin Traynor
---
v2: update NEWS
---
.github/workflows/build-and-test.yml | 4 ++--
Documentation/faq/releases.rst | 10 +-
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
Update the CI and docs to use DPDK 22.11.5.
Signed-off-by: Kevin Traynor
---
v2: no change
---
.github/workflows/build-and-test.yml | 2 +-
Documentation/faq/releases.rst | 8
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files
Update the CI and docs to use DPDK 23.11.1.
Signed-off-by: Kevin Traynor
---
v2: update NEWS
---
.github/workflows/build-and-test.yml | 4 ++--
Documentation/faq/releases.rst | 10 +-
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
Update the CI and docs to use DPDK 21.11.7.
Signed-off-by: Kevin Traynor
---
v2: no change
---
.ci/linux-build.sh | 2 +-
Documentation/faq/releases.rst | 2 +-
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files
Update the CI and docs to use DPDK 21.11.7.
Signed-off-by: Kevin Traynor
---
v2: no change
---
.ci/linux-build.sh | 2 +-
Documentation/faq/releases.rst | 4 ++--
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files
On 27/05/2024 23:28, Ilya Maximets wrote:
> On 5/23/24 18:00, Kevin Traynor wrote:
>> Update the CI and docs to use DPDK 23.11.1.
>>
>> Signed-off-by: Kevin Traynor
>> ---
>> .github/workflows/build-and-test.yml | 4 ++--
>> Documentation/faq/releases.rst | 10 +-
>>
Getting the following message while trying to build a debian package.
debian/openvswitch-switch.init
debian/openvswitch-switch.postinst
See above for files that use tabs for indentation.
Please use spaces instead.
Fix it.
Signed-off-by: Roi Dayan
---
debian/openvswitch-switch.init | 22
On 27 May 2024, at 16:04, Ilya Maximets wrote:
> On 5/27/24 13:01, Eelco Chaudron wrote:
>> Fix three Unintentional integer overflow reports by adding the
>> ULL/LL suffix to the numerical literals used in the multiplications.
>>
>> Fixes: 5767a79a4059 ("cfm: Require ccm received in demand
Would it help if I set up a separate github project for this sFlow encoding
C code? Then we could make it easier to incorporate in OVS by fixing the
whitespace and indentation issues there, and maybe change all the "time_t"
variables to uint32_t to save unnecessary headaches like these. (We
On 5/23/24 18:00, Kevin Traynor wrote:
> Update the CI and docs to use DPDK 23.11.1.
>
> Signed-off-by: Kevin Traynor
> ---
> .github/workflows/build-and-test.yml | 4 ++--
> Documentation/faq/releases.rst | 10 +-
> Documentation/intro/install/dpdk.rst | 8
> NEWS
On 5/23/24 18:00, Kevin Traynor wrote:
> Update the CI and docs to use DPDK 23.11.1.
>
> Signed-off-by: Kevin Traynor
> ---
> .github/workflows/build-and-test.yml | 4 ++--
> Documentation/faq/releases.rst | 10 +-
> Documentation/intro/install/dpdk.rst | 8
> NEWS
Bleep bloop. Greetings John Hubbard, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: sha1 information is lacking or useless
(tools/testing/selftests/net/Makefile).
error:
When a row is modified, python IDL doesn't perform any operations on
existing client-side indexes. This means that if the column on which
index is created changes, the old value will remain in the index and
the new one will not be added to the index. Beside lookup failures
this is also causing
When building with clang, via:
make LLVM=1 -C tools/testing/selftest
...clang warns that "a variable sized type not at the end of a struct or
class is a GNU extension".
These cases are not easily changed, because they involve structs that
are part of the API. Fortunately, however, the tests
Clang's static analyzer noted that the output from
netdev_linux_get_speed_locked can be checked even if this function
doesn't set any values.
Now we always set those values to a sane default in all cases.
Fixes: b8f8fad86435 ("netdev-linux: Use speed as max rate in tc classes.")
Signed-off-by:
When retrieving a list of features supported by a network card, return
with an error code if the request completed without an error but the
list contains zero entries.
In practice this should never happen, but it does contribute to a
detection in Clang's static analyzer.
Fixes: 6c59c195266c
Clang's static analyzer will complain about a null pointer dereference
because dumps can be set to null and then there is a loop where it could
have been written to. This is a false positive, but only because the
netdev dpif type won't change during this loop.
Instead, return early from the
Clang's static analyzer has identified several instances of uninitialized
variable usage and null pointer dereferences that - while not likely - are
possible. These mostly included making sure that a variable is properly set
or error code properly returned in every error condition.
Signed-off-by:
Clang's static analyzer will complain about an uninitialized value
because we weren't setting a value for ufid_generated in all code paths.
Now we initialize this on declaration. This patch also corrects the
reverse x-mass of variable declaration.
Fixes: bbe2e3928747 ("dpctl: Fix broken flow
Clang's static analyzer will complain about uninitialized value 'hlen'
because we weren't properly checking the error code from a function that
would have initialized the value.
Instead, add a check for that return code.
Fixes: 03fc1ad78521 ("userspace: Add SRv6 tunnel support.")
Signed-off-by:
Clang's static analyzer will complain about uninitialized value
dns_failure because we weren't setting a value for dns_failure in all
code paths.
Now we initialize this in the error conditions of inet_parse_passive and
inet_parse_active.
Fixes: 08e9e5337383 ("ovsdb: raft: Fix inability to read
Currently, GARP/RARP broadcast is sent for VIFs (part of logical
switch with localnet port) after iface-id is set.
This fix is to avoid packet loss during migration if iface-id
is set even before the VM migration is completed.
Signed-off-by: Shibir Basak
Acked-by: Naveen Yerramneni
---
On 5/27/24 13:01, Eelco Chaudron wrote:
> This patch fixes a uninitialized gso_type case in
> netdev_linux_prepend_vnet_hdr().
>
> Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
> Signed-off-by: Eelco Chaudron
> ---
> lib/netdev-linux.c | 3 ++-
> 1 file changed, 2
On 5/27/24 13:01, Eelco Chaudron wrote:
> Coverity was flagged that the uninitialized output variable was used
> in the ctl_context_init_command() function. This patch initializes
> the variable.
>
> Fixes: 07ff77ccb82a ("db-ctl-base: Make common database command code into
> library.")
>
On 5/27/24 13:01, Eelco Chaudron wrote:
> Instead of casting time_t to uint32_t for the 0x comparison,
> define a TIME_T_MAX and use it for both setting and comparison.
>
> Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
> Signed-off-by: Eelco Chaudron
> --
>
On 5/27/24 13:01, Eelco Chaudron wrote:
> Fix three Unintentional integer overflow reports by adding the
> ULL/LL suffix to the numerical literals used in the multiplications.
>
> Fixes: 5767a79a4059 ("cfm: Require ccm received in demand mode.")
> Fixes: ed2300cca0d3 ("netdev-linux: Refactor put
On 27/05/2024 15:44, Ilya Maximets wrote:
> On 5/27/24 13:00, Roi Dayan via dev wrote:
>> Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0
>> lib/netdev-linux.c:4985:54: error: ‘current_speed’ may be used uninitialized
>> in this function [-Werror=maybe-uninitialized]
>>
>> Fixes:
On 5/23/24 21:11, Mike Pattrick wrote:
> Clang's static analyzer noted that the output from
> netdev_linux_get_speed_locked can be checked even if this function
> doesn't set any values.
>
> Now we always set those values to a sane default in all cases.
>
> Fixes: 6240c0b4c80e ("netdev: Add
On 5/23/24 21:11, Mike Pattrick wrote:
> When retrieving a list of features supported by a network card, return
> with an error code if the request completed without an error but the
> list contains zero entries.
>
> In practice this should never happen, but it does contribute to a
> detection in
On 5/23/24 21:11, Mike Pattrick wrote:
> Clang's static analyzer will complain about uninitialized value 'hlen'
> because we weren't properly checking the error code from a function that
> would have initialized the value.
>
> Instead, add a check for that return code.
>
> Signed-off-by: Mike
On 5/27/24 13:00, Roi Dayan via dev wrote:
> Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0
> lib/netdev-linux.c:4985:54: error: ‘current_speed’ may be used uninitialized
> in this function [-Werror=maybe-uninitialized]
>
> Fixes: b8f8fad86435 ("netdev-linux: Use speed as max rate in tc
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Improper whitespace around control block
#40 FILE: lib/sflow_receiver.c:149:
This patch fixes a uninitialized gso_type case in
netdev_linux_prepend_vnet_hdr().
Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
Signed-off-by: Eelco Chaudron
---
lib/netdev-linux.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Coverity was flagged that the uninitialized output variable was used
in the ctl_context_init_command() function. This patch initializes
the variable.
Fixes: 07ff77ccb82a ("db-ctl-base: Make common database command code into
library.")
Signed-off-by: Eelco Chaudron
---
lib/db-ctl-base.c | 1 +
Fix the warning from Coverity about potential truncation of the
time_t value when copying to a local variable by changing the
local variable's type to time_t.
ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static fdb
entry.")
Signed-off-by: Eelco Chaudron
---
Instead of casting time_t to uint32_t for the 0x comparison,
define a TIME_T_MAX and use it for both setting and comparison.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
Signed-off-by: Eelco Chaudron
--
Note that this checkpatch reports an 'Improper
The sFlow library uses a uint32_t to configure timeout ticks, but
stores this value as a time_t. Although this doesn't cause functional
issues, it wastes space and confuses Coverity, potentially indicating
a Y2K38 problem when storing uint32_t values in time_t. This patch
updates the internal data
Coverity has flagged the use of a potentially unsafe function.
Although this is not a concern in this case since it's not used for
encryption, we should replace it with the OVS implementation to
achieve better randomness.
Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build
Fix three Unintentional integer overflow reports by adding the
ULL/LL suffix to the numerical literals used in the multiplications.
Fixes: 5767a79a4059 ("cfm: Require ccm received in demand mode.")
Fixes: ed2300cca0d3 ("netdev-linux: Refactor put police action netlink message")
Signed-off-by:
Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0
lib/netdev-linux.c:4985:54: error: ‘current_speed’ may be used uninitialized in
this function [-Werror=maybe-uninitialized]
Fixes: b8f8fad86435 ("netdev-linux: Use speed as max rate in tc classes.")
Signed-off-by: Roi Dayan
---
Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0
lib/netdev-linux.c: In function ‘netdev_linux_construct’:
lib/netdev-linux.c:7003:15: error: array subscript ‘struct ethtool_cmd[0]’ is
partly outside array bounds of ‘union [1]’ [-Werror=array-bounds]
7003 | ecmd->cmd = cmd;
|
On Mon, May 27, 2024 at 9:00 AM Ales Musil wrote:
> Move more code into the new ct-zone module and encapsulate
> functionality that is strictly related to CT zone handling.
>
> Signed-off-by: Ales Musil
> ---
> controller/ct-zone.c| 156 +---
>
On Thu, May 23, 2024 at 04:21:48PM GMT, Simon Jones wrote:
> Hi all,
>
> I found a bug in OVS-DPDK(ovs-2.17.1, dpdk-21.11).
> Which is Miss setting port number in openflow while delete port and add
> port.
Hi Simon.
See my comments inline.
>
> 1. The process of problem is:
> ```
> add bridge;
>
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 84 characters long (recommended limit is 79)
#497 FILE: ovn-nb.xml:726:
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#190 FILE: controller/ct-zone.c:146:
/* XXX Add
Move the CT zone handling specific bits into it's own module. This
allows for easier changes done within the module and separates the
logic that is unrelated from ovn-controller.
Signed-off-by: Ales Musil
---
controller/automake.mk | 4 +-
controller/ct-zone.c| 377
In order to be able to store CT limits for specified zone, store the
zone inside separate struct instead of simap. This allows to add
the addition of limit without chaning the whole infrastructure again.
This is a preparation step for the CT zone limits.
Signed-off-by: Ales Musil
---
v2: Fix
Move more code into the new ct-zone module and encapsulate
functionality that is strictly related to CT zone handling.
Signed-off-by: Ales Musil
---
controller/ct-zone.c| 156 +---
controller/ct-zone.h| 8 +-
controller/ovn-controller.c | 49
Add support for limitng the CT zone usage per Ls, LR or LSP.
When the limit is configured on logical switch it will also implicitly
set limits for all ports in that logical switch. The port configuration
can be overwritten individually and has priority over the whole logical
switch configuration.
Add ability that allows to set CT limits per logical switch, logical
router or logical switch port. When the limit is applied to logical
switch it will be implicitly set for all logical ports in the logical
switch. This can be overwritten individually per port.
To achieve this there is a small
From: Wilson Peng
While deploying Tanzu Kubernetes(Antrea based solution) in Broadcom customer,
Sometimes it is found that the kernel thread OvsConntrackEntryCleaner is not
started
After the Windows node is rebooted on unexpected condition. It could be also
observed a similar issue in local
References: <20240526084316.44848-1-sunyang...@jaguarmicro.com>
Bleep bloop. Greetings Sunyang Wu, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary
Signed-off-by: Sunyang Wu
---
lib/netdev-offload-dpdk.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 623005b1c..524942457 100644
--- a/lib/netdev-offload-dpdk.c
+++ b/lib/netdev-offload-dpdk.c
From: Maor Dickman
The cited commit reserved lower tc priorities for IP ethertypes in order
to give IP traffic higher priority than other management traffic.
In case of of vlan encap traffic, IP traffic will still get lower
priority.
Fix it by also reserving low priority tc prio for vlan.
From: Wilson Peng
While deploying Tanzu Kubernetes(Antrea based solution) in Broadcom customer,
Sometimes it is found that the kernel thread OvsConntrackEntryCleaner is not
started
After the Windows node is rebooted on unexpected condition. It could be also
observed a similar issue in local
References: <20240526053923.54978-1-svc.ovs-commun...@vmware.com>
Bleep bloop. Greetings Wilson Peng, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject, ':
From: Wilson Peng
While deploying Tanzu Kubernetes(Antrea based solution) in Broadcom
customer,
Sometimes it is found that the kernel thread OvsConntrackEntryCleaner is not
started
After the Windows node is rebooted on unexpected condition. It could be also
observed a similar issue in
From: Shaohua Wu
In scenarios with multiple PMDs, there may be
simultaneous requests for recirc_id from multiple
PMD threads.In recirc_alloc_id_ctx, we first check
if there is a duplicate entry in the metadata_map
for the same frozen_state field. If successful,
we directly retrieve the
> -Original Message-
> From: Ilya Maximets
> Sent: Thursday, May 23, 2024 10:37 PM
> To: Van Haaren, Harry ; Chaudron, Eelco
> ; Finn, Emma
> Cc: i.maxim...@ovn.org; ovs-dev@openvswitch.org
> Subject: Re: [ovs-dev] [v3] odp-execute: Fix AVX checksum calculation.
>
> On 5/23/24 13:03,
The AVX implementation for calcualting checksums was not
handling carry-over addition correctly in some cases.
This patch adds an additional shuffle to add 16-bit padding to
the final part of the calculation to handle such cases. This
commit also adds a unit test to check the checksum carry-bits
Reply only if target ethernet address is broadcast, if
address is specified explicitly do noting to let target
reply by itself. This technique allows to monitor target
aliveness with arping.
Closes #239
Signed-off-by: Vasyl Saienko
---
northd/northd.c | 11 +--
On 5/23/24 13:03, Van Haaren, Harry wrote:
>> On 21 May 2024, at 16:13, Emma Finn wrote:
>>> The AVX implementation for calcualting checksums was not
>>> handling carry-over addition correctly in some cases.
>>> This patch adds an additional shuffle to add 16-bit padding
>>> to the final part of
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject, ': ', is over 70 characters, i.e., 72.
Subject: netdev-offload: Fix
When retrieving a list of features supported by a network card, return
with an error code if the request completed without an error but the
list contains zero entries.
In practice this should never happen, but it does contribute to a
detection in Clang's static analyzer.
Fixes: 6c59c195266c
Clang's static analyzer will complain about uninitialized value
dns_failure because we weren't setting a value for dns_failure in all
code paths.
Now we initialize this in the error conditions of inet_parse_passive and
inet_parse_active.
Fixes: 08e9e5337383 ("ovsdb: raft: Fix inability to read
Clang's static analyzer noted that the output from
netdev_linux_get_speed_locked can be checked even if this function
doesn't set any values.
Now we always set those values to a sane default in all cases.
Fixes: 6240c0b4c80e ("netdev: Add netdev_get_speed() to netdev API.")
Signed-off-by: Mike
Clang's static analyzer will complain about an uninitialized value
because we weren't setting a value for ufid_generated in all code paths.
Now we initialize this on declaration. This patch also corrects the
reverse x-mass of variable declaration.
Fixes: bbe2e3928747 ("dpctl: Fix broken flow
Clang's static analyzer will complain about uninitialized value 'hlen'
because we weren't properly checking the error code from a function that
would have initialized the value.
Instead, add a check for that return code.
Signed-off-by: Mike Pattrick
Fixes: 03fc1ad78521 ("userspace: Add SRv6
Clang's static analyzer will complain about a null pointer dereference
because dumps can be set to null and then there is a loop where it could
have been written to. This is a false positive, but only because the
netdev dpif type won't change during this loop.
Instead, return early from the
Update the CI and docs to use DPDK 23.11.1.
Signed-off-by: Kevin Traynor
---
.github/workflows/build-and-test.yml | 4 ++--
Documentation/faq/releases.rst | 10 +-
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files changed,
Update the CI and docs to use DPDK 23.11.1.
Signed-off-by: Kevin Traynor
---
.github/workflows/build-and-test.yml | 4 ++--
Documentation/faq/releases.rst | 10 +-
Documentation/intro/install/dpdk.rst | 8
NEWS | 3 +++
4 files changed,
Update the CI and docs to use DPDK 22.11.5.
Signed-off-by: Kevin Traynor
---
.github/workflows/build-and-test.yml | 2 +-
Documentation/faq/releases.rst | 8
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files changed, 11
Update the CI and docs to use DPDK 22.11.5.
Signed-off-by: Kevin Traynor
---
.github/workflows/build-and-test.yml | 2 +-
Documentation/faq/releases.rst | 6 +++---
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files changed, 10
Update the CI and docs to use DPDK 21.11.7.
Signed-off-by: Kevin Traynor
---
.ci/linux-build.sh | 2 +-
Documentation/faq/releases.rst | 4 ++--
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files changed, 9
Update the CI and docs to use DPDK 21.11.7.
Signed-off-by: Kevin Traynor
---
.ci/linux-build.sh | 2 +-
Documentation/faq/releases.rst | 2 +-
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 ++
4 files changed, 8
On Wed, May 22, 2024 at 03:26:05PM GMT, Aaron Conole wrote:
> Ilya Maximets writes:
>
> > On 5/16/24 19:03, Adrian Moreno wrote:
> >>
> >>
> >> On 4/24/24 9:53 PM, Adrian Moreno wrote:
> >>> This is the userspace counterpart of the work being done in the kernel
> >>> [1]. Sending it as RFC to get
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 84 characters long (recommended limit is 79)
#497 FILE: ovn-nb.xml:726:
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#190 FILE: controller/ct-zone.c:146:
/* XXX Add
Add support for limitng the CT zone usage per Ls, LR or LSP.
When the limit is configured on logical switch it will also implicitly
set limits for all ports in that logical switch. The port configuration
can be overwritten individually and has priority over the whole logical
switch configuration.
Move the CT zone handling specific bits into it's own module. This
allows for easier changes done within the module and separates the
logic that is unrelated from ovn-controller.
Signed-off-by: Ales Musil
---
controller/automake.mk | 4 +-
controller/ct-zone.c| 377
In order to be able to store CT limits for specified zone, store the
zone inside separate struct instead of simap. This allows to add
the addition of limit without chaning the whole infrastructure again.
This is a preparation step for the CT zone limits.
Signed-off-by: Ales Musil
---
Move more code into the new ct-zone module and encapsulate
functionality that is strictly related to CT zone handling.
Signed-off-by: Ales Musil
---
controller/ct-zone.c| 156 +---
controller/ct-zone.h| 8 +-
controller/ovn-controller.c | 49
1 - 100 of 148524 matches
Mail list logo
