Re: [ovs-dev] [PATCH] ofp-actions: Fix use-after-free with ofpact_finish().

2016-03-29 Thread Joe Stringer
On 20 March 2016 at 05:34, Ben Pfaff wrote: > On Mon, Mar 07, 2016 at 03:36:37PM -0800, Joe Stringer wrote: >> ofpact_finish() may now reallocate the buffer it is passed, but not all >> callers updated their local pointers to the current action in the >> buffer. This could

Re: [ovs-dev] [PATCH] ofp-actions: Fix use-after-free with ofpact_finish().

2016-03-19 Thread Ben Pfaff
On Mon, Mar 07, 2016 at 03:36:37PM -0800, Joe Stringer wrote: > ofpact_finish() may now reallocate the buffer it is passed, but not all > callers updated their local pointers to the current action in the > buffer. This could potentially lead to several use-after-free bugs. > > Update

[ovs-dev] [PATCH] ofp-actions: Fix use-after-free with ofpact_finish().

2016-03-07 Thread Joe Stringer
ofpact_finish() may now reallocate the buffer it is passed, but not all callers updated their local pointers to the current action in the buffer. This could potentially lead to several use-after-free bugs. Update ofpact_finish() to return the new pointer to the ofpact which is provided, and