Re: [ovs-dev] [PATCH] ovn-controller: add restart test

2016-03-23 Thread Ramu Ramamurthy
On Wed, Mar 23, 2016 at 4:23 PM, Ben Pfaff wrote: > On Tue, Mar 22, 2016 at 04:37:16PM -0700, Ramu Ramamurthy wrote: >> > This adds a test for this invariant for a specific test case, which is >> > useful. However, I believe that this should be a universal invariant >> > for

Re: [ovs-dev] [PATCH] ovn-controller: add restart test

2016-03-23 Thread Ben Pfaff
On Tue, Mar 22, 2016 at 04:37:16PM -0700, Ramu Ramamurthy wrote: > > This adds a test for this invariant for a specific test case, which is > > useful. However, I believe that this should be a universal invariant > > for ovn-controller, so that at any time if ovn-controller is restarted > >

Re: [ovs-dev] [PATCH] ovn-controller: add restart test

2016-03-22 Thread Ramu Ramamurthy
> This adds a test for this invariant for a specific test case, which is > useful. However, I believe that this should be a universal invariant > for ovn-controller, so that at any time if ovn-controller is restarted > gracefully after it has converged, it should preserve these flows. Is > that

Re: [ovs-dev] [PATCH] ovn-controller: add restart test

2016-03-22 Thread Ben Pfaff
On Mon, Mar 07, 2016 at 04:03:56PM -0500, Ramu Ramamurthy wrote: > Add a test to validate that a restart of the ovn-controller > will program flows in table 0 consistently. Flows before > restart are compared against flows after restart to detect > problems with ofports or zone-ids. > >

Re: [ovs-dev] [PATCH] ovn-controller: add restart test

2016-03-07 Thread ramu
> What I would probably do is submit them together: the zone-ids fix + this > test case that helps test it. If you take out your "xyz" change, will this > test fail currently? > > If i take out the change which masks the zone-ids, this test fails on master because, zone-ids dont match before and

Re: [ovs-dev] [PATCH] ovn-controller: add restart test

2016-03-07 Thread Russell Bryant
On Mon, Mar 7, 2016 at 4:27 PM, ramu wrote: > > >> Does this depend on your zone-ids fix? Do you have another rev of that >> coming? >> > > Russell, This test does not depend on the zone-id fix, because it replaces > zone-ids on flows > with a dummy string "xyz". It

Re: [ovs-dev] [PATCH] ovn-controller: add restart test

2016-03-07 Thread ramu
> > Does this depend on your zone-ids fix? Do you have another rev of that > coming? > Russell, This test does not depend on the zone-id fix, because it replaces zone-ids on flows with a dummy string "xyz". It passes on the master as is. I will send the next revision of the zone-id fix soon,

Re: [ovs-dev] [PATCH] ovn-controller: add restart test

2016-03-07 Thread Russell Bryant
On Mon, Mar 7, 2016 at 4:03 PM, Ramu Ramamurthy wrote: > Add a test to validate that a restart of the ovn-controller > will program flows in table 0 consistently. Flows before > restart are compared against flows after restart to detect > problems with ofports or

[ovs-dev] [PATCH] ovn-controller: add restart test

2016-03-07 Thread Ramu Ramamurthy
Add a test to validate that a restart of the ovn-controller will program flows in table 0 consistently. Flows before restart are compared against flows after restart to detect problems with ofports or zone-ids. Signed-off-by: Ramu Ramamurthy ---