Re: [ovs-dev] [PATCH 5/6] ovs-router: Do not allow routes over loopback device.

2016-03-10 Thread pravin shelar
On Thu, Mar 10, 2016 at 5:04 PM, Ben Pfaff wrote: > On Wed, Mar 09, 2016 at 04:40:44PM -0800, Pravin B Shelar wrote: >> This just avoid unnecessary routes in the ovs-router. >> >> Signed-off-by: Pravin B Shelar > > This adds three more test failures: > >

Re: [ovs-dev] [PATCH 5/6] ovs-router: Do not allow routes over loopback device.

2016-03-10 Thread Ben Pfaff
On Wed, Mar 09, 2016 at 04:40:44PM -0800, Pravin B Shelar wrote: > This just avoid unnecessary routes in the ovs-router. > > Signed-off-by: Pravin B Shelar This also raises confusion on whether errors should be positive or negative.

[ovs-dev] [PATCH 5/6] ovs-router: Do not allow routes over loopback device.

2016-03-09 Thread Pravin B Shelar
This just avoid unnecessary routes in the ovs-router. Signed-off-by: Pravin B Shelar --- lib/ovs-router.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/ovs-router.c b/lib/ovs-router.c index 9b64ffb..3b11512 100644 --- a/lib/ovs-router.c +++ b/lib/ovs-router.c