Re: [ovs-dev] [PATCH V2] ipfix: Export user specified virtual observation ID

2016-06-24 Thread Wenyu Zhang
I have fixed the issue, and sent out a new patch. Due to the result of this feature only can been seen in the exported IPFIX packet, the test case for it may be a big work. We may consider it with other IPFIX features tests a litter later. 发自我的 iPhone > 在 2016年6月25日,上午6:20,Wenyu Zhang

Re: [ovs-dev] [PATCH V2] ipfix: Export user specified virtual observation ID

2016-06-24 Thread Wenyu Zhang
Sorry for the stupid mistake. I am working on it,and will verify it by running check. 发自我的 iPhone > 在 2016年6月25日,上午4:43,Ben Pfaff 写道: > >> On Fri, Jun 24, 2016 at 05:25:57AM -0700, Wenyu Zhang wrote: >> In virtual network, users want more info about the virtual point to observe

Re: [ovs-dev] [PATCH V2] ipfix: Export user specified virtual observation ID

2016-06-24 Thread Wenyu Zhang
Thanks for your catch. Iam working on it. 发自我的 iPhone > 在 2016年6月25日,上午4:55,William Tu 写道: > > Hi Wenyu, > > I was debugging a little bit and the issue is a NULL pointer deference > of be_cfg at virtual_obs_id = smap_get(_cfg->other_config, > "virtual_obs_id"); > >

Re: [ovs-dev] [PATCH V2] ipfix: Export user specified virtual observation ID

2016-06-24 Thread William Tu
Hi Wenyu, I was debugging a little bit and the issue is a NULL pointer deference of be_cfg at virtual_obs_id = smap_get(_cfg->other_config, "virtual_obs_id"); Maybe adding if (valid_be_cfg) check before the deference? I will leave you to fix it. Also I hope you can add a test case to this

Re: [ovs-dev] [PATCH V2] ipfix: Export user specified virtual observation ID

2016-06-24 Thread Ben Pfaff
On Fri, Jun 24, 2016 at 05:25:57AM -0700, Wenyu Zhang wrote: > In virtual network, users want more info about the virtual point to observe > the traffic. > It should be a string to provide clear info, not a simple interger ID. > > Introduce "other-config: virtual_obs_id" in IPFIX, which is a

Re: [ovs-dev] [PATCH V2] ipfix: Export user specified virtual observation ID

2016-06-24 Thread Ben Pfaff
On Fri, Jun 24, 2016 at 05:25:57AM -0700, Wenyu Zhang wrote: > In virtual network, users want more info about the virtual point to observe > the traffic. > It should be a string to provide clear info, not a simple interger ID. > > Introduce "other-config: virtual_obs_id" in IPFIX, which is a

[ovs-dev] [PATCH V2] ipfix: Export user specified virtual observation ID

2016-06-24 Thread Wenyu Zhang
In virtual network, users want more info about the virtual point to observe the traffic. It should be a string to provide clear info, not a simple interger ID. Introduce "other-config: virtual_obs_id" in IPFIX, which is a string configured by user. Introduce an enterprise IPFIX entity