Re: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon to Windows

2016-07-15 Thread Paul Boca
Hi Alin, Comments inlined. Thanks for review, Paul > -Original Message- > From: Alin Serdean > Sent: Friday, July 15, 2016 2:28 AM > To: Paul Boca; dev@openvswitch.org > Subject: RE: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon > to Windows

Re: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon to Windows

2016-07-14 Thread Alin Serdean
6 3:38 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon to > Windows > > Used subprocess.Popen instead os.fork (not implemented on windows) and > repaced of os.pipe with Windows pipes. > > To be able to identify t

Re: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon to Windows

2016-07-14 Thread Alin Serdean
> > Hi Alin, > > It was easier for me to call Windows APIs from python, that mimics > detach_process, and to be in a better control on what's happening, than > creating a *DLL and loading it in order to call this function. > *On Windows the LIB file cannot be loaded as-is; a DLL with entry point >

Re: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon to Windows

2016-07-13 Thread Alin Serdean
> -Mesaj original- > De la: Paul Boca > Trimis: Wednesday, July 13, 2016 11:24 AM > Către: Alin Serdean <aserd...@cloudbasesolutions.com>; > dev@openvswitch.org > Subiect: RE: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python > daemon to Windows > > H

Re: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon to Windows

2016-07-13 Thread Paul Boca
his opinion about this. Thanks, Paul > -Original Message- > From: Alin Serdean > Sent: Tuesday, July 12, 2016 10:54 PM > To: Paul Boca; dev@openvswitch.org > Subject: RE: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon > to Windows > > I am wonderi

Re: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon to Windows

2016-07-12 Thread Alin Serdean
. > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca > Trimis: Wednesday, July 6, 2016 3:38 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon to > Windows > > Used subproce

[ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon to Windows

2016-07-06 Thread Paul Boca
Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to