Re: [ovs-dev] [PATCH net-next] openvswitch: Only set mark and labels when commiting a connection.

Thanks for the review! > On Jun 21, 2016, at 1:57 PM, Joe Stringer wrote: > > On 20 June 2016 at 17:19, Jarno Rajahalme wrote: >> Only allow setting conntrack mark or labels when the commit flag is >> specified. This makes sure we can not set them before the

Re: [ovs-dev] [PATCH net-next] openvswitch: Only set mark and labels when commiting a connection.

On 20 June 2016 at 17:19, Jarno Rajahalme wrote: > Only allow setting conntrack mark or labels when the commit flag is > specified. This makes sure we can not set them before the connection > has been persisted, as in that case the mark and labels would be lost > in an event of an

Re: [ovs-dev] [PATCH net-next] openvswitch: Only set mark and labels when commiting a connection.

The title should have been: openvswitch: Only set mark and labels with a commit flag. This reflects the fact that modifying the mark and/or labels of an existing connection is allowed. The commit flag is still required to do that, though. Jarno > On Jun 20, 2016, at 5:19 PM, Jarno Rajahalme

[ovs-dev] [PATCH net-next] openvswitch: Only set mark and labels when commiting a connection.

Only allow setting conntrack mark or labels when the commit flag is specified. This makes sure we can not set them before the connection has been persisted, as in that case the mark and labels would be lost in an event of an userspace upcall. OVS userspace already requires the commit flag to