Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Mon, Sep 26, 2016 at 9:53 AM, Jiri Benc wrote: > Reviving a very old thread, sorry. Simon handed this over to me, I'm > preparing v12. > > On Fri, 15 Jul 2016 14:07:37 -0700, pravin shelar wrote: >> I am not sure if you can use only mac_len to detect L3 packet. This >> does

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

Reviving a very old thread, sorry. Simon handed this over to me, I'm preparing v12. On Fri, 15 Jul 2016 14:07:37 -0700, pravin shelar wrote: > I am not sure if you can use only mac_len to detect L3 packet. This > does not work with MPLS packets, mac_len is used to account MPLS > headers pushed on

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On 26 August 2016 at 02:13, Simon Horman wrote: > On Thu, Aug 25, 2016 at 05:33:57PM -0700, Joe Stringer wrote: >> On 25 August 2016 at 03:08, Simon Horman wrote: >> > Please find my working patch below. >> > >> > From: Simon Horman

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Thu, Aug 25, 2016 at 05:33:57PM -0700, Joe Stringer wrote: > On 25 August 2016 at 03:08, Simon Horman wrote: > > Please find my working patch below. > > > > From: Simon Horman > > Subject: [PATCH] system-traffic: Exercise GSO > > > > Exercise

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On 25 August 2016 at 03:08, Simon Horman wrote: > Please find my working patch below. > > From: Simon Horman > Subject: [PATCH] system-traffic: Exercise GSO > > Exercise GSO for: unencapsulated; MPLS; GRE; and MPLS in GRE. > > There is scope to

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Tue, Aug 23, 2016 at 10:51:47AM +0200, Simon Horman wrote: > On Mon, Aug 22, 2016 at 02:47:42PM -0700, Joe Stringer wrote: > > On 22 August 2016 at 04:04, Simon Horman wrote: > > > On Wed, Aug 10, 2016 at 10:17:30AM -0700, Joe Stringer wrote: > > >> On 10 August

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Mon, Aug 22, 2016 at 02:47:42PM -0700, Joe Stringer wrote: > On 22 August 2016 at 04:04, Simon Horman wrote: > > On Wed, Aug 10, 2016 at 10:17:30AM -0700, Joe Stringer wrote: > >> On 10 August 2016 at 03:20, Simon Horman > >> wrote: >

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On 22 August 2016 at 04:04, Simon Horman wrote: > On Wed, Aug 10, 2016 at 10:17:30AM -0700, Joe Stringer wrote: >> On 10 August 2016 at 03:20, Simon Horman wrote: >> > On Tue, Aug 09, 2016 at 08:47:40AM -0700, pravin shelar wrote: >> >> On

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Wed, Aug 10, 2016 at 10:17:30AM -0700, Joe Stringer wrote: > On 10 August 2016 at 03:20, Simon Horman wrote: > > On Tue, Aug 09, 2016 at 08:47:40AM -0700, pravin shelar wrote: > >> On Mon, Aug 8, 2016 at 8:17 AM, Simon Horman > >>

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On 10 August 2016 at 03:20, Simon Horman wrote: > On Tue, Aug 09, 2016 at 08:47:40AM -0700, pravin shelar wrote: >> On Mon, Aug 8, 2016 at 8:17 AM, Simon Horman >> wrote: >> > Light testing seems to indicate that it works for GSO skbs >> >

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Tue, Aug 09, 2016 at 08:47:40AM -0700, pravin shelar wrote: > On Mon, Aug 8, 2016 at 8:17 AM, Simon Horman > wrote: ... > > Hi Pravin, > > > > I have made an attempt to implement your suggestion to the extent that > > I understand it. The following is an

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Mon, Aug 08, 2016 at 05:28:39PM +0200, Jiri Benc wrote: > On Mon, 8 Aug 2016 17:17:17 +0200, Simon Horman wrote: > > +bool skb_mac_header_present(struct sk_buff *skb) > > +{ > > + return skb->dev->type == ARPHRD_ETHER || > > + (skb->dev->type == ARPHRD_NONE && > > +

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Mon, Aug 8, 2016 at 8:17 AM, Simon Horman wrote: > On Wed, Jul 20, 2016 at 11:06:37AM -0700, pravin shelar wrote: >> On Tue, Jul 19, 2016 at 5:02 PM, Simon Horman >> wrote: >> > On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Mon, 8 Aug 2016 17:17:17 +0200, Simon Horman wrote: > +bool skb_mac_header_present(struct sk_buff *skb) > +{ > + return skb->dev->type == ARPHRD_ETHER || > + (skb->dev->type == ARPHRD_NONE && > + skb->protocol == htons(ETH_P_TEB)); > +} >

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Wed, Jul 20, 2016 at 11:06:37AM -0700, pravin shelar wrote: > On Tue, Jul 19, 2016 at 5:02 PM, Simon Horman > wrote: > > On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote: > >> On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman > >>

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Mon, 18 Jul 2016 13:50:27 +0900, Simon Horman wrote: > On Fri, Jul 15, 2016 at 02:07:37PM -0700, pravin shelar wrote: > > I think we should send L2 header with l2 header pushed on skb. This is > > what OVS expect. The skb-push should be done for all l2 packets rather > > than for particular

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Tue, Jul 19, 2016 at 5:02 PM, Simon Horman wrote: > On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote: >> On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman >> wrote: >> > [CC Jiri Benc for portion regarding GRE] >> > >> > Hi

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote: > On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman > wrote: > > [CC Jiri Benc for portion regarding GRE] > > > > Hi Pravin, > > > > On Fri, Jul 15, 2016 at 02:07:37PM -0700, pravin shelar wrote: > >> On Wed,

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman wrote: > [CC Jiri Benc for portion regarding GRE] > > Hi Pravin, > > On Fri, Jul 15, 2016 at 02:07:37PM -0700, pravin shelar wrote: >> On Wed, Jul 13, 2016 at 12:31 AM, Simon Horman >> wrote: >>

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

[CC Jiri Benc for portion regarding GRE] Hi Pravin, On Fri, Jul 15, 2016 at 02:07:37PM -0700, pravin shelar wrote: > On Wed, Jul 13, 2016 at 12:31 AM, Simon Horman > wrote: > > Hi Pravin, > > > > On Thu, Jul 07, 2016 at 01:54:15PM -0700, pravin shelar wrote: > >> On

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Wed, Jul 13, 2016 at 12:31 AM, Simon Horman wrote: > Hi Pravin, > > On Thu, Jul 07, 2016 at 01:54:15PM -0700, pravin shelar wrote: >> On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman >> wrote: > > ... > >> > diff --git

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman wrote: > From: Lorand Jakab > > Implementation of the pop_eth and push_eth actions in the kernel, and > layer 3 flow support. > > This doesn't actually do anything yet as no layer 2 tunnel ports are >

[ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

From: Lorand Jakab Implementation of the pop_eth and push_eth actions in the kernel, and layer 3 flow support. This doesn't actually do anything yet as no layer 2 tunnel ports are supported yet. The original patch by Lorand was against the Open vSwitch tree which has L2 LISP