Re: [ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

2016-07-29 Thread Ben Pfaff
On Fri, Jul 29, 2016 at 01:02:05PM -0700, Jarno Rajahalme wrote: > > > On Jul 29, 2016, at 12:54 PM, Jarno Rajahalme wrote: > > > >> > >> On Jul 29, 2016, at 12:48 PM, Ben Pfaff >> > wrote: > >> > >> On Fri, Jul 29, 2016 at 11:46:49AM

Re: [ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

2016-07-29 Thread Jarno Rajahalme
> On Jul 29, 2016, at 12:54 PM, Jarno Rajahalme wrote: > >> >> On Jul 29, 2016, at 12:48 PM, Ben Pfaff > >> wrote: >> >> On Fri, Jul 29, 2016 at 11:46:49AM -0700, Jarno Rajahalme wrote: >>> On Jul 29, 2016, at 11:20 AM, Ben Pfaff

Re: [ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

2016-07-29 Thread Jarno Rajahalme
> On Jul 29, 2016, at 12:48 PM, Ben Pfaff wrote: > > On Fri, Jul 29, 2016 at 11:46:49AM -0700, Jarno Rajahalme wrote: >> >>> On Jul 29, 2016, at 11:20 AM, Ben Pfaff wrote: >>> >>> On Thu, Jul 28, 2016 at 05:55:54PM -0700, Jarno Rajahalme wrote: Make groups

Re: [ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

2016-07-29 Thread Ben Pfaff
On Fri, Jul 29, 2016 at 11:46:49AM -0700, Jarno Rajahalme wrote: > > > On Jul 29, 2016, at 11:20 AM, Ben Pfaff wrote: > > > > On Thu, Jul 28, 2016 at 05:55:54PM -0700, Jarno Rajahalme wrote: > >> Make groups RCU protected and make group lookups lockless. > >> > >> Signed-off-by:

Re: [ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

2016-07-29 Thread Jarno Rajahalme
> On Jul 29, 2016, at 11:20 AM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:55:54PM -0700, Jarno Rajahalme wrote: >> Make groups RCU protected and make group lookups lockless. >> >> Signed-off-by: Jarno Rajahalme > > I'd add a little motivation to the commit

Re: [ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

2016-07-29 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 05:55:54PM -0700, Jarno Rajahalme wrote: > Make groups RCU protected and make group lookups lockless. > > Signed-off-by: Jarno Rajahalme I'd add a little motivation to the commit message. A common reason to switch to RCU is performance, but I doubt that

[ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

2016-07-28 Thread Jarno Rajahalme
Make groups RCU protected and make group lookups lockless. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 22 +++--- ofproto/ofproto-dpif.c | 27 +++ ofproto/ofproto-dpif.h | 7 +- ofproto/ofproto-provider.h | 12 ++-- ofproto/ofproto.c