Re: [ovs-dev] [PATCH v2 16/26] meta-flow: Clean up masking with prerequisities checking.

2016-07-29 Thread Jarno Rajahalme
> On Jul 29, 2016, at 3:54 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:56:08PM -0700, Jarno Rajahalme wrote: >> Change mf_are_prereqs_ok() take a flow_wildcards pointer, so that the >> wildcards can be set at the same time as the prerequisiteis are >> checked. This makes

Re: [ovs-dev] [PATCH v2 16/26] meta-flow: Clean up masking with prerequisities checking.

2016-07-29 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 05:56:08PM -0700, Jarno Rajahalme wrote: > Change mf_are_prereqs_ok() take a flow_wildcards pointer, so that the > wildcards can be set at the same time as the prerequisiteis are > checked. This makes it easier to write more obviously correct code. > > Remove the

[ovs-dev] [PATCH v2 16/26] meta-flow: Clean up masking with prerequisities checking.

2016-07-28 Thread Jarno Rajahalme
Change mf_are_prereqs_ok() take a flow_wildcards pointer, so that the wildcards can be set at the same time as the prerequisiteis are checked. This makes it easier to write more obviously correct code. Remove the functions mf_mask_field_and_prereqs() and mf_mask_field_and_prereqs__(), and make